* [PATCH 0/2] arm64: dts: renesas: r8a779f0: Add IPMMU nodes
@ 2022-01-25 13:00 Yoshihiro Shimoda
2022-01-25 13:00 ` [PATCH 1/2] " Yoshihiro Shimoda
2022-01-25 13:00 ` [PATCH 2/2] arm64: dts: renesas: r8a779f0: Add iommus in dmac nodes Yoshihiro Shimoda
0 siblings, 2 replies; 7+ messages in thread
From: Yoshihiro Shimoda @ 2022-01-25 13:00 UTC (permalink / raw)
To: geert+renesas, magnus.damm; +Cc: linux-renesas-soc, Yoshihiro Shimoda
This patch series is based on renesas-drivers-2022-01-11-v5.16.
And, the following patch series which I have submitted today is required to use.
[PATCH 0/2] iommu/ipmmu-vmsa: Add support for R-Car Gen4
Yoshihiro Shimoda (2):
arm64: dts: renesas: r8a779f0: Add IPMMU nodes
arm64: dts: renesas: r8a779f0: Add iommus in dmac nodes
arch/arm64/boot/dts/renesas/r8a779f0.dtsi | 62 +++++++++++++++++++++++
1 file changed, 62 insertions(+)
--
2.25.1
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 1/2] arm64: dts: renesas: r8a779f0: Add IPMMU nodes
2022-01-25 13:00 [PATCH 0/2] arm64: dts: renesas: r8a779f0: Add IPMMU nodes Yoshihiro Shimoda
@ 2022-01-25 13:00 ` Yoshihiro Shimoda
2022-02-02 9:21 ` Geert Uytterhoeven
2022-01-25 13:00 ` [PATCH 2/2] arm64: dts: renesas: r8a779f0: Add iommus in dmac nodes Yoshihiro Shimoda
1 sibling, 1 reply; 7+ messages in thread
From: Yoshihiro Shimoda @ 2022-01-25 13:00 UTC (permalink / raw)
To: geert+renesas, magnus.damm; +Cc: linux-renesas-soc, Yoshihiro Shimoda
Add IPMMU nodes for r8a779f0.
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
---
arch/arm64/boot/dts/renesas/r8a779f0.dtsi | 46 +++++++++++++++++++++++
1 file changed, 46 insertions(+)
diff --git a/arch/arm64/boot/dts/renesas/r8a779f0.dtsi b/arch/arm64/boot/dts/renesas/r8a779f0.dtsi
index 5426532d10e2..3b3d01ba08dd 100644
--- a/arch/arm64/boot/dts/renesas/r8a779f0.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a779f0.dtsi
@@ -164,6 +164,52 @@ dmac1: dma-controller@e7351000 {
dma-channels = <16>;
};
+ ipmmu_rt0: iommu@ee480000 {
+ compatible = "renesas,ipmmu-r8a779f0",
+ "renesas,rcar-gen4-ipmmu";
+ reg = <0 0xee480000 0 0x20000>;
+ renesas,ipmmu-main = <&ipmmu_mm 10>;
+ power-domains = <&sysc R8A779F0_PD_ALWAYS_ON>;
+ #iommu-cells = <1>;
+ };
+
+ ipmmu_rt1: iommu@ee4c0000 {
+ compatible = "renesas,ipmmu-r8a779f0",
+ "renesas,rcar-gen4-ipmmu";
+ reg = <0 0xee4c0000 0 0x20000>;
+ renesas,ipmmu-main = <&ipmmu_mm 19>;
+ power-domains = <&sysc R8A779F0_PD_ALWAYS_ON>;
+ #iommu-cells = <1>;
+ };
+
+ ipmmu_ds0: iommu@eed00000 {
+ compatible = "renesas,ipmmu-r8a779f0",
+ "renesas,rcar-gen4-ipmmu";
+ reg = <0 0xeed00000 0 0x20000>;
+ renesas,ipmmu-main = <&ipmmu_mm 0>;
+ power-domains = <&sysc R8A779F0_PD_ALWAYS_ON>;
+ #iommu-cells = <1>;
+ };
+
+ ipmmu_hsc: iommu@eed40000 {
+ compatible = "renesas,ipmmu-r8a779f0",
+ "renesas,rcar-gen4-ipmmu";
+ reg = <0 0xeed40000 0 0x20000>;
+ renesas,ipmmu-main = <&ipmmu_mm 2>;
+ power-domains = <&sysc R8A779F0_PD_ALWAYS_ON>;
+ #iommu-cells = <1>;
+ };
+
+ ipmmu_mm: iommu@eefc0000 {
+ compatible = "renesas,ipmmu-r8a779f0",
+ "renesas,rcar-gen4-ipmmu";
+ reg = <0 0xeefc0000 0 0x20000>;
+ interrupts = <GIC_SPI 21 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 22 IRQ_TYPE_LEVEL_HIGH>;
+ power-domains = <&sysc R8A779F0_PD_ALWAYS_ON>;
+ #iommu-cells = <1>;
+ };
+
gic: interrupt-controller@f1000000 {
compatible = "arm,gic-v3";
#interrupt-cells = <3>;
--
2.25.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 2/2] arm64: dts: renesas: r8a779f0: Add iommus in dmac nodes
2022-01-25 13:00 [PATCH 0/2] arm64: dts: renesas: r8a779f0: Add IPMMU nodes Yoshihiro Shimoda
2022-01-25 13:00 ` [PATCH 1/2] " Yoshihiro Shimoda
@ 2022-01-25 13:00 ` Yoshihiro Shimoda
2022-02-02 9:38 ` Geert Uytterhoeven
1 sibling, 1 reply; 7+ messages in thread
From: Yoshihiro Shimoda @ 2022-01-25 13:00 UTC (permalink / raw)
To: geert+renesas, magnus.damm; +Cc: linux-renesas-soc, Yoshihiro Shimoda
Add iommus propaties in the dmac nodes for r8a779f0.
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
---
arch/arm64/boot/dts/renesas/r8a779f0.dtsi | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
diff --git a/arch/arm64/boot/dts/renesas/r8a779f0.dtsi b/arch/arm64/boot/dts/renesas/r8a779f0.dtsi
index 3b3d01ba08dd..bce7808cf380 100644
--- a/arch/arm64/boot/dts/renesas/r8a779f0.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a779f0.dtsi
@@ -127,6 +127,14 @@ dmac0: dma-controller@e7350000 {
resets = <&cpg 709>;
#dma-cells = <1>;
dma-channels = <16>;
+ iommus = <&ipmmu_ds0 0>, <&ipmmu_ds0 1>,
+ <&ipmmu_ds0 2>, <&ipmmu_ds0 3>,
+ <&ipmmu_ds0 4>, <&ipmmu_ds0 5>,
+ <&ipmmu_ds0 6>, <&ipmmu_ds0 7>,
+ <&ipmmu_ds0 8>, <&ipmmu_ds0 9>,
+ <&ipmmu_ds0 10>, <&ipmmu_ds0 11>,
+ <&ipmmu_ds0 12>, <&ipmmu_ds0 13>,
+ <&ipmmu_ds0 14>, <&ipmmu_ds0 15>;
};
dmac1: dma-controller@e7351000 {
@@ -162,6 +170,14 @@ dmac1: dma-controller@e7351000 {
resets = <&cpg 710>;
#dma-cells = <1>;
dma-channels = <16>;
+ iommus = <&ipmmu_ds0 16>, <&ipmmu_ds0 17>,
+ <&ipmmu_ds0 18>, <&ipmmu_ds0 19>,
+ <&ipmmu_ds0 20>, <&ipmmu_ds0 21>,
+ <&ipmmu_ds0 22>, <&ipmmu_ds0 23>,
+ <&ipmmu_ds0 24>, <&ipmmu_ds0 25>,
+ <&ipmmu_ds0 26>, <&ipmmu_ds0 27>,
+ <&ipmmu_ds0 28>, <&ipmmu_ds0 29>,
+ <&ipmmu_ds0 30>, <&ipmmu_ds0 31>;
};
ipmmu_rt0: iommu@ee480000 {
--
2.25.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] arm64: dts: renesas: r8a779f0: Add IPMMU nodes
2022-01-25 13:00 ` [PATCH 1/2] " Yoshihiro Shimoda
@ 2022-02-02 9:21 ` Geert Uytterhoeven
2022-05-30 1:08 ` Yoshihiro Shimoda
0 siblings, 1 reply; 7+ messages in thread
From: Geert Uytterhoeven @ 2022-02-02 9:21 UTC (permalink / raw)
To: Yoshihiro Shimoda; +Cc: Magnus Damm, Linux-Renesas
Hi Shimodan-san,
On Tue, Jan 25, 2022 at 2:00 PM Yoshihiro Shimoda
<yoshihiro.shimoda.uh@renesas.com> wrote:
> Add IPMMU nodes for r8a779f0.
>
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Thanks for your patch!
> --- a/arch/arm64/boot/dts/renesas/r8a779f0.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a779f0.dtsi
> @@ -164,6 +164,52 @@ dmac1: dma-controller@e7351000 {
> dma-channels = <16>;
> };
>
> + ipmmu_rt0: iommu@ee480000 {
> + compatible = "renesas,ipmmu-r8a779f0",
> + "renesas,rcar-gen4-ipmmu";
> + reg = <0 0xee480000 0 0x20000>;
> + renesas,ipmmu-main = <&ipmmu_mm 10>;
> + power-domains = <&sysc R8A779F0_PD_ALWAYS_ON>;
> + #iommu-cells = <1>;
> + };
> +
> + ipmmu_rt1: iommu@ee4c0000 {
> + compatible = "renesas,ipmmu-r8a779f0",
> + "renesas,rcar-gen4-ipmmu";
> + reg = <0 0xee4c0000 0 0x20000>;
> + renesas,ipmmu-main = <&ipmmu_mm 19>;
> + power-domains = <&sysc R8A779F0_PD_ALWAYS_ON>;
> + #iommu-cells = <1>;
> + };
> +
> + ipmmu_ds0: iommu@eed00000 {
> + compatible = "renesas,ipmmu-r8a779f0",
> + "renesas,rcar-gen4-ipmmu";
> + reg = <0 0xeed00000 0 0x20000>;
> + renesas,ipmmu-main = <&ipmmu_mm 0>;
> + power-domains = <&sysc R8A779F0_PD_ALWAYS_ON>;
> + #iommu-cells = <1>;
> + };
> +
> + ipmmu_hsc: iommu@eed40000 {
> + compatible = "renesas,ipmmu-r8a779f0",
> + "renesas,rcar-gen4-ipmmu";
> + reg = <0 0xeed40000 0 0x20000>;
> + renesas,ipmmu-main = <&ipmmu_mm 2>;
Bit 2 nor HSC are documented in the MMU Interrupt Status Register
(IMSSTR) register in Rev. 0.51 of the R-Car S4 Hardware User's Manual.
> + power-domains = <&sysc R8A779F0_PD_ALWAYS_ON>;
> + #iommu-cells = <1>;
> + };
> +
> + ipmmu_mm: iommu@eefc0000 {
> + compatible = "renesas,ipmmu-r8a779f0",
> + "renesas,rcar-gen4-ipmmu";
> + reg = <0 0xeefc0000 0 0x20000>;
> + interrupts = <GIC_SPI 21 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 22 IRQ_TYPE_LEVEL_HIGH>;
> + power-domains = <&sysc R8A779F0_PD_ALWAYS_ON>;
> + #iommu-cells = <1>;
> + };
> +
The rest looks good to me.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] arm64: dts: renesas: r8a779f0: Add iommus in dmac nodes
2022-01-25 13:00 ` [PATCH 2/2] arm64: dts: renesas: r8a779f0: Add iommus in dmac nodes Yoshihiro Shimoda
@ 2022-02-02 9:38 ` Geert Uytterhoeven
0 siblings, 0 replies; 7+ messages in thread
From: Geert Uytterhoeven @ 2022-02-02 9:38 UTC (permalink / raw)
To: Yoshihiro Shimoda; +Cc: Magnus Damm, Linux-Renesas
Hi Shimoda-san,
Thanks for your patch!
On Tue, Jan 25, 2022 at 2:00 PM Yoshihiro Shimoda
<yoshihiro.shimoda.uh@renesas.com> wrote:
> Add iommus propaties in the dmac nodes for r8a779f0.
properties.
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: [PATCH 1/2] arm64: dts: renesas: r8a779f0: Add IPMMU nodes
2022-02-02 9:21 ` Geert Uytterhoeven
@ 2022-05-30 1:08 ` Yoshihiro Shimoda
2022-05-30 1:19 ` Yoshihiro Shimoda
0 siblings, 1 reply; 7+ messages in thread
From: Yoshihiro Shimoda @ 2022-05-30 1:08 UTC (permalink / raw)
To: Geert Uytterhoeven; +Cc: Magnus Damm, Linux-Renesas
Hi Geert-san,
> From: Geert Uytterhoeven, Sent: Wednesday, February 2, 2022 6:21 PM
>
> Hi Shimodan-san,
>
> On Tue, Jan 25, 2022 at 2:00 PM Yoshihiro Shimoda
> <yoshihiro.shimoda.uh@renesas.com> wrote:
> > Add IPMMU nodes for r8a779f0.
> >
> > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
>
> Thanks for your patch!
Thank you for your review! And, I'm sorry, I completely overlooked this email...
> > --- a/arch/arm64/boot/dts/renesas/r8a779f0.dtsi
> > +++ b/arch/arm64/boot/dts/renesas/r8a779f0.dtsi
> > @@ -164,6 +164,52 @@ dmac1: dma-controller@e7351000 {
> > dma-channels = <16>;
> > };
> >
> > + ipmmu_rt0: iommu@ee480000 {
> > + compatible = "renesas,ipmmu-r8a779f0",
> > + "renesas,rcar-gen4-ipmmu";
> > + reg = <0 0xee480000 0 0x20000>;
> > + renesas,ipmmu-main = <&ipmmu_mm 10>;
> > + power-domains = <&sysc R8A779F0_PD_ALWAYS_ON>;
> > + #iommu-cells = <1>;
> > + };
> > +
> > + ipmmu_rt1: iommu@ee4c0000 {
> > + compatible = "renesas,ipmmu-r8a779f0",
> > + "renesas,rcar-gen4-ipmmu";
> > + reg = <0 0xee4c0000 0 0x20000>;
> > + renesas,ipmmu-main = <&ipmmu_mm 19>;
> > + power-domains = <&sysc R8A779F0_PD_ALWAYS_ON>;
> > + #iommu-cells = <1>;
> > + };
> > +
> > + ipmmu_ds0: iommu@eed00000 {
> > + compatible = "renesas,ipmmu-r8a779f0",
> > + "renesas,rcar-gen4-ipmmu";
> > + reg = <0 0xeed00000 0 0x20000>;
> > + renesas,ipmmu-main = <&ipmmu_mm 0>;
> > + power-domains = <&sysc R8A779F0_PD_ALWAYS_ON>;
> > + #iommu-cells = <1>;
> > + };
> > +
> > + ipmmu_hsc: iommu@eed40000 {
> > + compatible = "renesas,ipmmu-r8a779f0",
> > + "renesas,rcar-gen4-ipmmu";
> > + reg = <0 0xeed40000 0 0x20000>;
> > + renesas,ipmmu-main = <&ipmmu_mm 2>;
>
> Bit 2 nor HSC are documented in the MMU Interrupt Status Register
> (IMSSTR) register in Rev. 0.51 of the R-Car S4 Hardware User's Manual.
I got it. I'll remove this.
> > + power-domains = <&sysc R8A779F0_PD_ALWAYS_ON>;
> > + #iommu-cells = <1>;
> > + };
> > +
> > + ipmmu_mm: iommu@eefc0000 {
> > + compatible = "renesas,ipmmu-r8a779f0",
> > + "renesas,rcar-gen4-ipmmu";
> > + reg = <0 0xeefc0000 0 0x20000>;
> > + interrupts = <GIC_SPI 21 IRQ_TYPE_LEVEL_HIGH>,
> > + <GIC_SPI 22 IRQ_TYPE_LEVEL_HIGH>;
> > + power-domains = <&sysc R8A779F0_PD_ALWAYS_ON>;
> > + #iommu-cells = <1>;
> > + };
> > +
>
> The rest looks good to me.
Thanks!
Best regards,
Yoshihiro Shimoda
^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: [PATCH 1/2] arm64: dts: renesas: r8a779f0: Add IPMMU nodes
2022-05-30 1:08 ` Yoshihiro Shimoda
@ 2022-05-30 1:19 ` Yoshihiro Shimoda
0 siblings, 0 replies; 7+ messages in thread
From: Yoshihiro Shimoda @ 2022-05-30 1:19 UTC (permalink / raw)
To: Geert Uytterhoeven; +Cc: Magnus Damm, Linux-Renesas
Hi Geert-san again,
> From: Yoshihiro Shimoda, Sent: Monday, May 30, 2022 10:09 AM
> > From: Geert Uytterhoeven, Sent: Wednesday, February 2, 2022 6:21 PM
> >
> > Hi Shimodan-san,
> >
> > On Tue, Jan 25, 2022 at 2:00 PM Yoshihiro Shimoda
> > <yoshihiro.shimoda.uh@renesas.com> wrote:
> > > Add IPMMU nodes for r8a779f0.
> > >
> > > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> >
> > Thanks for your patch!
>
> Thank you for your review! And, I'm sorry, I completely overlooked this email...
>
> > > --- a/arch/arm64/boot/dts/renesas/r8a779f0.dtsi
> > > +++ b/arch/arm64/boot/dts/renesas/r8a779f0.dtsi
> > > @@ -164,6 +164,52 @@ dmac1: dma-controller@e7351000 {
> > > dma-channels = <16>;
> > > };
> > >
> > > + ipmmu_rt0: iommu@ee480000 {
> > > + compatible = "renesas,ipmmu-r8a779f0",
> > > + "renesas,rcar-gen4-ipmmu";
> > > + reg = <0 0xee480000 0 0x20000>;
> > > + renesas,ipmmu-main = <&ipmmu_mm 10>;
> > > + power-domains = <&sysc R8A779F0_PD_ALWAYS_ON>;
> > > + #iommu-cells = <1>;
> > > + };
> > > +
> > > + ipmmu_rt1: iommu@ee4c0000 {
> > > + compatible = "renesas,ipmmu-r8a779f0",
> > > + "renesas,rcar-gen4-ipmmu";
> > > + reg = <0 0xee4c0000 0 0x20000>;
> > > + renesas,ipmmu-main = <&ipmmu_mm 19>;
> > > + power-domains = <&sysc R8A779F0_PD_ALWAYS_ON>;
> > > + #iommu-cells = <1>;
> > > + };
> > > +
> > > + ipmmu_ds0: iommu@eed00000 {
> > > + compatible = "renesas,ipmmu-r8a779f0",
> > > + "renesas,rcar-gen4-ipmmu";
> > > + reg = <0 0xeed00000 0 0x20000>;
> > > + renesas,ipmmu-main = <&ipmmu_mm 0>;
> > > + power-domains = <&sysc R8A779F0_PD_ALWAYS_ON>;
> > > + #iommu-cells = <1>;
> > > + };
> > > +
> > > + ipmmu_hsc: iommu@eed40000 {
> > > + compatible = "renesas,ipmmu-r8a779f0",
> > > + "renesas,rcar-gen4-ipmmu";
> > > + reg = <0 0xeed40000 0 0x20000>;
> > > + renesas,ipmmu-main = <&ipmmu_mm 2>;
> >
> > Bit 2 nor HSC are documented in the MMU Interrupt Status Register
> > (IMSSTR) register in Rev. 0.51 of the R-Car S4 Hardware User's Manual.
>
> I got it. I'll remove this.
I'm sorry again, but I checked the Rev.0.70 of the R-Car S4 Hardware User's Manual
and then the Bit 2 HC is documented in the register. So, I'll rename it.
Best regards,
Yoshihiro Shimoda
> > > + power-domains = <&sysc R8A779F0_PD_ALWAYS_ON>;
> > > + #iommu-cells = <1>;
> > > + };
> > > +
> > > + ipmmu_mm: iommu@eefc0000 {
> > > + compatible = "renesas,ipmmu-r8a779f0",
> > > + "renesas,rcar-gen4-ipmmu";
> > > + reg = <0 0xeefc0000 0 0x20000>;
> > > + interrupts = <GIC_SPI 21 IRQ_TYPE_LEVEL_HIGH>,
> > > + <GIC_SPI 22 IRQ_TYPE_LEVEL_HIGH>;
> > > + power-domains = <&sysc R8A779F0_PD_ALWAYS_ON>;
> > > + #iommu-cells = <1>;
> > > + };
> > > +
> >
> > The rest looks good to me.
>
> Thanks!
>
> Best regards,
> Yoshihiro Shimoda
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2022-05-30 1:19 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-25 13:00 [PATCH 0/2] arm64: dts: renesas: r8a779f0: Add IPMMU nodes Yoshihiro Shimoda
2022-01-25 13:00 ` [PATCH 1/2] " Yoshihiro Shimoda
2022-02-02 9:21 ` Geert Uytterhoeven
2022-05-30 1:08 ` Yoshihiro Shimoda
2022-05-30 1:19 ` Yoshihiro Shimoda
2022-01-25 13:00 ` [PATCH 2/2] arm64: dts: renesas: r8a779f0: Add iommus in dmac nodes Yoshihiro Shimoda
2022-02-02 9:38 ` Geert Uytterhoeven
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).