* [PATCH 0/2] phy: renesas: Add Renesas Ethernet SERDES driver for R-Car S4-8 @ 2022-09-22 5:16 Yoshihiro Shimoda 2022-09-22 5:16 ` [PATCH 1/2] dt-bindings: phy: renesas: Document Renesas Ethernet SERDES Yoshihiro Shimoda 2022-09-22 5:16 ` [PATCH 2/2] phy: renesas: Add Renesas Ethernet SERDES driver for R-Car S4-8 Yoshihiro Shimoda 0 siblings, 2 replies; 6+ messages in thread From: Yoshihiro Shimoda @ 2022-09-22 5:16 UTC (permalink / raw) To: kishon, vkoul, robh+dt, krzysztof.kozlowski+dt Cc: linux-phy, devicetree, linux-renesas-soc, Yoshihiro Shimoda This patch series is based on next-20220915. Add support for R-Car S4-8 Etherent SERDES as a Generic PHY. This patch series is the same as the following patches, but separate patches into each subsystem: https://lore.kernel.org/all/20220921084745.3355107-3-yoshihiro.shimoda.uh@renesas.com/ https://lore.kernel.org/all/20220921084745.3355107-4-yoshihiro.shimoda.uh@renesas.com/ Yoshihiro Shimoda (2): dt-bindings: phy: renesas: Document Renesas Ethernet SERDES phy: renesas: Add Renesas Ethernet SERDES driver for R-Car S4-8 .../bindings/phy/renesas,ether-serdes.yaml | 54 ++++ drivers/phy/renesas/Kconfig | 7 + drivers/phy/renesas/Makefile | 2 +- drivers/phy/renesas/r8a779f0-ether-serdes.c | 303 ++++++++++++++++++ 4 files changed, 365 insertions(+), 1 deletion(-) create mode 100644 Documentation/devicetree/bindings/phy/renesas,ether-serdes.yaml create mode 100644 drivers/phy/renesas/r8a779f0-ether-serdes.c -- 2.25.1 ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 1/2] dt-bindings: phy: renesas: Document Renesas Ethernet SERDES 2022-09-22 5:16 [PATCH 0/2] phy: renesas: Add Renesas Ethernet SERDES driver for R-Car S4-8 Yoshihiro Shimoda @ 2022-09-22 5:16 ` Yoshihiro Shimoda 2022-09-22 7:40 ` Krzysztof Kozlowski 2022-09-22 5:16 ` [PATCH 2/2] phy: renesas: Add Renesas Ethernet SERDES driver for R-Car S4-8 Yoshihiro Shimoda 1 sibling, 1 reply; 6+ messages in thread From: Yoshihiro Shimoda @ 2022-09-22 5:16 UTC (permalink / raw) To: kishon, vkoul, robh+dt, krzysztof.kozlowski+dt Cc: linux-phy, devicetree, linux-renesas-soc, Yoshihiro Shimoda Document Renesas Etherent SERDES for R-Car S4-8 (r8a779f0). Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> --- .../bindings/phy/renesas,ether-serdes.yaml | 54 +++++++++++++++++++ 1 file changed, 54 insertions(+) create mode 100644 Documentation/devicetree/bindings/phy/renesas,ether-serdes.yaml diff --git a/Documentation/devicetree/bindings/phy/renesas,ether-serdes.yaml b/Documentation/devicetree/bindings/phy/renesas,ether-serdes.yaml new file mode 100644 index 000000000000..04d650244a6a --- /dev/null +++ b/Documentation/devicetree/bindings/phy/renesas,ether-serdes.yaml @@ -0,0 +1,54 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/phy/renesas,ether-serdes.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Renesas Ethernet SERDES + +maintainers: + - Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> + +properties: + compatible: + const: renesas,r8a779f0-ether-serdes + + reg: + maxItems: 1 + + clocks: + maxItems: 1 + + resets: + maxItems: 1 + + power-domains: + maxItems: 1 + + '#phy-cells': + description: Port number of SERDES. + const: 1 + +required: + - compatible + - reg + - clocks + - resets + - power-domains + - '#phy-cells' + +additionalProperties: false + +examples: + - | + #include <dt-bindings/clock/r8a779f0-cpg-mssr.h> + #include <dt-bindings/power/r8a779f0-sysc.h> + + ethernet@e6880000 { + compatible = "renesas,r8a779f0-ether-serdes"; + reg = <0xe6444000 0xc00>; + clocks = <&cpg CPG_MOD 1506>; + power-domains = <&sysc R8A779F0_PD_ALWAYS_ON>; + resets = <&cpg 1506>; + #phy-cells = <1>; + }; -- 2.25.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] dt-bindings: phy: renesas: Document Renesas Ethernet SERDES 2022-09-22 5:16 ` [PATCH 1/2] dt-bindings: phy: renesas: Document Renesas Ethernet SERDES Yoshihiro Shimoda @ 2022-09-22 7:40 ` Krzysztof Kozlowski 0 siblings, 0 replies; 6+ messages in thread From: Krzysztof Kozlowski @ 2022-09-22 7:40 UTC (permalink / raw) To: Yoshihiro Shimoda, kishon, vkoul, robh+dt, krzysztof.kozlowski+dt Cc: linux-phy, devicetree, linux-renesas-soc On 22/09/2022 07:16, Yoshihiro Shimoda wrote: > Document Renesas Etherent SERDES for R-Car S4-8 (r8a779f0). > > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> > --- > .../bindings/phy/renesas,ether-serdes.yaml | 54 +++++++++++++++++++ > 1 file changed, 54 insertions(+) > create mode 100644 Documentation/devicetree/bindings/phy/renesas,ether-serdes.yaml > Thank you for your patch. There is something to discuss/improve. > diff --git a/Documentation/devicetree/bindings/phy/renesas,ether-serdes.yaml b/Documentation/devicetree/bindings/phy/renesas,ether-serdes.yaml > new file mode 100644 > index 000000000000..04d650244a6a > --- /dev/null > +++ b/Documentation/devicetree/bindings/phy/renesas,ether-serdes.yaml All the comments from v2 are still applicable. Please fix or respond. Best regards, Krzysztof ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 2/2] phy: renesas: Add Renesas Ethernet SERDES driver for R-Car S4-8 2022-09-22 5:16 [PATCH 0/2] phy: renesas: Add Renesas Ethernet SERDES driver for R-Car S4-8 Yoshihiro Shimoda 2022-09-22 5:16 ` [PATCH 1/2] dt-bindings: phy: renesas: Document Renesas Ethernet SERDES Yoshihiro Shimoda @ 2022-09-22 5:16 ` Yoshihiro Shimoda 2022-09-24 7:08 ` Vinod Koul 1 sibling, 1 reply; 6+ messages in thread From: Yoshihiro Shimoda @ 2022-09-22 5:16 UTC (permalink / raw) To: kishon, vkoul, robh+dt, krzysztof.kozlowski+dt Cc: linux-phy, devicetree, linux-renesas-soc, Yoshihiro Shimoda Add Renesas Ethernet SERDES driver for R-Car S4-8 (r8a779f0). Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> --- drivers/phy/renesas/Kconfig | 7 + drivers/phy/renesas/Makefile | 2 +- drivers/phy/renesas/r8a779f0-ether-serdes.c | 303 ++++++++++++++++++++ 3 files changed, 311 insertions(+), 1 deletion(-) create mode 100644 drivers/phy/renesas/r8a779f0-ether-serdes.c diff --git a/drivers/phy/renesas/Kconfig b/drivers/phy/renesas/Kconfig index 111bdcae775c..68f160b0e8ef 100644 --- a/drivers/phy/renesas/Kconfig +++ b/drivers/phy/renesas/Kconfig @@ -32,3 +32,10 @@ config PHY_RCAR_GEN3_USB3 select GENERIC_PHY help Support for USB 3.0 PHY found on Renesas R-Car generation 3 SoCs. + +config PHY_R8A779F0_ETHERNET_SERDES + tristate "Renesas R-Car S4-8 Ethernet SERDES driver" + depends on ARCH_RENESAS || COMPILE_TEST + select GENERIC_PHY + help + Support for Ethernet SERDES found on Renesas R-Car S4-8 SoCs. diff --git a/drivers/phy/renesas/Makefile b/drivers/phy/renesas/Makefile index b599ff8a4349..a2db7125da19 100644 --- a/drivers/phy/renesas/Makefile +++ b/drivers/phy/renesas/Makefile @@ -1,5 +1,5 @@ # SPDX-License-Identifier: GPL-2.0 +obj-$(CONFIG_PHY_R8A779F0_ETHERNET_SERDES) += r8a779f0-ether-serdes.o obj-$(CONFIG_PHY_RCAR_GEN2) += phy-rcar-gen2.o obj-$(CONFIG_PHY_RCAR_GEN3_PCIE) += phy-rcar-gen3-pcie.o obj-$(CONFIG_PHY_RCAR_GEN3_USB2) += phy-rcar-gen3-usb2.o -obj-$(CONFIG_PHY_RCAR_GEN3_USB3) += phy-rcar-gen3-usb3.o diff --git a/drivers/phy/renesas/r8a779f0-ether-serdes.c b/drivers/phy/renesas/r8a779f0-ether-serdes.c new file mode 100644 index 000000000000..1aaf70b3ed3d --- /dev/null +++ b/drivers/phy/renesas/r8a779f0-ether-serdes.c @@ -0,0 +1,303 @@ +// SPDX-License-Identifier: GPL-2.0 +/* Renesas Ethernet SERDES device driver + * + * Copyright (C) 2022 Renesas Electronics Corporation + */ + +#include <linux/delay.h> +#include <linux/err.h> +#include <linux/iopoll.h> +#include <linux/kernel.h> +#include <linux/phy.h> +#include <linux/phy/phy.h> +#include <linux/platform_device.h> + +#define R8A779F0_ETH_SERDES_NUM 3 +#define R8A779F0_ETH_SERDES_OFFSET 0x0400 +#define R8A779F0_ETH_SERDES_BANK_SELECT 0x03fc +#define R8A779F0_ETH_SERDES_TIMEOUT_US 100000 + +struct r8a779f0_eth_serdes_channel { + struct phy *phy; + void __iomem *addr; + void __iomem *addr0; + phy_interface_t phy_interface; + int speed; +}; + +struct r8a779f0_eth_serdes_drv_data { + void __iomem *addr; + struct platform_device *pdev; + struct r8a779f0_eth_serdes_channel channel[R8A779F0_ETH_SERDES_NUM]; +}; + +/* + * The datasheet describes initialization procedure without any information + * about registers' name/bits. So, this is all black magic to initialize + * the hardware. + */ +static void r8a779f0_eth_serdes_write32(void __iomem *addr, u32 offs, u32 bank, u32 data) +{ + iowrite32(bank, addr + R8A779F0_ETH_SERDES_BANK_SELECT); + iowrite32(data, addr + offs); +} + +static int r8a779f0_eth_serdes_reg_wait(void __iomem *addr, u32 offs, u32 bank, + u32 mask, u32 expected) +{ + u32 val; + + iowrite32(bank, addr + R8A779F0_ETH_SERDES_BANK_SELECT); + + return readl_poll_timeout_atomic(addr + offs, val, (val & mask) == expected, + 1, R8A779F0_ETH_SERDES_TIMEOUT_US); +} + +static int +r8a779f0_eth_serdes_common_init_ram(struct r8a779f0_eth_serdes_channel *channel) +{ + int ret; + + ret = r8a779f0_eth_serdes_reg_wait(channel->addr, 0x026c, 0x180, BIT(0), 0x01); + if (ret) + return ret; + + r8a779f0_eth_serdes_write32(channel->addr0, 0x026c, 0x180, 0x03); + + return ret; +} + +static int +r8a779f0_eth_serdes_common_setting(struct r8a779f0_eth_serdes_channel *channel) +{ + switch (channel->phy_interface) { + case PHY_INTERFACE_MODE_SGMII: + r8a779f0_eth_serdes_write32(channel->addr0, 0x0244, 0x180, 0x0097); + r8a779f0_eth_serdes_write32(channel->addr0, 0x01d0, 0x180, 0x0060); + r8a779f0_eth_serdes_write32(channel->addr0, 0x01d8, 0x180, 0x2200); + r8a779f0_eth_serdes_write32(channel->addr0, 0x01d4, 0x180, 0x0000); + r8a779f0_eth_serdes_write32(channel->addr0, 0x01e0, 0x180, 0x003d); + return 0; + default: + return -EOPNOTSUPP; + } +} + +static int +r8a779f0_eth_serdes_chan_setting(struct r8a779f0_eth_serdes_channel *channel) +{ + int ret; + + switch (channel->phy_interface) { + case PHY_INTERFACE_MODE_SGMII: + r8a779f0_eth_serdes_write32(channel->addr, 0x0000, 0x380, 0x2000); + r8a779f0_eth_serdes_write32(channel->addr, 0x01c0, 0x180, 0x0011); + r8a779f0_eth_serdes_write32(channel->addr, 0x0248, 0x180, 0x0540); + r8a779f0_eth_serdes_write32(channel->addr, 0x0258, 0x180, 0x0015); + r8a779f0_eth_serdes_write32(channel->addr, 0x0144, 0x180, 0x0100); + r8a779f0_eth_serdes_write32(channel->addr, 0x01a0, 0x180, 0x0000); + r8a779f0_eth_serdes_write32(channel->addr, 0x00d0, 0x180, 0x0002); + r8a779f0_eth_serdes_write32(channel->addr, 0x0150, 0x180, 0x0003); + r8a779f0_eth_serdes_write32(channel->addr, 0x00c8, 0x180, 0x0100); + r8a779f0_eth_serdes_write32(channel->addr, 0x0148, 0x180, 0x0100); + r8a779f0_eth_serdes_write32(channel->addr, 0x0174, 0x180, 0x0000); + r8a779f0_eth_serdes_write32(channel->addr, 0x0160, 0x180, 0x0007); + r8a779f0_eth_serdes_write32(channel->addr, 0x01ac, 0x180, 0x0000); + r8a779f0_eth_serdes_write32(channel->addr, 0x00c4, 0x180, 0x0310); + r8a779f0_eth_serdes_write32(channel->addr, 0x00c8, 0x380, 0x0101); + ret = r8a779f0_eth_serdes_reg_wait(channel->addr, 0x00c8, 0x0180, BIT(0), 0); + if (ret) + return ret; + + r8a779f0_eth_serdes_write32(channel->addr, 0x0148, 0x180, 0x0101); + ret = r8a779f0_eth_serdes_reg_wait(channel->addr, 0x0148, 0x0180, BIT(0), 0); + if (ret) + return ret; + + r8a779f0_eth_serdes_write32(channel->addr, 0x00c4, 0x180, 0x1310); + r8a779f0_eth_serdes_write32(channel->addr, 0x00d8, 0x180, 0x1800); + r8a779f0_eth_serdes_write32(channel->addr, 0x00dc, 0x180, 0x0000); + r8a779f0_eth_serdes_write32(channel->addr, 0x001c, 0x300, 0x0001); + r8a779f0_eth_serdes_write32(channel->addr, 0x0000, 0x380, 0x2100); + ret = r8a779f0_eth_serdes_reg_wait(channel->addr, 0x0000, 0x0380, BIT(8), 0); + if (ret) + return ret; + + if (channel->speed == 1000) + r8a779f0_eth_serdes_write32(channel->addr, 0x0000, 0x1f00, 0x0140); + else if (channel->speed == 100) + r8a779f0_eth_serdes_write32(channel->addr, 0x0000, 0x1f00, 0x2100); + break; + default: + return -EOPNOTSUPP; + } + + return 0; +} + +static int r8a779f0_eth_serdes_hw_init(struct r8a779f0_eth_serdes_channel *channel) +{ + int ret; + + ret = r8a779f0_eth_serdes_common_init_ram(channel); + if (ret) + return ret; + + ret = r8a779f0_eth_serdes_reg_wait(channel->addr, 0x0000, 0x300, BIT(15), 0); + if (ret) + return ret; + + r8a779f0_eth_serdes_write32(channel->addr, 0x03d4, 0x380, 0x0443); + + ret = r8a779f0_eth_serdes_common_setting(channel); + if (ret) + return ret; + + r8a779f0_eth_serdes_write32(channel->addr, 0x03d0, 0x380, 0x0001); + + r8a779f0_eth_serdes_write32(channel->addr0, 0x0000, 0x380, 0x8000); + + ret = r8a779f0_eth_serdes_common_init_ram(channel); + if (ret) + return ret; + + ret = r8a779f0_eth_serdes_reg_wait(channel->addr0, 0x0000, 0x380, BIT(15), 0); + if (ret) + return ret; + + ret = r8a779f0_eth_serdes_chan_setting(channel); + if (ret) + return ret; + + r8a779f0_eth_serdes_write32(channel->addr, 0x03c0, 0x380, 0x0000); + r8a779f0_eth_serdes_write32(channel->addr, 0x03d0, 0x380, 0x0000); + + return 0; +} + +static int r8a779f0_eth_serdes_init(struct phy *p) +{ + struct r8a779f0_eth_serdes_channel *channel = phy_get_drvdata(p); + + return r8a779f0_eth_serdes_hw_init(channel); +} + +static int r8a779f0_eth_serdes_set_mode(struct phy *p, enum phy_mode mode, + int submode) +{ + struct r8a779f0_eth_serdes_channel *channel = phy_get_drvdata(p); + + if (mode != PHY_MODE_ETHERNET) + return -EOPNOTSUPP; + + switch (submode) { + case PHY_INTERFACE_MODE_GMII: + case PHY_INTERFACE_MODE_SGMII: + case PHY_INTERFACE_MODE_USXGMII: + channel->phy_interface = submode; + return 0; + default: + return -EOPNOTSUPP; + } +} + +static int r8a779f0_eth_serdes_set_speed(struct phy *p, int speed) +{ + struct r8a779f0_eth_serdes_channel *channel = phy_get_drvdata(p); + + channel->speed = speed; + + return 0; +} + +static const struct phy_ops r8a779f0_eth_serdes_ops = { + .init = r8a779f0_eth_serdes_init, + .set_mode = r8a779f0_eth_serdes_set_mode, + .set_speed = r8a779f0_eth_serdes_set_speed, +}; + +static struct phy *r8a779f0_eth_serdes_xlate(struct device *dev, + struct of_phandle_args *args) +{ + struct r8a779f0_eth_serdes_drv_data *dd = dev_get_drvdata(dev); + + if (args->args[0] >= R8A779F0_ETH_SERDES_NUM) + return ERR_PTR(-ENODEV); + + return dd->channel[args->args[0]].phy; +} + +static const struct of_device_id r8a779f0_eth_serdes_of_table[] = { + { .compatible = "renesas,r8a779f0-ether-serdes", }, + { } +}; +MODULE_DEVICE_TABLE(of, r8a779f0_eth_serdes_of_table); + +static int r8a779f0_eth_serdes_probe(struct platform_device *pdev) +{ + struct r8a779f0_eth_serdes_drv_data *dd; + struct phy_provider *provider; + struct resource *res; + int i, ret; + + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); + if (!res) { + dev_err(&pdev->dev, "invalid resource\n"); + return -EINVAL; + } + + dd = devm_kzalloc(&pdev->dev, sizeof(*dd), GFP_KERNEL); + if (!dd) + return -ENOMEM; + + platform_set_drvdata(pdev, dd); + dd->pdev = pdev; + dd->addr = devm_ioremap_resource(&pdev->dev, res); + if (IS_ERR(dd->addr)) + return PTR_ERR(dd->addr); + + for (i = 0; i < R8A779F0_ETH_SERDES_NUM; i++) { + struct r8a779f0_eth_serdes_channel *channel = &dd->channel[i]; + + channel->phy = devm_phy_create(&pdev->dev, NULL, + &r8a779f0_eth_serdes_ops); + if (IS_ERR(channel->phy)) + return PTR_ERR(channel->phy); + channel->addr = dd->addr + R8A779F0_ETH_SERDES_OFFSET * i; + channel->addr0 = dd->addr; + phy_set_drvdata(channel->phy, channel); + } + + provider = devm_of_phy_provider_register(&pdev->dev, + r8a779f0_eth_serdes_xlate); + if (IS_ERR(provider)) + return PTR_ERR(provider); + + pm_runtime_enable(&pdev->dev); + pm_runtime_get_sync(&pdev->dev); + + return ret; +} + +static int r8a779f0_eth_serdes_remove(struct platform_device *pdev) +{ + pm_runtime_put(&pdev->dev); + pm_runtime_disable(&pdev->dev); + + platform_set_drvdata(pdev, NULL); + + return 0; +} + +static struct platform_driver r8a779f0_eth_serdes_driver_platform = { + .probe = r8a779f0_eth_serdes_probe, + .remove = r8a779f0_eth_serdes_remove, + .driver = { + .name = "r8a779f0_eth_serdes", + .of_match_table = r8a779f0_eth_serdes_of_table, + } +}; +module_platform_driver(r8a779f0_eth_serdes_driver_platform); +MODULE_AUTHOR("Yoshihiro Shimoda"); +MODULE_DESCRIPTION("Renesas Ethernet SERDES device driver"); +MODULE_LICENSE("GPL"); -- 2.25.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] phy: renesas: Add Renesas Ethernet SERDES driver for R-Car S4-8 2022-09-22 5:16 ` [PATCH 2/2] phy: renesas: Add Renesas Ethernet SERDES driver for R-Car S4-8 Yoshihiro Shimoda @ 2022-09-24 7:08 ` Vinod Koul 2022-09-26 0:24 ` Yoshihiro Shimoda 0 siblings, 1 reply; 6+ messages in thread From: Vinod Koul @ 2022-09-24 7:08 UTC (permalink / raw) To: Yoshihiro Shimoda Cc: kishon, robh+dt, krzysztof.kozlowski+dt, linux-phy, devicetree, linux-renesas-soc On 22-09-22, 14:16, Yoshihiro Shimoda wrote: > Add Renesas Ethernet SERDES driver for R-Car S4-8 (r8a779f0). > > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> > --- > drivers/phy/renesas/Kconfig | 7 + > drivers/phy/renesas/Makefile | 2 +- > drivers/phy/renesas/r8a779f0-ether-serdes.c | 303 ++++++++++++++++++++ > 3 files changed, 311 insertions(+), 1 deletion(-) > create mode 100644 drivers/phy/renesas/r8a779f0-ether-serdes.c > > diff --git a/drivers/phy/renesas/Kconfig b/drivers/phy/renesas/Kconfig > index 111bdcae775c..68f160b0e8ef 100644 > --- a/drivers/phy/renesas/Kconfig > +++ b/drivers/phy/renesas/Kconfig > @@ -32,3 +32,10 @@ config PHY_RCAR_GEN3_USB3 > select GENERIC_PHY > help > Support for USB 3.0 PHY found on Renesas R-Car generation 3 SoCs. > + > +config PHY_R8A779F0_ETHERNET_SERDES > + tristate "Renesas R-Car S4-8 Ethernet SERDES driver" > + depends on ARCH_RENESAS || COMPILE_TEST > + select GENERIC_PHY > + help > + Support for Ethernet SERDES found on Renesas R-Car S4-8 SoCs. > diff --git a/drivers/phy/renesas/Makefile b/drivers/phy/renesas/Makefile > index b599ff8a4349..a2db7125da19 100644 > --- a/drivers/phy/renesas/Makefile > +++ b/drivers/phy/renesas/Makefile > @@ -1,5 +1,5 @@ > # SPDX-License-Identifier: GPL-2.0 > +obj-$(CONFIG_PHY_R8A779F0_ETHERNET_SERDES) += r8a779f0-ether-serdes.o > obj-$(CONFIG_PHY_RCAR_GEN2) += phy-rcar-gen2.o > obj-$(CONFIG_PHY_RCAR_GEN3_PCIE) += phy-rcar-gen3-pcie.o > obj-$(CONFIG_PHY_RCAR_GEN3_USB2) += phy-rcar-gen3-usb2.o > -obj-$(CONFIG_PHY_RCAR_GEN3_USB3) += phy-rcar-gen3-usb3.o Why? > diff --git a/drivers/phy/renesas/r8a779f0-ether-serdes.c b/drivers/phy/renesas/r8a779f0-ether-serdes.c > new file mode 100644 > index 000000000000..1aaf70b3ed3d > --- /dev/null > +++ b/drivers/phy/renesas/r8a779f0-ether-serdes.c > @@ -0,0 +1,303 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* Renesas Ethernet SERDES device driver > + * > + * Copyright (C) 2022 Renesas Electronics Corporation > + */ > + > +#include <linux/delay.h> > +#include <linux/err.h> > +#include <linux/iopoll.h> > +#include <linux/kernel.h> > +#include <linux/phy.h> > +#include <linux/phy/phy.h> > +#include <linux/platform_device.h> > + > +#define R8A779F0_ETH_SERDES_NUM 3 > +#define R8A779F0_ETH_SERDES_OFFSET 0x0400 > +#define R8A779F0_ETH_SERDES_BANK_SELECT 0x03fc > +#define R8A779F0_ETH_SERDES_TIMEOUT_US 100000 > + > +struct r8a779f0_eth_serdes_channel { > + struct phy *phy; > + void __iomem *addr; > + void __iomem *addr0; > + phy_interface_t phy_interface; > + int speed; > +}; > + > +struct r8a779f0_eth_serdes_drv_data { > + void __iomem *addr; > + struct platform_device *pdev; > + struct r8a779f0_eth_serdes_channel channel[R8A779F0_ETH_SERDES_NUM]; > +}; > + > +/* > + * The datasheet describes initialization procedure without any information > + * about registers' name/bits. So, this is all black magic to initialize > + * the hardware. > + */ > +static void r8a779f0_eth_serdes_write32(void __iomem *addr, u32 offs, u32 bank, u32 data) > +{ > + iowrite32(bank, addr + R8A779F0_ETH_SERDES_BANK_SELECT); > + iowrite32(data, addr + offs); > +} > + > +static int r8a779f0_eth_serdes_reg_wait(void __iomem *addr, u32 offs, u32 bank, > + u32 mask, u32 expected) > +{ > + u32 val; > + > + iowrite32(bank, addr + R8A779F0_ETH_SERDES_BANK_SELECT); > + > + return readl_poll_timeout_atomic(addr + offs, val, (val & mask) == expected, > + 1, R8A779F0_ETH_SERDES_TIMEOUT_US); > +} > + > +static int > +r8a779f0_eth_serdes_common_init_ram(struct r8a779f0_eth_serdes_channel *channel) > +{ > + int ret; > + > + ret = r8a779f0_eth_serdes_reg_wait(channel->addr, 0x026c, 0x180, BIT(0), 0x01); > + if (ret) > + return ret; > + > + r8a779f0_eth_serdes_write32(channel->addr0, 0x026c, 0x180, 0x03); > + > + return ret; > +} > + > +static int > +r8a779f0_eth_serdes_common_setting(struct r8a779f0_eth_serdes_channel *channel) > +{ > + switch (channel->phy_interface) { > + case PHY_INTERFACE_MODE_SGMII: > + r8a779f0_eth_serdes_write32(channel->addr0, 0x0244, 0x180, 0x0097); > + r8a779f0_eth_serdes_write32(channel->addr0, 0x01d0, 0x180, 0x0060); > + r8a779f0_eth_serdes_write32(channel->addr0, 0x01d8, 0x180, 0x2200); > + r8a779f0_eth_serdes_write32(channel->addr0, 0x01d4, 0x180, 0x0000); > + r8a779f0_eth_serdes_write32(channel->addr0, 0x01e0, 0x180, 0x003d); > + return 0; > + default: > + return -EOPNOTSUPP; > + } > +} > + > +static int > +r8a779f0_eth_serdes_chan_setting(struct r8a779f0_eth_serdes_channel *channel) > +{ > + int ret; > + > + switch (channel->phy_interface) { > + case PHY_INTERFACE_MODE_SGMII: > + r8a779f0_eth_serdes_write32(channel->addr, 0x0000, 0x380, 0x2000); > + r8a779f0_eth_serdes_write32(channel->addr, 0x01c0, 0x180, 0x0011); > + r8a779f0_eth_serdes_write32(channel->addr, 0x0248, 0x180, 0x0540); > + r8a779f0_eth_serdes_write32(channel->addr, 0x0258, 0x180, 0x0015); > + r8a779f0_eth_serdes_write32(channel->addr, 0x0144, 0x180, 0x0100); > + r8a779f0_eth_serdes_write32(channel->addr, 0x01a0, 0x180, 0x0000); > + r8a779f0_eth_serdes_write32(channel->addr, 0x00d0, 0x180, 0x0002); > + r8a779f0_eth_serdes_write32(channel->addr, 0x0150, 0x180, 0x0003); > + r8a779f0_eth_serdes_write32(channel->addr, 0x00c8, 0x180, 0x0100); > + r8a779f0_eth_serdes_write32(channel->addr, 0x0148, 0x180, 0x0100); > + r8a779f0_eth_serdes_write32(channel->addr, 0x0174, 0x180, 0x0000); > + r8a779f0_eth_serdes_write32(channel->addr, 0x0160, 0x180, 0x0007); > + r8a779f0_eth_serdes_write32(channel->addr, 0x01ac, 0x180, 0x0000); > + r8a779f0_eth_serdes_write32(channel->addr, 0x00c4, 0x180, 0x0310); > + r8a779f0_eth_serdes_write32(channel->addr, 0x00c8, 0x380, 0x0101); > + ret = r8a779f0_eth_serdes_reg_wait(channel->addr, 0x00c8, 0x0180, BIT(0), 0); > + if (ret) > + return ret; > + > + r8a779f0_eth_serdes_write32(channel->addr, 0x0148, 0x180, 0x0101); > + ret = r8a779f0_eth_serdes_reg_wait(channel->addr, 0x0148, 0x0180, BIT(0), 0); > + if (ret) > + return ret; > + > + r8a779f0_eth_serdes_write32(channel->addr, 0x00c4, 0x180, 0x1310); > + r8a779f0_eth_serdes_write32(channel->addr, 0x00d8, 0x180, 0x1800); > + r8a779f0_eth_serdes_write32(channel->addr, 0x00dc, 0x180, 0x0000); > + r8a779f0_eth_serdes_write32(channel->addr, 0x001c, 0x300, 0x0001); > + r8a779f0_eth_serdes_write32(channel->addr, 0x0000, 0x380, 0x2100); > + ret = r8a779f0_eth_serdes_reg_wait(channel->addr, 0x0000, 0x0380, BIT(8), 0); > + if (ret) > + return ret; > + > + if (channel->speed == 1000) > + r8a779f0_eth_serdes_write32(channel->addr, 0x0000, 0x1f00, 0x0140); > + else if (channel->speed == 100) > + r8a779f0_eth_serdes_write32(channel->addr, 0x0000, 0x1f00, 0x2100); > + break; > + default: > + return -EOPNOTSUPP; > + } > + > + return 0; > +} > + > +static int r8a779f0_eth_serdes_hw_init(struct r8a779f0_eth_serdes_channel *channel) > +{ > + int ret; > + > + ret = r8a779f0_eth_serdes_common_init_ram(channel); > + if (ret) > + return ret; > + > + ret = r8a779f0_eth_serdes_reg_wait(channel->addr, 0x0000, 0x300, BIT(15), 0); > + if (ret) > + return ret; > + > + r8a779f0_eth_serdes_write32(channel->addr, 0x03d4, 0x380, 0x0443); > + > + ret = r8a779f0_eth_serdes_common_setting(channel); > + if (ret) > + return ret; > + > + r8a779f0_eth_serdes_write32(channel->addr, 0x03d0, 0x380, 0x0001); > + > + r8a779f0_eth_serdes_write32(channel->addr0, 0x0000, 0x380, 0x8000); > + > + ret = r8a779f0_eth_serdes_common_init_ram(channel); > + if (ret) > + return ret; > + > + ret = r8a779f0_eth_serdes_reg_wait(channel->addr0, 0x0000, 0x380, BIT(15), 0); > + if (ret) > + return ret; > + > + ret = r8a779f0_eth_serdes_chan_setting(channel); > + if (ret) > + return ret; > + > + r8a779f0_eth_serdes_write32(channel->addr, 0x03c0, 0x380, 0x0000); > + r8a779f0_eth_serdes_write32(channel->addr, 0x03d0, 0x380, 0x0000); > + > + return 0; > +} > + > +static int r8a779f0_eth_serdes_init(struct phy *p) > +{ > + struct r8a779f0_eth_serdes_channel *channel = phy_get_drvdata(p); > + > + return r8a779f0_eth_serdes_hw_init(channel); > +} > + > +static int r8a779f0_eth_serdes_set_mode(struct phy *p, enum phy_mode mode, > + int submode) > +{ > + struct r8a779f0_eth_serdes_channel *channel = phy_get_drvdata(p); > + > + if (mode != PHY_MODE_ETHERNET) > + return -EOPNOTSUPP; > + > + switch (submode) { > + case PHY_INTERFACE_MODE_GMII: > + case PHY_INTERFACE_MODE_SGMII: > + case PHY_INTERFACE_MODE_USXGMII: > + channel->phy_interface = submode; > + return 0; > + default: > + return -EOPNOTSUPP; > + } > +} > + > +static int r8a779f0_eth_serdes_set_speed(struct phy *p, int speed) > +{ > + struct r8a779f0_eth_serdes_channel *channel = phy_get_drvdata(p); > + > + channel->speed = speed; > + > + return 0; > +} > + > +static const struct phy_ops r8a779f0_eth_serdes_ops = { > + .init = r8a779f0_eth_serdes_init, > + .set_mode = r8a779f0_eth_serdes_set_mode, > + .set_speed = r8a779f0_eth_serdes_set_speed, > +}; > + > +static struct phy *r8a779f0_eth_serdes_xlate(struct device *dev, > + struct of_phandle_args *args) > +{ > + struct r8a779f0_eth_serdes_drv_data *dd = dev_get_drvdata(dev); > + > + if (args->args[0] >= R8A779F0_ETH_SERDES_NUM) > + return ERR_PTR(-ENODEV); > + > + return dd->channel[args->args[0]].phy; > +} > + > +static const struct of_device_id r8a779f0_eth_serdes_of_table[] = { > + { .compatible = "renesas,r8a779f0-ether-serdes", }, > + { } > +}; > +MODULE_DEVICE_TABLE(of, r8a779f0_eth_serdes_of_table); > + > +static int r8a779f0_eth_serdes_probe(struct platform_device *pdev) > +{ > + struct r8a779f0_eth_serdes_drv_data *dd; > + struct phy_provider *provider; > + struct resource *res; > + int i, ret; > + > + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > + if (!res) { > + dev_err(&pdev->dev, "invalid resource\n"); > + return -EINVAL; > + } > + > + dd = devm_kzalloc(&pdev->dev, sizeof(*dd), GFP_KERNEL); > + if (!dd) > + return -ENOMEM; > + > + platform_set_drvdata(pdev, dd); > + dd->pdev = pdev; > + dd->addr = devm_ioremap_resource(&pdev->dev, res); > + if (IS_ERR(dd->addr)) > + return PTR_ERR(dd->addr); > + > + for (i = 0; i < R8A779F0_ETH_SERDES_NUM; i++) { > + struct r8a779f0_eth_serdes_channel *channel = &dd->channel[i]; > + > + channel->phy = devm_phy_create(&pdev->dev, NULL, > + &r8a779f0_eth_serdes_ops); > + if (IS_ERR(channel->phy)) > + return PTR_ERR(channel->phy); > + channel->addr = dd->addr + R8A779F0_ETH_SERDES_OFFSET * i; > + channel->addr0 = dd->addr; > + phy_set_drvdata(channel->phy, channel); > + } > + > + provider = devm_of_phy_provider_register(&pdev->dev, > + r8a779f0_eth_serdes_xlate); > + if (IS_ERR(provider)) > + return PTR_ERR(provider); > + > + pm_runtime_enable(&pdev->dev); > + pm_runtime_get_sync(&pdev->dev); > + > + return ret; > +} > + > +static int r8a779f0_eth_serdes_remove(struct platform_device *pdev) > +{ > + pm_runtime_put(&pdev->dev); > + pm_runtime_disable(&pdev->dev); > + > + platform_set_drvdata(pdev, NULL); > + > + return 0; > +} > + > +static struct platform_driver r8a779f0_eth_serdes_driver_platform = { > + .probe = r8a779f0_eth_serdes_probe, > + .remove = r8a779f0_eth_serdes_remove, > + .driver = { > + .name = "r8a779f0_eth_serdes", > + .of_match_table = r8a779f0_eth_serdes_of_table, > + } > +}; > +module_platform_driver(r8a779f0_eth_serdes_driver_platform); > +MODULE_AUTHOR("Yoshihiro Shimoda"); > +MODULE_DESCRIPTION("Renesas Ethernet SERDES device driver"); > +MODULE_LICENSE("GPL"); > -- > 2.25.1 -- ~Vinod ^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH 2/2] phy: renesas: Add Renesas Ethernet SERDES driver for R-Car S4-8 2022-09-24 7:08 ` Vinod Koul @ 2022-09-26 0:24 ` Yoshihiro Shimoda 0 siblings, 0 replies; 6+ messages in thread From: Yoshihiro Shimoda @ 2022-09-26 0:24 UTC (permalink / raw) To: Vinod Koul Cc: kishon, robh+dt, krzysztof.kozlowski+dt, linux-phy, devicetree, linux-renesas-soc Hi Vinod, > From: Vinod Koul, Sent: Saturday, September 24, 2022 4:08 PM > > On 22-09-22, 14:16, Yoshihiro Shimoda wrote: > > Add Renesas Ethernet SERDES driver for R-Car S4-8 (r8a779f0). > > > > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> > > --- > > drivers/phy/renesas/Kconfig | 7 + > > drivers/phy/renesas/Makefile | 2 +- > > drivers/phy/renesas/r8a779f0-ether-serdes.c | 303 ++++++++++++++++++++ > > 3 files changed, 311 insertions(+), 1 deletion(-) > > create mode 100644 drivers/phy/renesas/r8a779f0-ether-serdes.c > > > > diff --git a/drivers/phy/renesas/Kconfig b/drivers/phy/renesas/Kconfig > > index 111bdcae775c..68f160b0e8ef 100644 > > --- a/drivers/phy/renesas/Kconfig > > +++ b/drivers/phy/renesas/Kconfig > > @@ -32,3 +32,10 @@ config PHY_RCAR_GEN3_USB3 > > select GENERIC_PHY > > help > > Support for USB 3.0 PHY found on Renesas R-Car generation 3 SoCs. > > + > > +config PHY_R8A779F0_ETHERNET_SERDES > > + tristate "Renesas R-Car S4-8 Ethernet SERDES driver" > > + depends on ARCH_RENESAS || COMPILE_TEST > > + select GENERIC_PHY > > + help > > + Support for Ethernet SERDES found on Renesas R-Car S4-8 SoCs. > > diff --git a/drivers/phy/renesas/Makefile b/drivers/phy/renesas/Makefile > > index b599ff8a4349..a2db7125da19 100644 > > --- a/drivers/phy/renesas/Makefile > > +++ b/drivers/phy/renesas/Makefile > > @@ -1,5 +1,5 @@ > > # SPDX-License-Identifier: GPL-2.0 > > +obj-$(CONFIG_PHY_R8A779F0_ETHERNET_SERDES) += r8a779f0-ether-serdes.o > > obj-$(CONFIG_PHY_RCAR_GEN2) += phy-rcar-gen2.o > > obj-$(CONFIG_PHY_RCAR_GEN3_PCIE) += phy-rcar-gen3-pcie.o > > obj-$(CONFIG_PHY_RCAR_GEN3_USB2) += phy-rcar-gen3-usb2.o > > -obj-$(CONFIG_PHY_RCAR_GEN3_USB3) += phy-rcar-gen3-usb3.o > > Why? I'm sorry. I completely mistook to drop it and I completely overlooked this before I submit the patch... I'll fix it. Best regards, Yoshihiro Shimoda > > diff --git a/drivers/phy/renesas/r8a779f0-ether-serdes.c b/drivers/phy/renesas/r8a779f0-ether-serdes.c > > new file mode 100644 > > index 000000000000..1aaf70b3ed3d > > --- /dev/null > > +++ b/drivers/phy/renesas/r8a779f0-ether-serdes.c > > @@ -0,0 +1,303 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > +/* Renesas Ethernet SERDES device driver > > + * > > + * Copyright (C) 2022 Renesas Electronics Corporation > > + */ > > + > > +#include <linux/delay.h> > > +#include <linux/err.h> > > +#include <linux/iopoll.h> > > +#include <linux/kernel.h> > > +#include <linux/phy.h> > > +#include <linux/phy/phy.h> > > +#include <linux/platform_device.h> > > + > > +#define R8A779F0_ETH_SERDES_NUM 3 > > +#define R8A779F0_ETH_SERDES_OFFSET 0x0400 > > +#define R8A779F0_ETH_SERDES_BANK_SELECT 0x03fc > > +#define R8A779F0_ETH_SERDES_TIMEOUT_US 100000 > > + > > +struct r8a779f0_eth_serdes_channel { > > + struct phy *phy; > > + void __iomem *addr; > > + void __iomem *addr0; > > + phy_interface_t phy_interface; > > + int speed; > > +}; > > + > > +struct r8a779f0_eth_serdes_drv_data { > > + void __iomem *addr; > > + struct platform_device *pdev; > > + struct r8a779f0_eth_serdes_channel channel[R8A779F0_ETH_SERDES_NUM]; > > +}; > > + > > +/* > > + * The datasheet describes initialization procedure without any information > > + * about registers' name/bits. So, this is all black magic to initialize > > + * the hardware. > > + */ > > +static void r8a779f0_eth_serdes_write32(void __iomem *addr, u32 offs, u32 bank, u32 data) > > +{ > > + iowrite32(bank, addr + R8A779F0_ETH_SERDES_BANK_SELECT); > > + iowrite32(data, addr + offs); > > +} > > + > > +static int r8a779f0_eth_serdes_reg_wait(void __iomem *addr, u32 offs, u32 bank, > > + u32 mask, u32 expected) > > +{ > > + u32 val; > > + > > + iowrite32(bank, addr + R8A779F0_ETH_SERDES_BANK_SELECT); > > + > > + return readl_poll_timeout_atomic(addr + offs, val, (val & mask) == expected, > > + 1, R8A779F0_ETH_SERDES_TIMEOUT_US); > > +} > > + > > +static int > > +r8a779f0_eth_serdes_common_init_ram(struct r8a779f0_eth_serdes_channel *channel) > > +{ > > + int ret; > > + > > + ret = r8a779f0_eth_serdes_reg_wait(channel->addr, 0x026c, 0x180, BIT(0), 0x01); > > + if (ret) > > + return ret; > > + > > + r8a779f0_eth_serdes_write32(channel->addr0, 0x026c, 0x180, 0x03); > > + > > + return ret; > > +} > > + > > +static int > > +r8a779f0_eth_serdes_common_setting(struct r8a779f0_eth_serdes_channel *channel) > > +{ > > + switch (channel->phy_interface) { > > + case PHY_INTERFACE_MODE_SGMII: > > + r8a779f0_eth_serdes_write32(channel->addr0, 0x0244, 0x180, 0x0097); > > + r8a779f0_eth_serdes_write32(channel->addr0, 0x01d0, 0x180, 0x0060); > > + r8a779f0_eth_serdes_write32(channel->addr0, 0x01d8, 0x180, 0x2200); > > + r8a779f0_eth_serdes_write32(channel->addr0, 0x01d4, 0x180, 0x0000); > > + r8a779f0_eth_serdes_write32(channel->addr0, 0x01e0, 0x180, 0x003d); > > + return 0; > > + default: > > + return -EOPNOTSUPP; > > + } > > +} > > + > > +static int > > +r8a779f0_eth_serdes_chan_setting(struct r8a779f0_eth_serdes_channel *channel) > > +{ > > + int ret; > > + > > + switch (channel->phy_interface) { > > + case PHY_INTERFACE_MODE_SGMII: > > + r8a779f0_eth_serdes_write32(channel->addr, 0x0000, 0x380, 0x2000); > > + r8a779f0_eth_serdes_write32(channel->addr, 0x01c0, 0x180, 0x0011); > > + r8a779f0_eth_serdes_write32(channel->addr, 0x0248, 0x180, 0x0540); > > + r8a779f0_eth_serdes_write32(channel->addr, 0x0258, 0x180, 0x0015); > > + r8a779f0_eth_serdes_write32(channel->addr, 0x0144, 0x180, 0x0100); > > + r8a779f0_eth_serdes_write32(channel->addr, 0x01a0, 0x180, 0x0000); > > + r8a779f0_eth_serdes_write32(channel->addr, 0x00d0, 0x180, 0x0002); > > + r8a779f0_eth_serdes_write32(channel->addr, 0x0150, 0x180, 0x0003); > > + r8a779f0_eth_serdes_write32(channel->addr, 0x00c8, 0x180, 0x0100); > > + r8a779f0_eth_serdes_write32(channel->addr, 0x0148, 0x180, 0x0100); > > + r8a779f0_eth_serdes_write32(channel->addr, 0x0174, 0x180, 0x0000); > > + r8a779f0_eth_serdes_write32(channel->addr, 0x0160, 0x180, 0x0007); > > + r8a779f0_eth_serdes_write32(channel->addr, 0x01ac, 0x180, 0x0000); > > + r8a779f0_eth_serdes_write32(channel->addr, 0x00c4, 0x180, 0x0310); > > + r8a779f0_eth_serdes_write32(channel->addr, 0x00c8, 0x380, 0x0101); > > + ret = r8a779f0_eth_serdes_reg_wait(channel->addr, 0x00c8, 0x0180, BIT(0), 0); > > + if (ret) > > + return ret; > > + > > + r8a779f0_eth_serdes_write32(channel->addr, 0x0148, 0x180, 0x0101); > > + ret = r8a779f0_eth_serdes_reg_wait(channel->addr, 0x0148, 0x0180, BIT(0), 0); > > + if (ret) > > + return ret; > > + > > + r8a779f0_eth_serdes_write32(channel->addr, 0x00c4, 0x180, 0x1310); > > + r8a779f0_eth_serdes_write32(channel->addr, 0x00d8, 0x180, 0x1800); > > + r8a779f0_eth_serdes_write32(channel->addr, 0x00dc, 0x180, 0x0000); > > + r8a779f0_eth_serdes_write32(channel->addr, 0x001c, 0x300, 0x0001); > > + r8a779f0_eth_serdes_write32(channel->addr, 0x0000, 0x380, 0x2100); > > + ret = r8a779f0_eth_serdes_reg_wait(channel->addr, 0x0000, 0x0380, BIT(8), 0); > > + if (ret) > > + return ret; > > + > > + if (channel->speed == 1000) > > + r8a779f0_eth_serdes_write32(channel->addr, 0x0000, 0x1f00, 0x0140); > > + else if (channel->speed == 100) > > + r8a779f0_eth_serdes_write32(channel->addr, 0x0000, 0x1f00, 0x2100); > > + break; > > + default: > > + return -EOPNOTSUPP; > > + } > > + > > + return 0; > > +} > > + > > +static int r8a779f0_eth_serdes_hw_init(struct r8a779f0_eth_serdes_channel *channel) > > +{ > > + int ret; > > + > > + ret = r8a779f0_eth_serdes_common_init_ram(channel); > > + if (ret) > > + return ret; > > + > > + ret = r8a779f0_eth_serdes_reg_wait(channel->addr, 0x0000, 0x300, BIT(15), 0); > > + if (ret) > > + return ret; > > + > > + r8a779f0_eth_serdes_write32(channel->addr, 0x03d4, 0x380, 0x0443); > > + > > + ret = r8a779f0_eth_serdes_common_setting(channel); > > + if (ret) > > + return ret; > > + > > + r8a779f0_eth_serdes_write32(channel->addr, 0x03d0, 0x380, 0x0001); > > + > > + r8a779f0_eth_serdes_write32(channel->addr0, 0x0000, 0x380, 0x8000); > > + > > + ret = r8a779f0_eth_serdes_common_init_ram(channel); > > + if (ret) > > + return ret; > > + > > + ret = r8a779f0_eth_serdes_reg_wait(channel->addr0, 0x0000, 0x380, BIT(15), 0); > > + if (ret) > > + return ret; > > + > > + ret = r8a779f0_eth_serdes_chan_setting(channel); > > + if (ret) > > + return ret; > > + > > + r8a779f0_eth_serdes_write32(channel->addr, 0x03c0, 0x380, 0x0000); > > + r8a779f0_eth_serdes_write32(channel->addr, 0x03d0, 0x380, 0x0000); > > + > > + return 0; > > +} > > + > > +static int r8a779f0_eth_serdes_init(struct phy *p) > > +{ > > + struct r8a779f0_eth_serdes_channel *channel = phy_get_drvdata(p); > > + > > + return r8a779f0_eth_serdes_hw_init(channel); > > +} > > + > > +static int r8a779f0_eth_serdes_set_mode(struct phy *p, enum phy_mode mode, > > + int submode) > > +{ > > + struct r8a779f0_eth_serdes_channel *channel = phy_get_drvdata(p); > > + > > + if (mode != PHY_MODE_ETHERNET) > > + return -EOPNOTSUPP; > > + > > + switch (submode) { > > + case PHY_INTERFACE_MODE_GMII: > > + case PHY_INTERFACE_MODE_SGMII: > > + case PHY_INTERFACE_MODE_USXGMII: > > + channel->phy_interface = submode; > > + return 0; > > + default: > > + return -EOPNOTSUPP; > > + } > > +} > > + > > +static int r8a779f0_eth_serdes_set_speed(struct phy *p, int speed) > > +{ > > + struct r8a779f0_eth_serdes_channel *channel = phy_get_drvdata(p); > > + > > + channel->speed = speed; > > + > > + return 0; > > +} > > + > > +static const struct phy_ops r8a779f0_eth_serdes_ops = { > > + .init = r8a779f0_eth_serdes_init, > > + .set_mode = r8a779f0_eth_serdes_set_mode, > > + .set_speed = r8a779f0_eth_serdes_set_speed, > > +}; > > + > > +static struct phy *r8a779f0_eth_serdes_xlate(struct device *dev, > > + struct of_phandle_args *args) > > +{ > > + struct r8a779f0_eth_serdes_drv_data *dd = dev_get_drvdata(dev); > > + > > + if (args->args[0] >= R8A779F0_ETH_SERDES_NUM) > > + return ERR_PTR(-ENODEV); > > + > > + return dd->channel[args->args[0]].phy; > > +} > > + > > +static const struct of_device_id r8a779f0_eth_serdes_of_table[] = { > > + { .compatible = "renesas,r8a779f0-ether-serdes", }, > > + { } > > +}; > > +MODULE_DEVICE_TABLE(of, r8a779f0_eth_serdes_of_table); > > + > > +static int r8a779f0_eth_serdes_probe(struct platform_device *pdev) > > +{ > > + struct r8a779f0_eth_serdes_drv_data *dd; > > + struct phy_provider *provider; > > + struct resource *res; > > + int i, ret; > > + > > + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > > + if (!res) { > > + dev_err(&pdev->dev, "invalid resource\n"); > > + return -EINVAL; > > + } > > + > > + dd = devm_kzalloc(&pdev->dev, sizeof(*dd), GFP_KERNEL); > > + if (!dd) > > + return -ENOMEM; > > + > > + platform_set_drvdata(pdev, dd); > > + dd->pdev = pdev; > > + dd->addr = devm_ioremap_resource(&pdev->dev, res); > > + if (IS_ERR(dd->addr)) > > + return PTR_ERR(dd->addr); > > + > > + for (i = 0; i < R8A779F0_ETH_SERDES_NUM; i++) { > > + struct r8a779f0_eth_serdes_channel *channel = &dd->channel[i]; > > + > > + channel->phy = devm_phy_create(&pdev->dev, NULL, > > + &r8a779f0_eth_serdes_ops); > > + if (IS_ERR(channel->phy)) > > + return PTR_ERR(channel->phy); > > + channel->addr = dd->addr + R8A779F0_ETH_SERDES_OFFSET * i; > > + channel->addr0 = dd->addr; > > + phy_set_drvdata(channel->phy, channel); > > + } > > + > > + provider = devm_of_phy_provider_register(&pdev->dev, > > + r8a779f0_eth_serdes_xlate); > > + if (IS_ERR(provider)) > > + return PTR_ERR(provider); > > + > > + pm_runtime_enable(&pdev->dev); > > + pm_runtime_get_sync(&pdev->dev); > > + > > + return ret; > > +} > > + > > +static int r8a779f0_eth_serdes_remove(struct platform_device *pdev) > > +{ > > + pm_runtime_put(&pdev->dev); > > + pm_runtime_disable(&pdev->dev); > > + > > + platform_set_drvdata(pdev, NULL); > > + > > + return 0; > > +} > > + > > +static struct platform_driver r8a779f0_eth_serdes_driver_platform = { > > + .probe = r8a779f0_eth_serdes_probe, > > + .remove = r8a779f0_eth_serdes_remove, > > + .driver = { > > + .name = "r8a779f0_eth_serdes", > > + .of_match_table = r8a779f0_eth_serdes_of_table, > > + } > > +}; > > +module_platform_driver(r8a779f0_eth_serdes_driver_platform); > > +MODULE_AUTHOR("Yoshihiro Shimoda"); > > +MODULE_DESCRIPTION("Renesas Ethernet SERDES device driver"); > > +MODULE_LICENSE("GPL"); > > -- > > 2.25.1 > > -- > ~Vinod ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-09-26 0:25 UTC | newest] Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2022-09-22 5:16 [PATCH 0/2] phy: renesas: Add Renesas Ethernet SERDES driver for R-Car S4-8 Yoshihiro Shimoda 2022-09-22 5:16 ` [PATCH 1/2] dt-bindings: phy: renesas: Document Renesas Ethernet SERDES Yoshihiro Shimoda 2022-09-22 7:40 ` Krzysztof Kozlowski 2022-09-22 5:16 ` [PATCH 2/2] phy: renesas: Add Renesas Ethernet SERDES driver for R-Car S4-8 Yoshihiro Shimoda 2022-09-24 7:08 ` Vinod Koul 2022-09-26 0:24 ` Yoshihiro Shimoda
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).