From: Rob Herring <robh@kernel.org>
To: Biju Das <biju.das.jz@bp.renesas.com>
Cc: "Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Thierry Reding" <thierry.reding@gmail.com>,
"Lee Jones" <lee@kernel.org>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
linux-pwm@vger.kernel.org, devicetree@vger.kernel.org,
"Geert Uytterhoeven" <geert+renesas@glider.be>,
"Chris Paterson" <Chris.Paterson2@renesas.com>,
"Biju Das" <biju.das@bp.renesas.com>,
"Prabhakar Mahadev Lad" <prabhakar.mahadev-lad.rj@bp.renesas.com>,
linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH RFC 3/7] dt-bindings: mfd: rz-mtu3: Document RZ/G2L MTU3 PWM
Date: Fri, 30 Sep 2022 13:35:37 -0500 [thread overview]
Message-ID: <20220930183537.GB567190-robh@kernel.org> (raw)
In-Reply-To: <20220929103043.1228235-4-biju.das.jz@bp.renesas.com>
On Thu, Sep 29, 2022 at 11:30:39AM +0100, Biju Das wrote:
> Document RZ/G2L MTU3 PWM support. It supports following pwm modes.
> 1) PWM mode 1
> 2) PWM mode 2
> 3) Reset-synchronized PWM mode
> 4) Complementary PWM mode 1 (transfer at crest)
> 5) Complementary PWM mode 2 (transfer at trough)
> 6) Complementary PWM mode 3 (transfer at crest and trough)
What does 'complementary' mean here?
Mode 1, 2, 3 isn't very meaningful. Do other PWMs have similar modes? No
way to tell without better descriptions.
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> ---
> .../bindings/mfd/renesas,rzg2l-mtu3.yaml | 50 +++++++++++++++++++
> 1 file changed, 50 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mfd/renesas,rzg2l-mtu3.yaml b/Documentation/devicetree/bindings/mfd/renesas,rzg2l-mtu3.yaml
> index c4bcf28623d6..362fedf5bedb 100644
> --- a/Documentation/devicetree/bindings/mfd/renesas,rzg2l-mtu3.yaml
> +++ b/Documentation/devicetree/bindings/mfd/renesas,rzg2l-mtu3.yaml
> @@ -223,6 +223,50 @@ patternProperties:
> - compatible
> - reg
>
> + "^pwm@([0-4]|[6-7])+$":
> + type: object
> +
> + properties:
> + compatible:
> + const: renesas,rz-mtu3-pwm
> +
> + reg:
> + description: Identify pwm channels.
> + items:
> + enum: [ 0, 1, 2, 3, 4, 6, 7 ]
At any given level in DT, there is only 1 address space. You've created
2 with pwms and counters.
> +
> + "#pwm-cells":
> + const: 2
> +
> + renesas,pwm-mode1:
> + type: boolean
> + description: Enable PWM mode 1.
> +
> + renesas,pwm-mode2:
> + type: boolean
> + description: Enable PWM mode 2.
> +
> + renesas,reset-synchronized-pwm-mode:
> + type: boolean
> + description: Enable Reset-synchronized PWM mode.
> +
> + renesas,complementary-pwm-mode1:
> + type: boolean
> + description: Complementary PWM mode 1 (transfer at crest).
> +
> + renesas,complementary-pwm-mode2:
> + type: boolean
> + description: Complementary PWM mode 2 (transfer at trough).
> +
> + renesas,complementary-pwm-mode3:
> + type: boolean
> + description: Complementary PWM mode 3 (transfer at crest and trough).
These all look like client configuration and should be either runtime
config or part of pwm cells args.
> +
> + required:
> + - compatible
> + - reg
> + - "#pwm-cells"
> +
> required:
> - compatible
> - reg
> @@ -305,6 +349,12 @@ examples:
> compatible = "renesas,rzg2l-mtu3-counter";
> reg = <1>;
> };
> + pwm@3 {
> + compatible = "renesas,rz-mtu3-pwm";
> + reg = <3>;
> + #pwm-cells = <2>;
> + renesas,pwm-mode1;
> + };
> };
>
> ...
> --
> 2.25.1
>
>
next prev parent reply other threads:[~2022-09-30 18:35 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-29 10:30 [PATCH RFC 0/7] Add RZ/G2L MTU3 PWM driver Biju Das
2022-09-29 10:30 ` [PATCH RFC 1/7] dt-bindings: mfd: Document RZ/G2L MTU3a bindings Biju Das
2022-09-29 17:53 ` Lee Jones
2022-09-30 17:47 ` Rob Herring
2022-10-03 7:34 ` Lee Jones
2022-10-03 7:38 ` Geert Uytterhoeven
2022-10-03 8:51 ` Lee Jones
2022-09-29 10:30 ` [PATCH RFC 2/7] dt-bindings: mfd: rzg2l-mtu3: Document RZ/G2L MTU3 counter Biju Das
2022-09-29 17:52 ` Lee Jones
2022-09-30 19:03 ` Rob Herring
2022-10-01 16:36 ` Biju Das
2022-10-02 16:50 ` Biju Das
2022-09-29 10:30 ` [PATCH RFC 3/7] dt-bindings: mfd: rz-mtu3: Document RZ/G2L MTU3 PWM Biju Das
2022-09-29 17:52 ` Lee Jones
2022-09-29 17:59 ` Biju Das
2022-09-30 12:10 ` Lee Jones
2022-10-01 19:26 ` Biju Das
2022-10-03 7:32 ` Lee Jones
2022-10-03 8:16 ` Biju Das
2022-10-03 8:57 ` Lee Jones
2022-10-03 9:04 ` Biju Das
2022-10-03 9:34 ` Biju Das
2022-09-30 18:35 ` Rob Herring [this message]
2022-10-01 16:30 ` Biju Das
2022-09-29 10:30 ` [PATCH RFC 4/7] pwm: Add support for " Biju Das
2022-09-29 10:30 ` [PATCH RFC 5/7] arm64: dts: renesas: r9a07g044: Add MTU3 PWM support Biju Das
2022-09-29 10:30 ` [PATCH RFC 6/7] arm64: dts: renesas: r9a07g054: " Biju Das
2022-09-29 10:30 ` [PATCH RFC 7/7] arm64: dts: renesas: rzg2l-smarc: [HACK] Enable MTU3 PWM channel 3 for PWM mode 1 testing Biju Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220930183537.GB567190-robh@kernel.org \
--to=robh@kernel.org \
--cc=Chris.Paterson2@renesas.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=biju.das@bp.renesas.com \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee@kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).