[PATCH 0/5] arm64: dts: renesas: Add/update IPMMU support for R-Car Gen4

[PATCH 0/5] arm64: dts: renesas: Add/update IPMMU support for R-Car Gen4

[Yoshihiro Shimoda]

This patch series is based on the following patch which update the dt-binding
for renesas,ipmmu-main property.

https://lore.kernel.org/all/20230123012940.1250879-1-yoshihiro.shimoda.uh@renesas.com/

Yoshihiro Shimoda (5):
  arm64: dts: renesas: r8a779f0: Revise renesas,ipmmu-main
  arm64: dts: renesas: r8a779f0: Add iommus to MMC node
  arm64: dts: renesas: r8a779g0: Add IPMMU nodes
  arm64: dts: renesas: r8a779g0: Add iommus to DMAC nodes
  arm64: dts: renesas: r8a779g0: Add iommus to MMC node

 arch/arm64/boot/dts/renesas/r8a779f0.dtsi |   9 +-
 arch/arm64/boot/dts/renesas/r8a779g0.dtsi | 126 ++++++++++++++++++++++
 2 files changed, 131 insertions(+), 4 deletions(-)

-- 
2.25.1

[PATCH 1/5] arm64: dts: renesas: r8a779f0: Revise renesas,ipmmu-main

[Yoshihiro Shimoda]

Since IMSSTR register was undocumented on the latest datasheet and
dt-bindings of renesas,ipmmu-vmsa was updated about
the renesas,ipmmu-main property, revise the property on each cache
IPMMU node.

Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
---
 arch/arm64/boot/dts/renesas/r8a779f0.dtsi | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/arch/arm64/boot/dts/renesas/r8a779f0.dtsi b/arch/arm64/boot/dts/renesas/r8a779f0.dtsi
index ac294168c867..4f409bb2d953 100644
--- a/arch/arm64/boot/dts/renesas/r8a779f0.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a779f0.dtsi
@@ -1058,7 +1058,7 @@ ipmmu_rt0: iommu@ee480000 {
 			compatible = "renesas,ipmmu-r8a779f0",
 				     "renesas,rcar-gen4-ipmmu-vmsa";
 			reg = <0 0xee480000 0 0x20000>;
-			renesas,ipmmu-main = <&ipmmu_mm 10>;
+			renesas,ipmmu-main = <&ipmmu_mm 0>;
 			power-domains = <&sysc R8A779F0_PD_ALWAYS_ON>;
 			#iommu-cells = <1>;
 		};
@@ -1067,7 +1067,7 @@ ipmmu_rt1: iommu@ee4c0000 {
 			compatible = "renesas,ipmmu-r8a779f0",
 				     "renesas,rcar-gen4-ipmmu-vmsa";
 			reg = <0 0xee4c0000 0 0x20000>;
-			renesas,ipmmu-main = <&ipmmu_mm 19>;
+			renesas,ipmmu-main = <&ipmmu_mm 1>;
 			power-domains = <&sysc R8A779F0_PD_ALWAYS_ON>;
 			#iommu-cells = <1>;
 		};
@@ -1076,7 +1076,7 @@ ipmmu_ds0: iommu@eed00000 {
 			compatible = "renesas,ipmmu-r8a779f0",
 				     "renesas,rcar-gen4-ipmmu-vmsa";
 			reg = <0 0xeed00000 0 0x20000>;
-			renesas,ipmmu-main = <&ipmmu_mm 0>;
+			renesas,ipmmu-main = <&ipmmu_mm 2>;
 			power-domains = <&sysc R8A779F0_PD_ALWAYS_ON>;
 			#iommu-cells = <1>;
 		};
@@ -1085,7 +1085,7 @@ ipmmu_hc: iommu@eed40000 {
 			compatible = "renesas,ipmmu-r8a779f0",
 				     "renesas,rcar-gen4-ipmmu-vmsa";
 			reg = <0 0xeed40000 0 0x20000>;
-			renesas,ipmmu-main = <&ipmmu_mm 2>;
+			renesas,ipmmu-main = <&ipmmu_mm 3>;
 			power-domains = <&sysc R8A779F0_PD_ALWAYS_ON>;
 			#iommu-cells = <1>;
 		};
-- 
2.25.1

[PATCH 2/5] arm64: dts: renesas: r8a779f0: Add iommus to MMC node

[Yoshihiro Shimoda]

Add iommus property to the MMC node for r8a779f0.

Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
---
 arch/arm64/boot/dts/renesas/r8a779f0.dtsi | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/renesas/r8a779f0.dtsi b/arch/arm64/boot/dts/renesas/r8a779f0.dtsi
index 4f409bb2d953..fa4cde4e6c09 100644
--- a/arch/arm64/boot/dts/renesas/r8a779f0.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a779f0.dtsi
@@ -1051,6 +1051,7 @@ mmc0: mmc@ee140000 {
 			power-domains = <&sysc R8A779F0_PD_ALWAYS_ON>;
 			resets = <&cpg 706>;
 			max-frequency = <200000000>;
+			iommus = <&ipmmu_ds0 32>;
 			status = "disabled";
 		};
 
-- 
2.25.1

[PATCH 3/5] arm64: dts: renesas: r8a779g0: Add IPMMU nodes

[Yoshihiro Shimoda]

Add IPMMU nodes for r8a779g0.

Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
---
 arch/arm64/boot/dts/renesas/r8a779g0.dtsi | 109 ++++++++++++++++++++++
 1 file changed, 109 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/r8a779g0.dtsi b/arch/arm64/boot/dts/renesas/r8a779g0.dtsi
index 83d1666a2ea1..631192dec514 100644
--- a/arch/arm64/boot/dts/renesas/r8a779g0.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a779g0.dtsi
@@ -1162,6 +1162,115 @@ dmac1: dma-controller@e7351000 {
 			dma-channels = <16>;
 		};
 
+		ipmmu_rt0: iommu@ee480000 {
+			compatible = "renesas,ipmmu-r8a779g0",
+				     "renesas,rcar-gen4-ipmmu-vmsa";
+			reg = <0 0xee480000 0 0x20000>;
+			renesas,ipmmu-main = <&ipmmu_mm 4>;
+			power-domains = <&sysc R8A779G0_PD_ALWAYS_ON>;
+			#iommu-cells = <1>;
+		};
+
+		ipmmu_rt1: iommu@ee4c0000 {
+			compatible = "renesas,ipmmu-r8a779g0",
+				     "renesas,rcar-gen4-ipmmu-vmsa";
+			reg = <0 0xee4c0000 0 0x20000>;
+			renesas,ipmmu-main = <&ipmmu_mm 5>;
+			power-domains = <&sysc R8A779G0_PD_ALWAYS_ON>;
+			#iommu-cells = <1>;
+		};
+
+		ipmmu_ds0: iommu@eed00000 {
+			compatible = "renesas,ipmmu-r8a779g0",
+				     "renesas,rcar-gen4-ipmmu-vmsa";
+			reg = <0 0xeed00000 0 0x20000>;
+			renesas,ipmmu-main = <&ipmmu_mm 6>;
+			power-domains = <&sysc R8A779G0_PD_ALWAYS_ON>;
+			#iommu-cells = <1>;
+		};
+
+		ipmmu_hsc: iommu@eed40000 {
+			compatible = "renesas,ipmmu-r8a779g0",
+				     "renesas,rcar-gen4-ipmmu-vmsa";
+			reg = <0 0xeed40000 0 0x20000>;
+			renesas,ipmmu-main = <&ipmmu_mm 7>;
+			power-domains = <&sysc R8A779G0_PD_ALWAYS_ON>;
+			#iommu-cells = <1>;
+		};
+
+		ipmmu_ir: iommu@eed80000 {
+			compatible = "renesas,ipmmu-r8a779g0",
+				     "renesas,rcar-gen4-ipmmu-vmsa";
+			reg = <0 0xeed80000 0 0x20000>;
+			renesas,ipmmu-main = <&ipmmu_mm 3>;
+			power-domains = <&sysc R8A779G0_PD_ALWAYS_ON>;
+			#iommu-cells = <1>;
+		};
+
+		ipmmu_vc0: iommu@eedc0000 {
+			compatible = "renesas,ipmmu-r8a779g0",
+				     "renesas,rcar-gen4-ipmmu-vmsa";
+			reg = <0 0xeedc0000 0 0x20000>;
+			renesas,ipmmu-main = <&ipmmu_mm 2>;
+			power-domains = <&sysc R8A779G0_PD_ALWAYS_ON>;
+			#iommu-cells = <1>;
+		};
+
+		ipmmu_3dg: iommu@eee00000 {
+			compatible = "renesas,ipmmu-r8a779g0",
+				     "renesas,rcar-gen4-ipmmu-vmsa";
+			reg = <0 0xeee00000 0 0x20000>;
+			renesas,ipmmu-main = <&ipmmu_mm 10>;
+			power-domains = <&sysc R8A779G0_PD_ALWAYS_ON>;
+			#iommu-cells = <1>;
+		};
+
+		ipmmu_vi0: iommu@eee80000 {
+			compatible = "renesas,ipmmu-r8a779g0",
+				     "renesas,rcar-gen4-ipmmu-vmsa";
+			reg = <0 0xeee80000 0 0x20000>;
+			renesas,ipmmu-main = <&ipmmu_mm 0>;
+			power-domains = <&sysc R8A779G0_PD_ALWAYS_ON>;
+			#iommu-cells = <1>;
+		};
+
+		ipmmu_vi1: iommu@eeec0000 {
+			compatible = "renesas,ipmmu-r8a779g0",
+				     "renesas,rcar-gen4-ipmmu-vmsa";
+			reg = <0 0xeeec0000 0 0x20000>;
+			renesas,ipmmu-main = <&ipmmu_mm 1>;
+			power-domains = <&sysc R8A779G0_PD_ALWAYS_ON>;
+			#iommu-cells = <1>;
+		};
+
+		ipmmu_vip0: iommu@eef00000 {
+			compatible = "renesas,ipmmu-r8a779g0",
+				     "renesas,rcar-gen4-ipmmu-vmsa";
+			reg = <0 0xeef00000 0 0x20000>;
+			renesas,ipmmu-main = <&ipmmu_mm 8>;
+			power-domains = <&sysc R8A779G0_PD_ALWAYS_ON>;
+			#iommu-cells = <1>;
+		};
+
+		ipmmu_vip1: iommu@eef40000 {
+			compatible = "renesas,ipmmu-r8a779g0",
+				     "renesas,rcar-gen4-ipmmu-vmsa";
+			reg = <0 0xeef40000 0 0x20000>;
+			renesas,ipmmu-main = <&ipmmu_mm 8>;
+			power-domains = <&sysc R8A779G0_PD_ALWAYS_ON>;
+			#iommu-cells = <1>;
+		};
+
+		ipmmu_mm: iommu@eefc0000 {
+			compatible = "renesas,ipmmu-r8a779g0",
+				     "renesas,rcar-gen4-ipmmu-vmsa";
+			reg = <0 0xeefc0000 0 0x20000>;
+			interrupts = <GIC_SPI 210 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 211 IRQ_TYPE_LEVEL_HIGH>;
+			power-domains = <&sysc R8A779G0_PD_ALWAYS_ON>;
+			#iommu-cells = <1>;
+		};
+
 		mmc0: mmc@ee140000 {
 			compatible = "renesas,sdhi-r8a779g0",
 				     "renesas,rcar-gen4-sdhi";
-- 
2.25.1

[PATCH 4/5] arm64: dts: renesas: r8a779g0: Add iommus to DMAC nodes

[Yoshihiro Shimoda]

Add iommus properties to the DMAC nodes for r8a779g0.

Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
---
 arch/arm64/boot/dts/renesas/r8a779g0.dtsi | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/r8a779g0.dtsi b/arch/arm64/boot/dts/renesas/r8a779g0.dtsi
index 631192dec514..1d2c9fd53100 100644
--- a/arch/arm64/boot/dts/renesas/r8a779g0.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a779g0.dtsi
@@ -1125,6 +1125,14 @@ dmac0: dma-controller@e7350000 {
 			resets = <&cpg 709>;
 			#dma-cells = <1>;
 			dma-channels = <16>;
+			iommus = <&ipmmu_ds0 0>, <&ipmmu_ds0 1>,
+				 <&ipmmu_ds0 2>, <&ipmmu_ds0 3>,
+				 <&ipmmu_ds0 4>, <&ipmmu_ds0 5>,
+				 <&ipmmu_ds0 6>, <&ipmmu_ds0 7>,
+				 <&ipmmu_ds0 8>, <&ipmmu_ds0 9>,
+				 <&ipmmu_ds0 10>, <&ipmmu_ds0 11>,
+				 <&ipmmu_ds0 12>, <&ipmmu_ds0 13>,
+				 <&ipmmu_ds0 14>, <&ipmmu_ds0 15>;
 		};
 
 		dmac1: dma-controller@e7351000 {
@@ -1160,6 +1168,14 @@ dmac1: dma-controller@e7351000 {
 			resets = <&cpg 710>;
 			#dma-cells = <1>;
 			dma-channels = <16>;
+			iommus = <&ipmmu_ds0 16>, <&ipmmu_ds0 17>,
+				 <&ipmmu_ds0 18>, <&ipmmu_ds0 19>,
+				 <&ipmmu_ds0 20>, <&ipmmu_ds0 21>,
+				 <&ipmmu_ds0 22>, <&ipmmu_ds0 23>,
+				 <&ipmmu_ds0 24>, <&ipmmu_ds0 25>,
+				 <&ipmmu_ds0 26>, <&ipmmu_ds0 27>,
+				 <&ipmmu_ds0 28>, <&ipmmu_ds0 29>,
+				 <&ipmmu_ds0 30>, <&ipmmu_ds0 31>;
 		};
 
 		ipmmu_rt0: iommu@ee480000 {
-- 
2.25.1

[PATCH 5/5] arm64: dts: renesas: r8a779g0: Add iommus to MMC node

[Yoshihiro Shimoda]

Add iommus property to the MMC node for r8a779g0.

Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Tested-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
 arch/arm64/boot/dts/renesas/r8a779g0.dtsi | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/renesas/r8a779g0.dtsi b/arch/arm64/boot/dts/renesas/r8a779g0.dtsi
index 1d2c9fd53100..1f3568bcacde 100644
--- a/arch/arm64/boot/dts/renesas/r8a779g0.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a779g0.dtsi
@@ -1298,6 +1298,7 @@ mmc0: mmc@ee140000 {
 			power-domains = <&sysc R8A779G0_PD_ALWAYS_ON>;
 			resets = <&cpg 706>;
 			max-frequency = <200000000>;
+			iommus = <&ipmmu_ds0 32>;
 			status = "disabled";
 		};
 
-- 
2.25.1

RE: [PATCH 3/5] arm64: dts: renesas: r8a779g0: Add IPMMU nodes

[Yoshihiro Shimoda]

Hi Geert-san,

> From: Yoshihiro Shimoda, Sent: Monday, January 23, 2023 10:35 AM
> 
> Add IPMMU nodes for r8a779g0.
> 
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> ---
>  arch/arm64/boot/dts/renesas/r8a779g0.dtsi | 109 ++++++++++++++++++++++
>  1 file changed, 109 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/renesas/r8a779g0.dtsi b/arch/arm64/boot/dts/renesas/r8a779g0.dtsi
> index 83d1666a2ea1..631192dec514 100644
> --- a/arch/arm64/boot/dts/renesas/r8a779g0.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a779g0.dtsi
> @@ -1162,6 +1162,115 @@ dmac1: dma-controller@e7351000 {
>  			dma-channels = <16>;
>  		};
> 
> +		ipmmu_rt0: iommu@ee480000 {
> +			compatible = "renesas,ipmmu-r8a779g0",
> +				     "renesas,rcar-gen4-ipmmu-vmsa";
> +			reg = <0 0xee480000 0 0x20000>;
> +			renesas,ipmmu-main = <&ipmmu_mm 4>;
> +			power-domains = <&sysc R8A779G0_PD_ALWAYS_ON>;
> +			#iommu-cells = <1>;
> +		};
> +
> +		ipmmu_rt1: iommu@ee4c0000 {
> +			compatible = "renesas,ipmmu-r8a779g0",
> +				     "renesas,rcar-gen4-ipmmu-vmsa";
> +			reg = <0 0xee4c0000 0 0x20000>;
> +			renesas,ipmmu-main = <&ipmmu_mm 5>;
> +			power-domains = <&sysc R8A779G0_PD_ALWAYS_ON>;
> +			#iommu-cells = <1>;
> +		};
> +
> +		ipmmu_ds0: iommu@eed00000 {
> +			compatible = "renesas,ipmmu-r8a779g0",
> +				     "renesas,rcar-gen4-ipmmu-vmsa";
> +			reg = <0 0xeed00000 0 0x20000>;
> +			renesas,ipmmu-main = <&ipmmu_mm 6>;
> +			power-domains = <&sysc R8A779G0_PD_ALWAYS_ON>;
> +			#iommu-cells = <1>;
> +		};
> +
> +		ipmmu_hsc: iommu@eed40000 {
> +			compatible = "renesas,ipmmu-r8a779g0",
> +				     "renesas,rcar-gen4-ipmmu-vmsa";
> +			reg = <0 0xeed40000 0 0x20000>;
> +			renesas,ipmmu-main = <&ipmmu_mm 7>;
> +			power-domains = <&sysc R8A779G0_PD_ALWAYS_ON>;
> +			#iommu-cells = <1>;
> +		};
> +
> +		ipmmu_ir: iommu@eed80000 {
> +			compatible = "renesas,ipmmu-r8a779g0",
> +				     "renesas,rcar-gen4-ipmmu-vmsa";
> +			reg = <0 0xeed80000 0 0x20000>;
> +			renesas,ipmmu-main = <&ipmmu_mm 3>;
> +			power-domains = <&sysc R8A779G0_PD_ALWAYS_ON>;

The power-domains should be R8A779G0_PD_A3IR.
So, I'll send v2 patch after we discussed updating dt-bindings of "renesas,ipmmu-main".

Best regards,
Yoshihiro Shimoda

> +			#iommu-cells = <1>;
> +		};
> +
> +		ipmmu_vc0: iommu@eedc0000 {
> +			compatible = "renesas,ipmmu-r8a779g0",
> +				     "renesas,rcar-gen4-ipmmu-vmsa";
> +			reg = <0 0xeedc0000 0 0x20000>;
> +			renesas,ipmmu-main = <&ipmmu_mm 2>;
> +			power-domains = <&sysc R8A779G0_PD_ALWAYS_ON>;
> +			#iommu-cells = <1>;
> +		};
> +
> +		ipmmu_3dg: iommu@eee00000 {
> +			compatible = "renesas,ipmmu-r8a779g0",
> +				     "renesas,rcar-gen4-ipmmu-vmsa";
> +			reg = <0 0xeee00000 0 0x20000>;
> +			renesas,ipmmu-main = <&ipmmu_mm 10>;
> +			power-domains = <&sysc R8A779G0_PD_ALWAYS_ON>;
> +			#iommu-cells = <1>;
> +		};
> +
> +		ipmmu_vi0: iommu@eee80000 {
> +			compatible = "renesas,ipmmu-r8a779g0",
> +				     "renesas,rcar-gen4-ipmmu-vmsa";
> +			reg = <0 0xeee80000 0 0x20000>;
> +			renesas,ipmmu-main = <&ipmmu_mm 0>;
> +			power-domains = <&sysc R8A779G0_PD_ALWAYS_ON>;
> +			#iommu-cells = <1>;
> +		};
> +
> +		ipmmu_vi1: iommu@eeec0000 {
> +			compatible = "renesas,ipmmu-r8a779g0",
> +				     "renesas,rcar-gen4-ipmmu-vmsa";
> +			reg = <0 0xeeec0000 0 0x20000>;
> +			renesas,ipmmu-main = <&ipmmu_mm 1>;
> +			power-domains = <&sysc R8A779G0_PD_ALWAYS_ON>;
> +			#iommu-cells = <1>;
> +		};
> +
> +		ipmmu_vip0: iommu@eef00000 {
> +			compatible = "renesas,ipmmu-r8a779g0",
> +				     "renesas,rcar-gen4-ipmmu-vmsa";
> +			reg = <0 0xeef00000 0 0x20000>;
> +			renesas,ipmmu-main = <&ipmmu_mm 8>;
> +			power-domains = <&sysc R8A779G0_PD_ALWAYS_ON>;
> +			#iommu-cells = <1>;
> +		};
> +
> +		ipmmu_vip1: iommu@eef40000 {
> +			compatible = "renesas,ipmmu-r8a779g0",
> +				     "renesas,rcar-gen4-ipmmu-vmsa";
> +			reg = <0 0xeef40000 0 0x20000>;
> +			renesas,ipmmu-main = <&ipmmu_mm 8>;
> +			power-domains = <&sysc R8A779G0_PD_ALWAYS_ON>;
> +			#iommu-cells = <1>;
> +		};
> +
> +		ipmmu_mm: iommu@eefc0000 {
> +			compatible = "renesas,ipmmu-r8a779g0",
> +				     "renesas,rcar-gen4-ipmmu-vmsa";
> +			reg = <0 0xeefc0000 0 0x20000>;
> +			interrupts = <GIC_SPI 210 IRQ_TYPE_LEVEL_HIGH>,
> +				     <GIC_SPI 211 IRQ_TYPE_LEVEL_HIGH>;
> +			power-domains = <&sysc R8A779G0_PD_ALWAYS_ON>;
> +			#iommu-cells = <1>;
> +		};
> +
>  		mmc0: mmc@ee140000 {
>  			compatible = "renesas,sdhi-r8a779g0",
>  				     "renesas,rcar-gen4-sdhi";
> --
> 2.25.1

Re: [PATCH 2/5] arm64: dts: renesas: r8a779f0: Add iommus to MMC node

[Geert Uytterhoeven]

On Mon, Jan 23, 2023 at 2:35 AM Yoshihiro Shimoda
<yoshihiro.shimoda.uh@renesas.com> wrote:
> Add iommus property to the MMC node for r8a779f0.
>
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
i.e. will queue in renesas-devel for v6.3.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH 4/5] arm64: dts: renesas: r8a779g0: Add iommus to DMAC nodes

[Geert Uytterhoeven]

On Mon, Jan 23, 2023 at 2:35 AM Yoshihiro Shimoda
<yoshihiro.shimoda.uh@renesas.com> wrote:
> Add iommus properties to the DMAC nodes for r8a779g0.
>
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH 5/5] arm64: dts: renesas: r8a779g0: Add iommus to MMC node

[Geert Uytterhoeven]

On Mon, Jan 23, 2023 at 2:35 AM Yoshihiro Shimoda
<yoshihiro.shimoda.uh@renesas.com> wrote:
> Add iommus property to the MMC node for r8a779g0.
>
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> Tested-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH 3/5] arm64: dts: renesas: r8a779g0: Add IPMMU nodes

[Geert Uytterhoeven]

Hi Shimoda-san,

On Mon, Jan 23, 2023 at 2:38 AM Yoshihiro Shimoda
<yoshihiro.shimoda.uh@renesas.com> wrote:
> Add IPMMU nodes for r8a779g0.
>
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>

Thanks for your patch!

> --- a/arch/arm64/boot/dts/renesas/r8a779g0.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a779g0.dtsi
> @@ -1162,6 +1162,115 @@ dmac1: dma-controller@e7351000 {
>                         dma-channels = <16>;
>                 };
>
> +               ipmmu_rt0: iommu@ee480000 {
> +                       compatible = "renesas,ipmmu-r8a779g0",
> +                                    "renesas,rcar-gen4-ipmmu-vmsa";
> +                       reg = <0 0xee480000 0 0x20000>;
> +                       renesas,ipmmu-main = <&ipmmu_mm 4>;
> +                       power-domains = <&sysc R8A779G0_PD_ALWAYS_ON>;
> +                       #iommu-cells = <1>;
> +               };
> +
> +               ipmmu_rt1: iommu@ee4c0000 {
> +                       compatible = "renesas,ipmmu-r8a779g0",
> +                                    "renesas,rcar-gen4-ipmmu-vmsa";
> +                       reg = <0 0xee4c0000 0 0x20000>;
> +                       renesas,ipmmu-main = <&ipmmu_mm 5>;
> +                       power-domains = <&sysc R8A779G0_PD_ALWAYS_ON>;
> +                       #iommu-cells = <1>;
> +               };
> +
> +               ipmmu_ds0: iommu@eed00000 {
> +                       compatible = "renesas,ipmmu-r8a779g0",
> +                                    "renesas,rcar-gen4-ipmmu-vmsa";
> +                       reg = <0 0xeed00000 0 0x20000>;
> +                       renesas,ipmmu-main = <&ipmmu_mm 6>;
> +                       power-domains = <&sysc R8A779G0_PD_ALWAYS_ON>;
> +                       #iommu-cells = <1>;
> +               };
> +
> +               ipmmu_hsc: iommu@eed40000 {

ipmmu_hc?

> +                       compatible = "renesas,ipmmu-r8a779g0",
> +                                    "renesas,rcar-gen4-ipmmu-vmsa";
> +                       reg = <0 0xeed40000 0 0x20000>;
> +                       renesas,ipmmu-main = <&ipmmu_mm 7>;
> +                       power-domains = <&sysc R8A779G0_PD_ALWAYS_ON>;
> +                       #iommu-cells = <1>;
> +               };
> +
> +               ipmmu_ir: iommu@eed80000 {
> +                       compatible = "renesas,ipmmu-r8a779g0",
> +                                    "renesas,rcar-gen4-ipmmu-vmsa";
> +                       reg = <0 0xeed80000 0 0x20000>;
> +                       renesas,ipmmu-main = <&ipmmu_mm 3>;
> +                       power-domains = <&sysc R8A779G0_PD_ALWAYS_ON>;
> +                       #iommu-cells = <1>;
> +               };
> +
> +               ipmmu_vc0: iommu@eedc0000 {

ipmmu_vc?

> +                       compatible = "renesas,ipmmu-r8a779g0",
> +                                    "renesas,rcar-gen4-ipmmu-vmsa";
> +                       reg = <0 0xeedc0000 0 0x20000>;
> +                       renesas,ipmmu-main = <&ipmmu_mm 2>;
> +                       power-domains = <&sysc R8A779G0_PD_ALWAYS_ON>;
> +                       #iommu-cells = <1>;
> +               };

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH 3/5] arm64: dts: renesas: r8a779g0: Add IPMMU nodes

[Geert Uytterhoeven]

Hi Shimoda-san,

On Wed, Jan 25, 2023 at 1:52 AM Yoshihiro Shimoda
<yoshihiro.shimoda.uh@renesas.com> wrote:
> > From: Yoshihiro Shimoda, Sent: Monday, January 23, 2023 10:35 AM
> >
> > Add IPMMU nodes for r8a779g0.
> >
> > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>

> > --- a/arch/arm64/boot/dts/renesas/r8a779g0.dtsi
> > +++ b/arch/arm64/boot/dts/renesas/r8a779g0.dtsi

> > +             ipmmu_ir: iommu@eed80000 {
> > +                     compatible = "renesas,ipmmu-r8a779g0",
> > +                                  "renesas,rcar-gen4-ipmmu-vmsa";
> > +                     reg = <0 0xeed80000 0 0x20000>;
> > +                     renesas,ipmmu-main = <&ipmmu_mm 3>;
> > +                     power-domains = <&sysc R8A779G0_PD_ALWAYS_ON>;
>
> The power-domains should be R8A779G0_PD_A3IR.
> So, I'll send v2 patch after we discussed updating dt-bindings of "renesas,ipmmu-main".

The binding update is commit b67ab6fb63bbbe6d ("dt-bindings: iommu:
renesas, ipmmu-vmsa: Update for R-Car Gen4") in iommu/next.

Do you still plan to send a v2, or shall I fix this (+ removal of
renesas,ipmmu-main indices) while applying?

Thanks!

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

RE: [PATCH 3/5] arm64: dts: renesas: r8a779g0: Add IPMMU nodes

[Yoshihiro Shimoda]

Hi Geert-san,

> From: Geert Uytterhoeven, Sent: Tuesday, April 4, 2023 4:21 PM
> 
> Hi Shimoda-san,
> 
> On Wed, Jan 25, 2023 at 1:52 AM Yoshihiro Shimoda
> <yoshihiro.shimoda.uh@renesas.com> wrote:
> > > From: Yoshihiro Shimoda, Sent: Monday, January 23, 2023 10:35 AM
> > >
> > > Add IPMMU nodes for r8a779g0.
> > >
> > > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> 
> > > --- a/arch/arm64/boot/dts/renesas/r8a779g0.dtsi
> > > +++ b/arch/arm64/boot/dts/renesas/r8a779g0.dtsi
> 
> > > +             ipmmu_ir: iommu@eed80000 {
> > > +                     compatible = "renesas,ipmmu-r8a779g0",
> > > +                                  "renesas,rcar-gen4-ipmmu-vmsa";
> > > +                     reg = <0 0xeed80000 0 0x20000>;
> > > +                     renesas,ipmmu-main = <&ipmmu_mm 3>;
> > > +                     power-domains = <&sysc R8A779G0_PD_ALWAYS_ON>;
> >
> > The power-domains should be R8A779G0_PD_A3IR.
> > So, I'll send v2 patch after we discussed updating dt-bindings of "renesas,ipmmu-main".
> 
> The binding update is commit b67ab6fb63bbbe6d ("dt-bindings: iommu:
> renesas, ipmmu-vmsa: Update for R-Car Gen4") in iommu/next.
> 
> Do you still plan to send a v2, or shall I fix this (+ removal of
> renesas,ipmmu-main indices) while applying?

I said I will send a v2, but I'm happy if you will fix this while applying.

Best regards,
Yoshihiro Shimoda

> Thanks!
> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds

Re: [PATCH 3/5] arm64: dts: renesas: r8a779g0: Add IPMMU nodes

[Geert Uytterhoeven]

Hi Shimoda-san,

On Tue, Apr 4, 2023 at 9:33 AM Yoshihiro Shimoda
<yoshihiro.shimoda.uh@renesas.com> wrote:
> > From: Geert Uytterhoeven, Sent: Tuesday, April 4, 2023 4:21 PM
> > On Wed, Jan 25, 2023 at 1:52 AM Yoshihiro Shimoda
> > <yoshihiro.shimoda.uh@renesas.com> wrote:
> > > > From: Yoshihiro Shimoda, Sent: Monday, January 23, 2023 10:35 AM
> > > >
> > > > Add IPMMU nodes for r8a779g0.
> > > >
> > > > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> >
> > > > --- a/arch/arm64/boot/dts/renesas/r8a779g0.dtsi
> > > > +++ b/arch/arm64/boot/dts/renesas/r8a779g0.dtsi
> >
> > > > +             ipmmu_ir: iommu@eed80000 {
> > > > +                     compatible = "renesas,ipmmu-r8a779g0",
> > > > +                                  "renesas,rcar-gen4-ipmmu-vmsa";
> > > > +                     reg = <0 0xeed80000 0 0x20000>;
> > > > +                     renesas,ipmmu-main = <&ipmmu_mm 3>;
> > > > +                     power-domains = <&sysc R8A779G0_PD_ALWAYS_ON>;
> > >
> > > The power-domains should be R8A779G0_PD_A3IR.
> > > So, I'll send v2 patch after we discussed updating dt-bindings of "renesas,ipmmu-main".
> >
> > The binding update is commit b67ab6fb63bbbe6d ("dt-bindings: iommu:
> > renesas, ipmmu-vmsa: Update for R-Car Gen4") in iommu/next.
> >
> > Do you still plan to send a v2, or shall I fix this (+ removal of
> > renesas,ipmmu-main indices) while applying?
>
> I said I will send a v2, but I'm happy if you will fix this while applying.

Thanks, queuing all remaining iommu patches in renesas-devel
for v6.4...

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds