[PATCH v8 0/4] Enable RZ/{G2L,G2LC} and RZ/V2L DU

[PATCH v8 0/4] Enable RZ/{G2L,G2LC} and RZ/V2L DU

[Biju Das]

Enable DU on RZ/{G2L,G2LC} and RZ/V2L SMARC EVK.

This patch series depend upon [1]
[1] https://lore.kernel.org/linux-renesas-soc/20230424161024.136316-1-biju.das.jz@bp.renesas.com/T/#t

v7->v8:
 * Added Rb tags from Geert for patch#1 and patch#2
 * Added RZ/G2L fallback for RZ/V2L DU node.
v7:
 * Added dtsi patches for DU.

Biju Das (4):
  arm64: dts: renesas: r9a07g044: Add DU node
  arm64: dts: renesas: r9a07g054: Add DU node
  arm64: dts: renesas: rzg2l-smarc: Enable DU and link with DSI
  arm64: dts: renesas: rzg2lc-smarc: Enable DU and link with DSI

 arch/arm64/boot/dts/renesas/r9a07g044.dtsi    | 14 +++++++++++++
 arch/arm64/boot/dts/renesas/r9a07g054.dtsi    | 15 +++++++++++++
 arch/arm64/boot/dts/renesas/rzg2l-smarc.dtsi  | 21 +++++++++++++++++++
 arch/arm64/boot/dts/renesas/rzg2lc-smarc.dtsi | 21 +++++++++++++++++++
 4 files changed, 71 insertions(+)

-- 
2.25.1

[PATCH v8 1/4] arm64: dts: renesas: r9a07g044: Add DU node

[Biju Das]

Add DU node to RZ/G2L SoC DTSI.

Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
v7->v8:
 * Added Rb tag from Geert.
v7:
 * New patch.
---
 arch/arm64/boot/dts/renesas/r9a07g044.dtsi | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/r9a07g044.dtsi b/arch/arm64/boot/dts/renesas/r9a07g044.dtsi
index 23bd28dd4d95..003a3711ad56 100644
--- a/arch/arm64/boot/dts/renesas/r9a07g044.dtsi
+++ b/arch/arm64/boot/dts/renesas/r9a07g044.dtsi
@@ -671,6 +671,20 @@ fcpvd: fcp@10880000 {
 			resets = <&cpg R9A07G044_LCDC_RESET_N>;
 		};
 
+		du: display@10890000 {
+			compatible = "renesas,r9a07g044-du";
+			reg = <0 0x10890000 0 0x10000>;
+			interrupts = <GIC_SPI 152 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&cpg CPG_MOD R9A07G044_LCDC_CLK_A>,
+				 <&cpg CPG_MOD R9A07G044_LCDC_CLK_P>,
+				 <&cpg CPG_MOD R9A07G044_LCDC_CLK_D>;
+			clock-names = "aclk", "pclk", "vclk";
+			power-domains = <&cpg>;
+			resets = <&cpg R9A07G044_LCDC_RESET_N>;
+			renesas,vsps = <&vspd 0>;
+			status = "disabled";
+		};
+
 		cpg: clock-controller@11010000 {
 			compatible = "renesas,r9a07g044-cpg";
 			reg = <0 0x11010000 0 0x10000>;
-- 
2.25.1

[PATCH v8 2/4] arm64: dts: renesas: r9a07g054: Add DU node

[Biju Das]

Add DU node to RZ/V2L SoC DTSI.

Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
v7->v8:
 * Added RZ/G2L fallback
 * Added Rb tag from Geert.
v7:
 * New patch.
---
 arch/arm64/boot/dts/renesas/r9a07g054.dtsi | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/r9a07g054.dtsi b/arch/arm64/boot/dts/renesas/r9a07g054.dtsi
index 244934ce5991..3495f6bacfeb 100644
--- a/arch/arm64/boot/dts/renesas/r9a07g054.dtsi
+++ b/arch/arm64/boot/dts/renesas/r9a07g054.dtsi
@@ -677,6 +677,21 @@ fcpvd: fcp@10880000 {
 			resets = <&cpg R9A07G054_LCDC_RESET_N>;
 		};
 
+		du: display@10890000 {
+			compatible = "renesas,r9a07g054-du",
+				     "renesas,r9a07g044-du";
+			reg = <0 0x10890000 0 0x10000>;
+			interrupts = <GIC_SPI 152 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&cpg CPG_MOD R9A07G054_LCDC_CLK_A>,
+				 <&cpg CPG_MOD R9A07G054_LCDC_CLK_P>,
+				 <&cpg CPG_MOD R9A07G054_LCDC_CLK_D>;
+			clock-names = "aclk", "pclk", "vclk";
+			power-domains = <&cpg>;
+			resets = <&cpg R9A07G054_LCDC_RESET_N>;
+			renesas,vsps = <&vspd 0>;
+			status = "disabled";
+		};
+
 		cpg: clock-controller@11010000 {
 			compatible = "renesas,r9a07g054-cpg";
 			reg = <0 0x11010000 0 0x10000>;
-- 
2.25.1

[PATCH v8 3/4] arm64: dts: renesas: rzg2l-smarc: Enable DU and link with DSI

[Biju Das]

Enable DU and link with DSI on RZ/{G2L,V2L} SMARC EVK.

Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
---
v7->v8:
 * No Change.
v7:
 * New patch.
---
 arch/arm64/boot/dts/renesas/rzg2l-smarc.dtsi | 21 ++++++++++++++++++++
 1 file changed, 21 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/rzg2l-smarc.dtsi b/arch/arm64/boot/dts/renesas/rzg2l-smarc.dtsi
index 2a158a954b2f..cd4f569df5cd 100644
--- a/arch/arm64/boot/dts/renesas/rzg2l-smarc.dtsi
+++ b/arch/arm64/boot/dts/renesas/rzg2l-smarc.dtsi
@@ -49,6 +49,7 @@ ports {
 		port@0 {
 			reg = <0>;
 			dsi0_in: endpoint {
+				remote-endpoint = <&du_out_dsi>;
 			};
 		};
 
@@ -62,6 +63,26 @@ dsi0_out: endpoint {
 	};
 };
 
+&du {
+	status = "okay";
+
+	ports {
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		port@0 {
+			reg = <0>;
+			du_out_dsi: endpoint {
+				remote-endpoint = <&dsi0_in>;
+			};
+		};
+
+		port@1 {
+			reg = <1>;
+		};
+	};
+};
+
 &i2c1 {
 	adv7535: hdmi@3d {
 		compatible = "adi,adv7535";
-- 
2.25.1

[PATCH v8 4/4] arm64: dts: renesas: rzg2lc-smarc: Enable DU and link with DSI

[Biju Das]

Enable DU on RZ/G2LC SMARC EVK by linking with DSI.

Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
---
v7->v8:
 * No change.
v7:
 * New patch.
---
 arch/arm64/boot/dts/renesas/rzg2lc-smarc.dtsi | 21 +++++++++++++++++++
 1 file changed, 21 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/rzg2lc-smarc.dtsi b/arch/arm64/boot/dts/renesas/rzg2lc-smarc.dtsi
index 6818fd49b2be..a56110b6d0d4 100644
--- a/arch/arm64/boot/dts/renesas/rzg2lc-smarc.dtsi
+++ b/arch/arm64/boot/dts/renesas/rzg2lc-smarc.dtsi
@@ -63,6 +63,7 @@ ports {
 		port@0 {
 			reg = <0>;
 			dsi0_in: endpoint {
+				remote-endpoint = <&du_out_dsi>;
 			};
 		};
 
@@ -76,6 +77,26 @@ dsi0_out: endpoint {
 	};
 };
 
+&du {
+	status = "okay";
+
+	ports {
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		port@0 {
+			reg = <0>;
+			du_out_dsi: endpoint {
+				remote-endpoint = <&dsi0_in>;
+			};
+		};
+
+		port@1 {
+			reg = <1>;
+		};
+	};
+};
+
 &i2c1 {
 	adv7535: hdmi@3d {
 		compatible = "adi,adv7535";
-- 
2.25.1

Re: [PATCH v8 3/4] arm64: dts: renesas: rzg2l-smarc: Enable DU and link with DSI

[Geert Uytterhoeven]

Hi Biju,

On Mon, Apr 24, 2023 at 6:39 PM Biju Das <biju.das.jz@bp.renesas.com> wrote:
> Enable DU and link with DSI on RZ/{G2L,V2L} SMARC EVK.
>
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>

Thanks for your patch!

> --- a/arch/arm64/boot/dts/renesas/rzg2l-smarc.dtsi
> +++ b/arch/arm64/boot/dts/renesas/rzg2l-smarc.dtsi
> @@ -49,6 +49,7 @@ ports {
>                 port@0 {
>                         reg = <0>;
>                         dsi0_in: endpoint {
> +                               remote-endpoint = <&du_out_dsi>;
>                         };
>                 };
>
> @@ -62,6 +63,26 @@ dsi0_out: endpoint {
>         };
>  };
>
> +&du {
> +       status = "okay";
> +
> +       ports {
> +               #address-cells = <1>;
> +               #size-cells = <0>;
> +
> +               port@0 {
> +                       reg = <0>;
> +                       du_out_dsi: endpoint {
> +                               remote-endpoint = <&dsi0_in>;
> +                       };
> +               };
> +
> +               port@1 {
> +                       reg = <1>;
> +               };

Do you need port@1 if it is not connected to anything?
If yes, don't the port@ subnodes and reg properties belong in the
SoC-specific .dtsi?

> +       };
> +};
> +
>  &i2c1 {
>         adv7535: hdmi@3d {
>                 compatible = "adi,adv7535";

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

RE: [PATCH v8 3/4] arm64: dts: renesas: rzg2l-smarc: Enable DU and link with DSI

[Biju Das]

Hi Geert,

Thanks for the feedback.

> Subject: Re: [PATCH v8 3/4] arm64: dts: renesas: rzg2l-smarc: Enable DU and
> link with DSI
> 
> Hi Biju,
> 
> On Mon, Apr 24, 2023 at 6:39 PM Biju Das <biju.das.jz@bp.renesas.com> wrote:
> > Enable DU and link with DSI on RZ/{G2L,V2L} SMARC EVK.
> >
> > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> 
> Thanks for your patch!
> 
> > --- a/arch/arm64/boot/dts/renesas/rzg2l-smarc.dtsi
> > +++ b/arch/arm64/boot/dts/renesas/rzg2l-smarc.dtsi
> > @@ -49,6 +49,7 @@ ports {
> >                 port@0 {
> >                         reg = <0>;
> >                         dsi0_in: endpoint {
> > +                               remote-endpoint = <&du_out_dsi>;
> >                         };
> >                 };
> >
> > @@ -62,6 +63,26 @@ dsi0_out: endpoint {
> >         };
> >  };
> >
> > +&du {
> > +       status = "okay";
> > +
> > +       ports {
> > +               #address-cells = <1>;
> > +               #size-cells = <0>;
> > +
> > +               port@0 {
> > +                       reg = <0>;
> > +                       du_out_dsi: endpoint {
> > +                               remote-endpoint = <&dsi0_in>;
> > +                       };
> > +               };
> > +
> > +               port@1 {
> > +                       reg = <1>;
> > +               };
> 
> Do you need port@1 if it is not connected to anything?
> If yes, don't the port@ subnodes and reg properties belong in the SoC-
> specific .dtsi?

If I remove port@1, I get below warnings

  DTC     arch/arm64/boot/dts/renesas/r9a07g044l2-smarc.dtb
arch/arm64/boot/dts/renesas/rzg2l-smarc.dtsi:69.8-79.4: Warning (graph_child_address): /soc/display@10890000/ports: graph node has single child node 'port@0', #address-cells/#size-cells are not necessary
  DTC     arch/arm64/boot/dts/renesas/r9a07g054l2-smarc.dtb
arch/arm64/boot/dts/renesas/rzg2l-smarc.dtsi:69.8-79.4: Warning (graph_child_address): /soc/display@10890000/ports: graph node has single child node 'port@0', #address-cells/#size-cells are not necessary


Rob, Krzysztof Kozlowski,

From DT perspective, Is this warning expected?

I see lot of similar warnings related to single vs multiple ports issue.

  DTC     arch/arm64/boot/dts/renesas/r8a779a0-falcon.dtb
arch/arm64/boot/dts/renesas/r8a779a0.dtsi:1124.12-1134.7: Warning (graph_child_address): /soc/video@e6ef0000/ports/port@2: graph node has single child node 'endpoint@0', #address-cells/#size-cells are not necessary
arch/arm64/boot/dts/renesas/r8a779a0.dtsi:1152.12-1162.7: Warning (graph_child_address): /soc/video@e6ef1000/ports/port@2: graph node has single child node 'endpoint@0', #address-cells/#size-cells are not necessary
arch/arm64/boot/dts/renesas/r8a779a0.dtsi:1180.12-1190.7: Warning (graph_child_address): /soc/video@e6ef2000/ports/port@2: graph node has single child node 'endpoint@0', #address-cells/#size-cells are not necessary
arch/arm64/boot/dts/renesas/r8a779a0.dtsi:1208.12-1218.7: Warning (graph_child_address): /soc/video@e6ef3000/ports/port@2: graph node has single child node 'endpoint@0', #address-cells/#size-cells are not necessary
arch/arm64/boot/dts/renesas/r8a779a0.dtsi:1236.12-1246.7: Warning (graph_child_address): /soc/video@e6ef4000/ports/port@2: graph node has single child node 'endpoint@0', #address-cells/#size-cells are not necessary
arch/arm64/boot/dts/renesas/r8a779a0.dtsi:1264.12-1274.7: Warning (graph_child_address): /soc/video@e6ef5000/ports/port@2: graph node has single child node 'endpoint@0', #address-cells/#size-cells are not necessary
arch/arm64/boot/dts/renesas/r8a779a0.dtsi:1292.12-1302.7: Warning (graph_child_address): /soc/video@e6ef6000/ports/port@2: graph node has single child node 'endpoint@0', #address-cells/#size-cells are not necessary
arch/arm64/boot/dts/renesas/r8a779a0.dtsi:1320.12-1330.7: Warning (graph_child_address): /soc/video@e6ef7000/ports/port@2: graph node has single child node 'endpoint@0', #address-cells/#size-cells are not necessary
arch/arm64/boot/dts/renesas/r8a779a0.dtsi:2405.12-2415.7: Warning (graph_child_address): /soc/isp@fed00000/ports/port@0: graph node has single child node 'endpoint@0', #address-cells/#size-cells are not necessary
arch/arm64/boot/dts/renesas/r8a779a0.dtsi:2571.12-2581.7: Warning (graph_child_address): /soc/isp@fed30000/ports/port@0: graph node has single child node 'endpoint@0', #address-cells/#size-cells are not necessary

  DTC     arch/arm64/boot/dts/renesas/r8a779a0-falcon.dtb
arch/arm64/boot/dts/renesas/r8a779a0.dtsi:1124.12-1134.7: Warning (graph_child_address): /soc/video@e6ef0000/ports/port@2: graph node has single child node 'endpoint@0', #address-cells/#size-cells are not necessary
arch/arm64/boot/dts/renesas/r8a779a0.dtsi:1152.12-1162.7: Warning (graph_child_address): /soc/video@e6ef1000/ports/port@2: graph node has single child node 'endpoint@0', #address-cells/#size-cells are not necessary
arch/arm64/boot/dts/renesas/r8a779a0.dtsi:1180.12-1190.7: Warning (graph_child_address): /soc/video@e6ef2000/ports/port@2: graph node has single child node 'endpoint@0', #address-cells/#size-cells are not necessary
arch/arm64/boot/dts/renesas/r8a779a0.dtsi:1208.12-1218.7: Warning (graph_child_address): /soc/video@e6ef3000/ports/port@2: graph node has single child node 'endpoint@0', #address-cells/#size-cells are not necessary
arch/arm64/boot/dts/renesas/r8a779a0.dtsi:1236.12-1246.7: Warning (graph_child_address): /soc/video@e6ef4000/ports/port@2: graph node has single child node 'endpoint@0', #address-cells/#size-cells are not necessary
arch/arm64/boot/dts/renesas/r8a779a0.dtsi:1264.12-1274.7: Warning (graph_child_address): /soc/video@e6ef5000/ports/port@2: graph node has single child node 'endpoint@0', #address-cells/#size-cells are not necessary
arch/arm64/boot/dts/renesas/r8a779a0.dtsi:1292.12-1302.7: Warning (graph_child_address): /soc/video@e6ef6000/ports/port@2: graph node has single child node 'endpoint@0', #address-cells/#size-cells are not necessary
arch/arm64/boot/dts/renesas/r8a779a0.dtsi:1320.12-1330.7: Warning (graph_child_address): /soc/video@e6ef7000/ports/port@2: graph node has single child node 'endpoint@0', #address-cells/#size-cells are not necessary
arch/arm64/boot/dts/renesas/r8a779a0.dtsi:2405.12-2415.7: Warning (graph_child_address): /soc/isp@fed00000/ports/port@0: graph node has single child node 'endpoint@0', #address-cells/#size-cells are not necessary
arch/arm64/boot/dts/renesas/r8a779a0.dtsi:2571.12-2581.7: Warning (graph_child_address): /soc/isp@fed30000/ports/port@0: graph node has single child node 'endpoint@0', #address-cells/#size-cells are not necessary

Cheers,
Biju

> 
> > +       };
> > +};
> > +
> >  &i2c1 {
> >         adv7535: hdmi@3d {
> >                 compatible = "adi,adv7535";
> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-
> m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like
> that.
>                                 -- Linus Torvalds