linux-renesas-soc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/2] clk: vc5: Use device_get_match_data() instead of of_device_get_match_data()
@ 2023-05-07 13:41 Marek Vasut
  2023-05-07 13:41 ` [PATCH 2/2] clk: vc7: " Marek Vasut
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Marek Vasut @ 2023-05-07 13:41 UTC (permalink / raw)
  To: linux-clk
  Cc: Marek Vasut, Alex Helms, Geert Uytterhoeven, Luca Ceresoli,
	Magnus Damm, Michael Turquette, Nathan Chancellor,
	Nick Desaulniers, Stephen Boyd, Tom Rix, linux-renesas-soc

Use device_get_match_data() which, unlike of_device_get_match_data(),
is compatible with other firmware interfaces than just OF.

Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org>
---
Cc: Alex Helms <alexander.helms.jy@renesas.com>
Cc: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Luca Ceresoli <luca.ceresoli@bootlin.com>
Cc: Magnus Damm <magnus.damm@gmail.com>
Cc: Michael Turquette <mturquette@baylibre.com>
Cc: Nathan Chancellor <nathan@kernel.org>
Cc: Nick Desaulniers <ndesaulniers@google.com>
Cc: Stephen Boyd <sboyd@kernel.org>
Cc: Tom Rix <trix@redhat.com>
Cc: linux-clk@vger.kernel.org
Cc: linux-renesas-soc@vger.kernel.org
---
 drivers/clk/clk-versaclock5.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/clk-versaclock5.c b/drivers/clk/clk-versaclock5.c
index 5452471b7ba5..7d91d5e862a3 100644
--- a/drivers/clk/clk-versaclock5.c
+++ b/drivers/clk/clk-versaclock5.c
@@ -953,7 +953,7 @@ static int vc5_probe(struct i2c_client *client)
 
 	i2c_set_clientdata(client, vc5);
 	vc5->client = client;
-	vc5->chip_info = of_device_get_match_data(&client->dev);
+	vc5->chip_info = device_get_match_data(&client->dev);
 
 	vc5->pin_xin = devm_clk_get(&client->dev, "xin");
 	if (PTR_ERR(vc5->pin_xin) == -EPROBE_DEFER)
-- 
2.39.2


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH 2/2] clk: vc7: Use device_get_match_data() instead of of_device_get_match_data()
  2023-05-07 13:41 [PATCH 1/2] clk: vc5: Use device_get_match_data() instead of of_device_get_match_data() Marek Vasut
@ 2023-05-07 13:41 ` Marek Vasut
  2023-05-08 13:07   ` Geert Uytterhoeven
  2023-05-08 12:43 ` [PATCH 1/2] clk: vc5: " Luca Ceresoli
  2023-05-08 13:04 ` Geert Uytterhoeven
  2 siblings, 1 reply; 5+ messages in thread
From: Marek Vasut @ 2023-05-07 13:41 UTC (permalink / raw)
  To: linux-clk
  Cc: Marek Vasut, Alex Helms, Geert Uytterhoeven, Luca Ceresoli,
	Magnus Damm, Michael Turquette, Nathan Chancellor,
	Nick Desaulniers, Stephen Boyd, Tom Rix, linux-renesas-soc

Use device_get_match_data() which, unlike of_device_get_match_data(),
is compatible with other firmware interfaces than just OF.

Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org>
---
Cc: Alex Helms <alexander.helms.jy@renesas.com>
Cc: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Luca Ceresoli <luca.ceresoli@bootlin.com>
Cc: Magnus Damm <magnus.damm@gmail.com>
Cc: Michael Turquette <mturquette@baylibre.com>
Cc: Nathan Chancellor <nathan@kernel.org>
Cc: Nick Desaulniers <ndesaulniers@google.com>
Cc: Stephen Boyd <sboyd@kernel.org>
Cc: Tom Rix <trix@redhat.com>
Cc: linux-clk@vger.kernel.org
Cc: linux-renesas-soc@vger.kernel.org
---
 drivers/clk/clk-versaclock7.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/clk-versaclock7.c b/drivers/clk/clk-versaclock7.c
index 0ae191f50b4b..d563afee79d4 100644
--- a/drivers/clk/clk-versaclock7.c
+++ b/drivers/clk/clk-versaclock7.c
@@ -1108,7 +1108,7 @@ static int vc7_probe(struct i2c_client *client)
 
 	i2c_set_clientdata(client, vc7);
 	vc7->client = client;
-	vc7->chip_info = of_device_get_match_data(&client->dev);
+	vc7->chip_info = device_get_match_data(&client->dev);
 
 	vc7->pin_xin = devm_clk_get(&client->dev, "xin");
 	if (PTR_ERR(vc7->pin_xin) == -EPROBE_DEFER) {
-- 
2.39.2


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/2] clk: vc5: Use device_get_match_data() instead of of_device_get_match_data()
  2023-05-07 13:41 [PATCH 1/2] clk: vc5: Use device_get_match_data() instead of of_device_get_match_data() Marek Vasut
  2023-05-07 13:41 ` [PATCH 2/2] clk: vc7: " Marek Vasut
@ 2023-05-08 12:43 ` Luca Ceresoli
  2023-05-08 13:04 ` Geert Uytterhoeven
  2 siblings, 0 replies; 5+ messages in thread
From: Luca Ceresoli @ 2023-05-08 12:43 UTC (permalink / raw)
  To: Marek Vasut
  Cc: linux-clk, Alex Helms, Geert Uytterhoeven, Magnus Damm,
	Michael Turquette, Nathan Chancellor, Nick Desaulniers,
	Stephen Boyd, Tom Rix, linux-renesas-soc

On Sun,  7 May 2023 15:41:47 +0200
Marek Vasut <marek.vasut+renesas@mailbox.org> wrote:

> Use device_get_match_data() which, unlike of_device_get_match_data(),
> is compatible with other firmware interfaces than just OF.
> 
> Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org>
> ---
> Cc: Alex Helms <alexander.helms.jy@renesas.com>
> Cc: Geert Uytterhoeven <geert+renesas@glider.be>
> Cc: Luca Ceresoli <luca.ceresoli@bootlin.com>
> Cc: Magnus Damm <magnus.damm@gmail.com>
> Cc: Michael Turquette <mturquette@baylibre.com>
> Cc: Nathan Chancellor <nathan@kernel.org>
> Cc: Nick Desaulniers <ndesaulniers@google.com>
> Cc: Stephen Boyd <sboyd@kernel.org>
> Cc: Tom Rix <trix@redhat.com>
> Cc: linux-clk@vger.kernel.org
> Cc: linux-renesas-soc@vger.kernel.org

Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com>

-- 
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/2] clk: vc5: Use device_get_match_data() instead of of_device_get_match_data()
  2023-05-07 13:41 [PATCH 1/2] clk: vc5: Use device_get_match_data() instead of of_device_get_match_data() Marek Vasut
  2023-05-07 13:41 ` [PATCH 2/2] clk: vc7: " Marek Vasut
  2023-05-08 12:43 ` [PATCH 1/2] clk: vc5: " Luca Ceresoli
@ 2023-05-08 13:04 ` Geert Uytterhoeven
  2 siblings, 0 replies; 5+ messages in thread
From: Geert Uytterhoeven @ 2023-05-08 13:04 UTC (permalink / raw)
  To: Marek Vasut
  Cc: linux-clk, Alex Helms, Luca Ceresoli, Magnus Damm,
	Michael Turquette, Nathan Chancellor, Nick Desaulniers,
	Stephen Boyd, Tom Rix, linux-renesas-soc

Hi Marek,

On Sun, May 7, 2023 at 3:42 PM Marek Vasut
<marek.vasut+renesas@mailbox.org> wrote:
> Use device_get_match_data() which, unlike of_device_get_match_data(),
> is compatible with other firmware interfaces than just OF.
>
> Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org>

Thanks for your patch!

> --- a/drivers/clk/clk-versaclock5.c
> +++ b/drivers/clk/clk-versaclock5.c
> @@ -953,7 +953,7 @@ static int vc5_probe(struct i2c_client *client)
>
>         i2c_set_clientdata(client, vc5);
>         vc5->client = client;
> -       vc5->chip_info = of_device_get_match_data(&client->dev);
> +       vc5->chip_info = device_get_match_data(&client->dev);
>
>         vc5->pin_xin = devm_clk_get(&client->dev, "xin");
>         if (PTR_ERR(vc5->pin_xin) == -EPROBE_DEFER)

LGTM, but probably you want to include <linux/property.h> explicitly?

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 2/2] clk: vc7: Use device_get_match_data() instead of of_device_get_match_data()
  2023-05-07 13:41 ` [PATCH 2/2] clk: vc7: " Marek Vasut
@ 2023-05-08 13:07   ` Geert Uytterhoeven
  0 siblings, 0 replies; 5+ messages in thread
From: Geert Uytterhoeven @ 2023-05-08 13:07 UTC (permalink / raw)
  To: Marek Vasut
  Cc: linux-clk, Alex Helms, Luca Ceresoli, Magnus Damm,
	Michael Turquette, Nathan Chancellor, Nick Desaulniers,
	Stephen Boyd, Tom Rix, linux-renesas-soc

Hi Marek,

On Sun, May 7, 2023 at 3:42 PM Marek Vasut
<marek.vasut+renesas@mailbox.org> wrote:
> Use device_get_match_data() which, unlike of_device_get_match_data(),
> is compatible with other firmware interfaces than just OF.
>
> Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org>

Thanks for your patch!

> --- a/drivers/clk/clk-versaclock7.c
> +++ b/drivers/clk/clk-versaclock7.c
> @@ -1108,7 +1108,7 @@ static int vc7_probe(struct i2c_client *client)
>
>         i2c_set_clientdata(client, vc7);
>         vc7->client = client;
> -       vc7->chip_info = of_device_get_match_data(&client->dev);
> +       vc7->chip_info = device_get_match_data(&client->dev);
>
>         vc7->pin_xin = devm_clk_get(&client->dev, "xin");
>         if (PTR_ERR(vc7->pin_xin) == -EPROBE_DEFER) {

LGTM, but probably you want to include <linux/property.h> explicitly?

Gr{oetje,eeting}s,

                        Geert


--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2023-05-08 13:07 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-07 13:41 [PATCH 1/2] clk: vc5: Use device_get_match_data() instead of of_device_get_match_data() Marek Vasut
2023-05-07 13:41 ` [PATCH 2/2] clk: vc7: " Marek Vasut
2023-05-08 13:07   ` Geert Uytterhoeven
2023-05-08 12:43 ` [PATCH 1/2] clk: vc5: " Luca Ceresoli
2023-05-08 13:04 ` Geert Uytterhoeven

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).