* [PATCH] dt-bindings: backlight: pwm: Make power-supply not required
@ 2023-05-23 15:38 Geert Uytterhoeven
2023-05-23 17:35 ` Conor Dooley
2023-05-25 11:32 ` Lee Jones
0 siblings, 2 replies; 3+ messages in thread
From: Geert Uytterhoeven @ 2023-05-23 15:38 UTC (permalink / raw)
To: Lee Jones, Daniel Thompson, Jingoo Han, Pavel Machek,
Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Uwe Kleine-König, Lad Prabhakar
Cc: dri-devel, linux-leds, devicetree, linux-renesas-soc, Geert Uytterhoeven
make dtbs_check:
arch/arm/boot/dts/renesas/r8a7742-iwg21d-q7.dtb: backlight: 'power-supply' is a required property
From schema: Documentation/devicetree/bindings/leds/backlight/pwm-backlight.yaml
As that backlight device node already has an "enable-gpios" property to
control the power supplied to the backlight, it sounds a bit silly to
have to add a "power-supply" property just to silence this warning. In
addition, as of commit deaeeda2051fa280 ("backlight: pwm_bl: Don't rely
on a disabled PWM emiting inactive state"), the Linux driver considers
the power supply optional.
Fix this by synchronizing the bindings with actual driver behavior by
making the "power-supply" optional.
Fixes: deaeeda2051fa280 ("backlight: pwm_bl: Don't rely on a disabled PWM emiting inactive state")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
As commit deaeeda2051fa280 was only upstreamed in v6.3, I'm wondering if
the backlight on the iWave Systems RainboW-G20D/G21D Qseven and
RainboW-G22D-SODIMM boards worked before? I don't have the hardware.
Thanks!
---
.../devicetree/bindings/leds/backlight/pwm-backlight.yaml | 1 -
1 file changed, 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/leds/backlight/pwm-backlight.yaml b/Documentation/devicetree/bindings/leds/backlight/pwm-backlight.yaml
index 5ec47a8c6568b60e..53569028899020d6 100644
--- a/Documentation/devicetree/bindings/leds/backlight/pwm-backlight.yaml
+++ b/Documentation/devicetree/bindings/leds/backlight/pwm-backlight.yaml
@@ -68,7 +68,6 @@ dependencies:
required:
- compatible
- pwms
- - power-supply
additionalProperties: false
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] dt-bindings: backlight: pwm: Make power-supply not required
2023-05-23 15:38 [PATCH] dt-bindings: backlight: pwm: Make power-supply not required Geert Uytterhoeven
@ 2023-05-23 17:35 ` Conor Dooley
2023-05-25 11:32 ` Lee Jones
1 sibling, 0 replies; 3+ messages in thread
From: Conor Dooley @ 2023-05-23 17:35 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Lee Jones, Daniel Thompson, Jingoo Han, Pavel Machek,
Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Uwe Kleine-König, Lad Prabhakar, dri-devel, linux-leds,
devicetree, linux-renesas-soc
[-- Attachment #1: Type: text/plain, Size: 1998 bytes --]
On Tue, May 23, 2023 at 05:38:37PM +0200, Geert Uytterhoeven wrote:
> make dtbs_check:
>
> arch/arm/boot/dts/renesas/r8a7742-iwg21d-q7.dtb: backlight: 'power-supply' is a required property
> From schema: Documentation/devicetree/bindings/leds/backlight/pwm-backlight.yaml
>
> As that backlight device node already has an "enable-gpios" property to
> control the power supplied to the backlight, it sounds a bit silly to
> have to add a "power-supply" property just to silence this warning. In
> addition, as of commit deaeeda2051fa280 ("backlight: pwm_bl: Don't rely
> on a disabled PWM emiting inactive state"), the Linux driver considers
> the power supply optional.
>
> Fix this by synchronizing the bindings with actual driver behavior by
> making the "power-supply" optional.
That seems to follow from reading the aforementioned commit.
Acked-by: Conor Dooley <conor.dooley@microchip.com>
Thanks,
Conor.
>
> Fixes: deaeeda2051fa280 ("backlight: pwm_bl: Don't rely on a disabled PWM emiting inactive state")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> As commit deaeeda2051fa280 was only upstreamed in v6.3, I'm wondering if
> the backlight on the iWave Systems RainboW-G20D/G21D Qseven and
> RainboW-G22D-SODIMM boards worked before? I don't have the hardware.
>
> Thanks!
> ---
> .../devicetree/bindings/leds/backlight/pwm-backlight.yaml | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/leds/backlight/pwm-backlight.yaml b/Documentation/devicetree/bindings/leds/backlight/pwm-backlight.yaml
> index 5ec47a8c6568b60e..53569028899020d6 100644
> --- a/Documentation/devicetree/bindings/leds/backlight/pwm-backlight.yaml
> +++ b/Documentation/devicetree/bindings/leds/backlight/pwm-backlight.yaml
> @@ -68,7 +68,6 @@ dependencies:
> required:
> - compatible
> - pwms
> - - power-supply
>
> additionalProperties: false
>
> --
> 2.34.1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] dt-bindings: backlight: pwm: Make power-supply not required
2023-05-23 15:38 [PATCH] dt-bindings: backlight: pwm: Make power-supply not required Geert Uytterhoeven
2023-05-23 17:35 ` Conor Dooley
@ 2023-05-25 11:32 ` Lee Jones
1 sibling, 0 replies; 3+ messages in thread
From: Lee Jones @ 2023-05-25 11:32 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Daniel Thompson, Jingoo Han, Pavel Machek, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Uwe Kleine-König,
Lad Prabhakar, dri-devel, linux-leds, devicetree,
linux-renesas-soc
On Tue, 23 May 2023, Geert Uytterhoeven wrote:
> make dtbs_check:
>
> arch/arm/boot/dts/renesas/r8a7742-iwg21d-q7.dtb: backlight: 'power-supply' is a required property
> From schema: Documentation/devicetree/bindings/leds/backlight/pwm-backlight.yaml
>
> As that backlight device node already has an "enable-gpios" property to
> control the power supplied to the backlight, it sounds a bit silly to
> have to add a "power-supply" property just to silence this warning. In
> addition, as of commit deaeeda2051fa280 ("backlight: pwm_bl: Don't rely
> on a disabled PWM emiting inactive state"), the Linux driver considers
> the power supply optional.
>
> Fix this by synchronizing the bindings with actual driver behavior by
> making the "power-supply" optional.
>
> Fixes: deaeeda2051fa280 ("backlight: pwm_bl: Don't rely on a disabled PWM emiting inactive state")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> As commit deaeeda2051fa280 was only upstreamed in v6.3, I'm wondering if
> the backlight on the iWave Systems RainboW-G20D/G21D Qseven and
> RainboW-G22D-SODIMM boards worked before? I don't have the hardware.
>
> Thanks!
> ---
> .../devicetree/bindings/leds/backlight/pwm-backlight.yaml | 1 -
> 1 file changed, 1 deletion(-)
Applied, thanks
--
Lee Jones [李琼斯]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-05-25 11:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-23 15:38 [PATCH] dt-bindings: backlight: pwm: Make power-supply not required Geert Uytterhoeven
2023-05-23 17:35 ` Conor Dooley
2023-05-25 11:32 ` Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).