[PATCH 0/2] serial: core: updates to uapi header

[PATCH 0/2] serial: core: updates to uapi header

[Wolfram Sang]

I tried to remove port 18 but that was rightfully a no-go. Add a comment
explaining the case. And remove boilerplate in the header while we are
here.


Wolfram Sang (2):
  serial: core: remove cruft from uapi header
  serial: core: add comment about definitely used port types

 include/uapi/linux/serial_core.h | 18 ++----------------
 1 file changed, 2 insertions(+), 16 deletions(-)

-- 
2.35.1

[PATCH 1/2] serial: core: remove cruft from uapi header

[Wolfram Sang]

Remove the GPL boilerplate since we have a valid SPDX entry. Also,
remove the outdated filename from the comment.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
 include/uapi/linux/serial_core.h | 16 ----------------
 1 file changed, 16 deletions(-)

diff --git a/include/uapi/linux/serial_core.h b/include/uapi/linux/serial_core.h
index add349889d0a..92e3dd56f631 100644
--- a/include/uapi/linux/serial_core.h
+++ b/include/uapi/linux/serial_core.h
@@ -1,22 +1,6 @@
 /* SPDX-License-Identifier: GPL-2.0+ WITH Linux-syscall-note */
 /*
- *  linux/drivers/char/serial_core.h
- *
  *  Copyright (C) 2000 Deep Blue Solutions Ltd.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
  */
 #ifndef _UAPILINUX_SERIAL_CORE_H
 #define _UAPILINUX_SERIAL_CORE_H
-- 
2.35.1

[PATCH 2/2] serial: core: add comment about definitely used port types

[Wolfram Sang]

When port type 18 was removed, it was deduced that the code could go but
its define has to stay because it is used in userspace. Share that
knowledge by adding a comment about it.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
 include/uapi/linux/serial_core.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/include/uapi/linux/serial_core.h b/include/uapi/linux/serial_core.h
index 92e3dd56f631..46e06c483899 100644
--- a/include/uapi/linux/serial_core.h
+++ b/include/uapi/linux/serial_core.h
@@ -11,6 +11,8 @@
  * The type definitions.  These are from Ted Ts'o's serial.h
  * By historical reasons the values from 0 to 13 are defined
  * in the include/uapi/linux/serial.h, do not define them here.
+ * Values 0 to 19 are used by setserial from busybox and must never
+ * be modified.
  */
 #define PORT_NS16550A	14
 #define PORT_XSCALE	15
-- 
2.35.1

Re: [PATCH 1/2] serial: core: remove cruft from uapi header

[Geert Uytterhoeven]

On Fri, Sep 22, 2023 at 10:48 AM Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
> Remove the GPL boilerplate since we have a valid SPDX entry. Also,
> remove the outdated filename from the comment.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds