linux-renesas-soc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sergei Shtylyov <sergei.shtylyov@gmail.com>
To: Yuusuke Ashizuka <ashiduka@fujitsu.com>,
	davem@davemloft.net, kuba@kernel.org
Cc: netdev@vger.kernel.org, linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH v3] ravb: Fixed to be able to unload modules
Date: Thu, 20 Aug 2020 13:03:07 +0300	[thread overview]
Message-ID: <47080d76-8fdd-9222-34c1-3d174ea6bef8@gmail.com> (raw)
In-Reply-To: <20200820094307.3977-1-ashiduka@fujitsu.com>

On 20.08.2020 12:43, Yuusuke Ashizuka wrote:

> When this driver is built as a module, I cannot rmmod it after insmoding
> it.
> This is because that this driver calls ravb_mdio_init() at the time of

    "That" not needed here at all; perhaps can be fixed while applying...

> probe, and module->refcnt is incremented by alloc_mdio_bitbang() called
> after that.
> Therefore, even if ifup is not performed, the driver is in use and rmmod
> cannot be performed.
> 
> $ lsmod
> Module                  Size  Used by
> ravb                   40960  1
> $ rmmod ravb
> rmmod: ERROR: Module ravb is in use
> 
> Call ravb_mdio_init() at open and free_mdio_bitbang() at close, thereby
> rmmod is possible in the ifdown state.
> 
> Fixes: c156633f1353 ("Renesas Ethernet AVB driver proper")
> Signed-off-by: Yuusuke Ashizuka <ashiduka@fujitsu.com>
> Reviewed-by: Sergei Shtylyov <sergei.shtylyov@gmail.com>
[...]

MBR, Sergei

  reply	other threads:[~2020-08-20 11:48 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-20  9:43 [PATCH v3] ravb: Fixed to be able to unload modules Yuusuke Ashizuka
2020-08-20 10:03 ` Sergei Shtylyov [this message]
2020-08-20 12:29 ` Sergei Shtylyov
2020-08-20 12:31   ` Sergei Shtylyov
2020-08-20 23:52 ` David Miller
2020-08-24 22:38 ` David Miller
2020-09-16  9:31 ` Geert Uytterhoeven
2020-09-21 13:16   ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47080d76-8fdd-9222-34c1-3d174ea6bef8@gmail.com \
    --to=sergei.shtylyov@gmail.com \
    --cc=ashiduka@fujitsu.com \
    --cc=davem@davemloft.net \
    --cc=kuba@kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).