* [PATCH] drm/rcar-du: DRM_RCAR_WRITEBACK depends on DRM
@ 2020-06-08 1:48 Qian Cai
2020-06-08 2:02 ` Laurent Pinchart
0 siblings, 1 reply; 3+ messages in thread
From: Qian Cai @ 2020-06-08 1:48 UTC (permalink / raw)
To: laurent.pinchart, kieran.bingham+renesas
Cc: airlied, daniel, dri-devel, linux-renesas-soc, linux-kernel, Qian Cai
There is no need to select DRM_RCAR_WRITEBACK if DRM=n which just make
the generated .config a bit ugly.
# ARM devices
#
# end of ARM devices
CONFIG_DRM_RCAR_WRITEBACK=y
#
# Frame buffer Devices
Signed-off-by: Qian Cai <cai@lca.pw>
---
drivers/gpu/drm/rcar-du/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/rcar-du/Kconfig b/drivers/gpu/drm/rcar-du/Kconfig
index 0919f1f159a4..d80696455d3e 100644
--- a/drivers/gpu/drm/rcar-du/Kconfig
+++ b/drivers/gpu/drm/rcar-du/Kconfig
@@ -48,3 +48,4 @@ config DRM_RCAR_VSP
config DRM_RCAR_WRITEBACK
bool
default y if ARM64
+ depends on DRM
--
2.21.0 (Apple Git-122.2)
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/rcar-du: DRM_RCAR_WRITEBACK depends on DRM
2020-06-08 1:48 [PATCH] drm/rcar-du: DRM_RCAR_WRITEBACK depends on DRM Qian Cai
@ 2020-06-08 2:02 ` Laurent Pinchart
2020-06-08 2:44 ` Qian Cai
0 siblings, 1 reply; 3+ messages in thread
From: Laurent Pinchart @ 2020-06-08 2:02 UTC (permalink / raw)
To: Qian Cai
Cc: kieran.bingham+renesas, airlied, daniel, dri-devel,
linux-renesas-soc, linux-kernel
Hi Qian,
Thank you for the patch.
On Sun, Jun 07, 2020 at 09:48:18PM -0400, Qian Cai wrote:
> There is no need to select DRM_RCAR_WRITEBACK if DRM=n which just make
> the generated .config a bit ugly.
>
> # ARM devices
> #
> # end of ARM devices
>
> CONFIG_DRM_RCAR_WRITEBACK=y
>
> #
> # Frame buffer Devices
>
> Signed-off-by: Qian Cai <cai@lca.pw>
> ---
> drivers/gpu/drm/rcar-du/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/rcar-du/Kconfig b/drivers/gpu/drm/rcar-du/Kconfig
> index 0919f1f159a4..d80696455d3e 100644
> --- a/drivers/gpu/drm/rcar-du/Kconfig
> +++ b/drivers/gpu/drm/rcar-du/Kconfig
> @@ -48,3 +48,4 @@ config DRM_RCAR_VSP
> config DRM_RCAR_WRITEBACK
> bool
> default y if ARM64
> + depends on DRM
How about depending on DRM_RCAR_DU instead, as DRM_RCAR_WRITEBACK is
used to select compilation of rcar_du_writeback.c that is part of the
rcar-du driver ?
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/rcar-du: DRM_RCAR_WRITEBACK depends on DRM
2020-06-08 2:02 ` Laurent Pinchart
@ 2020-06-08 2:44 ` Qian Cai
0 siblings, 0 replies; 3+ messages in thread
From: Qian Cai @ 2020-06-08 2:44 UTC (permalink / raw)
To: Laurent Pinchart
Cc: kieran.bingham+renesas, airlied, daniel, dri-devel,
linux-renesas-soc, linux-kernel
> On Jun 7, 2020, at 10:02 PM, Laurent Pinchart <laurent.pinchart@ideasonboard.com> wrote:
>
> How about depending on DRM_RCAR_DU instead, as DRM_RCAR_WRITEBACK is
> used to select compilation of rcar_du_writeback.c that is part of the
> rcar-du driver ?
Sure. I’ll send a v2.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-06-08 2:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-08 1:48 [PATCH] drm/rcar-du: DRM_RCAR_WRITEBACK depends on DRM Qian Cai
2020-06-08 2:02 ` Laurent Pinchart
2020-06-08 2:44 ` Qian Cai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).