From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: masonccyang@mxic.com.tw
Cc: bbrezillon@kernel.org, broonie@kernel.org,
devicetree@vger.kernel.org,
Geert Uytterhoeven <geert+renesas@glider.be>,
Simon Horman <horms@verge.net.au>,
juliensu@mxic.com.tw, lee.jones@linaro.org,
linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
linux-spi@vger.kernel.org, marek.vasut@gmail.com,
mark.rutland@arm.com, robh+dt@kernel.org, zhengxunli@mxic.com.tw
Subject: Re: [PATCH v9 2/3] spi: Add Renesas R-Car Gen3 RPC-IF SPI controller driver
Date: Mon, 22 Apr 2019 19:44:04 +0300 [thread overview]
Message-ID: <529fe004-63e2-43c3-0382-9aaa86d0c3a9@cogentembedded.com> (raw)
In-Reply-To: <OFE74649D4.F69BB5EF-ON482583E1.0033F73F-482583E1.00344ED2@mxic.com.tw>
On 04/19/2019 12:31 PM, masonccyang@mxic.com.tw wrote:
>> > Re: [PATCH v9 2/3] spi: Add Renesas R-Car Gen3 RPC-IF SPI controller driver
>> >
>> > On 04/18/2019 05:51 AM, masonccyang@mxic.com.tw wrote:
>> >
>> > >> >> >> Add a driver for Renesas R-Car Gen3 RPC-IF SPI controller.
>> > >> >> >>
>> > >> >> >> Signed-off-by: Mason Yang <masonccyang@mxic.com.tw>
>> > >> >> >> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>> > >> >> > [...]
>> > >> >> >> diff --git a/drivers/spi/spi-renesas-rpc.c b/drivers/spi/spi-
>> > >> renesas-rpc.c
>> > >> >> >> new file mode 100644
>> > >> >> >> index 0000000..037f273
>> > >> >> >> --- /dev/null
>> > >> >> >> +++ b/drivers/spi/spi-renesas-rpc.c
>> > >> >> > [...]
>> > >> >> >> +static int rpc_spi_probe(struct platform_device *pdev)
>> > >> >> >> +{
>> > >> >> >> + struct spi_controller *ctlr;
>> > >> >> >> + struct rpc_mfd *rpc_mfd = dev_get_drvdata(pdev->dev.parent);
>> > >> >> >> + struct rpc_spi *rpc;
>> > >> >> >> + int ret;
>> > >> >> >> +
>> > >> >> >> + ctlr = spi_alloc_master(&pdev->dev, sizeof(*rpc));
>> > >> >> >> + if (!ctlr)
>> > >> >> >> + return -ENOMEM;
>> > >> >> >> +
>> > >> >> >> + platform_set_drvdata(pdev, ctlr);
>> > >> >> >> +
>> > >> >> >> + rpc = spi_controller_get_devdata(ctlr);
>> > >> >> >> +
>> > >> >> >> + ctlr->dev.of_node = pdev->dev.of_node;
>> > >> >> > [...]
>> > >> >> >> +
>> > >> >> >> + pm_runtime_enable(&pdev->dev);
>> > >> >> >> + ctlr->auto_runtime_pm = true;
>> > >> >> >
>> > >> >> > I think this line no longer works as expected with the new
>> > >> >> probing scheme.
>> > >>
>> > >> That's because we added another (SPI) device under our MFD.
>> > >
>> > > Do you mean just to remove one line
>> > > ctlr->auto_runtime_pm = true;
>> > > ?
>
>> how did you test it ?
>> what is your testing flow ?
I think I've patched drivers/spi/spi-mem.c to get spi_mem_access_{start|end}()
to be called with ctlr->dev.parent->parent as an arg...
>> > No, you should explicitly call RPM for the MFD (not the SPI device).
>>
>> okay, patch RPM to RPC MFD and will remove SPI RPM enable part.
>
> wait! I test it ok.
>
> Don't need to patch RPM to RPC MFD, just keep RPM in SPI.
>
> root@draak:/sys/power# echo mem > state
> [ 135.848711] PM: suspend entry (s2idle)
> [ 135.852777] PM: Syncing filesystems ... done.
> [ 135.869468] Freezing user space processes ... (elapsed 0.002 seconds) done.
> [ 135.879962] OOM killer disabled.
> [ 135.883257] Freezing remaining freezable tasks ... (elapsed 0.002 seconds) done.
> [ 135.893474] Suspending console(s) (use no_console_suspend to debug)
> [ 135.910946] [Mason] rpc_spi_suspend
> [ 135.986022] PM: suspend devices took 0.084 seconds
> [ 135.986047] PM: suspend debug: Waiting for 5 second(s).
> [ 141.142024] [Mason] rpc_spi_resume
> [ 141.220859] PM: resume devices took 0.116 seconds
> [ 141.243179] OOM killer enabled.
> [ 141.246417] Restarting tasks ... done.
> [ 141.266579] PM: suspend exit
> root@draak:/sys/power#
That's not *runtime* PM, it's the *plain* PM you're testing here...
> thanks & best regards,
> Mason
MBR, Sergei
next prev parent reply other threads:[~2019-04-22 16:44 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-29 8:20 [PATCH v9 0/3] mfd: Add Renesas R-Car Gen3 RPC-IF MFD driver Mason Yang
2019-03-29 8:20 ` [PATCH v9 1/3] mfd: Add Renesas R-Car Gen3 RPC-IF MFD controller driver Mason Yang
2019-03-29 10:43 ` Marek Vasut
2019-03-29 15:12 ` Sergei Shtylyov
2019-03-29 8:20 ` [PATCH v9 2/3] spi: Add Renesas R-Car Gen3 RPC-IF SPI " Mason Yang
2019-03-29 10:44 ` Marek Vasut
2019-03-29 15:52 ` Sergei Shtylyov
[not found] ` <OF7F1B534F.B934A9FE-ON482583D0.001DC618-482583D0.001FE84B@mxic.com.tw>
2019-04-02 20:10 ` Sergei Shtylyov
[not found] ` <OFAEA16021.C7F7B095-ON482583D1.0031A13D-482583D1.00335085@mxic.com.tw>
2019-04-04 18:56 ` Sergei Shtylyov
2019-04-04 19:12 ` Boris Brezillon
2019-04-06 19:59 ` Sergei Shtylyov
2019-04-09 11:20 ` Sergei Shtylyov
2019-04-10 19:47 ` Sergei Shtylyov
2019-04-09 20:07 ` Sergei Shtylyov
[not found] ` <OFC7F0028A.CFF6BD04-ON482583D8.00084FA1-482583D8.0008985F@mxic.com.tw>
2019-04-10 6:27 ` Marek Vasut
[not found] ` <OF75EDBF48.5C308F1B-ON482583D8.0027A537-482583D8.002C0A64@mxic.com.tw>
2019-04-10 8:03 ` Marek Vasut
2019-04-10 8:11 ` Boris Brezillon
2019-04-10 17:53 ` Sergei Shtylyov
2019-04-13 16:38 ` Sergei Shtylyov
2019-04-13 16:39 ` Sergei Shtylyov
[not found] ` <OF82CE76E9.E6395EF7-ON482583DD.000E37D7-482583DD.000E5077@mxic.com.tw>
2019-04-17 18:44 ` Sergei Shtylyov
[not found] ` <OF4ABCC306.B053BA23-ON482583E0.000F480C-482583E0.000FAD4A@mxic.com.tw>
2019-04-18 19:43 ` Sergei Shtylyov
[not found] ` <OF58AAFF49.C4593DEB-ON482583E1.001D551E-482583E1.001F089D@LocalDomain>
[not found] ` <OFE74649D4.F69BB5EF-ON482583E1.0033F73F-482583E1.00344ED2@mxic.com.tw>
2019-04-22 16:44 ` Sergei Shtylyov [this message]
[not found] ` <OF58AAFF49.C4593DEB-ON482583E1.001D551E-482583E1.001F089D@mxic.com.tw>
2019-04-23 7:29 ` Geert Uytterhoeven
2019-05-14 19:06 ` Sergei Shtylyov
2019-05-14 19:13 ` Sergei Shtylyov
2019-03-29 8:20 ` [PATCH v9 3/3] dt-bindings: mfd: Document Renesas R-Car Gen3 RPC-IF controller bindings Mason Yang
2019-03-29 10:45 ` Marek Vasut
2019-03-29 10:49 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=529fe004-63e2-43c3-0382-9aaa86d0c3a9@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=bbrezillon@kernel.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=horms@verge.net.au \
--cc=juliensu@mxic.com.tw \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=marek.vasut@gmail.com \
--cc=mark.rutland@arm.com \
--cc=masonccyang@mxic.com.tw \
--cc=robh+dt@kernel.org \
--cc=zhengxunli@mxic.com.tw \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).