Linux-Renesas-SoC Archive on lore.kernel.org
 help / color / Atom feed
* [GIT PULL] Renesas ARM Based SoC Updates for v5.1
@ 2019-02-08 11:14 Simon Horman
  2019-02-08 11:14 ` [PATCH 1/2] ARM: shmobile: Add missing dts files to MAINTAINERS Simon Horman
                   ` (2 more replies)
  0 siblings, 3 replies; 9+ messages in thread
From: Simon Horman @ 2019-02-08 11:14 UTC (permalink / raw)
  To: arm
  Cc: linux-renesas-soc, Olof Johansson, Kevin Hilman, Arnd Bergmann,
	linux-arm-kernel, Magnus Damm, Simon Horman

Hi Olof, Hi Kevin, Hi Arnd,

Please consider these Renesas ARM based SoC updates for v5.1.


The following changes since commit bfeffd155283772bbe78c6a05dec7c0128ee500c:

  Linux 5.0-rc1 (2019-01-06 17:08:20 -0800)

are available in the git repository at:

  https://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas.git tags/renesas-arm-soc-for-v5.1

for you to fetch changes up to 5347a0203709d5039a74d7c94e23519eee478094:

  ARM: shmobile: Fix R-Car Gen2 regulator quirk (2019-01-07 13:24:07 +0100)

----------------------------------------------------------------
Renesas ARM Based SoC Updates for v5.1

* Correct shared IRQ handling of R-Car Gen2 Regulator quirk
* Add missing dts files to MAINTAINERS

----------------------------------------------------------------
Marek Vasut (1):
      ARM: shmobile: Fix R-Car Gen2 regulator quirk

Simon Horman (1):
      ARM: shmobile: Add missing dts files to MAINTAINERS

 MAINTAINERS                                        | 2 ++
 arch/arm/mach-shmobile/regulator-quirk-rcar-gen2.c | 5 +++++
 2 files changed, 7 insertions(+)

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [PATCH 1/2] ARM: shmobile: Add missing dts files to MAINTAINERS
  2019-02-08 11:14 [GIT PULL] Renesas ARM Based SoC Updates for v5.1 Simon Horman
@ 2019-02-08 11:14 ` Simon Horman
  2019-02-08 11:14 ` [PATCH 2/2] ARM: shmobile: Fix R-Car Gen2 regulator quirk Simon Horman
  2019-02-15 16:49 ` [GIT PULL] Renesas ARM Based SoC Updates for v5.1 Arnd Bergmann
  2 siblings, 0 replies; 9+ messages in thread
From: Simon Horman @ 2019-02-08 11:14 UTC (permalink / raw)
  To: linux-renesas-soc; +Cc: linux-arm-kernel, Magnus Damm, Simon Horman

Add some more patterns to the ARM/SHMOBILE ARM ARCHITECTURE
section of MAINTAINERS to complete the list of maintained dts files.

As of writing dts files covered are:
* arch/arm/boot/dts/gr-peach-audiocamerashield.dtsi
* arch/arm/boot/dts/iwg20d-q7-common.dtsi
* arch/arm/boot/dts/iwg20d-q7-dbcm-ca.dtsi

Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 MAINTAINERS | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 32d444476a90..f4c805c1a34b 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -2109,6 +2109,8 @@ Q:	http://patchwork.kernel.org/project/linux-renesas-soc/list/
 T:	git git://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas.git next
 S:	Supported
 F:	arch/arm/boot/dts/emev2*
+F:	arch/arm/boot/dts/gr-peach*
+F:	arch/arm/boot/dts/iwg20d-q7*
 F:	arch/arm/boot/dts/r7s*
 F:	arch/arm/boot/dts/r8a*
 F:	arch/arm/boot/dts/r9a*
-- 
2.11.0


^ permalink raw reply	[flat|nested] 9+ messages in thread

* [PATCH 2/2] ARM: shmobile: Fix R-Car Gen2 regulator quirk
  2019-02-08 11:14 [GIT PULL] Renesas ARM Based SoC Updates for v5.1 Simon Horman
  2019-02-08 11:14 ` [PATCH 1/2] ARM: shmobile: Add missing dts files to MAINTAINERS Simon Horman
@ 2019-02-08 11:14 ` Simon Horman
  2019-02-15 16:49 ` [GIT PULL] Renesas ARM Based SoC Updates for v5.1 Arnd Bergmann
  2 siblings, 0 replies; 9+ messages in thread
From: Simon Horman @ 2019-02-08 11:14 UTC (permalink / raw)
  To: linux-renesas-soc
  Cc: linux-arm-kernel, Magnus Damm, Marek Vasut, Marek Vasut, Simon Horman

From: Marek Vasut <marek.vasut@gmail.com>

The quirk code currently detects all compatible I2C chips with a shared
IRQ line on all I2C busses, adds them into a list, and registers a bus
notifier. For every chip for which the bus notifier triggers, the quirk
code performs I2C transfer on that I2C bus for all addresses in the list.
The problem is that this may generate transfers to non-existing chips on
systems with multiple I2C busses.

This patch adds a check to verify that the I2C bus to which the chip with
shared IRQ is attached to matches the I2C bus of the chip which triggered
the bus notifier and only starts the I2C transfer if they match.

Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com>
Tested-by: Nguyen Viet Dung <dung.nguyen.aj@renesas.com>
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
 arch/arm/mach-shmobile/regulator-quirk-rcar-gen2.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/arch/arm/mach-shmobile/regulator-quirk-rcar-gen2.c b/arch/arm/mach-shmobile/regulator-quirk-rcar-gen2.c
index 8e50daa99151..dc526ef2e9b3 100644
--- a/arch/arm/mach-shmobile/regulator-quirk-rcar-gen2.c
+++ b/arch/arm/mach-shmobile/regulator-quirk-rcar-gen2.c
@@ -40,6 +40,7 @@
 struct regulator_quirk {
 	struct list_head		list;
 	const struct of_device_id	*id;
+	struct device_node		*np;
 	struct of_phandle_args		irq_args;
 	struct i2c_msg			i2c_msg;
 	bool				shared;	/* IRQ line is shared */
@@ -101,6 +102,9 @@ static int regulator_quirk_notify(struct notifier_block *nb,
 		if (!pos->shared)
 			continue;
 
+		if (pos->np->parent != client->dev.parent->of_node)
+			continue;
+
 		dev_info(&client->dev, "clearing %s@0x%02x interrupts\n",
 			 pos->id->compatible, pos->i2c_msg.addr);
 
@@ -165,6 +169,7 @@ static int __init rcar_gen2_regulator_quirk(void)
 		memcpy(&quirk->i2c_msg, id->data, sizeof(quirk->i2c_msg));
 
 		quirk->id = id;
+		quirk->np = np;
 		quirk->i2c_msg.addr = addr;
 
 		ret = of_irq_parse_one(np, 0, argsa);
-- 
2.11.0


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [GIT PULL] Renesas ARM Based SoC Updates for v5.1
  2019-02-08 11:14 [GIT PULL] Renesas ARM Based SoC Updates for v5.1 Simon Horman
  2019-02-08 11:14 ` [PATCH 1/2] ARM: shmobile: Add missing dts files to MAINTAINERS Simon Horman
  2019-02-08 11:14 ` [PATCH 2/2] ARM: shmobile: Fix R-Car Gen2 regulator quirk Simon Horman
@ 2019-02-15 16:49 ` Arnd Bergmann
  2019-02-18 11:27   ` Simon Horman
  2 siblings, 1 reply; 9+ messages in thread
From: Arnd Bergmann @ 2019-02-15 16:49 UTC (permalink / raw)
  To: Simon Horman
  Cc: arm-soc, Linux-Renesas, Olof Johansson, Kevin Hilman, Linux ARM,
	Magnus Damm

On Fri, Feb 8, 2019 at 12:14 PM Simon Horman <horms+renesas@verge.net.au> wrote:
>
> Hi Olof, Hi Kevin, Hi Arnd,
>
> Please consider these Renesas ARM based SoC updates for v5.1.
>
>
> The following changes since commit bfeffd155283772bbe78c6a05dec7c0128ee500c:
>
>   Linux 5.0-rc1 (2019-01-06 17:08:20 -0800)
>
> are available in the git repository at:
>
>   https://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas.git tags/renesas-arm-soc-for-v5.1
>
> for you to fetch changes up to 5347a0203709d5039a74d7c94e23519eee478094:
>
>   ARM: shmobile: Fix R-Car Gen2 regulator quirk (2019-01-07 13:24:07 +0100)
>
> ----------------------------------------------------------------
> Renesas ARM Based SoC Updates for v5.1
>
> * Correct shared IRQ handling of R-Car Gen2 Regulator quirk
> * Add missing dts files to MAINTAINERS

Should the bugfix be marked Cc:stable and and Fixes:... ?

Pulled into arm/soc, thanks!

    Arnd

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [GIT PULL] Renesas ARM Based SoC Updates for v5.1
  2019-02-15 16:49 ` [GIT PULL] Renesas ARM Based SoC Updates for v5.1 Arnd Bergmann
@ 2019-02-18 11:27   ` Simon Horman
  2019-02-18 13:12     ` Arnd Bergmann
  0 siblings, 1 reply; 9+ messages in thread
From: Simon Horman @ 2019-02-18 11:27 UTC (permalink / raw)
  To: Arnd Bergmann
  Cc: arm-soc, Linux-Renesas, Olof Johansson, Kevin Hilman, Linux ARM,
	Magnus Damm, Geert Uytterhoeven, Marek Vasut

On Fri, Feb 15, 2019 at 05:49:32PM +0100, Arnd Bergmann wrote:
> On Fri, Feb 8, 2019 at 12:14 PM Simon Horman <horms+renesas@verge.net.au> wrote:
> >
> > Hi Olof, Hi Kevin, Hi Arnd,
> >
> > Please consider these Renesas ARM based SoC updates for v5.1.
> >
> >
> > The following changes since commit bfeffd155283772bbe78c6a05dec7c0128ee500c:
> >
> >   Linux 5.0-rc1 (2019-01-06 17:08:20 -0800)
> >
> > are available in the git repository at:
> >
> >   https://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas.git tags/renesas-arm-soc-for-v5.1
> >
> > for you to fetch changes up to 5347a0203709d5039a74d7c94e23519eee478094:
> >
> >   ARM: shmobile: Fix R-Car Gen2 regulator quirk (2019-01-07 13:24:07 +0100)
> >
> > ----------------------------------------------------------------
> > Renesas ARM Based SoC Updates for v5.1
> >
> > * Correct shared IRQ handling of R-Car Gen2 Regulator quirk
> > * Add missing dts files to MAINTAINERS
> 
> Should the bugfix be marked Cc:stable and and Fixes:... ?
> 
> Pulled into arm/soc, thanks!

Thanks,

Sorry for missing that, I think that the bugfix should have had the following.
Let me know if/how you want to handle updating the patch's changelog.

Fixes: 6d14d4d313d09dab ("ARM: shmobile: Rework the PMIC IRQ line quirk")

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [GIT PULL] Renesas ARM Based SoC Updates for v5.1
  2019-02-18 11:27   ` Simon Horman
@ 2019-02-18 13:12     ` Arnd Bergmann
  2019-02-18 14:15       ` Simon Horman
  0 siblings, 1 reply; 9+ messages in thread
From: Arnd Bergmann @ 2019-02-18 13:12 UTC (permalink / raw)
  To: Simon Horman
  Cc: arm-soc, Linux-Renesas, Olof Johansson, Kevin Hilman, Linux ARM,
	Magnus Damm, Geert Uytterhoeven, Marek Vasut, stable

On Mon, Feb 18, 2019 at 12:27 PM Simon Horman <horms@verge.net.au> wrote:
> On Fri, Feb 15, 2019 at 05:49:32PM +0100, Arnd Bergmann wrote:
> > On Fri, Feb 8, 2019 at 12:14 PM Simon Horman <horms+renesas@verge.net.au> wrote:
> > > Renesas ARM Based SoC Updates for v5.1
> > >
> > > * Correct shared IRQ handling of R-Car Gen2 Regulator quirk
> > > * Add missing dts files to MAINTAINERS
> >
> > Should the bugfix be marked Cc:stable and and Fixes:... ?
> >
> Sorry for missing that, I think that the bugfix should have had the following.
> Let me know if/how you want to handle updating the patch's changelog.
>
> Fixes: 6d14d4d313d09dab ("ARM: shmobile: Rework the PMIC IRQ line quirk")

I think the easiest way is to send an email to stable@kernel.org asking for
a backport of commit 5347a0203709 ("ARM: shmobile: Fix R-Car Gen2 regulator
quirk") after that has hit the mainline kernel and asking for a backport.

I've added it to Cc here, but I don't know if that's sufficient.

If you'd rather have me pick up the patch for 5.0 as well, I can also do
that and add the Cc/Fixes lines there. We will then have a duplicate
commit in 5.1, but it should not cause any merge issues.

      Arnd

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [GIT PULL] Renesas ARM Based SoC Updates for v5.1
  2019-02-18 13:12     ` Arnd Bergmann
@ 2019-02-18 14:15       ` Simon Horman
  2019-02-18 14:21         ` Arnd Bergmann
  0 siblings, 1 reply; 9+ messages in thread
From: Simon Horman @ 2019-02-18 14:15 UTC (permalink / raw)
  To: Arnd Bergmann
  Cc: arm-soc, Linux-Renesas, Olof Johansson, Kevin Hilman, Linux ARM,
	Magnus Damm, Geert Uytterhoeven, Marek Vasut, stable

On Mon, Feb 18, 2019 at 02:12:07PM +0100, Arnd Bergmann wrote:
> On Mon, Feb 18, 2019 at 12:27 PM Simon Horman <horms@verge.net.au> wrote:
> > On Fri, Feb 15, 2019 at 05:49:32PM +0100, Arnd Bergmann wrote:
> > > On Fri, Feb 8, 2019 at 12:14 PM Simon Horman <horms+renesas@verge.net.au> wrote:
> > > > Renesas ARM Based SoC Updates for v5.1
> > > >
> > > > * Correct shared IRQ handling of R-Car Gen2 Regulator quirk
> > > > * Add missing dts files to MAINTAINERS
> > >
> > > Should the bugfix be marked Cc:stable and and Fixes:... ?
> > >
> > Sorry for missing that, I think that the bugfix should have had the following.
> > Let me know if/how you want to handle updating the patch's changelog.
> >
> > Fixes: 6d14d4d313d09dab ("ARM: shmobile: Rework the PMIC IRQ line quirk")
> 
> I think the easiest way is to send an email to stable@kernel.org asking for
> a backport of commit 5347a0203709 ("ARM: shmobile: Fix R-Car Gen2 regulator
> quirk") after that has hit the mainline kernel and asking for a backport.
> 
> I've added it to Cc here, but I don't know if that's sufficient.
> 
> If you'd rather have me pick up the patch for 5.0 as well, I can also do
> that and add the Cc/Fixes lines there. We will then have a duplicate
> commit in 5.1, but it should not cause any merge issues.

Thanks Arnd,

I'm happy to handle this via stable and avoid the duplicate.
If I don't hear back from them in a few days I'll make a formal
submission there.

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [GIT PULL] Renesas ARM Based SoC Updates for v5.1
  2019-02-18 14:15       ` Simon Horman
@ 2019-02-18 14:21         ` Arnd Bergmann
  2019-02-25 10:05           ` Simon Horman
  0 siblings, 1 reply; 9+ messages in thread
From: Arnd Bergmann @ 2019-02-18 14:21 UTC (permalink / raw)
  To: Simon Horman
  Cc: arm-soc, Linux-Renesas, Olof Johansson, Kevin Hilman, Linux ARM,
	Magnus Damm, Geert Uytterhoeven, Marek Vasut, stable

On Mon, Feb 18, 2019 at 3:15 PM Simon Horman <horms@verge.net.au> wrote:
>
> On Mon, Feb 18, 2019 at 02:12:07PM +0100, Arnd Bergmann wrote:
> > On Mon, Feb 18, 2019 at 12:27 PM Simon Horman <horms@verge.net.au> wrote:
> > > On Fri, Feb 15, 2019 at 05:49:32PM +0100, Arnd Bergmann wrote:
> > > > On Fri, Feb 8, 2019 at 12:14 PM Simon Horman <horms+renesas@verge.net.au> wrote:
> > > > > Renesas ARM Based SoC Updates for v5.1
> > > > >
> > > > > * Correct shared IRQ handling of R-Car Gen2 Regulator quirk
> > > > > * Add missing dts files to MAINTAINERS
> > > >
> > > > Should the bugfix be marked Cc:stable and and Fixes:... ?
> > > >
> > > Sorry for missing that, I think that the bugfix should have had the following.
> > > Let me know if/how you want to handle updating the patch's changelog.
> > >
> > > Fixes: 6d14d4d313d09dab ("ARM: shmobile: Rework the PMIC IRQ line quirk")
> >
> > I think the easiest way is to send an email to stable@kernel.org asking for
> > a backport of commit 5347a0203709 ("ARM: shmobile: Fix R-Car Gen2 regulator
> > quirk") after that has hit the mainline kernel and asking for a backport.
> >
> > I've added it to Cc here, but I don't know if that's sufficient.
> >
> > If you'd rather have me pick up the patch for 5.0 as well, I can also do
> > that and add the Cc/Fixes lines there. We will then have a duplicate
> > commit in 5.1, but it should not cause any merge issues.
>
> Thanks Arnd,
>
> I'm happy to handle this via stable and avoid the duplicate.
> If I don't hear back from them in a few days I'll make a formal
> submission there.

Ok, sounds good.

To clarify: I think you should only write them /after/ the commit
is in mainline then, i.e. near the end of the 5.1 merge window.

      Arnd

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [GIT PULL] Renesas ARM Based SoC Updates for v5.1
  2019-02-18 14:21         ` Arnd Bergmann
@ 2019-02-25 10:05           ` Simon Horman
  0 siblings, 0 replies; 9+ messages in thread
From: Simon Horman @ 2019-02-25 10:05 UTC (permalink / raw)
  To: Arnd Bergmann
  Cc: arm-soc, Linux-Renesas, Olof Johansson, Kevin Hilman, Linux ARM,
	Magnus Damm, Geert Uytterhoeven, Marek Vasut, stable

On Mon, Feb 18, 2019 at 03:21:14PM +0100, Arnd Bergmann wrote:
> On Mon, Feb 18, 2019 at 3:15 PM Simon Horman <horms@verge.net.au> wrote:
> >
> > On Mon, Feb 18, 2019 at 02:12:07PM +0100, Arnd Bergmann wrote:
> > > On Mon, Feb 18, 2019 at 12:27 PM Simon Horman <horms@verge.net.au> wrote:
> > > > On Fri, Feb 15, 2019 at 05:49:32PM +0100, Arnd Bergmann wrote:
> > > > > On Fri, Feb 8, 2019 at 12:14 PM Simon Horman <horms+renesas@verge.net.au> wrote:
> > > > > > Renesas ARM Based SoC Updates for v5.1
> > > > > >
> > > > > > * Correct shared IRQ handling of R-Car Gen2 Regulator quirk
> > > > > > * Add missing dts files to MAINTAINERS
> > > > >
> > > > > Should the bugfix be marked Cc:stable and and Fixes:... ?
> > > > >
> > > > Sorry for missing that, I think that the bugfix should have had the following.
> > > > Let me know if/how you want to handle updating the patch's changelog.
> > > >
> > > > Fixes: 6d14d4d313d09dab ("ARM: shmobile: Rework the PMIC IRQ line quirk")
> > >
> > > I think the easiest way is to send an email to stable@kernel.org asking for
> > > a backport of commit 5347a0203709 ("ARM: shmobile: Fix R-Car Gen2 regulator
> > > quirk") after that has hit the mainline kernel and asking for a backport.
> > >
> > > I've added it to Cc here, but I don't know if that's sufficient.
> > >
> > > If you'd rather have me pick up the patch for 5.0 as well, I can also do
> > > that and add the Cc/Fixes lines there. We will then have a duplicate
> > > commit in 5.1, but it should not cause any merge issues.
> >
> > Thanks Arnd,
> >
> > I'm happy to handle this via stable and avoid the duplicate.
> > If I don't hear back from them in a few days I'll make a formal
> > submission there.
> 
> Ok, sounds good.
> 
> To clarify: I think you should only write them /after/ the commit
> is in mainline then, i.e. near the end of the 5.1 merge window.

Thanks Arnd, got it.

^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, back to index

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-08 11:14 [GIT PULL] Renesas ARM Based SoC Updates for v5.1 Simon Horman
2019-02-08 11:14 ` [PATCH 1/2] ARM: shmobile: Add missing dts files to MAINTAINERS Simon Horman
2019-02-08 11:14 ` [PATCH 2/2] ARM: shmobile: Fix R-Car Gen2 regulator quirk Simon Horman
2019-02-15 16:49 ` [GIT PULL] Renesas ARM Based SoC Updates for v5.1 Arnd Bergmann
2019-02-18 11:27   ` Simon Horman
2019-02-18 13:12     ` Arnd Bergmann
2019-02-18 14:15       ` Simon Horman
2019-02-18 14:21         ` Arnd Bergmann
2019-02-25 10:05           ` Simon Horman

Linux-Renesas-SoC Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-renesas-soc/0 linux-renesas-soc/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-renesas-soc linux-renesas-soc/ https://lore.kernel.org/linux-renesas-soc \
		linux-renesas-soc@vger.kernel.org linux-renesas-soc@archiver.kernel.org
	public-inbox-index linux-renesas-soc

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-renesas-soc


AGPL code for this site: git clone https://public-inbox.org/ public-inbox