From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: masonccyang@mxic.com.tw
Cc: bbrezillon@kernel.org, broonie@kernel.org,
Geert Uytterhoeven <geert+renesas@glider.be>,
Simon Horman <horms@verge.net.au>,
juliensu@mxic.com.tw, linux-kernel@vger.kernel.org,
linux-renesas-soc@vger.kernel.org, linux-spi@vger.kernel.org,
marek.vasut@gmail.com, zhengxunli@mxic.com.tw
Subject: Re: [PATCH v8 1/2] spi: Add Renesas R-Car Gen3 RPC-IF SPI controller driver
Date: Tue, 26 Mar 2019 19:42:18 +0300 [thread overview]
Message-ID: <86e65614-814a-e8b8-fdbe-4b7b033e4938@cogentembedded.com> (raw)
In-Reply-To: <2fa6af66-de08-be37-7cdf-ccbf1e50ceb0@cogentembedded.com>
On 03/25/2019 10:12 PM, Sergei Shtylyov wrote:
>>>> +static void rpc_spi_mem_set_prep_op_cfg(struct spi_device *spi,
>>>> + const struct spi_mem_op *op,
>>>> + u64 *offs, size_t *len)
>>>> +{
>>>> + struct rpc_spi *rpc = spi_controller_get_devdata(spi->controller);
>>>
>>>> + if (op->dummy.nbytes) {
>>>> + rpc->smenr |= RPC_SMENR_DME;
>>>> + rpc->dummy = RPC_SMDMCR_DMCYC(op->dummy.nbytes);
>>>
>>> SMDMCR.DMCYC is in bits -- you forgot to multiply by 8.
>>
>> ?
>>
>> It's dummy cycles setting, i.e,. 0 is 1 cycle dummy and
>
> Yeah, I should've written "cycles", sorry about that.
I also should've mentioned that w/o this change the "read SFDP" command
returns garbage and the flash doesn't work.
[...]
MBR, Sergei
next prev parent reply other threads:[~2019-03-26 16:42 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-28 6:49 [PATCH v8 0/2] spi: Add Renesas R-Car Gen3 RPC-IF SPI driver Mason Yang
2019-01-28 6:49 ` [PATCH v8 1/2] spi: Add Renesas R-Car Gen3 RPC-IF SPI controller driver Mason Yang
2019-02-12 14:22 ` Applied "spi: Add Renesas R-Car Gen3 RPC-IF SPI controller driver" to the spi tree Mark Brown
2019-02-12 14:33 ` Marek Vasut
2019-02-12 14:43 ` Mark Brown
2019-02-12 16:49 ` Mark Brown
[not found] ` <OF9C8DA179.15D69C0A-ON482583A0.00283EB5-482583A0.002E45C8@mxic.com.tw>
2019-02-13 12:16 ` Mark Brown
2019-02-13 12:37 ` Marek Vasut
[not found] ` <OF9B3A3A20.C0BF34B8-ON482583A1.002D5F3B-482583A1.00329653@mxic.com.tw>
2019-02-14 10:52 ` Marek Vasut
2019-03-07 17:50 ` [PATCH v8 1/2] spi: Add Renesas R-Car Gen3 RPC-IF SPI controller driver Sergei Shtylyov
2019-03-08 9:14 ` Geert Uytterhoeven
2019-03-08 17:32 ` Sergei Shtylyov
2019-03-22 17:43 ` Sergei Shtylyov
[not found] ` <OF7C1EB3FC.1ABCD2C2-ON482583C8.002D7A69-482583C8.002E899C@mxic.com.tw>
2019-03-25 19:12 ` Sergei Shtylyov
2019-03-26 16:42 ` Sergei Shtylyov [this message]
[not found] ` <OF5BDFBDAB.B66A1ADE-ON482583CA.0006C5C2-482583CA.0008788E@mxic.com.tw>
2019-03-27 10:20 ` Sergei Shtylyov
2019-01-28 6:49 ` [PATCH v8 2/2] dt-bindings: spi: Document Renesas R-Car Gen3 RPC-IF controller bindings Mason Yang
2019-02-12 14:22 ` Applied "dt-bindings: spi: Document Renesas R-Car Gen3 RPC-IF controller bindings" to the spi tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86e65614-814a-e8b8-fdbe-4b7b033e4938@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=bbrezillon@kernel.org \
--cc=broonie@kernel.org \
--cc=geert+renesas@glider.be \
--cc=horms@verge.net.au \
--cc=juliensu@mxic.com.tw \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=marek.vasut@gmail.com \
--cc=masonccyang@mxic.com.tw \
--cc=zhengxunli@mxic.com.tw \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).