[PATCH] ARM: renesas: r8a7778: add missing reg-name for sound

[PATCH] ARM: renesas: r8a7778: add missing reg-name for sound

[Kuninori Morimoto]

Sound Driver requires "reg-name" to get register info. Current driver
try to get register info via "reg" instead of "reg-name" as backup plan,
but this support will be removed soon.
Use "reg-names" for r8a7778 sound.

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
 arch/arm/boot/dts/renesas/r8a7778.dtsi | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm/boot/dts/renesas/r8a7778.dtsi b/arch/arm/boot/dts/renesas/r8a7778.dtsi
index 8d4530ed2fc6..027a1c9ecc4e 100644
--- a/arch/arm/boot/dts/renesas/r8a7778.dtsi
+++ b/arch/arm/boot/dts/renesas/r8a7778.dtsi
@@ -250,6 +250,8 @@ rcar_sound: sound@ffd90000 {
 		reg =	<0xffd90000 0x1000>,	/* SRU */
 			<0xffd91000 0x240>,	/* SSI */
 			<0xfffe0000 0x24>;	/* ADG */
+		reg-names = "sru", "ssi", "adg";
+
 		clocks = <&mstp3_clks R8A7778_CLK_SSI8>,
 			<&mstp3_clks R8A7778_CLK_SSI7>,
 			<&mstp3_clks R8A7778_CLK_SSI6>,
-- 
2.25.1

Re: [PATCH] ARM: renesas: r8a7778: add missing reg-name for sound

[Geert Uytterhoeven]

Hi Morimoto-san,

On Wed, Feb 14, 2024 at 4:12 AM Kuninori Morimoto
<kuninori.morimoto.gx@renesas.com> wrote:
> Sound Driver requires "reg-name" to get register info. Current driver
> try to get register info via "reg" instead of "reg-name" as backup plan,
> but this support will be removed soon.
> Use "reg-names" for r8a7778 sound.
>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

Nice catch!

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
i.e. will queue in renesas-devel for v6.9.

This never triggered with "make dtbs_check", because
arch/arm/boot/dts/r8a7778-bockw.dts does not change the status property
of the rcar_sound node to "ok".

Can we just add a line to do that, or is anything else related to
sound missing in r8a7778-bockw.dts?

I do not have a Bock-W, so I cannot test this.

Thanks!

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH] ARM: renesas: r8a7778: add missing reg-name for sound

[Kuninori Morimoto]

Hi Geert

> > Sound Driver requires "reg-name" to get register info. Current driver
> > try to get register info via "reg" instead of "reg-name" as backup plan,
> > but this support will be removed soon.
> > Use "reg-names" for r8a7778 sound.
> >
> > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> 
> Nice catch!
> 
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> i.e. will queue in renesas-devel for v6.9.

Thanks

> Can we just add a line to do that, or is anything else related to
> sound missing in r8a7778-bockw.dts?

In my memory, first BockW support used platform-data style
(= arch/arm/mach-shmobile/board-bockw.c) but was switched to DT style
after that by Ulrich. I don't remember details, but when it switched to
DT style, we already focusing to Gen2 board support. So I didn't use it
via DT style. I guess he didn't test it, because it is missing many
settings to use sound on DT. So, just adding a line is enough anyway.

> I do not have a Bock-W, so I cannot test this.

Same here.

Thank you for your help !!

Best regards
---
Renesas Electronics
Ph.D. Kuninori Morimoto

Re: [PATCH] ARM: renesas: r8a7778: add missing reg-name for sound

[Geert Uytterhoeven]

Hi Morimoto-san,

On Thu, Feb 15, 2024 at 12:35 AM Kuninori Morimoto
<kuninori.morimoto.gx@renesas.com> wrote:
> > This never triggered with "make dtbs_check", because
> > arch/arm/boot/dts/r8a7778-bockw.dts does not change the status property
> > of the rcar_sound node to "ok".
> >
> > Can we just add a line to do that, or is anything else related to
> > sound missing in r8a7778-bockw.dts?
>
> In my memory, first BockW support used platform-data style
> (= arch/arm/mach-shmobile/board-bockw.c) but was switched to DT style
> after that by Ulrich. I don't remember details, but when it switched to
> DT style, we already focusing to Gen2 board support. So I didn't use it
> via DT style. I guess he didn't test it, because it is missing many
> settings to use sound on DT. So, just adding a line is enough anyway.

To clarify: adding the line is enough, or is not enough?

Thanks!

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH] ARM: renesas: r8a7778: add missing reg-name for sound

[Geert Uytterhoeven]

On Thu, Feb 15, 2024 at 9:20 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> On Thu, Feb 15, 2024 at 12:35 AM Kuninori Morimoto
> <kuninori.morimoto.gx@renesas.com> wrote:
> > > This never triggered with "make dtbs_check", because
> > > arch/arm/boot/dts/r8a7778-bockw.dts does not change the status property
> > > of the rcar_sound node to "ok".
> > >
> > > Can we just add a line to do that, or is anything else related to
> > > sound missing in r8a7778-bockw.dts?
> >
> > In my memory, first BockW support used platform-data style
> > (= arch/arm/mach-shmobile/board-bockw.c) but was switched to DT style
> > after that by Ulrich. I don't remember details, but when it switched to
> > DT style, we already focusing to Gen2 board support. So I didn't use it
> > via DT style. I guess he didn't test it, because it is missing many
> > settings to use sound on DT. So, just adding a line is enough anyway.
>
> To clarify: adding the line is enough, or is not enough?

It's missing (at least) pin control.


Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH] ARM: renesas: r8a7778: add missing reg-name for sound

[Kuninori Morimoto]

Hi Geert

> > > > Can we just add a line to do that, or is anything else related to
> > > > sound missing in r8a7778-bockw.dts?
(snip)
> > To clarify: adding the line is enough, or is not enough?
> 
> It's missing (at least) pin control.

Adding the line is very enough

Thank you for your help !!

Best regards
---
Renesas Electronics
Ph.D. Kuninori Morimoto