* [PATCH] clk: renesas: r8a779a0: tidyup DMAC name on SYS-DMAC
@ 2023-01-19 1:52 Kuninori Morimoto
2023-01-25 13:24 ` Geert Uytterhoeven
0 siblings, 1 reply; 4+ messages in thread
From: Kuninori Morimoto @ 2023-01-19 1:52 UTC (permalink / raw)
To: geert+renesas; +Cc: linux-renesas-soc
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
"sydm" is bit name. Let's rename it as common "sys-dmac".
This patch fixes the numbering, too.
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
drivers/clk/renesas/r8a779a0-cpg-mssr.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/clk/renesas/r8a779a0-cpg-mssr.c b/drivers/clk/renesas/r8a779a0-cpg-mssr.c
index e02542ca24a0..b4baef3c9857 100644
--- a/drivers/clk/renesas/r8a779a0-cpg-mssr.c
+++ b/drivers/clk/renesas/r8a779a0-cpg-mssr.c
@@ -176,8 +176,8 @@ static const struct mssr_mod_clk r8a779a0_mod_clks[] __initconst = {
DEF_MOD("scif3", 704, R8A779A0_CLK_S1D8),
DEF_MOD("scif4", 705, R8A779A0_CLK_S1D8),
DEF_MOD("sdhi0", 706, R8A779A0_CLK_SD0),
- DEF_MOD("sydm1", 709, R8A779A0_CLK_S1D2),
- DEF_MOD("sydm2", 710, R8A779A0_CLK_S1D2),
+ DEF_MOD("sys-dmac0", 709, R8A779A0_CLK_S1D2),
+ DEF_MOD("sys-dmac1", 710, R8A779A0_CLK_S1D2),
DEF_MOD("tmu0", 713, R8A779A0_CLK_CL16MCK),
DEF_MOD("tmu1", 714, R8A779A0_CLK_S1D4),
DEF_MOD("tmu2", 715, R8A779A0_CLK_S1D4),
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] clk: renesas: r8a779a0: tidyup DMAC name on SYS-DMAC
2023-01-19 1:52 [PATCH] clk: renesas: r8a779a0: tidyup DMAC name on SYS-DMAC Kuninori Morimoto
@ 2023-01-25 13:24 ` Geert Uytterhoeven
2023-01-25 22:39 ` Kuninori Morimoto
0 siblings, 1 reply; 4+ messages in thread
From: Geert Uytterhoeven @ 2023-01-25 13:24 UTC (permalink / raw)
To: Kuninori Morimoto; +Cc: linux-renesas-soc
Hi Morimoto-san,
On Thu, Jan 19, 2023 at 2:52 AM Kuninori Morimoto
<kuninori.morimoto.gx@renesas.com> wrote:
> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
>
> "sydm" is bit name. Let's rename it as common "sys-dmac".
> This patch fixes the numbering, too.
>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Thanks for your patch!
> --- a/drivers/clk/renesas/r8a779a0-cpg-mssr.c
> +++ b/drivers/clk/renesas/r8a779a0-cpg-mssr.c
> @@ -176,8 +176,8 @@ static const struct mssr_mod_clk r8a779a0_mod_clks[] __initconst = {
> DEF_MOD("scif3", 704, R8A779A0_CLK_S1D8),
> DEF_MOD("scif4", 705, R8A779A0_CLK_S1D8),
> DEF_MOD("sdhi0", 706, R8A779A0_CLK_SD0),
> - DEF_MOD("sydm1", 709, R8A779A0_CLK_S1D2),
> - DEF_MOD("sydm2", 710, R8A779A0_CLK_S1D2),
> + DEF_MOD("sys-dmac0", 709, R8A779A0_CLK_S1D2),
> + DEF_MOD("sys-dmac1", 710, R8A779A0_CLK_S1D2),
Actually Rev 0.5 of the documentation does call the channels "SYS-DMAC1"
and "SYS-DMAC2".
Shall we use that numbering?
We also have labels "dmac1" and "dmac2" in DTS.
> DEF_MOD("tmu0", 713, R8A779A0_CLK_CL16MCK),
> DEF_MOD("tmu1", 714, R8A779A0_CLK_S1D4),
> DEF_MOD("tmu2", 715, R8A779A0_CLK_S1D4),
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] clk: renesas: r8a779a0: tidyup DMAC name on SYS-DMAC
2023-01-25 13:24 ` Geert Uytterhoeven
@ 2023-01-25 22:39 ` Kuninori Morimoto
2023-01-26 8:39 ` Geert Uytterhoeven
0 siblings, 1 reply; 4+ messages in thread
From: Kuninori Morimoto @ 2023-01-25 22:39 UTC (permalink / raw)
To: Geert Uytterhoeven; +Cc: linux-renesas-soc
Hi Geert
> > + DEF_MOD("sys-dmac0", 709, R8A779A0_CLK_S1D2),
> > + DEF_MOD("sys-dmac1", 710, R8A779A0_CLK_S1D2),
>
> Actually Rev 0.5 of the documentation does call the channels "SYS-DMAC1"
> and "SYS-DMAC2".
> Shall we use that numbering?
> We also have labels "dmac1" and "dmac2" in DTS.
OK, I see.
I'm happy if you can modify it.
Of course I'm happy to post v2 patch.
Thank you for your help !!
Best regards
---
Kuninori Morimoto
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] clk: renesas: r8a779a0: tidyup DMAC name on SYS-DMAC
2023-01-25 22:39 ` Kuninori Morimoto
@ 2023-01-26 8:39 ` Geert Uytterhoeven
0 siblings, 0 replies; 4+ messages in thread
From: Geert Uytterhoeven @ 2023-01-26 8:39 UTC (permalink / raw)
To: Kuninori Morimoto; +Cc: linux-renesas-soc
Hi Morimoto-san,
On Wed, Jan 25, 2023 at 11:39 PM Kuninori Morimoto
<kuninori.morimoto.gx@renesas.com> wrote:
> > > + DEF_MOD("sys-dmac0", 709, R8A779A0_CLK_S1D2),
> > > + DEF_MOD("sys-dmac1", 710, R8A779A0_CLK_S1D2),
> >
> > Actually Rev 0.5 of the documentation does call the channels "SYS-DMAC1"
> > and "SYS-DMAC2".
> > Shall we use that numbering?
> > We also have labels "dmac1" and "dmac2" in DTS.
>
> OK, I see.
>
> I'm happy if you can modify it.
> Of course I'm happy to post v2 patch.
Thanks, no need for that, I will fix while applying.
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
i.e. will queue in renesas-clk for v6.3.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-01-26 8:40 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-19 1:52 [PATCH] clk: renesas: r8a779a0: tidyup DMAC name on SYS-DMAC Kuninori Morimoto
2023-01-25 13:24 ` Geert Uytterhoeven
2023-01-25 22:39 ` Kuninori Morimoto
2023-01-26 8:39 ` Geert Uytterhoeven
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).