* RE: [PATCH] arm64: dts: Remove inconsistent use of 'arm,armv8' compatible string
[not found] <20190109202934.29304-1-robh@kernel.org>
@ 2019-01-10 8:01 ` yamada.masahiro
2019-01-10 8:42 ` Heiko Stübner
1 sibling, 0 replies; 2+ messages in thread
From: yamada.masahiro @ 2019-01-10 8:01 UTC (permalink / raw)
To: robh, arm
Cc: devicetree, linux-kernel, afaerber, manivannan.sadhasivam,
tsahee, antoine.tenart, maxime.ripard, wens, dinguyen, khilman,
dhdang, liviu.dudau, sudeep.holla, lorenzo.pieralisi, rjui,
sbranden, bcm-kernel-feedback-list, rrichter, jnair, kgene, krzk,
xuwei5, chanho.min, jason, andrew, gregory.clement,
sebastian.hesselbarth, matthias.bgg, thierry.reding, jonathanh,
andy.gross, david.brown, horms, magnus.damm, heiko, orsonzhai,
baolin.wang, zhang.lyra, Jisheng.Zhang, t-kristo, nm, jun.nie,
shawnguo, linux-arm-kernel, linux-amlogic, linux-samsung-soc,
linux-mediatek, linux-tegra, linux-arm-msm, linux-renesas-soc,
linux-rockchip, mark.rutland, will.deacon, michal.simek
> -----Original Message-----
> From: Rob Herring [mailto:robh@kernel.org]
> Sent: Thursday, January 10, 2019 5:30 AM
> To: arm@kernel.org
> Cc: devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; Andreas
> Färber <afaerber@suse.de>; Manivannan Sadhasivam
> <manivannan.sadhasivam@linaro.org>; Tsahee Zidenberg
> <tsahee@annapurnalabs.com>; Antoine Tenart <antoine.tenart@bootlin.com>;
> Maxime Ripard <maxime.ripard@bootlin.com>; Chen-Yu Tsai <wens@csie.org>;
> Dinh Nguyen <dinguyen@kernel.org>; Kevin Hilman <khilman@baylibre.com>;
> Duc Dang <dhdang@apm.com>; Liviu Dudau <liviu.dudau@arm.com>; Sudeep Holla
> <sudeep.holla@arm.com>; Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>;
> Ray Jui <rjui@broadcom.com>; Scott Branden <sbranden@broadcom.com>;
> bcm-kernel-feedback-list@broadcom.com; Robert Richter
> <rrichter@cavium.com>; Jayachandran C <jnair@caviumnetworks.com>; Kukjin
> Kim <kgene@kernel.org>; Krzysztof Kozlowski <krzk@kernel.org>; Wei Xu
> <xuwei5@hisilicon.com>; Chanho Min <chanho.min@lge.com>; Jason Cooper
> <jason@lakedaemon.net>; Andrew Lunn <andrew@lunn.ch>; Gregory Clement
> <gregory.clement@bootlin.com>; Sebastian Hesselbarth
> <sebastian.hesselbarth@gmail.com>; Matthias Brugger
> <matthias.bgg@gmail.com>; Thierry Reding <thierry.reding@gmail.com>;
> Jonathan Hunter <jonathanh@nvidia.com>; Andy Gross
> <andy.gross@linaro.org>; David Brown <david.brown@linaro.org>; Simon
> Horman <horms@verge.net.au>; Magnus Damm <magnus.damm@gmail.com>; Heiko
> Stuebner <heiko@sntech.de>; Yamada, Masahiro/山田 真弘
> <yamada.masahiro@socionext.com>; Orson Zhai <orsonzhai@gmail.com>;
> Baolin Wang <baolin.wang@linaro.org>; Chunyan Zhang
> <zhang.lyra@gmail.com>; Jisheng Zhang <Jisheng.Zhang@synaptics.com>;
> Tero Kristo <t-kristo@ti.com>; Nishanth Menon <nm@ti.com>; Jun Nie
> <jun.nie@linaro.org>; Shawn Guo <shawnguo@kernel.org>;
> linux-arm-kernel@lists.infradead.org;
> linux-amlogic@lists.infradead.org; linux-samsung-soc@vger.kernel.org;
> linux-mediatek@lists.infradead.org; linux-tegra@vger.kernel.org;
> linux-arm-msm@vger.kernel.org; linux-renesas-soc@vger.kernel.org;
> linux-rockchip@lists.infradead.org; Mark Rutland <mark.rutland@arm.com>;
> Will Deacon <will.deacon@arm.com>; Michal Simek <michal.simek@xilinx.com>
> Subject: [PATCH] arm64: dts: Remove inconsistent use of 'arm,armv8'
> compatible string
>
> The 'arm,armv8' compatible string is only for software models. It adds
> little value otherwise and is inconsistently used as a fallback on some
> platforms. Remove it from those platforms.
>
> This fixes warnings generated by the DT schema.
>
> Reported-by: Michal Simek <michal.simek@xilinx.com>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Cc: Will Deacon <will.deacon@arm.com>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> armsoc folks, Please apply directly.
>
> Note that there's still a case left in msm8998 that needs a new
> compatible string.
>
> Rob
[> ]
> .../boot/dts/socionext/uniphier-ld11.dtsi | 4 +-
> .../boot/dts/socionext/uniphier-ld20.dtsi | 8 +-
> .../boot/dts/socionext/uniphier-pxs3.dtsi | 8 +-
For uniphier,
Acked-by: Masahiro Yamada <yamada.masahiro@socionext.com>
BTW, do you have a plan to fix files under
Documentation/devicetree/bindings/ ?
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] arm64: dts: Remove inconsistent use of 'arm,armv8' compatible string
[not found] <20190109202934.29304-1-robh@kernel.org>
2019-01-10 8:01 ` [PATCH] arm64: dts: Remove inconsistent use of 'arm,armv8' compatible string yamada.masahiro
@ 2019-01-10 8:42 ` Heiko Stübner
1 sibling, 0 replies; 2+ messages in thread
From: Heiko Stübner @ 2019-01-10 8:42 UTC (permalink / raw)
To: Rob Herring
Cc: arm, devicetree, linux-kernel, Matthias Brugger,
linux-arm-kernel, linux-amlogic, linux-samsung-soc,
linux-mediatek, linux-tegra, linux-arm-msm, linux-renesas-soc,
linux-rockchip, Mark Rutland, Will Deacon
Am Mittwoch, 9. Januar 2019, 21:29:34 CET schrieb Rob Herring:
> The 'arm,armv8' compatible string is only for software models. It adds
> little value otherwise and is inconsistently used as a fallback on some
> platforms. Remove it from those platforms.
>
> This fixes warnings generated by the DT schema.
>
> Reported-by: Michal Simek <michal.simek@xilinx.com>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Cc: Will Deacon <will.deacon@arm.com>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
For the Rockchip-parts
Acked-by: Heiko Stuebner <heiko@sntech.de>
> diff --git a/arch/arm64/boot/dts/rockchip/px30.dtsi
> b/arch/arm64/boot/dts/rockchip/px30.dtsi index 9aa8d5ef9e45..eb992d60e6ba
> 100644
> --- a/arch/arm64/boot/dts/rockchip/px30.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/px30.dtsi
> @@ -40,7 +40,7 @@
>
> cpu0: cpu@0 {
> device_type = "cpu";
> - compatible = "arm,cortex-a35", "arm,armv8";
> + compatible = "arm,cortex-a35";
> reg = <0x0 0x0>;
> enable-method = "psci";
> clocks = <&cru ARMCLK>;
> @@ -52,7 +52,7 @@
>
> cpu1: cpu@1 {
> device_type = "cpu";
> - compatible = "arm,cortex-a35", "arm,armv8";
> + compatible = "arm,cortex-a35";
> reg = <0x0 0x1>;
> enable-method = "psci";
> clocks = <&cru ARMCLK>;
> @@ -64,7 +64,7 @@
>
> cpu2: cpu@2 {
> device_type = "cpu";
> - compatible = "arm,cortex-a35", "arm,armv8";
> + compatible = "arm,cortex-a35";
> reg = <0x0 0x2>;
> enable-method = "psci";
> clocks = <&cru ARMCLK>;
> @@ -76,7 +76,7 @@
>
> cpu3: cpu@3 {
> device_type = "cpu";
> - compatible = "arm,cortex-a35", "arm,armv8";
> + compatible = "arm,cortex-a35";
> reg = <0x0 0x3>;
> enable-method = "psci";
> clocks = <&cru ARMCLK>;
> diff --git a/arch/arm64/boot/dts/rockchip/rk3328.dtsi
> b/arch/arm64/boot/dts/rockchip/rk3328.dtsi index ecd7f19c3542..0f72bb33ce86
> 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3328.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3328.dtsi
> @@ -37,7 +37,7 @@
>
> cpu0: cpu@0 {
> device_type = "cpu";
> - compatible = "arm,cortex-a53", "arm,armv8";
> + compatible = "arm,cortex-a53";
> reg = <0x0 0x0>;
> clocks = <&cru ARMCLK>;
> #cooling-cells = <2>;
> @@ -49,7 +49,7 @@
>
> cpu1: cpu@1 {
> device_type = "cpu";
> - compatible = "arm,cortex-a53", "arm,armv8";
> + compatible = "arm,cortex-a53";
> reg = <0x0 0x1>;
> clocks = <&cru ARMCLK>;
> #cooling-cells = <2>;
> @@ -61,7 +61,7 @@
>
> cpu2: cpu@2 {
> device_type = "cpu";
> - compatible = "arm,cortex-a53", "arm,armv8";
> + compatible = "arm,cortex-a53";
> reg = <0x0 0x2>;
> clocks = <&cru ARMCLK>;
> #cooling-cells = <2>;
> @@ -73,7 +73,7 @@
>
> cpu3: cpu@3 {
> device_type = "cpu";
> - compatible = "arm,cortex-a53", "arm,armv8";
> + compatible = "arm,cortex-a53";
> reg = <0x0 0x3>;
> clocks = <&cru ARMCLK>;
> #cooling-cells = <2>;
> diff --git a/arch/arm64/boot/dts/rockchip/rk3368.dtsi
> b/arch/arm64/boot/dts/rockchip/rk3368.dtsi index 7014d10b954c..06e7c31d7d07
> 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3368.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3368.dtsi
> @@ -73,7 +73,7 @@
>
> cpu_l0: cpu@0 {
> device_type = "cpu";
> - compatible = "arm,cortex-a53", "arm,armv8";
> + compatible = "arm,cortex-a53";
> reg = <0x0 0x0>;
> enable-method = "psci";
> #cooling-cells = <2>; /* min followed by max */
> @@ -81,7 +81,7 @@
>
> cpu_l1: cpu@1 {
> device_type = "cpu";
> - compatible = "arm,cortex-a53", "arm,armv8";
> + compatible = "arm,cortex-a53";
> reg = <0x0 0x1>;
> enable-method = "psci";
> #cooling-cells = <2>; /* min followed by max */
> @@ -89,7 +89,7 @@
>
> cpu_l2: cpu@2 {
> device_type = "cpu";
> - compatible = "arm,cortex-a53", "arm,armv8";
> + compatible = "arm,cortex-a53";
> reg = <0x0 0x2>;
> enable-method = "psci";
> #cooling-cells = <2>; /* min followed by max */
> @@ -97,7 +97,7 @@
>
> cpu_l3: cpu@3 {
> device_type = "cpu";
> - compatible = "arm,cortex-a53", "arm,armv8";
> + compatible = "arm,cortex-a53";
> reg = <0x0 0x3>;
> enable-method = "psci";
> #cooling-cells = <2>; /* min followed by max */
> @@ -105,7 +105,7 @@
>
> cpu_b0: cpu@100 {
> device_type = "cpu";
> - compatible = "arm,cortex-a53", "arm,armv8";
> + compatible = "arm,cortex-a53";
> reg = <0x0 0x100>;
> enable-method = "psci";
> #cooling-cells = <2>; /* min followed by max */
> @@ -113,7 +113,7 @@
>
> cpu_b1: cpu@101 {
> device_type = "cpu";
> - compatible = "arm,cortex-a53", "arm,armv8";
> + compatible = "arm,cortex-a53";
> reg = <0x0 0x101>;
> enable-method = "psci";
> #cooling-cells = <2>; /* min followed by max */
> @@ -121,7 +121,7 @@
>
> cpu_b2: cpu@102 {
> device_type = "cpu";
> - compatible = "arm,cortex-a53", "arm,armv8";
> + compatible = "arm,cortex-a53";
> reg = <0x0 0x102>;
> enable-method = "psci";
> #cooling-cells = <2>; /* min followed by max */
> @@ -129,7 +129,7 @@
>
> cpu_b3: cpu@103 {
> device_type = "cpu";
> - compatible = "arm,cortex-a53", "arm,armv8";
> + compatible = "arm,cortex-a53";
> reg = <0x0 0x103>;
> enable-method = "psci";
> #cooling-cells = <2>; /* min followed by max */
> diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> b/arch/arm64/boot/dts/rockchip/rk3399.dtsi index 6cc1c9fa4ea6..db9d948c0b03
> 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> @@ -68,7 +68,7 @@
>
> cpu_l0: cpu@0 {
> device_type = "cpu";
> - compatible = "arm,cortex-a53", "arm,armv8";
> + compatible = "arm,cortex-a53";
> reg = <0x0 0x0>;
> enable-method = "psci";
> clocks = <&cru ARMCLKL>;
> @@ -79,7 +79,7 @@
>
> cpu_l1: cpu@1 {
> device_type = "cpu";
> - compatible = "arm,cortex-a53", "arm,armv8";
> + compatible = "arm,cortex-a53";
> reg = <0x0 0x1>;
> enable-method = "psci";
> clocks = <&cru ARMCLKL>;
> @@ -90,7 +90,7 @@
>
> cpu_l2: cpu@2 {
> device_type = "cpu";
> - compatible = "arm,cortex-a53", "arm,armv8";
> + compatible = "arm,cortex-a53";
> reg = <0x0 0x2>;
> enable-method = "psci";
> clocks = <&cru ARMCLKL>;
> @@ -101,7 +101,7 @@
>
> cpu_l3: cpu@3 {
> device_type = "cpu";
> - compatible = "arm,cortex-a53", "arm,armv8";
> + compatible = "arm,cortex-a53";
> reg = <0x0 0x3>;
> enable-method = "psci";
> clocks = <&cru ARMCLKL>;
> @@ -112,7 +112,7 @@
>
> cpu_b0: cpu@100 {
> device_type = "cpu";
> - compatible = "arm,cortex-a72", "arm,armv8";
> + compatible = "arm,cortex-a72";
> reg = <0x0 0x100>;
> enable-method = "psci";
> clocks = <&cru ARMCLKB>;
> @@ -123,7 +123,7 @@
>
> cpu_b1: cpu@101 {
> device_type = "cpu";
> - compatible = "arm,cortex-a72", "arm,armv8";
> + compatible = "arm,cortex-a72";
> reg = <0x0 0x101>;
> enable-method = "psci";
> clocks = <&cru ARMCLKB>;
^ permalink raw reply [flat|nested] 2+ messages in thread