From: Peter Rosin <peda@axentia.se> To: Wolfram Sang <wsa+renesas@sang-engineering.com>, "linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org> Cc: "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Hiromitsu Yamasaki <hiromitsu.yamasaki.ym@renesas.com>, "linux-renesas-soc@vger.kernel.org" <linux-renesas-soc@vger.kernel.org>, Hans de Goede <hdegoede@redhat.com>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org> Subject: Re: [RFC/RFT 10/10] i2c: rcar: add suspend/resume support Date: Mon, 10 Dec 2018 21:52:07 +0000 [thread overview] Message-ID: <944a2523-aa40-eaf2-2c4a-d27254e7cbca@axentia.se> (raw) In-Reply-To: <20181210210310.12677-11-wsa+renesas@sang-engineering.com> On 2018-12-10 22:03, Wolfram Sang wrote: > Because the adapter will be set up before every transaction anyhow, we > just need to mark it as adapted to the I2C core. mark it as "suspended", not "adapted"? Cheers, Peter > > Signed-off-by: Hiromitsu Yamasaki <hiromitsu.yamasaki.ym@renesas.com> > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> > --- > drivers/i2c/busses/i2c-rcar.c | 25 +++++++++++++++++++++++++ > 1 file changed, 25 insertions(+) > > diff --git a/drivers/i2c/busses/i2c-rcar.c b/drivers/i2c/busses/i2c-rcar.c > index 254e6219e538..30cff066e0da 100644 > --- a/drivers/i2c/busses/i2c-rcar.c > +++ b/drivers/i2c/busses/i2c-rcar.c > @@ -1017,10 +1017,35 @@ static int rcar_i2c_remove(struct platform_device *pdev) > return 0; > } > > +#ifdef CONFIG_PM_SLEEP > +static int rcar_i2c_suspend(struct device *dev) > +{ > + struct rcar_i2c_priv *priv = dev_get_drvdata(dev); > + > + i2c_mark_adapter_suspended(&priv->adap, true); > + return 0; > +} > + > +static int rcar_i2c_resume(struct device *dev) > +{ > + struct rcar_i2c_priv *priv = dev_get_drvdata(dev); > + > + i2c_mark_adapter_suspended(&priv->adap, false); > + return 0; > +} > + > +static SIMPLE_DEV_PM_OPS(rcar_i2c_pm_ops, rcar_i2c_suspend, rcar_i2c_resume); > + > +#define DEV_PM_OPS (&rcar_i2c_pm_ops) > +#else > +#define DEV_PM_OPS NULL > +#endif /* CONFIG_PM_SLEEP */ > + > static struct platform_driver rcar_i2c_driver = { > .driver = { > .name = "i2c-rcar", > .of_match_table = rcar_i2c_dt_ids, > + .pm = DEV_PM_OPS, > }, > .probe = rcar_i2c_probe, > .remove = rcar_i2c_remove, > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Peter Rosin <peda@axentia.se> To: Wolfram Sang <wsa+renesas@sang-engineering.com>, "linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org> Cc: "linux-renesas-soc@vger.kernel.org" <linux-renesas-soc@vger.kernel.org>, Hans de Goede <hdegoede@redhat.com>, "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, Hiromitsu Yamasaki <hiromitsu.yamasaki.ym@renesas.com>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org> Subject: Re: [RFC/RFT 10/10] i2c: rcar: add suspend/resume support Date: Mon, 10 Dec 2018 21:52:07 +0000 [thread overview] Message-ID: <944a2523-aa40-eaf2-2c4a-d27254e7cbca@axentia.se> (raw) Message-ID: <20181210215207.6szAJI-O-hbMhxPQLhvCi_t7ZKDJEY5nEH06K5Gw2h0@z> (raw) In-Reply-To: <20181210210310.12677-11-wsa+renesas@sang-engineering.com> On 2018-12-10 22:03, Wolfram Sang wrote: > Because the adapter will be set up before every transaction anyhow, we > just need to mark it as adapted to the I2C core. mark it as "suspended", not "adapted"? Cheers, Peter > > Signed-off-by: Hiromitsu Yamasaki <hiromitsu.yamasaki.ym@renesas.com> > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> > --- > drivers/i2c/busses/i2c-rcar.c | 25 +++++++++++++++++++++++++ > 1 file changed, 25 insertions(+) > > diff --git a/drivers/i2c/busses/i2c-rcar.c b/drivers/i2c/busses/i2c-rcar.c > index 254e6219e538..30cff066e0da 100644 > --- a/drivers/i2c/busses/i2c-rcar.c > +++ b/drivers/i2c/busses/i2c-rcar.c > @@ -1017,10 +1017,35 @@ static int rcar_i2c_remove(struct platform_device *pdev) > return 0; > } > > +#ifdef CONFIG_PM_SLEEP > +static int rcar_i2c_suspend(struct device *dev) > +{ > + struct rcar_i2c_priv *priv = dev_get_drvdata(dev); > + > + i2c_mark_adapter_suspended(&priv->adap, true); > + return 0; > +} > + > +static int rcar_i2c_resume(struct device *dev) > +{ > + struct rcar_i2c_priv *priv = dev_get_drvdata(dev); > + > + i2c_mark_adapter_suspended(&priv->adap, false); > + return 0; > +} > + > +static SIMPLE_DEV_PM_OPS(rcar_i2c_pm_ops, rcar_i2c_suspend, rcar_i2c_resume); > + > +#define DEV_PM_OPS (&rcar_i2c_pm_ops) > +#else > +#define DEV_PM_OPS NULL > +#endif /* CONFIG_PM_SLEEP */ > + > static struct platform_driver rcar_i2c_driver = { > .driver = { > .name = "i2c-rcar", > .of_match_table = rcar_i2c_dt_ids, > + .pm = DEV_PM_OPS, > }, > .probe = rcar_i2c_probe, > .remove = rcar_i2c_remove, >
next prev parent reply other threads:[~2018-12-10 21:52 UTC|newest] Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-12-10 21:02 [RFC/RFT 00/10] i2c: move handling of suspended adapters to the core Wolfram Sang 2018-12-10 21:02 ` Wolfram Sang 2018-12-10 21:02 ` [RFC/RFT 01/10] i2c: add 'is_suspended' flag for i2c adapters Wolfram Sang 2018-12-10 21:02 ` Wolfram Sang 2018-12-10 22:03 ` Peter Rosin 2018-12-10 22:03 ` Peter Rosin 2018-12-18 23:33 ` Wolfram Sang 2018-12-19 9:39 ` Geert Uytterhoeven 2018-12-19 16:31 ` Wolfram Sang 2018-12-10 21:03 ` [RFC/RFT 02/10] i2c: reject new transfers when adapters are suspended Wolfram Sang 2018-12-10 21:03 ` Wolfram Sang 2018-12-10 21:03 ` [RFC/RFT 03/10] i2c: synquacer: remove unused is_suspended flag Wolfram Sang 2018-12-10 21:03 ` Wolfram Sang 2018-12-10 21:04 ` Ard Biesheuvel 2018-12-10 21:03 ` [RFC/RFT 04/10] i2c: brcmstb: use core helper to mark adapter suspended Wolfram Sang 2018-12-10 21:03 ` Wolfram Sang 2018-12-11 16:44 ` Kamal Dasu 2018-12-10 21:03 ` [RFC/RFT 05/10] i2c: zx2967: " Wolfram Sang 2018-12-11 2:12 ` Shawn Guo 2018-12-11 2:12 ` Shawn Guo 2018-12-10 21:03 ` [RFC/RFT 06/10] i2c: sprd: don't use pdev as variable name for struct device * Wolfram Sang 2018-12-10 21:03 ` [RFC/RFT 07/10] i2c: sprd: use core helper to mark adapter suspended Wolfram Sang 2018-12-10 21:03 ` [RFC/RFT 08/10] i2c: exynos5: " Wolfram Sang 2018-12-18 11:23 ` Marek Szyprowski 2018-12-18 19:52 ` Wolfram Sang 2018-12-10 21:03 ` [RFC/RFT 09/10] i2c: s3c2410: " Wolfram Sang 2018-12-10 21:03 ` Wolfram Sang 2018-12-18 11:24 ` Marek Szyprowski 2018-12-10 21:03 ` [RFC/RFT 10/10] i2c: rcar: add suspend/resume support Wolfram Sang 2018-12-10 21:03 ` Wolfram Sang 2018-12-10 21:52 ` Peter Rosin [this message] 2018-12-10 21:52 ` Peter Rosin 2018-12-18 23:47 ` Wolfram Sang 2018-12-11 19:24 ` [RFC/RFT 00/10] i2c: move handling of suspended adapters to the core Hans de Goede 2018-12-11 23:41 ` Wolfram Sang 2018-12-12 10:09 ` Hans de Goede 2018-12-18 20:17 ` Wolfram Sang 2018-12-18 21:44 ` Hans de Goede 2018-12-18 23:32 ` Wolfram Sang
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=944a2523-aa40-eaf2-2c4a-d27254e7cbca@axentia.se \ --to=peda@axentia.se \ --cc=hdegoede@redhat.com \ --cc=hiromitsu.yamasaki.ym@renesas.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-i2c@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pm@vger.kernel.org \ --cc=linux-renesas-soc@vger.kernel.org \ --cc=wsa+renesas@sang-engineering.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).