* [PATCH] irqchip: renesas-rzg2l: Convert to irq_data_get_irq_chip_data()
@ 2023-09-22 7:51 Geert Uytterhoeven
2023-09-22 7:57 ` Biju Das
2023-09-25 7:43 ` Lad, Prabhakar
0 siblings, 2 replies; 3+ messages in thread
From: Geert Uytterhoeven @ 2023-09-22 7:51 UTC (permalink / raw)
To: Thomas Gleixner, Marc Zyngier, Lad Prabhakar
Cc: linux-renesas-soc, linux-kernel, Geert Uytterhoeven
Use the existing irq_data_get_irq_chip_data() helper instead of
open-coding the same operation.
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
drivers/irqchip/irq-renesas-rzg2l.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/irqchip/irq-renesas-rzg2l.c b/drivers/irqchip/irq-renesas-rzg2l.c
index 4bbfa2b0a4df9b83..c0f3c09affa64511 100644
--- a/drivers/irqchip/irq-renesas-rzg2l.c
+++ b/drivers/irqchip/irq-renesas-rzg2l.c
@@ -131,7 +131,7 @@ static void rzg2l_irqc_irq_enable(struct irq_data *d)
if (hw_irq >= IRQC_TINT_START && hw_irq < IRQC_NUM_IRQ) {
struct rzg2l_irqc_priv *priv = irq_data_to_priv(d);
- unsigned long tint = (uintptr_t)d->chip_data;
+ unsigned long tint = (uintptr_t)irq_data_get_irq_chip_data(d);
u32 offset = hw_irq - IRQC_TINT_START;
u32 tssr_offset = TSSR_OFFSET(offset);
u8 tssr_index = TSSR_INDEX(offset);
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [PATCH] irqchip: renesas-rzg2l: Convert to irq_data_get_irq_chip_data()
2023-09-22 7:51 [PATCH] irqchip: renesas-rzg2l: Convert to irq_data_get_irq_chip_data() Geert Uytterhoeven
@ 2023-09-22 7:57 ` Biju Das
2023-09-25 7:43 ` Lad, Prabhakar
1 sibling, 0 replies; 3+ messages in thread
From: Biju Das @ 2023-09-22 7:57 UTC (permalink / raw)
To: Geert Uytterhoeven, Thomas Gleixner, Marc Zyngier, Prabhakar Mahadev Lad
Cc: linux-renesas-soc, linux-kernel
Hi Geert Uytterhoeven,
> Subject: [PATCH] irqchip: renesas-rzg2l: Convert to
> irq_data_get_irq_chip_data()
>
> Use the existing irq_data_get_irq_chip_data() helper instead of open-coding
> the same operation.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> drivers/irqchip/irq-renesas-rzg2l.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/irqchip/irq-renesas-rzg2l.c b/drivers/irqchip/irq-
> renesas-rzg2l.c
> index 4bbfa2b0a4df9b83..c0f3c09affa64511 100644
> --- a/drivers/irqchip/irq-renesas-rzg2l.c
> +++ b/drivers/irqchip/irq-renesas-rzg2l.c
> @@ -131,7 +131,7 @@ static void rzg2l_irqc_irq_enable(struct irq_data *d)
>
> if (hw_irq >= IRQC_TINT_START && hw_irq < IRQC_NUM_IRQ) {
> struct rzg2l_irqc_priv *priv = irq_data_to_priv(d);
> - unsigned long tint = (uintptr_t)d->chip_data;
> + unsigned long tint = (uintptr_t)irq_data_get_irq_chip_data(d);
Maybe variable defintion in x-mas tree reverse order
for consistency??
Cheers,
Biju
> u32 offset = hw_irq - IRQC_TINT_START;
> u32 tssr_offset = TSSR_OFFSET(offset);
> u8 tssr_index = TSSR_INDEX(offset);
> --
> 2.34.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] irqchip: renesas-rzg2l: Convert to irq_data_get_irq_chip_data()
2023-09-22 7:51 [PATCH] irqchip: renesas-rzg2l: Convert to irq_data_get_irq_chip_data() Geert Uytterhoeven
2023-09-22 7:57 ` Biju Das
@ 2023-09-25 7:43 ` Lad, Prabhakar
1 sibling, 0 replies; 3+ messages in thread
From: Lad, Prabhakar @ 2023-09-25 7:43 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Thomas Gleixner, Marc Zyngier, Lad Prabhakar, linux-renesas-soc,
linux-kernel
On Fri, Sep 22, 2023 at 9:09 AM Geert Uytterhoeven
<geert+renesas@glider.be> wrote:
>
> Use the existing irq_data_get_irq_chip_data() helper instead of
> open-coding the same operation.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> drivers/irqchip/irq-renesas-rzg2l.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Cheers,
Prabhakar
> diff --git a/drivers/irqchip/irq-renesas-rzg2l.c b/drivers/irqchip/irq-renesas-rzg2l.c
> index 4bbfa2b0a4df9b83..c0f3c09affa64511 100644
> --- a/drivers/irqchip/irq-renesas-rzg2l.c
> +++ b/drivers/irqchip/irq-renesas-rzg2l.c
> @@ -131,7 +131,7 @@ static void rzg2l_irqc_irq_enable(struct irq_data *d)
>
> if (hw_irq >= IRQC_TINT_START && hw_irq < IRQC_NUM_IRQ) {
> struct rzg2l_irqc_priv *priv = irq_data_to_priv(d);
> - unsigned long tint = (uintptr_t)d->chip_data;
> + unsigned long tint = (uintptr_t)irq_data_get_irq_chip_data(d);
> u32 offset = hw_irq - IRQC_TINT_START;
> u32 tssr_offset = TSSR_OFFSET(offset);
> u8 tssr_index = TSSR_INDEX(offset);
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-09-25 7:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-09-22 7:51 [PATCH] irqchip: renesas-rzg2l: Convert to irq_data_get_irq_chip_data() Geert Uytterhoeven
2023-09-22 7:57 ` Biju Das
2023-09-25 7:43 ` Lad, Prabhakar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).