From: Geert Uytterhoeven <geert@linux-m68k.org>
To: David Miller <davem@davemloft.net>
Cc: Geert Uytterhoeven <geert+renesas@glider.be>,
Jakub Kicinski <kuba@kernel.org>,
Yusuke Ashiduka <ashiduka@fujitsu.com>,
Sergei Shtylyov <sergei.shtylyov@gmail.com>,
Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
netdev <netdev@vger.kernel.org>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
stable <stable@vger.kernel.org>
Subject: Re: [PATCH net] Revert "ravb: Fixed to be able to unload modules"
Date: Thu, 24 Sep 2020 09:14:27 +0200 [thread overview]
Message-ID: <CAMuHMdU+2KXZ86f_PK8v2Kr08XsECp-YH586aW5WCDpkq07K-g@mail.gmail.com> (raw)
In-Reply-To: <20200923.174004.2129776473634492661.davem@davemloft.net>
Hi David,
On Thu, Sep 24, 2020 at 2:40 AM David Miller <davem@davemloft.net> wrote:
> From: Geert Uytterhoeven <geert+renesas@glider.be>
> Date: Tue, 22 Sep 2020 09:29:31 +0200
>
> > This reverts commit 1838d6c62f57836639bd3d83e7855e0ee4f6defc.
> >
> > This commit moved the ravb_mdio_init() call (and thus the
> > of_mdiobus_register() call) from the ravb_probe() to the ravb_open()
> > call. This causes a regression during system resume (s2idle/s2ram), as
> > new PHY devices cannot be bound while suspended.
> ...
> >
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > Cc: stable@vger.kernel.org
>
> I noticed this too late, but please don't CC: stable on networking
> patches. We have our own workflow as per the netdev FAQ.
OK, will try to remember.
I wanted to give a heads-up to stable that they've backported early a
patch which turned out to have issues.
> I've applied this but the inability to remove a module is an
> extremely serious bug and should be fixed properly.
Sure. As you stated in
https://lore.kernel.org/linux-renesas-soc/20200820.165244.540878641387937530.davem@davemloft.net/
that will need some rework in the MDIO subsystem...
Thanks!
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
prev parent reply other threads:[~2020-09-24 7:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-22 7:29 [PATCH net] Revert "ravb: Fixed to be able to unload modules" Geert Uytterhoeven
2020-09-22 9:53 ` Sergei Shtylyov
2020-09-24 0:40 ` David Miller
2020-09-24 7:14 ` Geert Uytterhoeven [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMuHMdU+2KXZ86f_PK8v2Kr08XsECp-YH586aW5WCDpkq07K-g@mail.gmail.com \
--to=geert@linux-m68k.org \
--cc=andrew@lunn.ch \
--cc=ashiduka@fujitsu.com \
--cc=davem@davemloft.net \
--cc=geert+renesas@glider.be \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=sergei.shtylyov@gmail.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).