* [PATCH] mmc: renesas_sdhi: simplify an expression
@ 2021-11-17 10:38 Wolfram Sang
2021-11-17 12:37 ` Niklas Söderlund
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Wolfram Sang @ 2021-11-17 10:38 UTC (permalink / raw)
To: linux-mmc; +Cc: linux-renesas-soc, Wolfram Sang
We already have 'quirks', no need to go via 'priv'.
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
drivers/mmc/host/renesas_sdhi_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/host/renesas_sdhi_core.c b/drivers/mmc/host/renesas_sdhi_core.c
index a4407f391f66..29bc086f6cb5 100644
--- a/drivers/mmc/host/renesas_sdhi_core.c
+++ b/drivers/mmc/host/renesas_sdhi_core.c
@@ -1044,7 +1044,7 @@ int renesas_sdhi_probe(struct platform_device *pdev,
host->mmc->caps2 & (MMC_CAP2_HS200_1_8V_SDR |
MMC_CAP2_HS400_1_8V))) {
const struct renesas_sdhi_scc *taps = of_data->taps;
- bool use_4tap = priv->quirks && priv->quirks->hs400_4taps;
+ bool use_4tap = quirks && quirks->hs400_4taps;
bool hit = false;
for (i = 0; i < of_data->taps_num; i++) {
--
2.30.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] mmc: renesas_sdhi: simplify an expression
2021-11-17 10:38 [PATCH] mmc: renesas_sdhi: simplify an expression Wolfram Sang
@ 2021-11-17 12:37 ` Niklas Söderlund
2021-11-17 14:48 ` Geert Uytterhoeven
2021-11-22 11:26 ` Ulf Hansson
2 siblings, 0 replies; 5+ messages in thread
From: Niklas Söderlund @ 2021-11-17 12:37 UTC (permalink / raw)
To: Wolfram Sang; +Cc: linux-mmc, linux-renesas-soc
Hi Wolfram,
Nice fix.
On 2021-11-17 11:38:50 +0100, Wolfram Sang wrote:
> We already have 'quirks', no need to go via 'priv'.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> ---
> drivers/mmc/host/renesas_sdhi_core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/renesas_sdhi_core.c b/drivers/mmc/host/renesas_sdhi_core.c
> index a4407f391f66..29bc086f6cb5 100644
> --- a/drivers/mmc/host/renesas_sdhi_core.c
> +++ b/drivers/mmc/host/renesas_sdhi_core.c
> @@ -1044,7 +1044,7 @@ int renesas_sdhi_probe(struct platform_device *pdev,
> host->mmc->caps2 & (MMC_CAP2_HS200_1_8V_SDR |
> MMC_CAP2_HS400_1_8V))) {
> const struct renesas_sdhi_scc *taps = of_data->taps;
> - bool use_4tap = priv->quirks && priv->quirks->hs400_4taps;
> + bool use_4tap = quirks && quirks->hs400_4taps;
> bool hit = false;
>
> for (i = 0; i < of_data->taps_num; i++) {
> --
> 2.30.2
>
--
Kind Regards,
Niklas Söderlund
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] mmc: renesas_sdhi: simplify an expression
2021-11-17 10:38 [PATCH] mmc: renesas_sdhi: simplify an expression Wolfram Sang
2021-11-17 12:37 ` Niklas Söderlund
@ 2021-11-17 14:48 ` Geert Uytterhoeven
2021-11-22 11:26 ` Ulf Hansson
2 siblings, 0 replies; 5+ messages in thread
From: Geert Uytterhoeven @ 2021-11-17 14:48 UTC (permalink / raw)
To: Wolfram Sang; +Cc: Linux MMC List, Linux-Renesas
On Wed, Nov 17, 2021 at 1:21 PM Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
> We already have 'quirks', no need to go via 'priv'.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] mmc: renesas_sdhi: simplify an expression
2021-11-17 10:38 [PATCH] mmc: renesas_sdhi: simplify an expression Wolfram Sang
2021-11-17 12:37 ` Niklas Söderlund
2021-11-17 14:48 ` Geert Uytterhoeven
@ 2021-11-22 11:26 ` Ulf Hansson
2021-11-24 15:43 ` Geert Uytterhoeven
2 siblings, 1 reply; 5+ messages in thread
From: Ulf Hansson @ 2021-11-22 11:26 UTC (permalink / raw)
To: Wolfram Sang; +Cc: linux-mmc, linux-renesas-soc
On Wed, 17 Nov 2021 at 11:38, Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
>
> We already have 'quirks', no need to go via 'priv'.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Acked-by: Ulf Hansson <ulf.hansson@linaro.org>
Kind regards
Uffe
> ---
> drivers/mmc/host/renesas_sdhi_core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/renesas_sdhi_core.c b/drivers/mmc/host/renesas_sdhi_core.c
> index a4407f391f66..29bc086f6cb5 100644
> --- a/drivers/mmc/host/renesas_sdhi_core.c
> +++ b/drivers/mmc/host/renesas_sdhi_core.c
> @@ -1044,7 +1044,7 @@ int renesas_sdhi_probe(struct platform_device *pdev,
> host->mmc->caps2 & (MMC_CAP2_HS200_1_8V_SDR |
> MMC_CAP2_HS400_1_8V))) {
> const struct renesas_sdhi_scc *taps = of_data->taps;
> - bool use_4tap = priv->quirks && priv->quirks->hs400_4taps;
> + bool use_4tap = quirks && quirks->hs400_4taps;
> bool hit = false;
>
> for (i = 0; i < of_data->taps_num; i++) {
> --
> 2.30.2
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] mmc: renesas_sdhi: simplify an expression
2021-11-22 11:26 ` Ulf Hansson
@ 2021-11-24 15:43 ` Geert Uytterhoeven
0 siblings, 0 replies; 5+ messages in thread
From: Geert Uytterhoeven @ 2021-11-24 15:43 UTC (permalink / raw)
To: Ulf Hansson; +Cc: Wolfram Sang, Linux MMC List, Linux-Renesas
On Mon, Nov 22, 2021 at 12:38 PM Ulf Hansson <ulf.hansson@linaro.org> wrote:
> On Wed, 17 Nov 2021 at 11:38, Wolfram Sang
> <wsa+renesas@sang-engineering.com> wrote:
> >
> > We already have 'quirks', no need to go via 'priv'.
> >
> > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
>
> Acked-by: Ulf Hansson <ulf.hansson@linaro.org>
Thanks, will queue in renesas-clk-for-v5.17 with the other MMC patches.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-11-24 15:43 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-17 10:38 [PATCH] mmc: renesas_sdhi: simplify an expression Wolfram Sang
2021-11-17 12:37 ` Niklas Söderlund
2021-11-17 14:48 ` Geert Uytterhoeven
2021-11-22 11:26 ` Ulf Hansson
2021-11-24 15:43 ` Geert Uytterhoeven
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).