* [PATCH v2] can: rcar_canfd: Improve error messages
@ 2023-03-14 9:00 Geert Uytterhoeven
2023-03-14 15:51 ` Simon Horman
0 siblings, 1 reply; 3+ messages in thread
From: Geert Uytterhoeven @ 2023-03-14 9:00 UTC (permalink / raw)
To: Wolfgang Grandegger, Marc Kleine-Budde, Vincent Mailhol
Cc: linux-can, netdev, linux-renesas-soc, Geert Uytterhoeven
Improve printed error messages:
- Replace numerical error codes by mnemotechnic error codes, to
improve the user experience in case of errors,
- Drop parentheses around printed numbers, cfr.
Documentation/process/coding-style.rst,
- Drop printing of an error message in case of out-of-memory, as the
core memory allocation code already takes care of this.
Suggested-by: Vincent Mailhol <mailhol.vincent@wanadoo.fr>
---
This is v2 of "[PATCH] can: rcar_canfd: Print mnemotechnic error codes".
I haven't added any tags given on v1, as half of the printed message
changed.
This depends on "[PATCH v2] can: rcar_canfd: Add transceiver support"
https://lore.kernel.org/r/e825b50a843ffe40e33f34e4d858c07c1b2ff259.1678280913.git.geert+renesas@glider.be
---
drivers/net/can/rcar/rcar_canfd.c | 43 +++++++++++++++----------------
1 file changed, 21 insertions(+), 22 deletions(-)
diff --git a/drivers/net/can/rcar/rcar_canfd.c b/drivers/net/can/rcar/rcar_canfd.c
index 6df9a259e5e4f92c..ecdb8ffe2f670c9b 100644
--- a/drivers/net/can/rcar/rcar_canfd.c
+++ b/drivers/net/can/rcar/rcar_canfd.c
@@ -1417,20 +1417,20 @@ static int rcar_canfd_open(struct net_device *ndev)
err = phy_power_on(priv->transceiver);
if (err) {
- netdev_err(ndev, "failed to power on PHY, error %d\n", err);
+ netdev_err(ndev, "failed to power on PHY, %pe\n", ERR_PTR(err));
return err;
}
/* Peripheral clock is already enabled in probe */
err = clk_prepare_enable(gpriv->can_clk);
if (err) {
- netdev_err(ndev, "failed to enable CAN clock, error %d\n", err);
+ netdev_err(ndev, "failed to enable CAN clock, %pe\n", ERR_PTR(err));
goto out_phy;
}
err = open_candev(ndev);
if (err) {
- netdev_err(ndev, "open_candev() failed, error %d\n", err);
+ netdev_err(ndev, "open_candev() failed, %pe\n", ERR_PTR(err));
goto out_can_clock;
}
@@ -1731,10 +1731,9 @@ static int rcar_canfd_channel_probe(struct rcar_canfd_global *gpriv, u32 ch,
int err = -ENODEV;
ndev = alloc_candev(sizeof(*priv), RCANFD_FIFO_DEPTH);
- if (!ndev) {
- dev_err(dev, "alloc_candev() failed\n");
+ if (!ndev)
return -ENOMEM;
- }
+
priv = netdev_priv(ndev);
ndev->netdev_ops = &rcar_canfd_netdev_ops;
@@ -1777,8 +1776,8 @@ static int rcar_canfd_channel_probe(struct rcar_canfd_global *gpriv, u32 ch,
rcar_canfd_channel_err_interrupt, 0,
irq_name, priv);
if (err) {
- dev_err(dev, "devm_request_irq CH Err(%d) failed, error %d\n",
- err_irq, err);
+ dev_err(dev, "devm_request_irq CH Err %d failed, %pe\n",
+ err_irq, ERR_PTR(err));
goto fail;
}
irq_name = devm_kasprintf(dev, GFP_KERNEL, "canfd.ch%d_trx",
@@ -1791,8 +1790,8 @@ static int rcar_canfd_channel_probe(struct rcar_canfd_global *gpriv, u32 ch,
rcar_canfd_channel_tx_interrupt, 0,
irq_name, priv);
if (err) {
- dev_err(dev, "devm_request_irq Tx (%d) failed, error %d\n",
- tx_irq, err);
+ dev_err(dev, "devm_request_irq Tx %d failed, %pe\n",
+ tx_irq, ERR_PTR(err));
goto fail;
}
}
@@ -1823,7 +1822,7 @@ static int rcar_canfd_channel_probe(struct rcar_canfd_global *gpriv, u32 ch,
gpriv->ch[priv->channel] = priv;
err = register_candev(ndev);
if (err) {
- dev_err(dev, "register_candev() failed, error %d\n", err);
+ dev_err(dev, "register_candev() failed, %pe\n", ERR_PTR(err));
goto fail_candev;
}
dev_info(dev, "device registered (channel %u)\n", priv->channel);
@@ -1967,16 +1966,16 @@ static int rcar_canfd_probe(struct platform_device *pdev)
rcar_canfd_channel_interrupt, 0,
"canfd.ch_int", gpriv);
if (err) {
- dev_err(dev, "devm_request_irq(%d) failed, error %d\n",
- ch_irq, err);
+ dev_err(dev, "devm_request_irq %d failed, %pe\n",
+ ch_irq, ERR_PTR(err));
goto fail_dev;
}
err = devm_request_irq(dev, g_irq, rcar_canfd_global_interrupt,
0, "canfd.g_int", gpriv);
if (err) {
- dev_err(dev, "devm_request_irq(%d) failed, error %d\n",
- g_irq, err);
+ dev_err(dev, "devm_request_irq %d failed, %pe\n",
+ g_irq, ERR_PTR(err));
goto fail_dev;
}
} else {
@@ -1985,8 +1984,8 @@ static int rcar_canfd_probe(struct platform_device *pdev)
"canfd.g_recc", gpriv);
if (err) {
- dev_err(dev, "devm_request_irq(%d) failed, error %d\n",
- g_recc_irq, err);
+ dev_err(dev, "devm_request_irq %d failed, %pe\n",
+ g_recc_irq, ERR_PTR(err));
goto fail_dev;
}
@@ -1994,8 +1993,8 @@ static int rcar_canfd_probe(struct platform_device *pdev)
rcar_canfd_global_err_interrupt, 0,
"canfd.g_err", gpriv);
if (err) {
- dev_err(dev, "devm_request_irq(%d) failed, error %d\n",
- g_err_irq, err);
+ dev_err(dev, "devm_request_irq %d failed, %pe\n",
+ g_err_irq, ERR_PTR(err));
goto fail_dev;
}
}
@@ -2012,14 +2011,14 @@ static int rcar_canfd_probe(struct platform_device *pdev)
/* Enable peripheral clock for register access */
err = clk_prepare_enable(gpriv->clkp);
if (err) {
- dev_err(dev, "failed to enable peripheral clock, error %d\n",
- err);
+ dev_err(dev, "failed to enable peripheral clock, %pe\n",
+ ERR_PTR(err));
goto fail_reset;
}
err = rcar_canfd_reset_controller(gpriv);
if (err) {
- dev_err(dev, "reset controller failed\n");
+ dev_err(dev, "reset controller failed, %pe\n", ERR_PTR(err));
goto fail_clk;
}
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] can: rcar_canfd: Improve error messages
2023-03-14 9:00 [PATCH v2] can: rcar_canfd: Improve error messages Geert Uytterhoeven
@ 2023-03-14 15:51 ` Simon Horman
2023-03-14 16:26 ` Geert Uytterhoeven
0 siblings, 1 reply; 3+ messages in thread
From: Simon Horman @ 2023-03-14 15:51 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Wolfgang Grandegger, Marc Kleine-Budde, Vincent Mailhol,
linux-can, netdev, linux-renesas-soc
On Tue, Mar 14, 2023 at 10:00:26AM +0100, Geert Uytterhoeven wrote:
> Improve printed error messages:
> - Replace numerical error codes by mnemotechnic error codes, to
> improve the user experience in case of errors,
> - Drop parentheses around printed numbers, cfr.
> Documentation/process/coding-style.rst,
> - Drop printing of an error message in case of out-of-memory, as the
> core memory allocation code already takes care of this.
>
> Suggested-by: Vincent Mailhol <mailhol.vincent@wanadoo.fr>
Hi Geert,
you forgot to sign-off.
> ---
...
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] can: rcar_canfd: Improve error messages
2023-03-14 15:51 ` Simon Horman
@ 2023-03-14 16:26 ` Geert Uytterhoeven
0 siblings, 0 replies; 3+ messages in thread
From: Geert Uytterhoeven @ 2023-03-14 16:26 UTC (permalink / raw)
To: Simon Horman
Cc: Wolfgang Grandegger, Marc Kleine-Budde, Vincent Mailhol,
linux-can, netdev, linux-renesas-soc
Hi Simon,
On Tue, Mar 14, 2023 at 4:51 PM Simon Horman <simon.horman@corigine.com> wrote:
> On Tue, Mar 14, 2023 at 10:00:26AM +0100, Geert Uytterhoeven wrote:
> > Improve printed error messages:
> > - Replace numerical error codes by mnemotechnic error codes, to
> > improve the user experience in case of errors,
> > - Drop parentheses around printed numbers, cfr.
> > Documentation/process/coding-style.rst,
> > - Drop printing of an error message in case of out-of-memory, as the
> > core memory allocation code already takes care of this.
> >
> > Suggested-by: Vincent Mailhol <mailhol.vincent@wanadoo.fr>
>
> you forgot to sign-off.
Thanks!
Checkpatch told me, I amended the commit, but forgot to re-run
git format-patch :-( Sorry for that, and stay tuned...
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-03-14 16:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-14 9:00 [PATCH v2] can: rcar_canfd: Improve error messages Geert Uytterhoeven
2023-03-14 15:51 ` Simon Horman
2023-03-14 16:26 ` Geert Uytterhoeven
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).