linux-renesas-soc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Biju Das <biju.das.jz@bp.renesas.com>
Cc: Rob Herring <robh+dt@kernel.org>,
	Magnus Damm <magnus.damm@gmail.com>,
	Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
	<devicetree@vger.kernel.org>,
	Chris Paterson <Chris.Paterson2@renesas.com>,
	Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>
Subject: Re: [PATCH] arm64: dts: renesas: rzg2: Add internal rx delay
Date: Fri, 23 Jul 2021 18:00:35 +0200	[thread overview]
Message-ID: <CAMuHMdVD41xHG+4msRm1F8FScLraJJ7EFaadczvx3nXKtq3XVg@mail.gmail.com> (raw)
In-Reply-To: <OS0PR01MB592299E2554B073C582F29BE86E59@OS0PR01MB5922.jpnprd01.prod.outlook.com>

Hi Biju,

On Fri, Jul 23, 2021 at 5:52 PM Biju Das <biju.das.jz@bp.renesas.com> wrote:
> > Subject: Re: [PATCH] arm64: dts: renesas: rzg2: Add internal rx delay
> > On Wed, Jul 21, 2021 at 8:06 PM Biju Das <biju.das.jz@bp.renesas.com>
> > wrote:
> > > Hihope boards use Realtek PHY. From the very beginning it use only tx
> > > delays. However the phy driver commit bbc4d71d63549bcd003
> > > ("net: phy: realtek: fix rtl8211e rx/tx delay config") introduced NFS
> > > mount failure. Now it needs rx delay inaddition to tx delay for NFS
> > > mount to work. This patch fixes NFS mount failure issue by adding MAC
> > > internal rx delay.
> > >
> > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> >
> > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> i.e. will queue
> > in renesas-devel for v5.15.
> >
> > Do you want a Fixes: tag?
>
> It is a tricky situation. The phy patch is introduced in 5.9 and is backported to 5.8.
> But we don't have MaC internal delays on those kernels. So Fixes for 5.10+ will be ok I guess,
> So that at least this fix will land on cip 5.10 kernel.

Fixes: bbc4d71d63549bcd ("net: phy: realtek: fix rtl8211e rx/tx delay config")

Then the stable people are at least aware that backporting the PHY
commit can cause issues.

So after it has hit upstream, you can send the patch to stable with the
following added:

Cc: stable@vger.kernel.org # 5.10.x: a6f51f2efa742df0 ravb: Add
support for explicit internal clock delay configuration

I hope I got the syntax right. And there may be dependencies to backport,
too.

As this doesn't fix an issue introduced in v5.13 or v5.14-rc1, I'll queue
this for v5.15. CIP can still take it.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

  reply	other threads:[~2021-07-23 16:00 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-21 18:06 Biju Das
2021-07-23 15:22 ` Geert Uytterhoeven
2021-07-23 15:52   ` Biju Das
2021-07-23 16:00     ` Geert Uytterhoeven [this message]
2021-07-23 16:08       ` Biju Das

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAMuHMdVD41xHG+4msRm1F8FScLraJJ7EFaadczvx3nXKtq3XVg@mail.gmail.com \
    --to=geert@linux-m68k.org \
    --cc=Chris.Paterson2@renesas.com \
    --cc=biju.das.jz@bp.renesas.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
    --cc=robh+dt@kernel.org \
    --subject='Re: [PATCH] arm64: dts: renesas: rzg2: Add internal rx delay' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).