RE: [PATCH] arm64: dts: renesas: rzg2: Add internal rx delay

From: Biju Das <biju.das.jz@bp.renesas.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Rob Herring <robh+dt@kernel.org>,
	Magnus Damm <magnus.damm@gmail.com>,
	Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
	<devicetree@vger.kernel.org>,
	Chris Paterson <Chris.Paterson2@renesas.com>,
	Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>
Subject: RE: [PATCH] arm64: dts: renesas: rzg2: Add internal rx delay
Date: Fri, 23 Jul 2021 16:08:09 +0000	[thread overview]
Message-ID: <OS0PR01MB5922733763F62FE77D25CA9F86E59@OS0PR01MB5922.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <CAMuHMdVD41xHG+4msRm1F8FScLraJJ7EFaadczvx3nXKtq3XVg@mail.gmail.com>

Hi Geert,

> -----Original Message-----
> From: Geert Uytterhoeven <geert@linux-m68k.org>
> Sent: 23 July 2021 17:01
> To: Biju Das <biju.das.jz@bp.renesas.com>
> Cc: Rob Herring <robh+dt@kernel.org>; Magnus Damm <magnus.damm@gmail.com>;
> Linux-Renesas <linux-renesas-soc@vger.kernel.org>; open list:OPEN FIRMWARE
> AND FLATTENED DEVICE TREE BINDINGS <devicetree@vger.kernel.org>; Chris
> Paterson <Chris.Paterson2@renesas.com>; Prabhakar Mahadev Lad
> <prabhakar.mahadev-lad.rj@bp.renesas.com>
> Subject: Re: [PATCH] arm64: dts: renesas: rzg2: Add internal rx delay
> 
> Hi Biju,
> 
> On Fri, Jul 23, 2021 at 5:52 PM Biju Das <biju.das.jz@bp.renesas.com>
> wrote:
> > > Subject: Re: [PATCH] arm64: dts: renesas: rzg2: Add internal rx
> > > delay On Wed, Jul 21, 2021 at 8:06 PM Biju Das
> > > <biju.das.jz@bp.renesas.com>
> > > wrote:
> > > > Hihope boards use Realtek PHY. From the very beginning it use only
> > > > tx delays. However the phy driver commit bbc4d71d63549bcd003
> > > > ("net: phy: realtek: fix rtl8211e rx/tx delay config") introduced
> > > > NFS mount failure. Now it needs rx delay inaddition to tx delay
> > > > for NFS mount to work. This patch fixes NFS mount failure issue by
> > > > adding MAC internal rx delay.
> > > >
> > > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> > >
> > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> i.e. will
> > > queue in renesas-devel for v5.15.
> > >
> > > Do you want a Fixes: tag?
> >
> > It is a tricky situation. The phy patch is introduced in 5.9 and is
> backported to 5.8.
> > But we don't have MaC internal delays on those kernels. So Fixes for
> > 5.10+ will be ok I guess, So that at least this fix will land on cip
> 5.10 kernel.
> 
> Fixes: bbc4d71d63549bcd ("net: phy: realtek: fix rtl8211e rx/tx delay
> config")
> 
> Then the stable people are at least aware that backporting the PHY commit
> can cause issues.

OK.

> So after it has hit upstream, you can send the patch to stable with the
> following added:
> 
> Cc: stable@vger.kernel.org # 5.10.x: a6f51f2efa742df0 ravb: Add support
> for explicit internal clock delay configuration
> 
> I hope I got the syntax right. And there may be dependencies to backport,
> too.
> 
> As this doesn't fix an issue introduced in v5.13 or v5.14-rc1, I'll queue
> this for v5.15. CIP can still take it.

Thank you. Will post the patch to stable once it hit mainline.

Regards,
Biju

> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-
> m68k.org
> 
> In personal conversations with technical people, I call myself a hacker.
> But when I'm talking to journalists I just say "programmer" or something
> like that.
>                                 -- Linus Torvalds