linux-renesas-soc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2 0/3] soc: renesas: use menu for Renesas SoC
@ 2020-08-17  4:50 Kuninori Morimoto
  2020-08-17  4:50 ` [PATCH v2 1/3] " Kuninori Morimoto
                   ` (2 more replies)
  0 siblings, 3 replies; 10+ messages in thread
From: Kuninori Morimoto @ 2020-08-17  4:50 UTC (permalink / raw)
  To: Geert Uytterhoeven, Magnus Damm; +Cc: linux-renesas-soc


Hi Geert

These are v2 patch for Renesas SoC.

Renesas related SoC settings are located on TOP level menu
when menuconfig, thus it is very verbose.
This patch groups Renesas related settings into
"Renesas SoC driver support" menu.

v1 -> v2
	- align description
	- sort description

Kuninori Morimoto (3):
  soc: renesas: use menu for Renesas SoC
  soc: renesas: align driver description title
  soc: renesas: sort driver description title

 drivers/soc/renesas/Kconfig | 144 ++++++++++++++++++------------------
 1 file changed, 72 insertions(+), 72 deletions(-)

-- 
2.25.1


^ permalink raw reply	[flat|nested] 10+ messages in thread

* [PATCH v2 1/3] soc: renesas: use menu for Renesas SoC
  2020-08-17  4:50 [PATCH v2 0/3] soc: renesas: use menu for Renesas SoC Kuninori Morimoto
@ 2020-08-17  4:50 ` Kuninori Morimoto
  2020-08-21 14:11   ` Geert Uytterhoeven
  2020-08-17  4:51 ` [PATCH v2 2/3] soc: renesas: align driver description title Kuninori Morimoto
  2020-08-17  4:51 ` [PATCH v2 3/3] soc: renesas: sort " Kuninori Morimoto
  2 siblings, 1 reply; 10+ messages in thread
From: Kuninori Morimoto @ 2020-08-17  4:50 UTC (permalink / raw)
  To: Geert Uytterhoeven, Magnus Damm; +Cc: linux-renesas-soc


From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

Renesas related SoC settings are located on TOP level menu,
thus it is very verbose.
This patch groups Renesas related settings into
"Renesas SoC driver support" menu.

And it aligns config menu names.

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
 drivers/soc/renesas/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/soc/renesas/Kconfig b/drivers/soc/renesas/Kconfig
index 30984659df90..265a59345909 100644
--- a/drivers/soc/renesas/Kconfig
+++ b/drivers/soc/renesas/Kconfig
@@ -1,5 +1,5 @@
 # SPDX-License-Identifier: GPL-2.0
-config SOC_RENESAS
+menuconfig SOC_RENESAS
 	bool "Renesas SoC driver support" if COMPILE_TEST && !ARCH_RENESAS
 	default y if ARCH_RENESAS
 	select SOC_BUS
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 10+ messages in thread

* [PATCH v2 2/3] soc: renesas: align driver description title
  2020-08-17  4:50 [PATCH v2 0/3] soc: renesas: use menu for Renesas SoC Kuninori Morimoto
  2020-08-17  4:50 ` [PATCH v2 1/3] " Kuninori Morimoto
@ 2020-08-17  4:51 ` Kuninori Morimoto
  2020-08-21 14:19   ` Geert Uytterhoeven
  2020-08-17  4:51 ` [PATCH v2 3/3] soc: renesas: sort " Kuninori Morimoto
  2 siblings, 1 reply; 10+ messages in thread
From: Kuninori Morimoto @ 2020-08-17  4:51 UTC (permalink / raw)
  To: Geert Uytterhoeven, Magnus Damm; +Cc: linux-renesas-soc


Now, Renesas SoC drivers are under menu,
but current description are not aligned.
This patch align these.

	- R-Car H2 System Controller support                                                                    │ │
	- R-Car M2-W/N System Controller support                                                                │ │
	- R-Car V2H System Controller support                                                                   │ │
	- R-Car E2 System Controller support                                                                    │ │
	- R-Car H3 System Controller support                                                                    │ │
	- R-Car M3-W System Controller support                                                                  │ │
	- R-Car M3-W+ System Controller support                                                                 │ │
	- R-Car M3-N System Controller support                                                                  │ │

	+ System Controller support for R-Car H2                                                                │ │
	+ System Controller support for R-Car M2-W/N                                                            │ │
	+ System Controller support for R-Car V2H                                                               │ │
	+ System Controller support for R-Car E2                                                                │ │
	+ System Controller support for R-Car H3                                                                │ │
	+ System Controller support for R-Car M3-W                                                              │ │
	+ System Controller support for R-Car M3-W+                                                             │ │
	+ System Controller support for R-Car M3-N                                                              │ │

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
 drivers/soc/renesas/Kconfig | 74 ++++++++++++++++++-------------------
 1 file changed, 37 insertions(+), 37 deletions(-)

diff --git a/drivers/soc/renesas/Kconfig b/drivers/soc/renesas/Kconfig
index 265a59345909..bd9a9ab10d21 100644
--- a/drivers/soc/renesas/Kconfig
+++ b/drivers/soc/renesas/Kconfig
@@ -181,42 +181,42 @@ endif # ARM
 if ARM64
 
 config ARCH_R8A774A1
-	bool "Renesas RZ/G2M SoC Platform"
+	bool "SoC Platform support for RZ/G2M"
 	select ARCH_RCAR_GEN3
 	select SYSC_R8A774A1
 	help
 	  This enables support for the Renesas RZ/G2M SoC.
 
 config ARCH_R8A774B1
-	bool "Renesas RZ/G2N SoC Platform"
+	bool "SoC Platform support for RZ/G2N"
 	select ARCH_RCAR_GEN3
 	select SYSC_R8A774B1
 	help
 	  This enables support for the Renesas RZ/G2N SoC.
 
 config ARCH_R8A774C0
-	bool "Renesas RZ/G2E SoC Platform"
+	bool "SoC Platform support for RZ/G2E"
 	select ARCH_RCAR_GEN3
 	select SYSC_R8A774C0
 	help
 	  This enables support for the Renesas RZ/G2E SoC.
 
 config ARCH_R8A774E1
-	bool "Renesas RZ/G2H SoC Platform"
+	bool "SoC Platform support for RZ/G2H"
 	select ARCH_RCAR_GEN3
 	select SYSC_R8A774E1
 	help
 	  This enables support for the Renesas RZ/G2H SoC.
 
 config ARCH_R8A77950
-	bool "Renesas R-Car H3 ES1.x SoC Platform"
+	bool "SoC Platform support for R-Car H3 ES1.x"
 	select ARCH_RCAR_GEN3
 	select SYSC_R8A7795
 	help
 	  This enables support for the Renesas R-Car H3 SoC (revision 1.x).
 
 config ARCH_R8A77951
-	bool "Renesas R-Car H3 ES2.0+ SoC Platform"
+	bool "SoC Platform support for R-Car H3 ES2.0+"
 	select ARCH_RCAR_GEN3
 	select SYSC_R8A7795
 	help
@@ -224,49 +224,49 @@ config ARCH_R8A77951
 	  later).
 
 config ARCH_R8A77960
-	bool "Renesas R-Car M3-W SoC Platform"
+	bool "SoC Platform support for R-Car M3-W"
 	select ARCH_RCAR_GEN3
 	select SYSC_R8A77960
 	help
 	  This enables support for the Renesas R-Car M3-W SoC.
 
 config ARCH_R8A77961
-	bool "Renesas R-Car M3-W+ SoC Platform"
+	bool "SoC Platform support for R-Car M3-W+"
 	select ARCH_RCAR_GEN3
 	select SYSC_R8A77961
 	help
 	  This enables support for the Renesas R-Car M3-W+ SoC.
 
 config ARCH_R8A77965
-	bool "Renesas R-Car M3-N SoC Platform"
+	bool "SoC Platform support for R-Car M3-N"
 	select ARCH_RCAR_GEN3
 	select SYSC_R8A77965
 	help
 	  This enables support for the Renesas R-Car M3-N SoC.
 
 config ARCH_R8A77970
-	bool "Renesas R-Car V3M SoC Platform"
+	bool "SoC Platform support for R-Car V3M"
 	select ARCH_RCAR_GEN3
 	select SYSC_R8A77970
 	help
 	  This enables support for the Renesas R-Car V3M SoC.
 
 config ARCH_R8A77980
-	bool "Renesas R-Car V3H SoC Platform"
+	bool "SoC Platform support for R-Car V3H"
 	select ARCH_RCAR_GEN3
 	select SYSC_R8A77980
 	help
 	  This enables support for the Renesas R-Car V3H SoC.
 
 config ARCH_R8A77990
-	bool "Renesas R-Car E3 SoC Platform"
+	bool "SoC Platform support for R-Car E3"
 	select ARCH_RCAR_GEN3
 	select SYSC_R8A77990
 	help
 	  This enables support for the Renesas R-Car E3 SoC.
 
 config ARCH_R8A77995
-	bool "Renesas R-Car D3 SoC Platform"
+	bool "SoC Platform support for R-Car D3"
 	select ARCH_RCAR_GEN3
 	select SYSC_R8A77995
 	help
@@ -276,97 +276,97 @@ endif # ARM64
 
 # SoC
 config SYSC_R8A7742
-	bool "RZ/G1H System Controller support" if COMPILE_TEST
+	bool "System Controller support for RZ/G1H" if COMPILE_TEST
 	select SYSC_RCAR
 
 config SYSC_R8A7743
-	bool "RZ/G1M System Controller support" if COMPILE_TEST
+	bool "System Controller support for RZ/G1M" if COMPILE_TEST
 	select SYSC_RCAR
 
 config SYSC_R8A7745
-	bool "RZ/G1E System Controller support" if COMPILE_TEST
+	bool "System Controller support for RZ/G1E" if COMPILE_TEST
 	select SYSC_RCAR
 
 config SYSC_R8A77470
-	bool "RZ/G1C System Controller support" if COMPILE_TEST
+	bool "System Controller support for RZ/G1C" if COMPILE_TEST
 	select SYSC_RCAR
 
 config SYSC_R8A774A1
-	bool "RZ/G2M System Controller support" if COMPILE_TEST
+	bool "System Controller support for RZ/G2M" if COMPILE_TEST
 	select SYSC_RCAR
 
 config SYSC_R8A774B1
-	bool "RZ/G2N System Controller support" if COMPILE_TEST
+	bool "System Controller support for RZ/G2N" if COMPILE_TEST
 	select SYSC_RCAR
 
 config SYSC_R8A774C0
-	bool "RZ/G2E System Controller support" if COMPILE_TEST
+	bool "System Controller support for RZ/G2E" if COMPILE_TEST
 	select SYSC_RCAR
 
 config SYSC_R8A774E1
-	bool "RZ/G2H System Controller support" if COMPILE_TEST
+	bool "System Controller support for RZ/G2H" if COMPILE_TEST
 	select SYSC_RCAR
 
 config SYSC_R8A7779
-	bool "R-Car H1 System Controller support" if COMPILE_TEST
+	bool "System Controller support for R-Car H1" if COMPILE_TEST
 	select SYSC_RCAR
 
 config SYSC_R8A7790
-	bool "R-Car H2 System Controller support" if COMPILE_TEST
+	bool "System Controller support for R-Car H2" if COMPILE_TEST
 	select SYSC_RCAR
 
 config SYSC_R8A7791
-	bool "R-Car M2-W/N System Controller support" if COMPILE_TEST
+	bool "System Controller support for R-Car M2-W/N" if COMPILE_TEST
 	select SYSC_RCAR
 
 config SYSC_R8A7792
-	bool "R-Car V2H System Controller support" if COMPILE_TEST
+	bool "System Controller support for R-Car V2H" if COMPILE_TEST
 	select SYSC_RCAR
 
 config SYSC_R8A7794
-	bool "R-Car E2 System Controller support" if COMPILE_TEST
+	bool "System Controller support for R-Car E2" if COMPILE_TEST
 	select SYSC_RCAR
 
 config SYSC_R8A7795
-	bool "R-Car H3 System Controller support" if COMPILE_TEST
+	bool "System Controller support for R-Car H3" if COMPILE_TEST
 	select SYSC_RCAR
 
 config SYSC_R8A77960
-	bool "R-Car M3-W System Controller support" if COMPILE_TEST
+	bool "System Controller support for R-Car M3-W" if COMPILE_TEST
 	select SYSC_RCAR
 
 config SYSC_R8A77961
-	bool "R-Car M3-W+ System Controller support" if COMPILE_TEST
+	bool "System Controller support for R-Car M3-W+" if COMPILE_TEST
 	select SYSC_RCAR
 
 config SYSC_R8A77965
-	bool "R-Car M3-N System Controller support" if COMPILE_TEST
+	bool "System Controller support for R-Car M3-N" if COMPILE_TEST
 	select SYSC_RCAR
 
 config SYSC_R8A77970
-	bool "R-Car V3M System Controller support" if COMPILE_TEST
+	bool "System Controller support for R-Car V3M" if COMPILE_TEST
 	select SYSC_RCAR
 
 config SYSC_R8A77980
-	bool "R-Car V3H System Controller support" if COMPILE_TEST
+	bool "System Controller support for R-Car V3H" if COMPILE_TEST
 	select SYSC_RCAR
 
 config SYSC_R8A77990
-	bool "R-Car E3 System Controller support" if COMPILE_TEST
+	bool "System Controller support for R-Car E3" if COMPILE_TEST
 	select SYSC_RCAR
 
 config SYSC_R8A77995
-	bool "R-Car D3 System Controller support" if COMPILE_TEST
+	bool "System Controller support for R-Car D3" if COMPILE_TEST
 	select SYSC_RCAR
 
 # Family
 config RST_RCAR
-	bool "R-Car Reset Controller support" if COMPILE_TEST
+	bool "Reset  Controller support for R-Car" if COMPILE_TEST
 
 config SYSC_RCAR
-	bool "R-Car System Controller support" if COMPILE_TEST
+	bool "System Controller support for R-Car" if COMPILE_TEST
 
 config SYSC_RMOBILE
-	bool "R-Mobile System Controller support" if COMPILE_TEST
+	bool "System Controller support for R-Mobile" if COMPILE_TEST
 
 endif # SOC_RENESAS
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 10+ messages in thread

* [PATCH v2 3/3] soc: renesas: sort driver description title
  2020-08-17  4:50 [PATCH v2 0/3] soc: renesas: use menu for Renesas SoC Kuninori Morimoto
  2020-08-17  4:50 ` [PATCH v2 1/3] " Kuninori Morimoto
  2020-08-17  4:51 ` [PATCH v2 2/3] soc: renesas: align driver description title Kuninori Morimoto
@ 2020-08-17  4:51 ` Kuninori Morimoto
  2020-08-21 14:25   ` Geert Uytterhoeven
  2 siblings, 1 reply; 10+ messages in thread
From: Kuninori Morimoto @ 2020-08-17  4:51 UTC (permalink / raw)
  To: Geert Uytterhoeven, Magnus Damm; +Cc: linux-renesas-soc


From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

Some Renesas drivers are not organized, or organized by Chip number.
Because of it, menu table is not readable.
This patch sort these.

This patch do
	- Collect RZ/xx in one place
	- Collect SH-Mobile xx in one place
	- align chip number on each groups

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
 drivers/soc/renesas/Kconfig | 68 ++++++++++++++++++-------------------
 1 file changed, 34 insertions(+), 34 deletions(-)

diff --git a/drivers/soc/renesas/Kconfig b/drivers/soc/renesas/Kconfig
index bd9a9ab10d21..d69d02a65f0a 100644
--- a/drivers/soc/renesas/Kconfig
+++ b/drivers/soc/renesas/Kconfig
@@ -53,21 +53,14 @@ config ARCH_EMEV2
 	select HAVE_ARM_SCU if SMP
 	select SYS_SUPPORTS_EM_STI
 
-config ARCH_R7S72100
-	bool "RZ/A1H (R7S72100)"
+config ARCH_SH73A0
+	bool "SH-Mobile AG5 (R8A73A00)"
+	select ARCH_RMOBILE
 	select ARM_ERRATA_754322
-	select PM
-	select PM_GENERIC_DOMAINS
-	select RENESAS_OSTM
-	select RENESAS_RZA1_IRQC
-	select SYS_SUPPORTS_SH_MTU2
-
-config ARCH_R7S9210
-	bool "RZ/A2 (R7S9210)"
-	select PM
-	select PM_GENERIC_DOMAINS
-	select RENESAS_OSTM
-	select RENESAS_RZA1_IRQC
+	select ARM_GLOBAL_TIMER
+	select HAVE_ARM_SCU if SMP
+	select HAVE_ARM_TWD if SMP
+	select RENESAS_INTC_IRQPIN
 
 config ARCH_R8A73A4
 	bool "R-Mobile APE6 (R8A73A40)"
@@ -78,11 +71,27 @@ config ARCH_R8A73A4
 	select RENESAS_IRQC
 
 config ARCH_R8A7740
-	bool "R-Mobile A1 (R8A77400)"
+	bool "R-Mobile A1   (R8A77400)"
 	select ARCH_RMOBILE
 	select ARM_ERRATA_754322
 	select RENESAS_INTC_IRQPIN
 
+config ARCH_R7S72100
+	bool "RZ/A1H (R7S72100)"
+	select ARM_ERRATA_754322
+	select PM
+	select PM_GENERIC_DOMAINS
+	select RENESAS_OSTM
+	select RENESAS_RZA1_IRQC
+	select SYS_SUPPORTS_SH_MTU2
+
+config ARCH_R7S9210
+	bool "RZ/A2  (R7S9210)"
+	select PM
+	select PM_GENERIC_DOMAINS
+	select RENESAS_OSTM
+	select RENESAS_RZA1_IRQC
+
 config ARCH_R8A7742
 	bool "RZ/G1H (R8A77420)"
 	select ARCH_RCAR_GEN2
@@ -114,13 +123,18 @@ config ARCH_R8A77470
 	select ARM_ERRATA_814220
 	select SYSC_R8A77470
 
+config ARCH_R9A06G032
+	bool "RZ/N1D (R9A06G032)"
+	select ARCH_RZN1
+	select ARM_ERRATA_814220
+
 config ARCH_R8A7778
-	bool "R-Car M1A (R8A77781)"
+	bool "R-Car M1A  (R8A77781)"
 	select ARCH_RCAR_GEN1
 	select ARM_ERRATA_754322
 
 config ARCH_R8A7779
-	bool "R-Car H1 (R8A77790)"
+	bool "R-Car H1   (R8A77790)"
 	select ARCH_RCAR_GEN1
 	select ARM_ERRATA_754322
 	select ARM_GLOBAL_TIMER
@@ -129,7 +143,7 @@ config ARCH_R8A7779
 	select SYSC_R8A7779
 
 config ARCH_R8A7790
-	bool "R-Car H2 (R8A77900)"
+	bool "R-Car H2   (R8A77900)"
 	select ARCH_RCAR_GEN2
 	select ARM_ERRATA_798181 if SMP
 	select ARM_ERRATA_814220
@@ -144,7 +158,7 @@ config ARCH_R8A7791
 	select SYSC_R8A7791
 
 config ARCH_R8A7792
-	bool "R-Car V2H (R8A77920)"
+	bool "R-Car V2H  (R8A77920)"
 	select ARCH_RCAR_GEN2
 	select ARM_ERRATA_798181 if SMP
 	select SYSC_R8A7792
@@ -157,25 +171,11 @@ config ARCH_R8A7793
 	select SYSC_R8A7791
 
 config ARCH_R8A7794
-	bool "R-Car E2 (R8A77940)"
+	bool "R-Car E2   (R8A77940)"
 	select ARCH_RCAR_GEN2
 	select ARM_ERRATA_814220
 	select SYSC_R8A7794
 
-config ARCH_R9A06G032
-	bool "RZ/N1D (R9A06G032)"
-	select ARCH_RZN1
-	select ARM_ERRATA_814220
-
-config ARCH_SH73A0
-	bool "SH-Mobile AG5 (R8A73A00)"
-	select ARCH_RMOBILE
-	select ARM_ERRATA_754322
-	select ARM_GLOBAL_TIMER
-	select HAVE_ARM_SCU if SMP
-	select HAVE_ARM_TWD if SMP
-	select RENESAS_INTC_IRQPIN
-
 endif # ARM
 
 if ARM64
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 10+ messages in thread

* Re: [PATCH v2 1/3] soc: renesas: use menu for Renesas SoC
  2020-08-17  4:50 ` [PATCH v2 1/3] " Kuninori Morimoto
@ 2020-08-21 14:11   ` Geert Uytterhoeven
  0 siblings, 0 replies; 10+ messages in thread
From: Geert Uytterhoeven @ 2020-08-21 14:11 UTC (permalink / raw)
  To: Kuninori Morimoto; +Cc: Magnus Damm, Linux-Renesas

On Mon, Aug 17, 2020 at 6:50 AM Kuninori Morimoto
<kuninori.morimoto.gx@renesas.com> wrote:
> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
>
> Renesas related SoC settings are located on TOP level menu,
> thus it is very verbose.
> This patch groups Renesas related settings into
> "Renesas SoC driver support" menu.
>
> And it aligns config menu names.
>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
i.e. will queue in renesas-devel for v5.10.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH v2 2/3] soc: renesas: align driver description title
  2020-08-17  4:51 ` [PATCH v2 2/3] soc: renesas: align driver description title Kuninori Morimoto
@ 2020-08-21 14:19   ` Geert Uytterhoeven
  2020-08-24  0:03     ` Kuninori Morimoto
  0 siblings, 1 reply; 10+ messages in thread
From: Geert Uytterhoeven @ 2020-08-21 14:19 UTC (permalink / raw)
  To: Kuninori Morimoto; +Cc: Magnus Damm, Linux-Renesas

Hi Morimoto-san,

On Mon, Aug 17, 2020 at 6:51 AM Kuninori Morimoto
<kuninori.morimoto.gx@renesas.com> wrote:
> Now, Renesas SoC drivers are under menu,
> but current description are not aligned.
> This patch align these.
>
>         - R-Car H2 System Controller support                                                                    │ │
>         - R-Car M2-W/N System Controller support                                                                │ │
>         - R-Car V2H System Controller support                                                                   │ │
>         - R-Car E2 System Controller support                                                                    │ │
>         - R-Car H3 System Controller support                                                                    │ │
>         - R-Car M3-W System Controller support                                                                  │ │
>         - R-Car M3-W+ System Controller support                                                                 │ │
>         - R-Car M3-N System Controller support                                                                  │ │
>
>         + System Controller support for R-Car H2                                                                │ │
>         + System Controller support for R-Car M2-W/N                                                            │ │
>         + System Controller support for R-Car V2H                                                               │ │
>         + System Controller support for R-Car E2                                                                │ │
>         + System Controller support for R-Car H3                                                                │ │
>         + System Controller support for R-Car M3-W                                                              │ │
>         + System Controller support for R-Car M3-W+                                                             │ │
>         + System Controller support for R-Car M3-N                                                              │ │
>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

Thanks for your patch!

> --- a/drivers/soc/renesas/Kconfig
> +++ b/drivers/soc/renesas/Kconfig
> @@ -276,97 +276,97 @@ endif # ARM64
>
>  # SoC
>  config SYSC_R8A7742
> -       bool "RZ/G1H System Controller support" if COMPILE_TEST
> +       bool "System Controller support for RZ/G1H" if COMPILE_TEST
>         select SYSC_RCAR

[...]

>  config SYSC_R8A77995
> -       bool "R-Car D3 System Controller support" if COMPILE_TEST
> +       bool "System Controller support for R-Car D3" if COMPILE_TEST
>         select SYSC_RCAR
>
>  # Family
>  config RST_RCAR
> -       bool "R-Car Reset Controller support" if COMPILE_TEST
> +       bool "Reset  Controller support for R-Car" if COMPILE_TEST

This one looks a bit strange, in between SoC-specific and family-specific
System Controller support.

It could be moved up (breaking the separation between SoC-specific
and family-specific options), or down (breaking alphabetical sort order).
Any other options?

>
>  config SYSC_RCAR
> -       bool "R-Car System Controller support" if COMPILE_TEST
> +       bool "System Controller support for R-Car" if COMPILE_TEST
>
>  config SYSC_RMOBILE
> -       bool "R-Mobile System Controller support" if COMPILE_TEST
> +       bool "System Controller support for R-Mobile" if COMPILE_TEST
>
>  endif # SOC_RENESAS

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH v2 3/3] soc: renesas: sort driver description title
  2020-08-17  4:51 ` [PATCH v2 3/3] soc: renesas: sort " Kuninori Morimoto
@ 2020-08-21 14:25   ` Geert Uytterhoeven
  2020-08-24  0:02     ` Kuninori Morimoto
  0 siblings, 1 reply; 10+ messages in thread
From: Geert Uytterhoeven @ 2020-08-21 14:25 UTC (permalink / raw)
  To: Kuninori Morimoto; +Cc: Magnus Damm, Linux-Renesas

Hi Morimoto-san,

Thanks for your patch!

On Mon, Aug 17, 2020 at 6:51 AM Kuninori Morimoto
<kuninori.morimoto.gx@renesas.com> wrote:
> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
>
> Some Renesas drivers are not organized, or organized by Chip number.

They are sorted by SoC part number?

> Because of it, menu table is not readable.
> This patch sort these.
>
> This patch do
>         - Collect RZ/xx in one place
>         - Collect SH-Mobile xx in one place
>         - align chip number on each groups
>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

So now we have:

    $ grep 'bool "' drivers/soc/renesas/Kconfig  | sed -e 's/   /        /g'
        bool "Renesas SoC driver support" if COMPILE_TEST && !ARCH_RENESAS
        bool "Emma Mobile EV2"
        bool "SH-Mobile AG5 (R8A73A00)"
        bool "R-Mobile APE6 (R8A73A40)"
        bool "R-Mobile A1   (R8A77400)"
        bool "RZ/A1H (R7S72100)"
        bool "RZ/A2  (R7S9210)"
        bool "RZ/G1H (R8A77420)"
        bool "RZ/G1M (R8A77430)"
        bool "RZ/G1N (R8A77440)"
        bool "RZ/G1E (R8A77450)"
        bool "RZ/G1C (R8A77470)"
        bool "RZ/N1D (R9A06G032)"
        bool "R-Car M1A  (R8A77781)"
        bool "R-Car H1   (R8A77790)"
        bool "R-Car H2   (R8A77900)"
        bool "R-Car M2-W (R8A77910)"
        bool "R-Car V2H  (R8A77920)"
        bool "R-Car M2-N (R8A7793)"
        bool "R-Car E2   (R8A77940)"

What about changing all the above to match the below?
I.e. "SoC Platform support for <foo>"?

        bool "SoC Platform support for RZ/G2M"
        bool "SoC Platform support for RZ/G2N"
        bool "SoC Platform support for RZ/G2E"
        bool "SoC Platform support for RZ/G2H"
        bool "SoC Platform support for R-Car H3 ES1.x"
        bool "SoC Platform support for R-Car H3 ES2.0+"
        bool "SoC Platform support for R-Car M3-W"
        bool "SoC Platform support for R-Car M3-W+"
        bool "SoC Platform support for R-Car M3-N"
        bool "SoC Platform support for R-Car V3M"
        bool "SoC Platform support for R-Car V3H"
        bool "SoC Platform support for R-Car E3"
        bool "SoC Platform support for R-Car D3"
        bool "System Controller support for RZ/G1H" if COMPILE_TEST
        bool "System Controller support for RZ/G1M" if COMPILE_TEST
        bool "System Controller support for RZ/G1E" if COMPILE_TEST
        bool "System Controller support for RZ/G1C" if COMPILE_TEST
        bool "System Controller support for RZ/G2M" if COMPILE_TEST
        bool "System Controller support for RZ/G2N" if COMPILE_TEST
        bool "System Controller support for RZ/G2E" if COMPILE_TEST
        bool "System Controller support for RZ/G2H" if COMPILE_TEST
        bool "System Controller support for R-Car H1" if COMPILE_TEST
        bool "System Controller support for R-Car H2" if COMPILE_TEST
        bool "System Controller support for R-Car M2-W/N" if COMPILE_TEST
        bool "System Controller support for R-Car V2H" if COMPILE_TEST
        bool "System Controller support for R-Car E2" if COMPILE_TEST
        bool "System Controller support for R-Car H3" if COMPILE_TEST
        bool "System Controller support for R-Car M3-W" if COMPILE_TEST
        bool "System Controller support for R-Car M3-W+" if COMPILE_TEST
        bool "System Controller support for R-Car M3-N" if COMPILE_TEST
        bool "System Controller support for R-Car V3M" if COMPILE_TEST
        bool "System Controller support for R-Car V3H" if COMPILE_TEST
        bool "System Controller support for R-Car E3" if COMPILE_TEST
        bool "System Controller support for R-Car D3" if COMPILE_TEST
        bool "Reset  Controller support for R-Car" if COMPILE_TEST
        bool "System Controller support for R-Car" if COMPILE_TEST
        bool "System Controller support for R-Mobile" if COMPILE_TEST



Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH v2 3/3] soc: renesas: sort driver description title
  2020-08-21 14:25   ` Geert Uytterhoeven
@ 2020-08-24  0:02     ` Kuninori Morimoto
  2020-08-24  1:16       ` Kuninori Morimoto
  0 siblings, 1 reply; 10+ messages in thread
From: Kuninori Morimoto @ 2020-08-24  0:02 UTC (permalink / raw)
  To: Geert Uytterhoeven; +Cc: Magnus Damm, Linux-Renesas


Hi Geert

Thank you for your review

>         bool "Renesas SoC driver support" if COMPILE_TEST && !ARCH_RENESAS
>         bool "Emma Mobile EV2"
>         bool "SH-Mobile AG5 (R8A73A00)"
>         bool "R-Mobile APE6 (R8A73A40)"
>         bool "R-Mobile A1   (R8A77400)"
>         bool "RZ/A1H (R7S72100)"
>         bool "RZ/A2  (R7S9210)"
>         bool "RZ/G1H (R8A77420)"
>         bool "RZ/G1M (R8A77430)"
>         bool "RZ/G1N (R8A77440)"
>         bool "RZ/G1E (R8A77450)"
>         bool "RZ/G1C (R8A77470)"
>         bool "RZ/N1D (R9A06G032)"
>         bool "R-Car M1A  (R8A77781)"
>         bool "R-Car H1   (R8A77790)"
>         bool "R-Car H2   (R8A77900)"
>         bool "R-Car M2-W (R8A77910)"
>         bool "R-Car V2H  (R8A77920)"
>         bool "R-Car M2-N (R8A7793)"
>         bool "R-Car E2   (R8A77940)"
(snip)
>         bool "SoC Platform support for RZ/G2M"
>         bool "SoC Platform support for RZ/G2N"
>         bool "SoC Platform support for RZ/G2E"
>         bool "SoC Platform support for RZ/G2H"
>         bool "SoC Platform support for R-Car H3 ES1.x"
>         bool "SoC Platform support for R-Car H3 ES2.0+"
>         bool "SoC Platform support for R-Car M3-W"
>         bool "SoC Platform support for R-Car M3-W+"
>         bool "SoC Platform support for R-Car M3-N"
>         bool "SoC Platform support for R-Car V3M"
>         bool "SoC Platform support for R-Car V3H"
>         bool "SoC Platform support for R-Car E3"
>         bool "SoC Platform support for R-Car D3"
>         bool "System Controller support for RZ/G1H" if COMPILE_TEST
>         bool "System Controller support for RZ/G1M" if COMPILE_TEST
>         bool "System Controller support for RZ/G1E" if COMPILE_TEST
>         bool "System Controller support for RZ/G1C" if COMPILE_TEST
>         bool "System Controller support for RZ/G2M" if COMPILE_TEST
>         bool "System Controller support for RZ/G2N" if COMPILE_TEST
>         bool "System Controller support for RZ/G2E" if COMPILE_TEST
>         bool "System Controller support for RZ/G2H" if COMPILE_TEST
>         bool "System Controller support for R-Car H1" if COMPILE_TEST
>         bool "System Controller support for R-Car H2" if COMPILE_TEST
>         bool "System Controller support for R-Car M2-W/N" if COMPILE_TEST
>         bool "System Controller support for R-Car V2H" if COMPILE_TEST
>         bool "System Controller support for R-Car E2" if COMPILE_TEST
>         bool "System Controller support for R-Car H3" if COMPILE_TEST
>         bool "System Controller support for R-Car M3-W" if COMPILE_TEST
>         bool "System Controller support for R-Car M3-W+" if COMPILE_TEST
>         bool "System Controller support for R-Car M3-N" if COMPILE_TEST
>         bool "System Controller support for R-Car V3M" if COMPILE_TEST
>         bool "System Controller support for R-Car V3H" if COMPILE_TEST
>         bool "System Controller support for R-Car E3" if COMPILE_TEST
>         bool "System Controller support for R-Car D3" if COMPILE_TEST
>         bool "Reset  Controller support for R-Car" if COMPILE_TEST
>         bool "System Controller support for R-Car" if COMPILE_TEST
>         bool "System Controller support for R-Mobile" if COMPILE_TEST
(snip)
> What about changing all the above to match the below?
> I.e. "SoC Platform support for <foo>"?

It sounds good for me. Will do in v3.

And can we rename/merge "SoC Platform support" and "System Controller support" ?
These are unser "Renesas SoC driver support" menu, so just "support for xxx" ?

Thank you for your help !!

Best regards
---
Kuninori Morimoto

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH v2 2/3] soc: renesas: align driver description title
  2020-08-21 14:19   ` Geert Uytterhoeven
@ 2020-08-24  0:03     ` Kuninori Morimoto
  0 siblings, 0 replies; 10+ messages in thread
From: Kuninori Morimoto @ 2020-08-24  0:03 UTC (permalink / raw)
  To: Geert Uytterhoeven; +Cc: Magnus Damm, Linux-Renesas


Hi Geert

> >  # Family
> >  config RST_RCAR
> > -       bool "R-Car Reset Controller support" if COMPILE_TEST
> > +       bool "Reset  Controller support for R-Car" if COMPILE_TEST
> 
> This one looks a bit strange, in between SoC-specific and family-specific
> System Controller support.
> 
> It could be moved up (breaking the separation between SoC-specific
> and family-specific options), or down (breaking alphabetical sort order).
> Any other options?

OK will do in v3

Thank you for your help !!

Best regards
---
Kuninori Morimoto

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH v2 3/3] soc: renesas: sort driver description title
  2020-08-24  0:02     ` Kuninori Morimoto
@ 2020-08-24  1:16       ` Kuninori Morimoto
  0 siblings, 0 replies; 10+ messages in thread
From: Kuninori Morimoto @ 2020-08-24  1:16 UTC (permalink / raw)
  To: Geert Uytterhoeven; +Cc: Magnus Damm, Linux-Renesas


Hi Geert, again

> And can we rename/merge "SoC Platform support" and "System Controller support" ?
> These are unser "Renesas SoC driver support" menu, so just "support for xxx" ?

Ahh, we can't do this...

Thank you for your help !!

Best regards
---
Kuninori Morimoto

^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2020-08-24  1:16 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-17  4:50 [PATCH v2 0/3] soc: renesas: use menu for Renesas SoC Kuninori Morimoto
2020-08-17  4:50 ` [PATCH v2 1/3] " Kuninori Morimoto
2020-08-21 14:11   ` Geert Uytterhoeven
2020-08-17  4:51 ` [PATCH v2 2/3] soc: renesas: align driver description title Kuninori Morimoto
2020-08-21 14:19   ` Geert Uytterhoeven
2020-08-24  0:03     ` Kuninori Morimoto
2020-08-17  4:51 ` [PATCH v2 3/3] soc: renesas: sort " Kuninori Morimoto
2020-08-21 14:25   ` Geert Uytterhoeven
2020-08-24  0:02     ` Kuninori Morimoto
2020-08-24  1:16       ` Kuninori Morimoto

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).