* [PATCH] dt-bindings: serial: re-order entries to match coding convention
@ 2023-10-16 6:16 Krzysztof Kozlowski
2023-10-16 8:00 ` Geert Uytterhoeven
0 siblings, 1 reply; 3+ messages in thread
From: Krzysztof Kozlowski @ 2023-10-16 6:16 UTC (permalink / raw)
To: Greg Kroah-Hartman, Jiri Slaby, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Thierry Reding, Jonathan Hunter, Andy Gross,
Bjorn Andersson, Konrad Dybcio, Geert Uytterhoeven, Magnus Damm,
linux-kernel, linux-serial, devicetree, linux-tegra,
linux-arm-msm, linux-renesas-soc
Cc: Krzysztof Kozlowski
The DT schema coding convetion express in
Documentation/devicetree/bindings/example-schema.yaml expects entries in
following order:
- properties, patternProperties
- required
- if blocks, allOf with if-blocks
- additionalProperties/unevaluatedProperties
Re-order few schemas to match the convention to avoid repeating reviews
for new patches using existing code as template. No functional changes.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
.../bindings/serial/nvidia,tegra20-hsuart.yaml | 10 +++++-----
.../bindings/serial/qcom,msm-uart.yaml | 4 ++--
.../bindings/serial/qcom,msm-uartdm.yaml | 4 ++--
.../bindings/serial/renesas,em-uart.yaml | 14 +++++++-------
.../bindings/serial/renesas,hscif.yaml | 4 ++--
.../bindings/serial/renesas,scifa.yaml | 4 ++--
.../bindings/serial/renesas,scifb.yaml | 4 ++--
.../devicetree/bindings/serial/samsung_uart.yaml | 4 ++--
.../devicetree/bindings/serial/serial.yaml | 16 ++++++++--------
9 files changed, 32 insertions(+), 32 deletions(-)
diff --git a/Documentation/devicetree/bindings/serial/nvidia,tegra20-hsuart.yaml b/Documentation/devicetree/bindings/serial/nvidia,tegra20-hsuart.yaml
index 04d55fecf47c..a5d67563cd53 100644
--- a/Documentation/devicetree/bindings/serial/nvidia,tegra20-hsuart.yaml
+++ b/Documentation/devicetree/bindings/serial/nvidia,tegra20-hsuart.yaml
@@ -91,11 +91,6 @@ properties:
- description: range upper bound
- description: adjustment (in permyriad, i.e. 0.01%)
-allOf:
- - $ref: serial.yaml
-
-unevaluatedProperties: false
-
required:
- compatible
- reg
@@ -106,6 +101,11 @@ required:
- dmas
- dma-names
+allOf:
+ - $ref: serial.yaml
+
+unevaluatedProperties: false
+
examples:
- |
#include <dt-bindings/clock/tegra30-car.h>
diff --git a/Documentation/devicetree/bindings/serial/qcom,msm-uart.yaml b/Documentation/devicetree/bindings/serial/qcom,msm-uart.yaml
index a052aaef21f4..ea6abfe2d95e 100644
--- a/Documentation/devicetree/bindings/serial/qcom,msm-uart.yaml
+++ b/Documentation/devicetree/bindings/serial/qcom,msm-uart.yaml
@@ -40,11 +40,11 @@ required:
- interrupts
- reg
-unevaluatedProperties: false
-
allOf:
- $ref: /schemas/serial/serial.yaml#
+unevaluatedProperties: false
+
examples:
- |
serial@a9c00000 {
diff --git a/Documentation/devicetree/bindings/serial/qcom,msm-uartdm.yaml b/Documentation/devicetree/bindings/serial/qcom,msm-uartdm.yaml
index 484b9a51f6a9..ee52bf8e8917 100644
--- a/Documentation/devicetree/bindings/serial/qcom,msm-uartdm.yaml
+++ b/Documentation/devicetree/bindings/serial/qcom,msm-uartdm.yaml
@@ -78,8 +78,6 @@ required:
- interrupts
- reg
-unevaluatedProperties: false
-
allOf:
- $ref: /schemas/serial/serial.yaml#
@@ -97,6 +95,8 @@ allOf:
reg:
maxItems: 1
+unevaluatedProperties: false
+
examples:
- |
#include <dt-bindings/interrupt-controller/arm-gic.h>
diff --git a/Documentation/devicetree/bindings/serial/renesas,em-uart.yaml b/Documentation/devicetree/bindings/serial/renesas,em-uart.yaml
index 3fc2601f1338..89f1eb0f2c5a 100644
--- a/Documentation/devicetree/bindings/serial/renesas,em-uart.yaml
+++ b/Documentation/devicetree/bindings/serial/renesas,em-uart.yaml
@@ -38,6 +38,13 @@ properties:
- const: sclk
- const: pclk
+required:
+ - compatible
+ - reg
+ - interrupts
+ - clocks
+ - clock-names
+
allOf:
- $ref: serial.yaml#
@@ -53,13 +60,6 @@ allOf:
clock-names:
minItems: 2
-required:
- - compatible
- - reg
- - interrupts
- - clocks
- - clock-names
-
unevaluatedProperties: false
examples:
diff --git a/Documentation/devicetree/bindings/serial/renesas,hscif.yaml b/Documentation/devicetree/bindings/serial/renesas,hscif.yaml
index 1c7f1276aed6..2046e2dc0a3d 100644
--- a/Documentation/devicetree/bindings/serial/renesas,hscif.yaml
+++ b/Documentation/devicetree/bindings/serial/renesas,hscif.yaml
@@ -111,8 +111,6 @@ required:
- clock-names
- power-domains
-unevaluatedProperties: false
-
if:
properties:
compatible:
@@ -125,6 +123,8 @@ then:
required:
- resets
+unevaluatedProperties: false
+
examples:
- |
#include <dt-bindings/clock/r8a7795-cpg-mssr.h>
diff --git a/Documentation/devicetree/bindings/serial/renesas,scifa.yaml b/Documentation/devicetree/bindings/serial/renesas,scifa.yaml
index 499507678cdf..c98657cf4666 100644
--- a/Documentation/devicetree/bindings/serial/renesas,scifa.yaml
+++ b/Documentation/devicetree/bindings/serial/renesas,scifa.yaml
@@ -77,8 +77,6 @@ required:
- clock-names
- power-domains
-unevaluatedProperties: false
-
if:
properties:
compatible:
@@ -89,6 +87,8 @@ then:
required:
- resets
+unevaluatedProperties: false
+
examples:
- |
#include <dt-bindings/clock/r8a7790-cpg-mssr.h>
diff --git a/Documentation/devicetree/bindings/serial/renesas,scifb.yaml b/Documentation/devicetree/bindings/serial/renesas,scifb.yaml
index 810d8a991fdd..fb695b3111ac 100644
--- a/Documentation/devicetree/bindings/serial/renesas,scifb.yaml
+++ b/Documentation/devicetree/bindings/serial/renesas,scifb.yaml
@@ -77,8 +77,6 @@ required:
- clock-names
- power-domains
-unevaluatedProperties: false
-
if:
properties:
compatible:
@@ -89,6 +87,8 @@ then:
required:
- resets
+unevaluatedProperties: false
+
examples:
- |
#include <dt-bindings/clock/r8a7740-clock.h>
diff --git a/Documentation/devicetree/bindings/serial/samsung_uart.yaml b/Documentation/devicetree/bindings/serial/samsung_uart.yaml
index 8bd88d5cbb11..aecb6761b49c 100644
--- a/Documentation/devicetree/bindings/serial/samsung_uart.yaml
+++ b/Documentation/devicetree/bindings/serial/samsung_uart.yaml
@@ -86,8 +86,6 @@ required:
- interrupts
- reg
-unevaluatedProperties: false
-
allOf:
- $ref: serial.yaml#
@@ -128,6 +126,8 @@ allOf:
- const: uart
- const: clk_uart_baud0
+unevaluatedProperties: false
+
examples:
- |
#include <dt-bindings/clock/samsung,s3c64xx-clock.h>
diff --git a/Documentation/devicetree/bindings/serial/serial.yaml b/Documentation/devicetree/bindings/serial/serial.yaml
index 468af429c3e6..65804ca274ae 100644
--- a/Documentation/devicetree/bindings/serial/serial.yaml
+++ b/Documentation/devicetree/bindings/serial/serial.yaml
@@ -87,14 +87,6 @@ properties:
description:
TX FIFO threshold configuration (in bytes).
-if:
- required:
- - uart-has-rtscts
-then:
- properties:
- cts-gpios: false
- rts-gpios: false
-
patternProperties:
"^(bluetooth|bluetooth-gnss|gnss|gps|mcu)$":
if:
@@ -136,6 +128,14 @@ patternProperties:
required:
- compatible
+if:
+ required:
+ - uart-has-rtscts
+then:
+ properties:
+ cts-gpios: false
+ rts-gpios: false
+
additionalProperties: true
examples:
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] dt-bindings: serial: re-order entries to match coding convention
2023-10-16 6:16 [PATCH] dt-bindings: serial: re-order entries to match coding convention Krzysztof Kozlowski
@ 2023-10-16 8:00 ` Geert Uytterhoeven
2023-10-16 16:43 ` Krzysztof Kozlowski
0 siblings, 1 reply; 3+ messages in thread
From: Geert Uytterhoeven @ 2023-10-16 8:00 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Greg Kroah-Hartman, Jiri Slaby, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Thierry Reding, Jonathan Hunter, Andy Gross,
Bjorn Andersson, Konrad Dybcio, Geert Uytterhoeven, Magnus Damm,
linux-kernel, linux-serial, devicetree, linux-tegra,
linux-arm-msm, linux-renesas-soc
On Mon, Oct 16, 2023 at 8:17 AM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
> The DT schema coding convetion express in
convention expressed
> Documentation/devicetree/bindings/example-schema.yaml expects entries in
> following order:
> - properties, patternProperties
> - required
> - if blocks, allOf with if-blocks
> - additionalProperties/unevaluatedProperties
>
> Re-order few schemas to match the convention to avoid repeating reviews
review comments
> for new patches using existing code as template. No functional changes.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] dt-bindings: serial: re-order entries to match coding convention
2023-10-16 8:00 ` Geert Uytterhoeven
@ 2023-10-16 16:43 ` Krzysztof Kozlowski
0 siblings, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2023-10-16 16:43 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Greg Kroah-Hartman, Jiri Slaby, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Thierry Reding, Jonathan Hunter, Andy Gross,
Bjorn Andersson, Konrad Dybcio, Geert Uytterhoeven, Magnus Damm,
linux-kernel, linux-serial, devicetree, linux-tegra,
linux-arm-msm, linux-renesas-soc
On 16/10/2023 10:00, Geert Uytterhoeven wrote:
> On Mon, Oct 16, 2023 at 8:17 AM Krzysztof Kozlowski
> <krzysztof.kozlowski@linaro.org> wrote:
>> The DT schema coding convetion express in
>
> convention expressed
>
>> Documentation/devicetree/bindings/example-schema.yaml expects entries in
>> following order:
>> - properties, patternProperties
>> - required
>> - if blocks, allOf with if-blocks
>> - additionalProperties/unevaluatedProperties
>>
>> Re-order few schemas to match the convention to avoid repeating reviews
>
> review comments
>
>> for new patches using existing code as template. No functional changes.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
I should have run spell-check. Thanks for review. I will send v2.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-10-16 16:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-10-16 6:16 [PATCH] dt-bindings: serial: re-order entries to match coding convention Krzysztof Kozlowski
2023-10-16 8:00 ` Geert Uytterhoeven
2023-10-16 16:43 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).