From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Simon Horman <horms@verge.net.au>
Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>
Subject: Re: [PATCH] arm64: dts: renesas: salvator-common: Add GPIO keys support
Date: Thu, 23 Aug 2018 11:54:10 +0200 [thread overview]
Message-ID: <CAMuHMdVkf+==3GN-h2fxomgnmPDkvQEvi1zwzwA+n65Wf10yEA@mail.gmail.com> (raw)
In-Reply-To: <20180822102950.v5bgqw52wuz6casn@verge.net.au>
Hi Simon,
On Wed, Aug 22, 2018 at 12:30 PM Simon Horman <horms@verge.net.au> wrote:
> On Sun, Aug 19, 2018 at 10:44:55PM +0300, Laurent Pinchart wrote:
> > The Salvator-X and XS boards have a 4 lines DIP switch and 3 push
> > buttons connected to SoC GPIOs, meant to be used as general-purpose test
> > keys. Add a corresponding node in DT, mapping (semi-randomly) the DIP
>
> Arbitrary may be a better word choice than random.
>
> > switch to keys 1-4 and the push buttons to keys A-C.
> >
> > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> > --- a/arch/arm64/boot/dts/renesas/salvator-common.dtsi
> > +++ b/arch/arm64/boot/dts/renesas/salvator-common.dtsi
> > + key-a {
> > + gpios = <&gpio6 11 GPIO_ACTIVE_LOW>;
> > + linux,code = <KEY_A>;
> > + label = "TSW0";
>
> What does the 'T' in 'TSW' stand for? Toggle?
Tact Switch, cfr. the schematics.
> > @@ -567,6 +625,11 @@
> > function = "intc_ex";
> > };
> >
> > + keys_pins: keys {
> > + pins = "GP_5_17", "GP_5_20", "GP_5_22";
>
> I am curious to know why only some of the pins used above appear here.
GP5_23 has an external 100K pull-up, GP5_{17,20,22} don't.
GP6_1[123] have external 1K + 2K pull-upps.
>
> > + bias-pull-up;
> > + };
> > +
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2018-08-23 13:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-19 19:44 [PATCH] arm64: dts: renesas: salvator-common: Add GPIO keys support Laurent Pinchart
2018-08-22 10:29 ` Simon Horman
2018-08-23 9:54 ` Geert Uytterhoeven [this message]
2018-08-23 9:58 ` Geert Uytterhoeven
2018-09-06 9:42 ` Simon Horman
2018-09-06 9:59 ` Laurent Pinchart
2018-09-12 10:25 ` Simon Horman
2018-09-12 11:59 ` Geert Uytterhoeven
2018-09-17 7:10 ` Simon Horman
2019-03-25 2:30 ` Laurent Pinchart
2019-03-27 12:02 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMuHMdVkf+==3GN-h2fxomgnmPDkvQEvi1zwzwA+n65Wf10yEA@mail.gmail.com' \
--to=geert@linux-m68k.org \
--cc=horms@verge.net.au \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=linux-renesas-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).