* [PATCH] arm64: dts: renesas: salvator-common: Add GPIO keys support @ 2018-08-19 19:44 Laurent Pinchart 2018-08-22 10:29 ` Simon Horman 2018-08-23 9:58 ` Geert Uytterhoeven 0 siblings, 2 replies; 11+ messages in thread From: Laurent Pinchart @ 2018-08-19 19:44 UTC (permalink / raw) To: linux-renesas-soc The Salvator-X and XS boards have a 4 lines DIP switch and 3 push buttons connected to SoC GPIOs, meant to be used as general-purpose test keys. Add a corresponding node in DT, mapping (semi-randomly) the DIP switch to keys 1-4 and the push buttons to keys A-C. Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> --- arch/arm64/boot/dts/renesas/salvator-common.dtsi | 63 ++++++++++++++++++++++++ 1 file changed, 63 insertions(+) diff --git a/arch/arm64/boot/dts/renesas/salvator-common.dtsi b/arch/arm64/boot/dts/renesas/salvator-common.dtsi index 7d3d866a0063..77d626baa9f3 100644 --- a/arch/arm64/boot/dts/renesas/salvator-common.dtsi +++ b/arch/arm64/boot/dts/renesas/salvator-common.dtsi @@ -29,6 +29,7 @@ */ #include <dt-bindings/gpio/gpio.h> +#include <dt-bindings/input/input.h> / { aliases { @@ -86,6 +87,63 @@ }; }; + keys { + compatible = "gpio-keys"; + + pinctrl-0 = <&keys_pins>; + pinctrl-names = "default"; + + key-1 { + gpios = <&gpio5 17 GPIO_ACTIVE_LOW>; + linux,code = <KEY_1>; + label = "SW4-1"; + wakeup-source; + debounce-interval = <20>; + }; + key-2 { + gpios = <&gpio5 20 GPIO_ACTIVE_LOW>; + linux,code = <KEY_2>; + label = "SW4-2"; + wakeup-source; + debounce-interval = <20>; + }; + key-3 { + gpios = <&gpio5 22 GPIO_ACTIVE_LOW>; + linux,code = <KEY_3>; + label = "SW4-3"; + wakeup-source; + debounce-interval = <20>; + }; + key-4 { + gpios = <&gpio5 23 GPIO_ACTIVE_LOW>; + linux,code = <KEY_4>; + label = "SW4-4"; + wakeup-source; + debounce-interval = <20>; + }; + key-a { + gpios = <&gpio6 11 GPIO_ACTIVE_LOW>; + linux,code = <KEY_A>; + label = "TSW0"; + wakeup-source; + debounce-interval = <20>; + }; + key-b { + gpios = <&gpio6 12 GPIO_ACTIVE_LOW>; + linux,code = <KEY_B>; + label = "TSW1"; + wakeup-source; + debounce-interval = <20>; + }; + key-c { + gpios = <&gpio6 13 GPIO_ACTIVE_LOW>; + linux,code = <KEY_C>; + label = "TSW2"; + wakeup-source; + debounce-interval = <20>; + }; + }; + reg_1p8v: regulator0 { compatible = "regulator-fixed"; regulator-name = "fixed-1.8V"; @@ -567,6 +625,11 @@ function = "intc_ex"; }; + keys_pins: keys { + pins = "GP_5_17", "GP_5_20", "GP_5_22"; + bias-pull-up; + }; + pwm1_pins: pwm1 { groups = "pwm1_a"; function = "pwm1"; -- Regards, Laurent Pinchart ^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH] arm64: dts: renesas: salvator-common: Add GPIO keys support 2018-08-19 19:44 [PATCH] arm64: dts: renesas: salvator-common: Add GPIO keys support Laurent Pinchart @ 2018-08-22 10:29 ` Simon Horman 2018-08-23 9:54 ` Geert Uytterhoeven 2018-08-23 9:58 ` Geert Uytterhoeven 1 sibling, 1 reply; 11+ messages in thread From: Simon Horman @ 2018-08-22 10:29 UTC (permalink / raw) To: Laurent Pinchart; +Cc: linux-renesas-soc Hi Laurent, thanks for your patch. On Sun, Aug 19, 2018 at 10:44:55PM +0300, Laurent Pinchart wrote: > The Salvator-X and XS boards have a 4 lines DIP switch and 3 push > buttons connected to SoC GPIOs, meant to be used as general-purpose test > keys. Add a corresponding node in DT, mapping (semi-randomly) the DIP Arbitrary may be a better word choice than random. > switch to keys 1-4 and the push buttons to keys A-C. > > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> > --- > arch/arm64/boot/dts/renesas/salvator-common.dtsi | 63 ++++++++++++++++++++++++ > 1 file changed, 63 insertions(+) > > diff --git a/arch/arm64/boot/dts/renesas/salvator-common.dtsi b/arch/arm64/boot/dts/renesas/salvator-common.dtsi > index 7d3d866a0063..77d626baa9f3 100644 > --- a/arch/arm64/boot/dts/renesas/salvator-common.dtsi > +++ b/arch/arm64/boot/dts/renesas/salvator-common.dtsi > @@ -29,6 +29,7 @@ > */ > > #include <dt-bindings/gpio/gpio.h> > +#include <dt-bindings/input/input.h> > > / { > aliases { > @@ -86,6 +87,63 @@ > }; > }; > > + keys { > + compatible = "gpio-keys"; > + > + pinctrl-0 = <&keys_pins>; > + pinctrl-names = "default"; > + > + key-1 { > + gpios = <&gpio5 17 GPIO_ACTIVE_LOW>; > + linux,code = <KEY_1>; > + label = "SW4-1"; > + wakeup-source; > + debounce-interval = <20>; > + }; > + key-2 { > + gpios = <&gpio5 20 GPIO_ACTIVE_LOW>; > + linux,code = <KEY_2>; > + label = "SW4-2"; > + wakeup-source; > + debounce-interval = <20>; > + }; > + key-3 { > + gpios = <&gpio5 22 GPIO_ACTIVE_LOW>; > + linux,code = <KEY_3>; > + label = "SW4-3"; > + wakeup-source; > + debounce-interval = <20>; > + }; > + key-4 { > + gpios = <&gpio5 23 GPIO_ACTIVE_LOW>; > + linux,code = <KEY_4>; > + label = "SW4-4"; > + wakeup-source; > + debounce-interval = <20>; > + }; > + key-a { > + gpios = <&gpio6 11 GPIO_ACTIVE_LOW>; > + linux,code = <KEY_A>; > + label = "TSW0"; What does the 'T' in 'TSW' stand for? Toggle? > + wakeup-source; > + debounce-interval = <20>; > + }; > + key-b { > + gpios = <&gpio6 12 GPIO_ACTIVE_LOW>; > + linux,code = <KEY_B>; > + label = "TSW1"; > + wakeup-source; > + debounce-interval = <20>; > + }; > + key-c { > + gpios = <&gpio6 13 GPIO_ACTIVE_LOW>; > + linux,code = <KEY_C>; > + label = "TSW2"; > + wakeup-source; > + debounce-interval = <20>; > + }; > + }; > + > reg_1p8v: regulator0 { > compatible = "regulator-fixed"; > regulator-name = "fixed-1.8V"; > @@ -567,6 +625,11 @@ > function = "intc_ex"; > }; > > + keys_pins: keys { > + pins = "GP_5_17", "GP_5_20", "GP_5_22"; I am curious to know why only some of the pins used above appear here. > + bias-pull-up; > + }; > + > pwm1_pins: pwm1 { > groups = "pwm1_a"; > function = "pwm1"; > -- > Regards, > > Laurent Pinchart > ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] arm64: dts: renesas: salvator-common: Add GPIO keys support 2018-08-22 10:29 ` Simon Horman @ 2018-08-23 9:54 ` Geert Uytterhoeven 0 siblings, 0 replies; 11+ messages in thread From: Geert Uytterhoeven @ 2018-08-23 9:54 UTC (permalink / raw) To: Simon Horman; +Cc: Laurent Pinchart, Linux-Renesas Hi Simon, On Wed, Aug 22, 2018 at 12:30 PM Simon Horman <horms@verge.net.au> wrote: > On Sun, Aug 19, 2018 at 10:44:55PM +0300, Laurent Pinchart wrote: > > The Salvator-X and XS boards have a 4 lines DIP switch and 3 push > > buttons connected to SoC GPIOs, meant to be used as general-purpose test > > keys. Add a corresponding node in DT, mapping (semi-randomly) the DIP > > Arbitrary may be a better word choice than random. > > > switch to keys 1-4 and the push buttons to keys A-C. > > > > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> > > --- a/arch/arm64/boot/dts/renesas/salvator-common.dtsi > > +++ b/arch/arm64/boot/dts/renesas/salvator-common.dtsi > > + key-a { > > + gpios = <&gpio6 11 GPIO_ACTIVE_LOW>; > > + linux,code = <KEY_A>; > > + label = "TSW0"; > > What does the 'T' in 'TSW' stand for? Toggle? Tact Switch, cfr. the schematics. > > @@ -567,6 +625,11 @@ > > function = "intc_ex"; > > }; > > > > + keys_pins: keys { > > + pins = "GP_5_17", "GP_5_20", "GP_5_22"; > > I am curious to know why only some of the pins used above appear here. GP5_23 has an external 100K pull-up, GP5_{17,20,22} don't. GP6_1[123] have external 1K + 2K pull-upps. > > > + bias-pull-up; > > + }; > > + Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] arm64: dts: renesas: salvator-common: Add GPIO keys support 2018-08-19 19:44 [PATCH] arm64: dts: renesas: salvator-common: Add GPIO keys support Laurent Pinchart 2018-08-22 10:29 ` Simon Horman @ 2018-08-23 9:58 ` Geert Uytterhoeven 2018-09-06 9:42 ` Simon Horman 1 sibling, 1 reply; 11+ messages in thread From: Geert Uytterhoeven @ 2018-08-23 9:58 UTC (permalink / raw) To: Laurent Pinchart; +Cc: Linux-Renesas Hi Laurent, On Sun, Aug 19, 2018 at 9:44 PM Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> wrote: > The Salvator-X and XS boards have a 4 lines DIP switch and 3 push > buttons connected to SoC GPIOs, meant to be used as general-purpose test > keys. Add a corresponding node in DT, mapping (semi-randomly) the DIP > switch to keys 1-4 and the push buttons to keys A-C. > > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> Given GP6_1[123] are not just wired to the 3 push buttons, but also to 3 LEDs, I wonder if we shouldn't postpone that part until Linux can handle GPIOs connected to both? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] arm64: dts: renesas: salvator-common: Add GPIO keys support 2018-08-23 9:58 ` Geert Uytterhoeven @ 2018-09-06 9:42 ` Simon Horman 2018-09-06 9:59 ` Laurent Pinchart 0 siblings, 1 reply; 11+ messages in thread From: Simon Horman @ 2018-09-06 9:42 UTC (permalink / raw) To: Geert Uytterhoeven; +Cc: Laurent Pinchart, Linux-Renesas On Thu, Aug 23, 2018 at 11:58:54AM +0200, Geert Uytterhoeven wrote: > Hi Laurent, > > On Sun, Aug 19, 2018 at 9:44 PM Laurent Pinchart > <laurent.pinchart+renesas@ideasonboard.com> wrote: > > The Salvator-X and XS boards have a 4 lines DIP switch and 3 push > > buttons connected to SoC GPIOs, meant to be used as general-purpose test > > keys. Add a corresponding node in DT, mapping (semi-randomly) the DIP > > switch to keys 1-4 and the push buttons to keys A-C. > > > > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> > > Given GP6_1[123] are not just wired to the 3 push buttons, but also to 3 > LEDs, I wonder if we shouldn't postpone that part until Linux can handle > GPIOs connected to both? Laurent, any thoughts on that? ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] arm64: dts: renesas: salvator-common: Add GPIO keys support 2018-09-06 9:42 ` Simon Horman @ 2018-09-06 9:59 ` Laurent Pinchart 2018-09-12 10:25 ` Simon Horman 0 siblings, 1 reply; 11+ messages in thread From: Laurent Pinchart @ 2018-09-06 9:59 UTC (permalink / raw) To: Simon Horman; +Cc: Geert Uytterhoeven, Laurent Pinchart, Linux-Renesas Hello, On Thursday, 6 September 2018 12:42:32 EEST Simon Horman wrote: > On Thu, Aug 23, 2018 at 11:58:54AM +0200, Geert Uytterhoeven wrote: > > On Sun, Aug 19, 2018 at 9:44 PM Laurent Pinchart wrote: > >> The Salvator-X and XS boards have a 4 lines DIP switch and 3 push > >> buttons connected to SoC GPIOs, meant to be used as general-purpose test > >> keys. Add a corresponding node in DT, mapping (semi-randomly) the DIP > >> switch to keys 1-4 and the push buttons to keys A-C. > >> > >> Signed-off-by: Laurent Pinchart > >> <laurent.pinchart+renesas@ideasonboard.com> > > > > Given GP6_1[123] are not just wired to the 3 push buttons, but also to 3 > > LEDs, I wonder if we shouldn't postpone that part until Linux can handle > > GPIOs connected to both? > > Laurent, any thoughts on that? Right now the GPIOs are not wired in DT, and we're thus without a way to interface to both LEDs and push buttons. While I agree that an ideal solution would be to support both, I think that moving from nothing to support for push buttons would be a step forward already. -- Regards, Laurent Pinchart ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] arm64: dts: renesas: salvator-common: Add GPIO keys support 2018-09-06 9:59 ` Laurent Pinchart @ 2018-09-12 10:25 ` Simon Horman 2018-09-12 11:59 ` Geert Uytterhoeven 0 siblings, 1 reply; 11+ messages in thread From: Simon Horman @ 2018-09-12 10:25 UTC (permalink / raw) To: Laurent Pinchart; +Cc: Geert Uytterhoeven, Laurent Pinchart, Linux-Renesas On Thu, Sep 06, 2018 at 12:59:20PM +0300, Laurent Pinchart wrote: > Hello, > > On Thursday, 6 September 2018 12:42:32 EEST Simon Horman wrote: > > On Thu, Aug 23, 2018 at 11:58:54AM +0200, Geert Uytterhoeven wrote: > > > On Sun, Aug 19, 2018 at 9:44 PM Laurent Pinchart wrote: > > >> The Salvator-X and XS boards have a 4 lines DIP switch and 3 push > > >> buttons connected to SoC GPIOs, meant to be used as general-purpose test > > >> keys. Add a corresponding node in DT, mapping (semi-randomly) the DIP > > >> switch to keys 1-4 and the push buttons to keys A-C. > > >> > > >> Signed-off-by: Laurent Pinchart > > >> <laurent.pinchart+renesas@ideasonboard.com> > > > > > > Given GP6_1[123] are not just wired to the 3 push buttons, but also to 3 > > > LEDs, I wonder if we shouldn't postpone that part until Linux can handle > > > GPIOs connected to both? > > > > Laurent, any thoughts on that? > > Right now the GPIOs are not wired in DT, and we're thus without a way to > interface to both LEDs and push buttons. While I agree that an ideal > solution would be to support both, I think that moving from nothing to > support for push buttons would be a step forward already. I tend to agree. Geert, what are your thoughts? ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] arm64: dts: renesas: salvator-common: Add GPIO keys support 2018-09-12 10:25 ` Simon Horman @ 2018-09-12 11:59 ` Geert Uytterhoeven 2018-09-17 7:10 ` Simon Horman 0 siblings, 1 reply; 11+ messages in thread From: Geert Uytterhoeven @ 2018-09-12 11:59 UTC (permalink / raw) To: Simon Horman; +Cc: Laurent Pinchart, Laurent Pinchart, Linux-Renesas Hi Simon, On Wed, Sep 12, 2018 at 12:25 PM Simon Horman <horms@verge.net.au> wrote: > On Thu, Sep 06, 2018 at 12:59:20PM +0300, Laurent Pinchart wrote: > > On Thursday, 6 September 2018 12:42:32 EEST Simon Horman wrote: > > > On Thu, Aug 23, 2018 at 11:58:54AM +0200, Geert Uytterhoeven wrote: > > > > On Sun, Aug 19, 2018 at 9:44 PM Laurent Pinchart wrote: > > > >> The Salvator-X and XS boards have a 4 lines DIP switch and 3 push > > > >> buttons connected to SoC GPIOs, meant to be used as general-purpose test > > > >> keys. Add a corresponding node in DT, mapping (semi-randomly) the DIP > > > >> switch to keys 1-4 and the push buttons to keys A-C. > > > >> > > > >> Signed-off-by: Laurent Pinchart > > > >> <laurent.pinchart+renesas@ideasonboard.com> > > > > > > > > Given GP6_1[123] are not just wired to the 3 push buttons, but also to 3 > > > > LEDs, I wonder if we shouldn't postpone that part until Linux can handle > > > > GPIOs connected to both? > > > > > > Laurent, any thoughts on that? > > > > Right now the GPIOs are not wired in DT, and we're thus without a way to > > interface to both LEDs and push buttons. While I agree that an ideal > > solution would be to support both, I think that moving from nothing to > > support for push buttons would be a step forward already. > > I tend to agree. Geert, what are your thoughts? Fine for me. Just one more bikeshedding question: what's most useful, buttons or LEDs? ;-) Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] arm64: dts: renesas: salvator-common: Add GPIO keys support 2018-09-12 11:59 ` Geert Uytterhoeven @ 2018-09-17 7:10 ` Simon Horman 2019-03-25 2:30 ` Laurent Pinchart 0 siblings, 1 reply; 11+ messages in thread From: Simon Horman @ 2018-09-17 7:10 UTC (permalink / raw) To: Geert Uytterhoeven; +Cc: Laurent Pinchart, Laurent Pinchart, Linux-Renesas On Wed, Sep 12, 2018 at 01:59:53PM +0200, Geert Uytterhoeven wrote: > Hi Simon, > > On Wed, Sep 12, 2018 at 12:25 PM Simon Horman <horms@verge.net.au> wrote: > > On Thu, Sep 06, 2018 at 12:59:20PM +0300, Laurent Pinchart wrote: > > > On Thursday, 6 September 2018 12:42:32 EEST Simon Horman wrote: > > > > On Thu, Aug 23, 2018 at 11:58:54AM +0200, Geert Uytterhoeven wrote: > > > > > On Sun, Aug 19, 2018 at 9:44 PM Laurent Pinchart wrote: > > > > >> The Salvator-X and XS boards have a 4 lines DIP switch and 3 push > > > > >> buttons connected to SoC GPIOs, meant to be used as general-purpose test > > > > >> keys. Add a corresponding node in DT, mapping (semi-randomly) the DIP > > > > >> switch to keys 1-4 and the push buttons to keys A-C. > > > > >> > > > > >> Signed-off-by: Laurent Pinchart > > > > >> <laurent.pinchart+renesas@ideasonboard.com> > > > > > > > > > > Given GP6_1[123] are not just wired to the 3 push buttons, but also to 3 > > > > > LEDs, I wonder if we shouldn't postpone that part until Linux can handle > > > > > GPIOs connected to both? > > > > > > > > Laurent, any thoughts on that? > > > > > > Right now the GPIOs are not wired in DT, and we're thus without a way to > > > interface to both LEDs and push buttons. While I agree that an ideal > > > solution would be to support both, I think that moving from nothing to > > > support for push buttons would be a step forward already. > > > > I tend to agree. Geert, what are your thoughts? > > Fine for me. > > Just one more bikeshedding question: what's most useful, buttons or LEDs? ;-) Lets go with the buttons. Applied for v4.20. ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] arm64: dts: renesas: salvator-common: Add GPIO keys support 2018-09-17 7:10 ` Simon Horman @ 2019-03-25 2:30 ` Laurent Pinchart 2019-03-27 12:02 ` Simon Horman 0 siblings, 1 reply; 11+ messages in thread From: Laurent Pinchart @ 2019-03-25 2:30 UTC (permalink / raw) To: Simon Horman; +Cc: Geert Uytterhoeven, Laurent Pinchart, Linux-Renesas Hi Simon, On Mon, Sep 17, 2018 at 09:10:42AM +0200, Simon Horman wrote: > On Wed, Sep 12, 2018 at 01:59:53PM +0200, Geert Uytterhoeven wrote: > > On Wed, Sep 12, 2018 at 12:25 PM Simon Horman <horms@verge.net.au> wrote: > >> On Thu, Sep 06, 2018 at 12:59:20PM +0300, Laurent Pinchart wrote: > >>> On Thursday, 6 September 2018 12:42:32 EEST Simon Horman wrote: > >>>> On Thu, Aug 23, 2018 at 11:58:54AM +0200, Geert Uytterhoeven wrote: > >>>>> On Sun, Aug 19, 2018 at 9:44 PM Laurent Pinchart wrote: > >>>>>> The Salvator-X and XS boards have a 4 lines DIP switch and 3 push > >>>>>> buttons connected to SoC GPIOs, meant to be used as general-purpose test > >>>>>> keys. Add a corresponding node in DT, mapping (semi-randomly) the DIP > >>>>>> switch to keys 1-4 and the push buttons to keys A-C. > >>>>>> > >>>>>> Signed-off-by: Laurent Pinchart > >>>>>> <laurent.pinchart+renesas@ideasonboard.com> > >>>>> > >>>>> Given GP6_1[123] are not just wired to the 3 push buttons, but also to 3 > >>>>> LEDs, I wonder if we shouldn't postpone that part until Linux can handle > >>>>> GPIOs connected to both? > >>>> > >>>> Laurent, any thoughts on that? > >>> > >>> Right now the GPIOs are not wired in DT, and we're thus without a way to > >>> interface to both LEDs and push buttons. While I agree that an ideal > >>> solution would be to support both, I think that moving from nothing to > >>> support for push buttons would be a step forward already. > >> > >> I tend to agree. Geert, what are your thoughts? > > > > Fine for me. > > > > Just one more bikeshedding question: what's most useful, buttons or LEDs? ;-) > > Lets go with the buttons. > > Applied for v4.20. Shouldn't it have made it to Linus' tree then ? :-) -- Regards, Laurent Pinchart ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] arm64: dts: renesas: salvator-common: Add GPIO keys support 2019-03-25 2:30 ` Laurent Pinchart @ 2019-03-27 12:02 ` Simon Horman 0 siblings, 0 replies; 11+ messages in thread From: Simon Horman @ 2019-03-27 12:02 UTC (permalink / raw) To: Laurent Pinchart; +Cc: Geert Uytterhoeven, Laurent Pinchart, Linux-Renesas On Mon, Mar 25, 2019 at 04:30:29AM +0200, Laurent Pinchart wrote: > Hi Simon, > > On Mon, Sep 17, 2018 at 09:10:42AM +0200, Simon Horman wrote: > > On Wed, Sep 12, 2018 at 01:59:53PM +0200, Geert Uytterhoeven wrote: > > > On Wed, Sep 12, 2018 at 12:25 PM Simon Horman <horms@verge.net.au> wrote: > > >> On Thu, Sep 06, 2018 at 12:59:20PM +0300, Laurent Pinchart wrote: > > >>> On Thursday, 6 September 2018 12:42:32 EEST Simon Horman wrote: > > >>>> On Thu, Aug 23, 2018 at 11:58:54AM +0200, Geert Uytterhoeven wrote: > > >>>>> On Sun, Aug 19, 2018 at 9:44 PM Laurent Pinchart wrote: > > >>>>>> The Salvator-X and XS boards have a 4 lines DIP switch and 3 push > > >>>>>> buttons connected to SoC GPIOs, meant to be used as general-purpose test > > >>>>>> keys. Add a corresponding node in DT, mapping (semi-randomly) the DIP > > >>>>>> switch to keys 1-4 and the push buttons to keys A-C. > > >>>>>> > > >>>>>> Signed-off-by: Laurent Pinchart > > >>>>>> <laurent.pinchart+renesas@ideasonboard.com> > > >>>>> > > >>>>> Given GP6_1[123] are not just wired to the 3 push buttons, but also to 3 > > >>>>> LEDs, I wonder if we shouldn't postpone that part until Linux can handle > > >>>>> GPIOs connected to both? > > >>>> > > >>>> Laurent, any thoughts on that? > > >>> > > >>> Right now the GPIOs are not wired in DT, and we're thus without a way to > > >>> interface to both LEDs and push buttons. While I agree that an ideal > > >>> solution would be to support both, I think that moving from nothing to > > >>> support for push buttons would be a step forward already. > > >> > > >> I tend to agree. Geert, what are your thoughts? > > > > > > Fine for me. > > > > > > Just one more bikeshedding question: what's most useful, buttons or LEDs? ;-) > > > > Lets go with the buttons. > > > > Applied for v4.20. > > Shouldn't it have made it to Linus' tree then ? :-) Sorry about that, it seems that I didn't apply it after all. I have done so now. ^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2019-03-27 12:02 UTC | newest] Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2018-08-19 19:44 [PATCH] arm64: dts: renesas: salvator-common: Add GPIO keys support Laurent Pinchart 2018-08-22 10:29 ` Simon Horman 2018-08-23 9:54 ` Geert Uytterhoeven 2018-08-23 9:58 ` Geert Uytterhoeven 2018-09-06 9:42 ` Simon Horman 2018-09-06 9:59 ` Laurent Pinchart 2018-09-12 10:25 ` Simon Horman 2018-09-12 11:59 ` Geert Uytterhoeven 2018-09-17 7:10 ` Simon Horman 2019-03-25 2:30 ` Laurent Pinchart 2019-03-27 12:02 ` Simon Horman
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).