* [PATCH v2 0/3] Update compat strings for SD/MMC nodes on RZ/{G2L (family), G3S, V2M} SoCs
@ 2024-04-23 18:24 Prabhakar
2024-04-23 18:24 ` [PATCH v2 1/3] dt-bindings: mmc: renesas,sdhi: Group single const value items into an enum list Prabhakar
` (2 more replies)
0 siblings, 3 replies; 11+ messages in thread
From: Prabhakar @ 2024-04-23 18:24 UTC (permalink / raw)
To: Geert Uytterhoeven, Ulf Hansson, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Magnus Damm, Wolfram Sang,
linux-mmc
Cc: devicetree, linux-kernel, linux-renesas-soc, Prabhakar, Biju Das,
Fabrizio Castro, Lad Prabhakar
From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Hi All,
- RZ/G2UL and RZ/Five ("r9a07g043")
- RZ/G2L(C) ("r9a07g044")
- RZ/V2L ("r9a07g054")
- RZ/G3S ("r9a08g045")
- RZ/V2M ("r9a09g011")
The SD/MMC Interface in the above listed SoCs is not identical to that of
R-Car Gen3. These SoCs have HS400 disabled and use fixed address mode.
Therefore, we need to apply fixed_addr_mode and hs400_disabled quirks.
'renesas,rzg2l-sdhi' is introduced as a generic compatible string for the
above SoCs where fixed_addr_mode and hs400_disabled quirks will be applied.
v1->v2
- Updated commit messages for patch #1 and #2
- Dropped SoC DTSI changes as its a hard dependency
- Grouped single const value items into an enum list.
- For backward compatibility retained RZ/V2M compat string
v1: https://patchwork.kernel.org/project/linux-renesas-soc/cover/20240422213006.505576-1-prabhakar.mahadev-lad.rj@bp.renesas.com/
Cheers,
Prabhakar
Lad Prabhakar (3):
dt-bindings: mmc: renesas,sdhi: Group single const value items into an
enum list
dt-bindings: mmc: renesas,sdhi: Document RZ/G2L family compatibility
mmc: renesas_sdhi: Add compatible string for RZ/G2L family, RZ/G3S,
and RZ/V2M SoCs
.../devicetree/bindings/mmc/renesas,sdhi.yaml | 38 ++++++++-----------
drivers/mmc/host/renesas_sdhi_internal_dmac.c | 9 +++--
2 files changed, 21 insertions(+), 26 deletions(-)
--
2.34.1
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH v2 1/3] dt-bindings: mmc: renesas,sdhi: Group single const value items into an enum list
2024-04-23 18:24 [PATCH v2 0/3] Update compat strings for SD/MMC nodes on RZ/{G2L (family), G3S, V2M} SoCs Prabhakar
@ 2024-04-23 18:24 ` Prabhakar
2024-04-24 5:42 ` Krzysztof Kozlowski
2024-04-23 18:24 ` [PATCH v2 2/3] dt-bindings: mmc: renesas,sdhi: Document RZ/G2L family compatibility Prabhakar
2024-04-23 18:24 ` [PATCH v2 3/3] mmc: renesas_sdhi: Add compatible string for RZ/G2L family, RZ/G3S, and RZ/V2M SoCs Prabhakar
2 siblings, 1 reply; 11+ messages in thread
From: Prabhakar @ 2024-04-23 18:24 UTC (permalink / raw)
To: Geert Uytterhoeven, Ulf Hansson, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Magnus Damm, Wolfram Sang,
linux-mmc
Cc: devicetree, linux-kernel, linux-renesas-soc, Prabhakar, Biju Das,
Fabrizio Castro, Lad Prabhakar
From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Group single const value items into an enum list.
Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
---
v1->v2
- Updated commit message
- Grouped single const value items into an enum list.
---
.../devicetree/bindings/mmc/renesas,sdhi.yaml | 18 +++++++-----------
1 file changed, 7 insertions(+), 11 deletions(-)
diff --git a/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml b/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml
index 29f2400247eb..2bf90095742b 100644
--- a/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml
+++ b/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml
@@ -13,15 +13,13 @@ properties:
compatible:
oneOf:
- items:
- - const: renesas,sdhi-sh73a0 # R-Mobile APE6
- - items:
- - const: renesas,sdhi-r7s72100 # RZ/A1H
- - items:
- - const: renesas,sdhi-r7s9210 # SH-Mobile AG5
- - items:
- - const: renesas,sdhi-r8a73a4 # R-Mobile APE6
- - items:
- - const: renesas,sdhi-r8a7740 # R-Mobile A1
+ - enum:
+ - renesas,sdhi-sh73a0 # R-Mobile APE6
+ - renesas,sdhi-r7s72100 # RZ/A1H
+ - renesas,sdhi-r7s9210 # SH-Mobile AG5
+ - renesas,sdhi-r8a73a4 # R-Mobile APE6
+ - renesas,sdhi-r8a7740 # R-Mobile A1
+ - renesas,sdhi-mmc-r8a77470 # RZ/G1C
- items:
- enum:
- renesas,sdhi-r8a7778 # R-Car M1
@@ -40,8 +38,6 @@ properties:
- renesas,sdhi-r8a7793 # R-Car M2-N
- renesas,sdhi-r8a7794 # R-Car E2
- const: renesas,rcar-gen2-sdhi # R-Car Gen2 and RZ/G1
- - items:
- - const: renesas,sdhi-mmc-r8a77470 # RZ/G1C (SDHI/MMC IP)
- items:
- enum:
- renesas,sdhi-r8a774a1 # RZ/G2M
--
2.34.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH v2 2/3] dt-bindings: mmc: renesas,sdhi: Document RZ/G2L family compatibility
2024-04-23 18:24 [PATCH v2 0/3] Update compat strings for SD/MMC nodes on RZ/{G2L (family), G3S, V2M} SoCs Prabhakar
2024-04-23 18:24 ` [PATCH v2 1/3] dt-bindings: mmc: renesas,sdhi: Group single const value items into an enum list Prabhakar
@ 2024-04-23 18:24 ` Prabhakar
2024-04-24 12:23 ` Geert Uytterhoeven
2024-04-23 18:24 ` [PATCH v2 3/3] mmc: renesas_sdhi: Add compatible string for RZ/G2L family, RZ/G3S, and RZ/V2M SoCs Prabhakar
2 siblings, 1 reply; 11+ messages in thread
From: Prabhakar @ 2024-04-23 18:24 UTC (permalink / raw)
To: Geert Uytterhoeven, Ulf Hansson, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Magnus Damm, Wolfram Sang,
linux-mmc
Cc: devicetree, linux-kernel, linux-renesas-soc, Prabhakar, Biju Das,
Fabrizio Castro, Lad Prabhakar, Krzysztof Kozlowski
From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
- RZ/G2UL and RZ/Five ("r9a07g043")
- RZ/G2L(C) ("r9a07g044")
- RZ/V2L ("r9a07g054")
- RZ/G3S ("r9a08g045")
- RZ/V2M ("r9a09g011")
The SD/MMC Interface in the above listed SoCs is not identical to that of
R-Car Gen3. These SoCs have HS400 disabled and use fixed address mode.
Therefore, we need to apply fixed_addr_mode and hs400_disabled quirks.
Document 'renesas,rzg2l-sdhi' as a generic compatible string for the
above SoCs.
Also now use the 'renesas,rzg2l-sdhi' string in the if check for making
sure the required clocks are present.
Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
v1->v2
- Collected the Ack
---
.../devicetree/bindings/mmc/renesas,sdhi.yaml | 20 +++++++++----------
1 file changed, 9 insertions(+), 11 deletions(-)
diff --git a/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml b/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml
index 2bf90095742b..afc2652fa6c8 100644
--- a/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml
+++ b/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml
@@ -52,11 +52,6 @@ properties:
- renesas,sdhi-r8a77980 # R-Car V3H
- renesas,sdhi-r8a77990 # R-Car E3
- renesas,sdhi-r8a77995 # R-Car D3
- - renesas,sdhi-r9a07g043 # RZ/G2UL and RZ/Five
- - renesas,sdhi-r9a07g044 # RZ/G2{L,LC}
- - renesas,sdhi-r9a07g054 # RZ/V2L
- - renesas,sdhi-r9a08g045 # RZ/G3S
- - renesas,sdhi-r9a09g011 # RZ/V2M
- const: renesas,rcar-gen3-sdhi # R-Car Gen3 or RZ/G2
- items:
- enum:
@@ -65,6 +60,14 @@ properties:
- renesas,sdhi-r8a779g0 # R-Car V4H
- renesas,sdhi-r8a779h0 # R-Car V4M
- const: renesas,rcar-gen4-sdhi # R-Car Gen4
+ - items:
+ - enum:
+ - renesas,sdhi-r9a07g043 # RZ/G2UL and RZ/Five
+ - renesas,sdhi-r9a07g044 # RZ/G2{L,LC}
+ - renesas,sdhi-r9a07g054 # RZ/V2L
+ - renesas,sdhi-r9a08g045 # RZ/G3S
+ - renesas,sdhi-r9a09g011 # RZ/V2M
+ - const: renesas,rzg2l-sdhi
reg:
maxItems: 1
@@ -116,12 +119,7 @@ allOf:
properties:
compatible:
contains:
- enum:
- - renesas,sdhi-r9a07g043
- - renesas,sdhi-r9a07g044
- - renesas,sdhi-r9a07g054
- - renesas,sdhi-r9a08g045
- - renesas,sdhi-r9a09g011
+ const: renesas,rzg2l-sdhi
then:
properties:
clocks:
--
2.34.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH v2 3/3] mmc: renesas_sdhi: Add compatible string for RZ/G2L family, RZ/G3S, and RZ/V2M SoCs
2024-04-23 18:24 [PATCH v2 0/3] Update compat strings for SD/MMC nodes on RZ/{G2L (family), G3S, V2M} SoCs Prabhakar
2024-04-23 18:24 ` [PATCH v2 1/3] dt-bindings: mmc: renesas,sdhi: Group single const value items into an enum list Prabhakar
2024-04-23 18:24 ` [PATCH v2 2/3] dt-bindings: mmc: renesas,sdhi: Document RZ/G2L family compatibility Prabhakar
@ 2024-04-23 18:24 ` Prabhakar
2024-04-24 12:25 ` Geert Uytterhoeven
2 siblings, 1 reply; 11+ messages in thread
From: Prabhakar @ 2024-04-23 18:24 UTC (permalink / raw)
To: Geert Uytterhoeven, Ulf Hansson, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Magnus Damm, Wolfram Sang,
linux-mmc
Cc: devicetree, linux-kernel, linux-renesas-soc, Prabhakar, Biju Das,
Fabrizio Castro, Lad Prabhakar
From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
- RZ/G2UL and RZ/Five ("r9a07g043")
- RZ/G2L(C) ("r9a07g044")
- RZ/V2L ("r9a07g054")
- RZ/G3S ("r9a08g045")
- RZ/V2M ("r9a09g011")
The above SoCs have HS400 disabled and use fixed address mode. Add a
generic compatible 'renesas,rzg2l-sdhi' fallback string for these SoCs,
where fixed_addr_mode and hs400_disabled quirks are applied.
For backward compatibility, compatible string 'renesas,sdhi-r9a09g011' for
RZ/V2M is retained.
Also rename sdhi_quirks_r9a09g011->sdhi_quirks_rzg2l and
of_r9a09g011_compatible->of_rzg2l_compatible to make it generic.
Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
---
v1->v2
- Updated commit message
- For backward compatibility retained RZ/V2M compat string
---
drivers/mmc/host/renesas_sdhi_internal_dmac.c | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/mmc/host/renesas_sdhi_internal_dmac.c b/drivers/mmc/host/renesas_sdhi_internal_dmac.c
index 53d34c3eddce..422fa63a2e99 100644
--- a/drivers/mmc/host/renesas_sdhi_internal_dmac.c
+++ b/drivers/mmc/host/renesas_sdhi_internal_dmac.c
@@ -210,7 +210,7 @@ static const struct renesas_sdhi_quirks sdhi_quirks_r8a77990 = {
.manual_tap_correction = true,
};
-static const struct renesas_sdhi_quirks sdhi_quirks_r9a09g011 = {
+static const struct renesas_sdhi_quirks sdhi_quirks_rzg2l = {
.fixed_addr_mode = true,
.hs400_disabled = true,
};
@@ -255,9 +255,9 @@ static const struct renesas_sdhi_of_data_with_quirks of_r8a77990_compatible = {
.quirks = &sdhi_quirks_r8a77990,
};
-static const struct renesas_sdhi_of_data_with_quirks of_r9a09g011_compatible = {
+static const struct renesas_sdhi_of_data_with_quirks of_rzg2l_compatible = {
.of_data = &of_data_rcar_gen3,
- .quirks = &sdhi_quirks_r9a09g011,
+ .quirks = &sdhi_quirks_rzg2l,
};
static const struct renesas_sdhi_of_data_with_quirks of_rcar_gen3_compatible = {
@@ -283,7 +283,8 @@ static const struct of_device_id renesas_sdhi_internal_dmac_of_match[] = {
{ .compatible = "renesas,sdhi-r8a77970", .data = &of_r8a77970_compatible, },
{ .compatible = "renesas,sdhi-r8a77990", .data = &of_r8a77990_compatible, },
{ .compatible = "renesas,sdhi-r8a77995", .data = &of_rcar_gen3_nohs400_compatible, },
- { .compatible = "renesas,sdhi-r9a09g011", .data = &of_r9a09g011_compatible, },
+ { .compatible = "renesas,sdhi-r9a09g011", .data = &of_rzg2l_compatible, },
+ { .compatible = "renesas,rzg2l-sdhi", .data = &of_rzg2l_compatible, },
{ .compatible = "renesas,rcar-gen3-sdhi", .data = &of_rcar_gen3_compatible, },
{ .compatible = "renesas,rcar-gen4-sdhi", .data = &of_rcar_gen3_compatible, },
{},
--
2.34.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH v2 1/3] dt-bindings: mmc: renesas,sdhi: Group single const value items into an enum list
2024-04-23 18:24 ` [PATCH v2 1/3] dt-bindings: mmc: renesas,sdhi: Group single const value items into an enum list Prabhakar
@ 2024-04-24 5:42 ` Krzysztof Kozlowski
2024-04-25 15:43 ` Lad, Prabhakar
0 siblings, 1 reply; 11+ messages in thread
From: Krzysztof Kozlowski @ 2024-04-24 5:42 UTC (permalink / raw)
To: Prabhakar, Geert Uytterhoeven, Ulf Hansson, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Magnus Damm, Wolfram Sang,
linux-mmc
Cc: devicetree, linux-kernel, linux-renesas-soc, Biju Das,
Fabrizio Castro, Lad Prabhakar
On 23/04/2024 20:24, Prabhakar wrote:
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>
> Group single const value items into an enum list.
>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> ---
> v1->v2
> - Updated commit message
> - Grouped single const value items into an enum list.
> ---
> .../devicetree/bindings/mmc/renesas,sdhi.yaml | 18 +++++++-----------
> 1 file changed, 7 insertions(+), 11 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml b/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml
> index 29f2400247eb..2bf90095742b 100644
> --- a/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml
> +++ b/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml
> @@ -13,15 +13,13 @@ properties:
> compatible:
> oneOf:
> - items:
> - - const: renesas,sdhi-sh73a0 # R-Mobile APE6
> - - items:
> - - const: renesas,sdhi-r7s72100 # RZ/A1H
> - - items:
> - - const: renesas,sdhi-r7s9210 # SH-Mobile AG5
> - - items:
> - - const: renesas,sdhi-r8a73a4 # R-Mobile APE6
> - - items:
> - - const: renesas,sdhi-r8a7740 # R-Mobile A1
> + - enum:
You wanted to drop the items, but I still see it here.
> + - renesas,sdhi-sh73a0 # R-Mobile APE6
> + - renesas,sdhi-r7s72100 # RZ/A1H
> + - renesas,sdhi-r7s9210 # SH-Mobile AG5
> + - renesas,sdhi-r8a73a4 # R-Mobile APE6
> + - renesas,sdhi-r8a7740 # R-Mobile A1
> + - renesas,sdhi-mmc-r8a77470 # RZ/G1C
Keep list alphabetically ordered.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2 2/3] dt-bindings: mmc: renesas,sdhi: Document RZ/G2L family compatibility
2024-04-23 18:24 ` [PATCH v2 2/3] dt-bindings: mmc: renesas,sdhi: Document RZ/G2L family compatibility Prabhakar
@ 2024-04-24 12:23 ` Geert Uytterhoeven
0 siblings, 0 replies; 11+ messages in thread
From: Geert Uytterhoeven @ 2024-04-24 12:23 UTC (permalink / raw)
To: Prabhakar
Cc: Ulf Hansson, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Magnus Damm, Wolfram Sang, linux-mmc, devicetree, linux-kernel,
linux-renesas-soc, Biju Das, Fabrizio Castro, Lad Prabhakar,
Krzysztof Kozlowski
On Tue, Apr 23, 2024 at 8:24 PM Prabhakar <prabhakar.csengg@gmail.com> wrote:
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>
> - RZ/G2UL and RZ/Five ("r9a07g043")
> - RZ/G2L(C) ("r9a07g044")
> - RZ/V2L ("r9a07g054")
> - RZ/G3S ("r9a08g045")
> - RZ/V2M ("r9a09g011")
>
> The SD/MMC Interface in the above listed SoCs is not identical to that of
> R-Car Gen3. These SoCs have HS400 disabled and use fixed address mode.
> Therefore, we need to apply fixed_addr_mode and hs400_disabled quirks.
>
> Document 'renesas,rzg2l-sdhi' as a generic compatible string for the
> above SoCs.
>
> Also now use the 'renesas,rzg2l-sdhi' string in the if check for making
> sure the required clocks are present.
>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> v1->v2
> - Collected the Ack
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2 3/3] mmc: renesas_sdhi: Add compatible string for RZ/G2L family, RZ/G3S, and RZ/V2M SoCs
2024-04-23 18:24 ` [PATCH v2 3/3] mmc: renesas_sdhi: Add compatible string for RZ/G2L family, RZ/G3S, and RZ/V2M SoCs Prabhakar
@ 2024-04-24 12:25 ` Geert Uytterhoeven
0 siblings, 0 replies; 11+ messages in thread
From: Geert Uytterhoeven @ 2024-04-24 12:25 UTC (permalink / raw)
To: Prabhakar
Cc: Ulf Hansson, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Magnus Damm, Wolfram Sang, linux-mmc, devicetree, linux-kernel,
linux-renesas-soc, Biju Das, Fabrizio Castro, Lad Prabhakar
On Tue, Apr 23, 2024 at 8:24 PM Prabhakar <prabhakar.csengg@gmail.com> wrote:
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>
> - RZ/G2UL and RZ/Five ("r9a07g043")
> - RZ/G2L(C) ("r9a07g044")
> - RZ/V2L ("r9a07g054")
> - RZ/G3S ("r9a08g045")
> - RZ/V2M ("r9a09g011")
>
> The above SoCs have HS400 disabled and use fixed address mode. Add a
> generic compatible 'renesas,rzg2l-sdhi' fallback string for these SoCs,
> where fixed_addr_mode and hs400_disabled quirks are applied.
>
> For backward compatibility, compatible string 'renesas,sdhi-r9a09g011' for
> RZ/V2M is retained.
>
> Also rename sdhi_quirks_r9a09g011->sdhi_quirks_rzg2l and
> of_r9a09g011_compatible->of_rzg2l_compatible to make it generic.
>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> ---
> v1->v2
> - Updated commit message
> - For backward compatibility retained RZ/V2M compat string
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2 1/3] dt-bindings: mmc: renesas,sdhi: Group single const value items into an enum list
2024-04-24 5:42 ` Krzysztof Kozlowski
@ 2024-04-25 15:43 ` Lad, Prabhakar
2024-04-25 17:11 ` Geert Uytterhoeven
0 siblings, 1 reply; 11+ messages in thread
From: Lad, Prabhakar @ 2024-04-25 15:43 UTC (permalink / raw)
To: Krzysztof Kozlowski, Geert Uytterhoeven
Cc: Ulf Hansson, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Magnus Damm, Wolfram Sang, linux-mmc, devicetree, linux-kernel,
linux-renesas-soc, Biju Das, Fabrizio Castro, Lad Prabhakar
Hi Krzysztof,
Thank you for the review.
On Wed, Apr 24, 2024 at 6:42 AM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> On 23/04/2024 20:24, Prabhakar wrote:
> > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> >
> > Group single const value items into an enum list.
> >
> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> > ---
> > v1->v2
> > - Updated commit message
> > - Grouped single const value items into an enum list.
> > ---
> > .../devicetree/bindings/mmc/renesas,sdhi.yaml | 18 +++++++-----------
> > 1 file changed, 7 insertions(+), 11 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml b/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml
> > index 29f2400247eb..2bf90095742b 100644
> > --- a/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml
> > +++ b/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml
> > @@ -13,15 +13,13 @@ properties:
> > compatible:
> > oneOf:
> > - items:
> > - - const: renesas,sdhi-sh73a0 # R-Mobile APE6
> > - - items:
> > - - const: renesas,sdhi-r7s72100 # RZ/A1H
> > - - items:
> > - - const: renesas,sdhi-r7s9210 # SH-Mobile AG5
> > - - items:
> > - - const: renesas,sdhi-r8a73a4 # R-Mobile APE6
> > - - items:
> > - - const: renesas,sdhi-r8a7740 # R-Mobile A1
> > + - enum:
>
> You wanted to drop the items, but I still see it here.
>
Ah, I missed that.
> > + - renesas,sdhi-sh73a0 # R-Mobile APE6
> > + - renesas,sdhi-r7s72100 # RZ/A1H
> > + - renesas,sdhi-r7s9210 # SH-Mobile AG5
> > + - renesas,sdhi-r8a73a4 # R-Mobile APE6
> > + - renesas,sdhi-r8a7740 # R-Mobile A1
> > + - renesas,sdhi-mmc-r8a77470 # RZ/G1C
>
> Keep list alphabetically ordered.
>
This list is sorted based on SoC, I will sort it alphabetically.
Geert is that OK with you?
Cheers,
Prabhakar
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2 1/3] dt-bindings: mmc: renesas,sdhi: Group single const value items into an enum list
2024-04-25 15:43 ` Lad, Prabhakar
@ 2024-04-25 17:11 ` Geert Uytterhoeven
2024-04-25 18:35 ` Krzysztof Kozlowski
2024-04-25 18:54 ` Lad, Prabhakar
0 siblings, 2 replies; 11+ messages in thread
From: Geert Uytterhoeven @ 2024-04-25 17:11 UTC (permalink / raw)
To: Lad, Prabhakar
Cc: Krzysztof Kozlowski, Geert Uytterhoeven, Ulf Hansson,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Magnus Damm,
Wolfram Sang, linux-mmc, devicetree, linux-kernel,
linux-renesas-soc, Biju Das, Fabrizio Castro, Lad Prabhakar
Hi Prabhakar,
On Thu, Apr 25, 2024 at 5:44 PM Lad, Prabhakar
<prabhakar.csengg@gmail.com> wrote:
> On Wed, Apr 24, 2024 at 6:42 AM Krzysztof Kozlowski <krzk@kernel.org> wrote:
> > On 23/04/2024 20:24, Prabhakar wrote:
> > > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> > >
> > > Group single const value items into an enum list.
> > >
> > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> > > ---
> > > v1->v2
> > > - Updated commit message
> > > - Grouped single const value items into an enum list.
> > > ---
> > > .../devicetree/bindings/mmc/renesas,sdhi.yaml | 18 +++++++-----------
> > > 1 file changed, 7 insertions(+), 11 deletions(-)
> > >
> > > diff --git a/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml b/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml
> > > index 29f2400247eb..2bf90095742b 100644
> > > --- a/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml
> > > +++ b/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml
> > > @@ -13,15 +13,13 @@ properties:
> > > compatible:
> > > oneOf:
> > > - items:
> > > - - const: renesas,sdhi-sh73a0 # R-Mobile APE6
> > > - - items:
> > > - - const: renesas,sdhi-r7s72100 # RZ/A1H
> > > - - items:
> > > - - const: renesas,sdhi-r7s9210 # SH-Mobile AG5
> > > - - items:
> > > - - const: renesas,sdhi-r8a73a4 # R-Mobile APE6
> > > - - items:
> > > - - const: renesas,sdhi-r8a7740 # R-Mobile A1
> > > + - enum:
> >
> > You wanted to drop the items, but I still see it here.
> >
> Ah, I missed that.
>
> > > + - renesas,sdhi-sh73a0 # R-Mobile APE6
> > > + - renesas,sdhi-r7s72100 # RZ/A1H
> > > + - renesas,sdhi-r7s9210 # SH-Mobile AG5
> > > + - renesas,sdhi-r8a73a4 # R-Mobile APE6
> > > + - renesas,sdhi-r8a7740 # R-Mobile A1
> > > + - renesas,sdhi-mmc-r8a77470 # RZ/G1C
> >
> > Keep list alphabetically ordered.
> >
> This list is sorted based on SoC, I will sort it alphabetically.
>
> Geert is that OK with you?
Usually we sort alphabetically by compatible value.
(FTR, sh73a0 is sometimes called r8a73a0).
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2 1/3] dt-bindings: mmc: renesas,sdhi: Group single const value items into an enum list
2024-04-25 17:11 ` Geert Uytterhoeven
@ 2024-04-25 18:35 ` Krzysztof Kozlowski
2024-04-25 18:54 ` Lad, Prabhakar
1 sibling, 0 replies; 11+ messages in thread
From: Krzysztof Kozlowski @ 2024-04-25 18:35 UTC (permalink / raw)
To: Geert Uytterhoeven, Lad, Prabhakar
Cc: Geert Uytterhoeven, Ulf Hansson, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Magnus Damm, Wolfram Sang,
linux-mmc, devicetree, linux-kernel, linux-renesas-soc, Biju Das,
Fabrizio Castro, Lad Prabhakar
On 25/04/2024 19:11, Geert Uytterhoeven wrote:
>>
>>>> + - renesas,sdhi-sh73a0 # R-Mobile APE6
>>>> + - renesas,sdhi-r7s72100 # RZ/A1H
>>>> + - renesas,sdhi-r7s9210 # SH-Mobile AG5
>>>> + - renesas,sdhi-r8a73a4 # R-Mobile APE6
>>>> + - renesas,sdhi-r8a7740 # R-Mobile A1
>>>> + - renesas,sdhi-mmc-r8a77470 # RZ/G1C
>>>
>>> Keep list alphabetically ordered.
>>>
>> This list is sorted based on SoC, I will sort it alphabetically.
>>
>> Geert is that OK with you?
>
> Usually we sort alphabetically by compatible value.
BTW, it is also fine if you keep some other sorting rule there, which is
in general known to interested parties. Although I would argue that most
people adding new entries are not aware of such rules, thus they add
things to the end increasing the chances for conflicts.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2 1/3] dt-bindings: mmc: renesas,sdhi: Group single const value items into an enum list
2024-04-25 17:11 ` Geert Uytterhoeven
2024-04-25 18:35 ` Krzysztof Kozlowski
@ 2024-04-25 18:54 ` Lad, Prabhakar
1 sibling, 0 replies; 11+ messages in thread
From: Lad, Prabhakar @ 2024-04-25 18:54 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Krzysztof Kozlowski, Geert Uytterhoeven, Ulf Hansson,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Magnus Damm,
Wolfram Sang, linux-mmc, devicetree, linux-kernel,
linux-renesas-soc, Biju Das, Fabrizio Castro, Lad Prabhakar
Hi Geert,
On Thu, Apr 25, 2024 at 6:11 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
>
> Hi Prabhakar,
>
> On Thu, Apr 25, 2024 at 5:44 PM Lad, Prabhakar
> <prabhakar.csengg@gmail.com> wrote:
> > On Wed, Apr 24, 2024 at 6:42 AM Krzysztof Kozlowski <krzk@kernel.org> wrote:
> > > On 23/04/2024 20:24, Prabhakar wrote:
> > > > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> > > >
> > > > Group single const value items into an enum list.
> > > >
> > > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> > > > ---
> > > > v1->v2
> > > > - Updated commit message
> > > > - Grouped single const value items into an enum list.
> > > > ---
> > > > .../devicetree/bindings/mmc/renesas,sdhi.yaml | 18 +++++++-----------
> > > > 1 file changed, 7 insertions(+), 11 deletions(-)
> > > >
> > > > diff --git a/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml b/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml
> > > > index 29f2400247eb..2bf90095742b 100644
> > > > --- a/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml
> > > > +++ b/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml
> > > > @@ -13,15 +13,13 @@ properties:
> > > > compatible:
> > > > oneOf:
> > > > - items:
> > > > - - const: renesas,sdhi-sh73a0 # R-Mobile APE6
> > > > - - items:
> > > > - - const: renesas,sdhi-r7s72100 # RZ/A1H
> > > > - - items:
> > > > - - const: renesas,sdhi-r7s9210 # SH-Mobile AG5
> > > > - - items:
> > > > - - const: renesas,sdhi-r8a73a4 # R-Mobile APE6
> > > > - - items:
> > > > - - const: renesas,sdhi-r8a7740 # R-Mobile A1
> > > > + - enum:
> > >
> > > You wanted to drop the items, but I still see it here.
> > >
> > Ah, I missed that.
> >
> > > > + - renesas,sdhi-sh73a0 # R-Mobile APE6
> > > > + - renesas,sdhi-r7s72100 # RZ/A1H
> > > > + - renesas,sdhi-r7s9210 # SH-Mobile AG5
> > > > + - renesas,sdhi-r8a73a4 # R-Mobile APE6
> > > > + - renesas,sdhi-r8a7740 # R-Mobile A1
> > > > + - renesas,sdhi-mmc-r8a77470 # RZ/G1C
> > >
> > > Keep list alphabetically ordered.
> > >
> > This list is sorted based on SoC, I will sort it alphabetically.
> >
> > Geert is that OK with you?
>
> Usually we sort alphabetically by compatible value.
>
Thank you for the confirmation.
> (FTR, sh73a0 is sometimes called r8a73a0).
>
Got that.
Cheers,
Prabhakar
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2024-04-25 18:55 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-04-23 18:24 [PATCH v2 0/3] Update compat strings for SD/MMC nodes on RZ/{G2L (family), G3S, V2M} SoCs Prabhakar
2024-04-23 18:24 ` [PATCH v2 1/3] dt-bindings: mmc: renesas,sdhi: Group single const value items into an enum list Prabhakar
2024-04-24 5:42 ` Krzysztof Kozlowski
2024-04-25 15:43 ` Lad, Prabhakar
2024-04-25 17:11 ` Geert Uytterhoeven
2024-04-25 18:35 ` Krzysztof Kozlowski
2024-04-25 18:54 ` Lad, Prabhakar
2024-04-23 18:24 ` [PATCH v2 2/3] dt-bindings: mmc: renesas,sdhi: Document RZ/G2L family compatibility Prabhakar
2024-04-24 12:23 ` Geert Uytterhoeven
2024-04-23 18:24 ` [PATCH v2 3/3] mmc: renesas_sdhi: Add compatible string for RZ/G2L family, RZ/G3S, and RZ/V2M SoCs Prabhakar
2024-04-24 12:25 ` Geert Uytterhoeven
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).