* [GIT PULL] clk: renesas: Updates for v5.8
@ 2020-04-30 8:49 Geert Uytterhoeven
2020-05-05 19:32 ` Stephen Boyd
0 siblings, 1 reply; 3+ messages in thread
From: Geert Uytterhoeven @ 2020-04-30 8:49 UTC (permalink / raw)
To: Michael Turquette, Stephen Boyd
Cc: linux-clk, linux-renesas-soc, Geert Uytterhoeven
Hi Mike, Stephen,
The following changes since commit 8f3d9f354286745c751374f5f1fcafee6b3f3136:
Linux 5.7-rc1 (2020-04-12 12:35:55 -0700)
are available in the Git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/geert/renesas-drivers.git tags/clk-renesas-for-v5.8-tag1
for you to fetch changes up to e2f022c10ed3b50ba1d2bb1f037b0e7a84cb1c3e:
clk: renesas: rcar-gen2: Remove superfluous CLK_RENESAS_DIV6 selects (2020-04-30 09:39:06 +0200)
----------------------------------------------------------------
clk: renesas: Updates for v5.8
- Add support for the USB 2.0 clock selector on R-Car M3-W+,
- Add support for the new RZ/G1H (R8A7742) SoC,
- Minor fixes and cleanups.
Note that the new Renesas RZ/G1H DT Binding Definitions are shared by
driver and DT source files, and thus included in multiple pull requests:
- "[GIT PULL 4/5] Renesas driver updates for v5.8" (for arm-soc),
- "[GIT PULL] clk: renesas: Updates for v5.8" (for clk).
Thanks for pulling!
----------------------------------------------------------------
Christophe JAILLET (1):
clk: renesas: r9a06g032: Fix some typo in comments
Geert Uytterhoeven (3):
MAINTAINERS: Add DT Bindings for Renesas Clock Generators
Merge tag 'renesas-r8a7742-dt-binding-defs-tag' into clk-renesas-for-v5.8
clk: renesas: rcar-gen2: Remove superfluous CLK_RENESAS_DIV6 selects
Lad Prabhakar (4):
dt-bindings: power: rcar-sysc: Add r8a7742 power domain index macros
clk: renesas: Add r8a7742 CPG Core Clock Definitions
dt-bindings: clock: renesas: cpg-mssr: Document r8a7742 binding
clk: renesas: cpg-mssr: Add R8A7742 support
Yoshihiro Shimoda (1):
dt-bindings: clock: renesas: rcar-usb2-clock-sel: Add r8a77961 support
.../bindings/clock/renesas,cpg-mssr.yaml | 1 +
.../bindings/clock/renesas,rcar-usb2-clock-sel.txt | 4 +-
MAINTAINERS | 1 +
drivers/clk/renesas/Kconfig | 8 +-
drivers/clk/renesas/Makefile | 1 +
drivers/clk/renesas/r8a7742-cpg-mssr.c | 275 +++++++++++++++++++++
drivers/clk/renesas/r9a06g032-clocks.c | 6 +-
drivers/clk/renesas/renesas-cpg-mssr.c | 6 +
drivers/clk/renesas/renesas-cpg-mssr.h | 1 +
include/dt-bindings/clock/r8a7742-cpg-mssr.h | 42 ++++
include/dt-bindings/power/r8a7742-sysc.h | 29 +++
11 files changed, 367 insertions(+), 7 deletions(-)
create mode 100644 drivers/clk/renesas/r8a7742-cpg-mssr.c
create mode 100644 include/dt-bindings/clock/r8a7742-cpg-mssr.h
create mode 100644 include/dt-bindings/power/r8a7742-sysc.h
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [GIT PULL] clk: renesas: Updates for v5.8
2020-04-30 8:49 [GIT PULL] clk: renesas: Updates for v5.8 Geert Uytterhoeven
@ 2020-05-05 19:32 ` Stephen Boyd
2020-05-06 7:35 ` Geert Uytterhoeven
0 siblings, 1 reply; 3+ messages in thread
From: Stephen Boyd @ 2020-05-05 19:32 UTC (permalink / raw)
To: Geert Uytterhoeven, Michael Turquette
Cc: linux-clk, linux-renesas-soc, Geert Uytterhoeven
Quoting Geert Uytterhoeven (2020-04-30 01:49:02)
> Hi Mike, Stephen,
>
> The following changes since commit 8f3d9f354286745c751374f5f1fcafee6b3f3136:
>
> Linux 5.7-rc1 (2020-04-12 12:35:55 -0700)
>
> are available in the Git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/geert/renesas-drivers.git tags/clk-renesas-for-v5.8-tag1
>
> for you to fetch changes up to e2f022c10ed3b50ba1d2bb1f037b0e7a84cb1c3e:
>
> clk: renesas: rcar-gen2: Remove superfluous CLK_RENESAS_DIV6 selects (2020-04-30 09:39:06 +0200)
>
> ----------------------------------------------------------------
Thanks. Pulled into clk-next
I see these warnings with smatch. Is it a real problem?
drivers/clk/renesas/renesas-cpg-mssr.c:851
cpg_mssr_resume_noirq() error: buffer overflow 'stbcr' 11 <= 11
drivers/clk/renesas/renesas-cpg-mssr.c:860
cpg_mssr_resume_noirq() error: buffer overflow 'stbcr' 11 <= 11
clk/renesas/renesas-cpg-mssr.c:862
cpg_mssr_resume_noirq() error: buffer overflow 'stbcr' 11 <= 11
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [GIT PULL] clk: renesas: Updates for v5.8
2020-05-05 19:32 ` Stephen Boyd
@ 2020-05-06 7:35 ` Geert Uytterhoeven
0 siblings, 0 replies; 3+ messages in thread
From: Geert Uytterhoeven @ 2020-05-06 7:35 UTC (permalink / raw)
To: Stephen Boyd; +Cc: Michael Turquette, linux-clk, Linux-Renesas
Hi Stephen,
On Tue, May 5, 2020 at 9:32 PM Stephen Boyd <sboyd@kernel.org> wrote:
> Quoting Geert Uytterhoeven (2020-04-30 01:49:02)
> > The following changes since commit 8f3d9f354286745c751374f5f1fcafee6b3f3136:
> >
> > Linux 5.7-rc1 (2020-04-12 12:35:55 -0700)
> >
> > are available in the Git repository at:
> >
> > git://git.kernel.org/pub/scm/linux/kernel/git/geert/renesas-drivers.git tags/clk-renesas-for-v5.8-tag1
> >
> > for you to fetch changes up to e2f022c10ed3b50ba1d2bb1f037b0e7a84cb1c3e:
> >
> > clk: renesas: rcar-gen2: Remove superfluous CLK_RENESAS_DIV6 selects (2020-04-30 09:39:06 +0200)
> >
> > ----------------------------------------------------------------
>
> Thanks. Pulled into clk-next
Thanks!
> I see these warnings with smatch. Is it a real problem?
>
> drivers/clk/renesas/renesas-cpg-mssr.c:851
> cpg_mssr_resume_noirq() error: buffer overflow 'stbcr' 11 <= 11
> drivers/clk/renesas/renesas-cpg-mssr.c:860
> cpg_mssr_resume_noirq() error: buffer overflow 'stbcr' 11 <= 11
> clk/renesas/renesas-cpg-mssr.c:862
> cpg_mssr_resume_noirq() error: buffer overflow 'stbcr' 11 <= 11
Hmm, just installed smatch, and gave it a try, but I don't see that error:
$ make C=1 CHECK="smatch -p=kernel" drivers/clk/renesas/renesas-cpg-mssr.o
...
CHECK drivers/clk/renesas/renesas-cpg-mssr.c
drivers/clk/renesas/renesas-cpg-mssr.c:378
cpg_mssr_register_core_clk() warn: passing zero to 'PTR_ERR'
(that one is harmless)
The buffer overflows can't really happen: cpg_mssr_resume_noirq() indeed
restores up to 12 registers, while there are only 11 STBCRs, but the
check below makes sure any unused registers are not restored:
mask = priv->smstpcr_saved[reg].mask;
if (!mask)
continue;
However, unlike cpg_mssr_resume_noirq(), cpg_mssr_suspend_noirq() does
not take into account systems with STBCRs instead of MSTPCRs, which is a
real bug. But even that bug cannot happen, as the suspend/resume code
is used on PSCI systems only, and systems with STBCRs (RZ/A1 and RZ/A2)
do not use PSCI.
I will fix the bug, to prevent us getting bitten on future systems.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-05-06 7:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-30 8:49 [GIT PULL] clk: renesas: Updates for v5.8 Geert Uytterhoeven
2020-05-05 19:32 ` Stephen Boyd
2020-05-06 7:35 ` Geert Uytterhoeven
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).