[PATCH v2 0/4] arm64: dts: renesas: Add R-Car S4 Starter Kit support

[PATCH v2 0/4] arm64: dts: renesas: Add R-Car S4 Starter Kit support

[Kuninori Morimoto]

Hi Geert

This patch-set is v2 of R-Car S4 Starter Kit support.
It needs Rswitch bug fix patch [1] which was posted to Ether ML.
I hope it will be accepted for v6.6 Kernel.

[1] Link: https://lore.kernel.org/r/20230925003416.3863560-1-yoshihiro.shimoda.uh@renesas.com

S4 Starter Kit is possible to setup details via config exe,
but the DT will be more complex. This DT is assuming "default" settings
to avoid confusion.

R-Car S4 Starter Kit is using new R8A779F4 SoC which is updated version
of R8A779F0. This patch adds new r8a779f4.dtsi file but is using existing
r8a779f0.dtsi internally.

v1 -> v2
	- correct board name
	- removed BSP specific device
	- alphabetical order
	- add missing compatibles
	- add new r8a779f4.dtsi

Kuninori Morimoto (4):
  dt-bindings: irqchip: renesas,irqc: Add r8a779f0 support
  dt-bindings: soc: renesas: renesas.yaml: Add renesas,s4sk compatible
  arm64: dts: renesas: Add Renesas R8A779F4 SoC support
  arm64: dts: renesas: Add R-Car S4 Starter Kit support

 .../interrupt-controller/renesas,irqc.yaml    |   1 +
 .../bindings/soc/renesas/renesas.yaml         |   1 +
 arch/arm64/boot/dts/renesas/Makefile          |   1 +
 arch/arm64/boot/dts/renesas/r8a779f4-s4sk.dts | 243 ++++++++++++++++++
 arch/arm64/boot/dts/renesas/r8a779f4.dtsi     |  12 +
 5 files changed, 258 insertions(+)
 create mode 100644 arch/arm64/boot/dts/renesas/r8a779f4-s4sk.dts
 create mode 100644 arch/arm64/boot/dts/renesas/r8a779f4.dtsi

-- 
2.25.1

[PATCH v2 1/4] dt-bindings: irqchip: renesas,irqc: Add r8a779f0 support

[Kuninori Morimoto]

Document support for the Interrupt Controller for External Devices
(INT-EX) in the Renesas R-Car S4 (R8A779F0) SoC.

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
 .../devicetree/bindings/interrupt-controller/renesas,irqc.yaml   | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/interrupt-controller/renesas,irqc.yaml b/Documentation/devicetree/bindings/interrupt-controller/renesas,irqc.yaml
index 95033cb514fb..b1f3e7d7b88c 100644
--- a/Documentation/devicetree/bindings/interrupt-controller/renesas,irqc.yaml
+++ b/Documentation/devicetree/bindings/interrupt-controller/renesas,irqc.yaml
@@ -37,6 +37,7 @@ properties:
           - renesas,intc-ex-r8a77990    # R-Car E3
           - renesas,intc-ex-r8a77995    # R-Car D3
           - renesas,intc-ex-r8a779a0    # R-Car V3U
+          - renesas,intc-ex-r8a779f0    # R-Car S4
           - renesas,intc-ex-r8a779g0    # R-Car V4H
       - const: renesas,irqc
 
-- 
2.25.1

[PATCH v2 2/4] dt-bindings: soc: renesas: renesas.yaml: Add renesas,s4sk compatible

[Kuninori Morimoto]

This patch adds "renesas,s4sk" which target the R-Car S4 Starter Kit
board.

Signed-off-by: Yusuke Goda <yusuke.goda.sx@renesas.com>
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
 Documentation/devicetree/bindings/soc/renesas/renesas.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/soc/renesas/renesas.yaml b/Documentation/devicetree/bindings/soc/renesas/renesas.yaml
index 53b95f348f8e..9e8ad803b46f 100644
--- a/Documentation/devicetree/bindings/soc/renesas/renesas.yaml
+++ b/Documentation/devicetree/bindings/soc/renesas/renesas.yaml
@@ -327,6 +327,7 @@ properties:
         items:
           - enum:
               - renesas,spider-cpu # Spider CPU board (RTP8A779F0ASKB0SC2S)
+              - renesas,s4sk       # R-Car S4 Starter Kit board (Y-ASK-RCAR-S4-1000BASE-T#WS12)
           - const: renesas,r8a779f0
 
       - items:
-- 
2.25.1

[PATCH v2 3/4] arm64: dts: renesas: Add Renesas R8A779F4 SoC support

[Kuninori Morimoto]

R8A779F4 is update version of R8A779F0.
This patch adds its support, but is using r8a7799f0 dtsi internally.

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
 arch/arm64/boot/dts/renesas/r8a779f4.dtsi | 12 ++++++++++++
 1 file changed, 12 insertions(+)
 create mode 100644 arch/arm64/boot/dts/renesas/r8a779f4.dtsi

diff --git a/arch/arm64/boot/dts/renesas/r8a779f4.dtsi b/arch/arm64/boot/dts/renesas/r8a779f4.dtsi
new file mode 100644
index 000000000000..f9a31bd891c7
--- /dev/null
+++ b/arch/arm64/boot/dts/renesas/r8a779f4.dtsi
@@ -0,0 +1,12 @@
+// SPDX-License-Identifier: (GPL-2.0 OR MIT)
+/*
+ * Device Tree Source for the R-Car S4-8 (R8A779F4) SoC
+ *
+ * Copyright (C) 2023 Renesas Electronics Corp.
+ */
+
+#include "r8a779f0.dtsi"
+
+/ {
+	compatible = "renesas,r8a77f4", "renesas,r8a779f0";
+};
-- 
2.25.1

[PATCH v2 4/4] arm64: dts: renesas: Add R-Car S4 Starter Kit support

[Kuninori Morimoto]

Add initial support for the R-Car S4 Starter Kit support
with R8A779F4 SoC. Based on a patch in the BSP.

Signed-off-by: Michael Dege <michael.dege@renesas.com>
Signed-off-by: Yusuke Goda <yusuke.goda.sx@renesas.com>
Signed-off-by: Tam Nguyen <tam.nguyen.xa@renesas.com>
Signed-off-by: Hai Pham <hai.pham.ud@renesas.com>
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
 arch/arm64/boot/dts/renesas/Makefile          |   1 +
 arch/arm64/boot/dts/renesas/r8a779f4-s4sk.dts | 243 ++++++++++++++++++
 2 files changed, 244 insertions(+)
 create mode 100644 arch/arm64/boot/dts/renesas/r8a779f4-s4sk.dts

diff --git a/arch/arm64/boot/dts/renesas/Makefile b/arch/arm64/boot/dts/renesas/Makefile
index 7114cbbd8713..751cb0c65dcd 100644
--- a/arch/arm64/boot/dts/renesas/Makefile
+++ b/arch/arm64/boot/dts/renesas/Makefile
@@ -61,6 +61,7 @@ dtb-$(CONFIG_ARCH_R8A77995) += r8a77995-draak.dtb
 dtb-$(CONFIG_ARCH_R8A779A0) += r8a779a0-falcon.dtb
 
 dtb-$(CONFIG_ARCH_R8A779F0) += r8a779f0-spider.dtb
+dtb-$(CONFIG_ARCH_R8A779F0) += r8a779f4-s4sk.dtb
 
 dtb-$(CONFIG_ARCH_R8A779G0) += r8a779g0-white-hawk.dtb
 dtb-$(CONFIG_ARCH_R8A779G0) += r8a779g0-white-hawk-ard-audio-da7212.dtbo
diff --git a/arch/arm64/boot/dts/renesas/r8a779f4-s4sk.dts b/arch/arm64/boot/dts/renesas/r8a779f4-s4sk.dts
new file mode 100644
index 000000000000..9eb846caac63
--- /dev/null
+++ b/arch/arm64/boot/dts/renesas/r8a779f4-s4sk.dts
@@ -0,0 +1,243 @@
+// SPDX-License-Identifier: (GPL-2.0 or MIT)
+/*
+ * Device Tree Source for the R-Car S4 Starter Kit board
+ *
+ * Copyright (C) 2023 Renesas Electronics Corp.
+ */
+
+/dts-v1/;
+#include <dt-bindings/gpio/gpio.h>
+#include "r8a779f4.dtsi"
+
+/ {
+	model = "R-Car S4 Starter Kit board";
+	compatible = "renesas,s4sk", "renesas,r8a779f4";
+
+	aliases {
+		serial0	= &hscif0;
+		serial1	= &hscif1;
+		eth0	= &rswitch;
+	};
+
+	chosen {
+		bootargs = "ignore_loglevel rw root=/dev/nfs ip=on";
+		stdout-path = "serial0:921600n8";
+	};
+
+	memory@48000000 {
+		device_type = "memory";
+		/* first 128MB is reserved for secure area. */
+		/* The last 512MB is reserved for CR. */
+		reg = <0x0 0x48000000 0x0 0x58000000>;
+	};
+
+	memory@480000000 {
+		device_type = "memory";
+		reg = <0x4 0x80000000 0x0 0x80000000>;
+	};
+
+	vcc_sdhi: regulator-vcc-sdhi {
+		compatible = "regulator-fixed";
+		regulator-name = "SDHI Vcc";
+		regulator-min-microvolt = <3300000>;
+		regulator-max-microvolt = <3300000>;
+		gpio = <&gpio1 24 GPIO_ACTIVE_HIGH>;
+		enable-active-high;
+	};
+};
+
+&eth_serdes {
+	status = "okay";
+};
+
+&extal_clk {
+	clock-frequency = <20000000>;
+};
+
+&extalr_clk {
+	clock-frequency = <32768>;
+};
+
+&hscif0 {
+	pinctrl-0 = <&hscif0_pins>;
+	pinctrl-names = "default";
+
+	uart-has-rtscts;
+	status = "okay";
+};
+
+&hscif1 {
+	pinctrl-0 = <&hscif1_pins>;
+	pinctrl-names = "default";
+
+	uart-has-rtscts;
+	status = "okay";
+};
+
+&i2c2 {
+	pinctrl-0 = <&i2c2_pins>;
+	pinctrl-names = "default";
+
+	status = "okay";
+	clock-frequency = <400000>;
+};
+
+&i2c4 {
+	pinctrl-0 = <&i2c4_pins>;
+	pinctrl-names = "default";
+
+	status = "okay";
+	clock-frequency = <400000>;
+};
+
+&i2c5 {
+	pinctrl-0 = <&i2c5_pins>;
+	pinctrl-names = "default";
+
+	status = "okay";
+	clock-frequency = <400000>;
+
+	eeprom@50 {
+		compatible = "atmel,24c16";
+		reg = <0x50>;
+		pagesize = <16>;
+	};
+};
+
+&mmc0 {
+	pinctrl-0 = <&sd_pins>;
+	pinctrl-1 = <&sd_pins>;
+	pinctrl-names = "default", "state_uhs";
+
+	vmmc-supply = <&vcc_sdhi>;
+	vqmmc-supply = <&vcc_sdhi>;
+	cd-gpios = <&gpio1 23 GPIO_ACTIVE_LOW>;
+	bus-width = <4>;
+	status = "okay";
+};
+
+&pfc {
+	pinctrl-0 = <&scif_clk_pins>;
+	pinctrl-names = "default";
+
+	i2c2_pins: i2c2 {
+		groups = "i2c2";
+		function = "i2c2";
+	};
+
+	i2c4_pins: i2c4 {
+		groups = "i2c4";
+		function = "i2c4";
+	};
+
+	i2c5_pins: i2c5 {
+		groups = "i2c5";
+		function = "i2c5";
+	};
+
+	sd_pins: sd {
+		groups = "mmc_data4", "mmc_ctrl";
+		function = "mmc";
+		power-source = <3300>;
+	};
+
+	qspi0_pins: qspi0 {
+		groups = "qspi0_ctrl", "qspi0_data4";
+		function = "qspi0";
+	};
+
+	hscif0_pins: hscif0 {
+		groups = "hscif0_data", "hscif0_ctrl";
+		function = "hscif0";
+	};
+
+	hscif1_pins: hscif1 {
+		groups = "hscif1_data", "hscif1_ctrl";
+		function = "hscif1";
+	};
+
+	scif_clk_pins: scif_clk {
+		groups = "scif_clk";
+		function = "scif_clk";
+	};
+
+	tsn0_pins: tsn0 {
+		groups = "tsn0_mdio_b", "tsn0_link_b";
+		function = "tsn0";
+		drive-strength = <18>;
+		power-source = <3300>;
+	};
+
+	tsn1_pins: tsn1 {
+		groups = "tsn1_mdio_b", "tsn1_link_b";
+		function = "tsn1";
+		drive-strength = <18>;
+		power-source = <3300>;
+	};
+};
+
+&rswitch {
+	pinctrl-0 = <&tsn0_pins>, <&tsn1_pins>;
+	pinctrl-names = "default";
+	status = "okay";
+
+	ethernet-ports {
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		port@0 {
+			reg = <0>;
+			phy-handle = <&u101>;
+			phy-mode = "sgmii";
+			phys = <&eth_serdes 0>;
+
+			mdio {
+				#address-cells = <1>;
+				#size-cells = <0>;
+
+				u101: ethernet-phy@1 {
+					reg = <1>;
+					compatible = "ethernet-phy-ieee802.3-c45";
+				};
+			};
+		};
+
+		port@1 {
+			reg = <1>;
+			phy-handle = <&u201>;
+			phy-mode = "sgmii";
+			phys = <&eth_serdes 1>;
+
+			mdio {
+				#address-cells = <1>;
+				#size-cells = <0>;
+
+				u201: ethernet-phy@2 {
+					reg = <2>;
+					compatible = "ethernet-phy-ieee802.3-c45";
+				};
+			};
+		};
+
+		port@2 {
+			status = "disabled";
+		};
+	};
+};
+
+&rwdt {
+	timeout-sec = <60>;
+	status = "okay";
+};
+
+&scif_clk {
+	clock-frequency = <24000000>;
+};
+
+&ufs {
+	status = "okay";
+};
+
+&ufs30_clk {
+	clock-frequency = <38400000>;
+};
-- 
2.25.1

Re: [PATCH v2 1/4] dt-bindings: irqchip: renesas,irqc: Add r8a779f0 support

[Geert Uytterhoeven]

Hi Morimoto-san,

On Tue, Sep 26, 2023 at 6:37 AM Kuninori Morimoto
<kuninori.morimoto.gx@renesas.com> wrote:
> Document support for the Interrupt Controller for External Devices
> (INT-EX) in the Renesas R-Car S4 (R8A779F0) SoC.
>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

I posted a similar patch before: "[PATCH v2] dt-bindings: irqchip:
renesas,irqc: Add r8a779f0 support"
https://lore.kernel.org/r/9467a1c67d5d240211f88336973fa968d39cc860.1690446928.git.geert+renesas@glider.be

Marc: please take one or the other ;-)
Thanks!

> --- a/Documentation/devicetree/bindings/interrupt-controller/renesas,irqc.yaml
> +++ b/Documentation/devicetree/bindings/interrupt-controller/renesas,irqc.yaml
> @@ -37,6 +37,7 @@ properties:
>            - renesas,intc-ex-r8a77990    # R-Car E3
>            - renesas,intc-ex-r8a77995    # R-Car D3
>            - renesas,intc-ex-r8a779a0    # R-Car V3U
> +          - renesas,intc-ex-r8a779f0    # R-Car S4
>            - renesas,intc-ex-r8a779g0    # R-Car V4H
>        - const: renesas,irqc

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH v2 2/4] dt-bindings: soc: renesas: renesas.yaml: Add renesas,s4sk compatible

[Geert Uytterhoeven]

Hi Morimoto-san,

On Tue, Sep 26, 2023 at 6:37 AM Kuninori Morimoto
<kuninori.morimoto.gx@renesas.com> wrote:
> This patch adds "renesas,s4sk" which target the R-Car S4 Starter Kit
> board.

Thanks for your patch!

> Signed-off-by: Yusuke Goda <yusuke.goda.sx@renesas.com>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

If this patch was developed by Goda-san, and you took it, and submitted
it, there should be a "From: Yusuke Goda ..." line at the top.
On the other hand, if you co-developed the patch with Goda-san, you
can keep your From: line, being the first author, and there should be
Co-developed-by tags, too:
https://elixir.bootlin.com/linux/v6.6-rc1/source/Documentation/process/submitting-patches.rst#L489

> --- a/Documentation/devicetree/bindings/soc/renesas/renesas.yaml
> +++ b/Documentation/devicetree/bindings/soc/renesas/renesas.yaml
> @@ -327,6 +327,7 @@ properties:
>          items:
>            - enum:
>                - renesas,spider-cpu # Spider CPU board (RTP8A779F0ASKB0SC2S)
> +              - renesas,s4sk       # R-Car S4 Starter Kit board (Y-ASK-RCAR-S4-1000BASE-T#WS12)
>            - const: renesas,r8a779f0

The above would be fine if the S4SK board would have had an R8A779F0
SoC. Instead, it has an R8A779F4 SoC.  So please add a section for
R8A779F4, and document the new "renesas,s4sk" and "renesas,r8a779f4"
compatible values, and the fallback to "renesas,r8a779f0".
You can have a look at the R-Car V3H2 section for an example.

Thanks!

Gr{oetje,eeting}s,

                        Geert


--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH v2 3/4] arm64: dts: renesas: Add Renesas R8A779F4 SoC support

[Geert Uytterhoeven]

On Tue, Sep 26, 2023 at 6:37 AM Kuninori Morimoto
<kuninori.morimoto.gx@renesas.com> wrote:
> R8A779F4 is update version of R8A779F0.
> This patch adds its support, but is using r8a7799f0 dtsi internally.
>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
i.e. will queue in renesas-devel for v6.7.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH v2 3/4] arm64: dts: renesas: Add Renesas R8A779F4 SoC support

[Geert Uytterhoeven]

On Fri, Sep 29, 2023 at 2:45 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> On Tue, Sep 26, 2023 at 6:37 AM Kuninori Morimoto
> <kuninori.morimoto.gx@renesas.com> wrote:
> > R8A779F4 is update version of R8A779F0.
> > This patch adds its support, but is using r8a7799f0 dtsi internally.
> >
> > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> i.e. will queue in renesas-devel for v6.7.

... with the silly typo s/r8a77f4/r8a779f4/ fixed, of course.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH v2 4/4] arm64: dts: renesas: Add R-Car S4 Starter Kit support

[Geert Uytterhoeven]

Hi Morimoto-san,

On Tue, Sep 26, 2023 at 6:37 AM Kuninori Morimoto
<kuninori.morimoto.gx@renesas.com> wrote:
> Add initial support for the R-Car S4 Starter Kit support
> with R8A779F4 SoC. Based on a patch in the BSP.

Thanks for your patch!

> Signed-off-by: Michael Dege <michael.dege@renesas.com>
> Signed-off-by: Yusuke Goda <yusuke.goda.sx@renesas.com>
> Signed-off-by: Tam Nguyen <tam.nguyen.xa@renesas.com>
> Signed-off-by: Hai Pham <hai.pham.ud@renesas.com>
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

Just as with "[PATCH v2 2/4]", please consider the transfer chain,
and add Co-developed-by when needed.

> --- /dev/null
> +++ b/arch/arm64/boot/dts/renesas/r8a779f4-s4sk.dts
> @@ -0,0 +1,243 @@
> +// SPDX-License-Identifier: (GPL-2.0 or MIT)

"OR", as per commit 05c618f39089d977 ("arm64: dts: use capital "OR"
for multiple licenses in SPDX") in v6.6-rc2.

> +/*
> + * Device Tree Source for the R-Car S4 Starter Kit board
> + *
> + * Copyright (C) 2023 Renesas Electronics Corp.
> + */
> +
> +/dts-v1/;
> +#include <dt-bindings/gpio/gpio.h>
> +#include "r8a779f4.dtsi"
> +
> +/ {
> +       model = "R-Car S4 Starter Kit board";

Renesas R-Car ...

> +       compatible = "renesas,s4sk", "renesas,r8a779f4";

Missing "renesas,r8a779f0" fallback.

> +       vcc_sdhi: regulator-vcc-sdhi {
> +               compatible = "regulator-fixed";
> +               regulator-name = "SDHI Vcc";
> +               regulator-min-microvolt = <3300000>;
> +               regulator-max-microvolt = <3300000>;

It looks like this can switch between 1.8V and 3.3V using SDHI_PWR_SEL.
But that is controlled through the FPGA, and according to the docs,
only used for initialization.  So I guess hardcoding 3.3V is OK.

> +               gpio = <&gpio1 24 GPIO_ACTIVE_HIGH>;
> +               enable-active-high;
> +       };
> +};

> +&extalr_clk {
> +       clock-frequency = <32768>;
> +};

This clock (and scif_clk and ufs30_clk below) is generated by a
programmable clock generator.  Modelling it as a fixed-clock is fine
for now.  It can be replaced by an output of the clock generator later,
when Linux has gained support for it.

> +&i2c5 {
> +       pinctrl-0 = <&i2c5_pins>;
> +       pinctrl-names = "default";
> +
> +       status = "okay";
> +       clock-frequency = <400000>;
> +
> +       eeprom@50 {
> +               compatible = "atmel,24c16";

As the schematics say this is a genuine ST part:

    "st,24c16", "atmel,24c16";

> +               reg = <0x50>;
> +               pagesize = <16>;
> +       };
> +};
> +
> +&mmc0 {
> +       pinctrl-0 = <&sd_pins>;
> +       pinctrl-1 = <&sd_pins>;
> +       pinctrl-names = "default", "state_uhs";

Do you need two states if there is a single voltage?
AFAIK, UHS needs 1.8V.

> +
> +       vmmc-supply = <&vcc_sdhi>;
> +       vqmmc-supply = <&vcc_sdhi>;

Do you need vqmmc-supply if there is a single voltage?
I'm not sure about this one...

> +       cd-gpios = <&gpio1 23 GPIO_ACTIVE_LOW>;
> +       bus-width = <4>;
> +       status = "okay";
> +};
> +
> +&pfc {
> +       pinctrl-0 = <&scif_clk_pins>;
> +       pinctrl-names = "default";
> +
> +       i2c2_pins: i2c2 {
> +               groups = "i2c2";
> +               function = "i2c2";
> +       };
> +
> +       i2c4_pins: i2c4 {
> +               groups = "i2c4";
> +               function = "i2c4";
> +       };
> +
> +       i2c5_pins: i2c5 {
> +               groups = "i2c5";
> +               function = "i2c5";
> +       };
> +
> +       sd_pins: sd {

Please sort alphabetically (everywhere).

> +               groups = "mmc_data4", "mmc_ctrl";
> +               function = "mmc";
> +               power-source = <3300>;
> +       };
> +
> +       qspi0_pins: qspi0 {
> +               groups = "qspi0_ctrl", "qspi0_data4";
> +               function = "qspi0";
> +       };

There is no reference to qspi0_pins.

> +&rswitch {
> +       pinctrl-0 = <&tsn0_pins>, <&tsn1_pins>;
> +       pinctrl-names = "default";
> +       status = "okay";
> +
> +       ethernet-ports {
> +               #address-cells = <1>;
> +               #size-cells = <0>;
> +
> +               port@0 {
> +                       reg = <0>;
> +                       phy-handle = <&u101>;
> +                       phy-mode = "sgmii";
> +                       phys = <&eth_serdes 0>;
> +
> +                       mdio {
> +                               #address-cells = <1>;
> +                               #size-cells = <0>;
> +
> +                               u101: ethernet-phy@1 {

This label seems to be copied from Spider?
On S4SK, the PHY is IC99, so perhaps "ic99"?
Although I'm open for a different name like "gbe_phy0"
or "sgmii_phy0"?

> +                                       reg = <1>;
> +                                       compatible = "ethernet-phy-ieee802.3-c45";

Missing interrupt (GP3_10).

> +                               };
> +                       };
> +               };
> +
> +               port@1 {
> +                       reg = <1>;
> +                       phy-handle = <&u201>;
> +                       phy-mode = "sgmii";
> +                       phys = <&eth_serdes 1>;
> +
> +                       mdio {
> +                               #address-cells = <1>;
> +                               #size-cells = <0>;
> +
> +                               u201: ethernet-phy@2 {

"ic102", or a better name...

> +                                       reg = <2>;
> +                                       compatible = "ethernet-phy-ieee802.3-c45";

Missing interrupt (GP3_11).

> +                               };
> +                       };
> +               };
> +
> +               port@2 {
> +                       status = "disabled";
> +               };
> +       };
> +};

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH v2 2/4] dt-bindings: soc: renesas: renesas.yaml: Add renesas,s4sk compatible

[Kuninori Morimoto]

Hi Geert

> If this patch was developed by Goda-san, and you took it, and submitted
> it, there should be a "From: Yusuke Goda ..." line at the top.
> On the other hand, if you co-developed the patch with Goda-san, you
> can keep your From: line, being the first author, and there should be
> Co-developed-by tags, too:

Not developed, Signed-off-by is enough in this case.

> The above would be fine if the S4SK board would have had an R8A779F0
> SoC. Instead, it has an R8A779F4 SoC.  So please add a section for
> R8A779F4, and document the new "renesas,s4sk" and "renesas,r8a779f4"
> compatible values, and the fallback to "renesas,r8a779f0".
> You can have a look at the R-Car V3H2 section for an example.

Will check and fix in v3

Thank you for your help !!

Best regards
---
Kuninori Morimoto

Re: [PATCH v2 3/4] arm64: dts: renesas: Add Renesas R8A779F4 SoC support

[Kuninori Morimoto]

Hi Geert

> > > R8A779F4 is update version of R8A779F0.
> > > This patch adds its support, but is using r8a7799f0 dtsi internally.
> > >
> > > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> >
> > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > i.e. will queue in renesas-devel for v6.7.
> 
> ... with the silly typo s/r8a77f4/r8a779f4/ fixed, of course.

Thanks, but will post v3 patch.

Thank you for your help !!

Best regards
---
Kuninori Morimoto

Re: [PATCH v2 4/4] arm64: dts: renesas: Add R-Car S4 Starter Kit support

[Kuninori Morimoto]

Hi Geert

> > Signed-off-by: Michael Dege <michael.dege@renesas.com>
> > Signed-off-by: Yusuke Goda <yusuke.goda.sx@renesas.com>
> > Signed-off-by: Tam Nguyen <tam.nguyen.xa@renesas.com>
> > Signed-off-by: Hai Pham <hai.pham.ud@renesas.com>
> > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> 
> Just as with "[PATCH v2 2/4]", please consider the transfer chain,
> and add Co-developed-by when needed.

It is based on BSP, but not as-is.
It is following same style of your similar patch (Based on BSP).
Co-developed with Shimoda-san. Will add it.

> > +// SPDX-License-Identifier: (GPL-2.0 or MIT)
> 
> "OR", as per commit 05c618f39089d977 ("arm64: dts: use capital "OR"
> for multiple licenses in SPDX") in v6.6-rc2.

will fix in v3

> > +       model = "R-Car S4 Starter Kit board";
> 
> Renesas R-Car ...

Offical S4 SK doesn't have "Renesas".

> > +&i2c5 {
> > +       pinctrl-0 = <&i2c5_pins>;
> > +       pinctrl-names = "default";
> > +
> > +       status = "okay";
> > +       clock-frequency = <400000>;
> > +
> > +       eeprom@50 {
> > +               compatible = "atmel,24c16";
> 
> As the schematics say this is a genuine ST part:
> 
>     "st,24c16", "atmel,24c16";

I have removed "st,24c16", but will add again in v3

> > +&mmc0 {
> > +       pinctrl-0 = <&sd_pins>;
> > +       pinctrl-1 = <&sd_pins>;
> > +       pinctrl-names = "default", "state_uhs";
> 
> Do you need two states if there is a single voltage?
> AFAIK, UHS needs 1.8V.
> 
> > +
> > +       vmmc-supply = <&vcc_sdhi>;
> > +       vqmmc-supply = <&vcc_sdhi>;
> 
> Do you need vqmmc-supply if there is a single voltage?
> I'm not sure about this one...

Shimoda-san has double-checked.
It can use UHS, but this FPGA can't handle 1.8v.
v3 will remove UHS / vqmmc.

> > +&pfc {
(snip)
> Please sort alphabetically (everywhere).

will do

> This label seems to be copied from Spider?
> On S4SK, the PHY is IC99, so perhaps "ic99"?
> Although I'm open for a different name like "gbe_phy0"
> or "sgmii_phy0"?
(snip)
> Missing interrupt (GP3_10).

will fix in v3

Thank you for your help !!

Best regards
---
Kuninori Morimoto