* [PATCH] treewide: fix typos of SPDX-License-Identifier
@ 2019-06-01 3:22 Masahiro Yamada
2019-06-01 16:29 ` Greg KH
2019-06-03 7:07 ` Geert Uytterhoeven
0 siblings, 2 replies; 3+ messages in thread
From: Masahiro Yamada @ 2019-06-01 3:22 UTC (permalink / raw)
To: Andrew Morton
Cc: linux-spdx, Thomas Gleixner, linux-kernel, Kees Cook,
Joe Perches, Masahiro Yamada, Jaroslav Kysela, alsa-devel,
Mark Brown, linux-gpio, Alexandre Torgue, Linus Walleij,
linux-stm32, linux-renesas-soc, Takashi Iwai, Liam Girdwood,
Kishon Vijay Abraham I, Maxime Coquelin, Geert Uytterhoeven,
Russell King, linux-arm-kernel
Prior to the adoption of SPDX, it was difficult for tools to determine
the correct license due to incomplete or badly formatted license text.
The SPDX solves this issue, assuming people can correctly spell
"SPDX-License-Identifier" although this assumption is broken in some
places.
Since scripts/spdxcheck.py parses only lines that exactly matches to
the correct tag, it cannot (should not) detect this kind of error.
If the correct tag is missing, scripts/checkpatch.pl warns like this:
WARNING: Missing or malformed SPDX-License-Identifier tag in line *
So, people should notice it before the patch submission, but in reality
broken tags sometimes slip in. The checkpatch warning is not useful for
checking the committed files globally since large number of files still
have no SPDX tag.
Also, I am not sure about the legal effect when the SPDX tag is broken.
Anyway, these typos are absolutely worth fixing. It is pretty easy to
find suspicious lines by grep.
$ git grep --not -e SPDX-License-Identifier --and -e SPDX- -- \
:^LICENSES :^scripts/spdxcheck.py :^*/license-rules.rst
arch/arm/kernel/bugs.c:// SPDX-Identifier: GPL-2.0
drivers/phy/st/phy-stm32-usbphyc.c:// SPDX-Licence-Identifier: GPL-2.0
drivers/pinctrl/sh-pfc/pfc-r8a77980.c:// SPDX-Lincense-Identifier: GPL 2.0
lib/test_stackinit.c:// SPDX-Licenses: GPLv2
sound/soc/codecs/max9759.c:// SPDX-Licence-Identifier: GPL-2.0
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---
arch/arm/kernel/bugs.c | 2 +-
drivers/phy/st/phy-stm32-usbphyc.c | 2 +-
drivers/pinctrl/sh-pfc/pfc-r8a77980.c | 2 +-
lib/test_stackinit.c | 2 +-
sound/soc/codecs/max9759.c | 2 +-
5 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/arch/arm/kernel/bugs.c b/arch/arm/kernel/bugs.c
index d41d3598e5e5..14c8dbbb7d2d 100644
--- a/arch/arm/kernel/bugs.c
+++ b/arch/arm/kernel/bugs.c
@@ -1,4 +1,4 @@
-// SPDX-Identifier: GPL-2.0
+// SPDX-License-Identifier: GPL-2.0
#include <linux/init.h>
#include <asm/bugs.h>
#include <asm/proc-fns.h>
diff --git a/drivers/phy/st/phy-stm32-usbphyc.c b/drivers/phy/st/phy-stm32-usbphyc.c
index 1255cd1d9a60..56bdea4b0bd9 100644
--- a/drivers/phy/st/phy-stm32-usbphyc.c
+++ b/drivers/phy/st/phy-stm32-usbphyc.c
@@ -1,4 +1,4 @@
-// SPDX-Licence-Identifier: GPL-2.0
+// SPDX-License-Identifier: GPL-2.0
/*
* STMicroelectronics STM32 USB PHY Controller driver
*
diff --git a/drivers/pinctrl/sh-pfc/pfc-r8a77980.c b/drivers/pinctrl/sh-pfc/pfc-r8a77980.c
index 473da65890a7..9ed4ead2dafb 100644
--- a/drivers/pinctrl/sh-pfc/pfc-r8a77980.c
+++ b/drivers/pinctrl/sh-pfc/pfc-r8a77980.c
@@ -1,4 +1,4 @@
-// SPDX-Lincense-Identifier: GPL 2.0
+// SPDX-License-Identifier: GPL-2.0
/*
* R8A77980 processor support - PFC hardware block.
*
diff --git a/lib/test_stackinit.c b/lib/test_stackinit.c
index 13115b6f2b88..e97dc54b4fdf 100644
--- a/lib/test_stackinit.c
+++ b/lib/test_stackinit.c
@@ -1,4 +1,4 @@
-// SPDX-Licenses: GPLv2
+// SPDX-License-Identifier: GPL-2.0
/*
* Test cases for compiler-based stack variable zeroing via future
* compiler flags or CONFIG_GCC_PLUGIN_STRUCTLEAK*.
diff --git a/sound/soc/codecs/max9759.c b/sound/soc/codecs/max9759.c
index ecfb4a80424b..00e9d4fd1651 100644
--- a/sound/soc/codecs/max9759.c
+++ b/sound/soc/codecs/max9759.c
@@ -1,4 +1,4 @@
-// SPDX-Licence-Identifier: GPL-2.0
+// SPDX-License-Identifier: GPL-2.0
/*
* MAX9759 Amplifier Driver
*
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] treewide: fix typos of SPDX-License-Identifier
2019-06-01 3:22 [PATCH] treewide: fix typos of SPDX-License-Identifier Masahiro Yamada
@ 2019-06-01 16:29 ` Greg KH
2019-06-03 7:07 ` Geert Uytterhoeven
1 sibling, 0 replies; 3+ messages in thread
From: Greg KH @ 2019-06-01 16:29 UTC (permalink / raw)
To: Masahiro Yamada
Cc: Andrew Morton, linux-spdx, Thomas Gleixner, linux-kernel,
Kees Cook, Joe Perches, Jaroslav Kysela, alsa-devel, Mark Brown,
linux-gpio, Alexandre Torgue, Linus Walleij, linux-stm32,
linux-renesas-soc, Takashi Iwai, Liam Girdwood,
Kishon Vijay Abraham I, Maxime Coquelin, Geert Uytterhoeven,
Russell King, linux-arm-kernel
On Sat, Jun 01, 2019 at 12:22:42PM +0900, Masahiro Yamada wrote:
> Prior to the adoption of SPDX, it was difficult for tools to determine
> the correct license due to incomplete or badly formatted license text.
> The SPDX solves this issue, assuming people can correctly spell
> "SPDX-License-Identifier" although this assumption is broken in some
> places.
>
> Since scripts/spdxcheck.py parses only lines that exactly matches to
> the correct tag, it cannot (should not) detect this kind of error.
>
> If the correct tag is missing, scripts/checkpatch.pl warns like this:
>
> WARNING: Missing or malformed SPDX-License-Identifier tag in line *
>
> So, people should notice it before the patch submission, but in reality
> broken tags sometimes slip in. The checkpatch warning is not useful for
> checking the committed files globally since large number of files still
> have no SPDX tag.
>
> Also, I am not sure about the legal effect when the SPDX tag is broken.
>
> Anyway, these typos are absolutely worth fixing. It is pretty easy to
> find suspicious lines by grep.
>
> $ git grep --not -e SPDX-License-Identifier --and -e SPDX- -- \
> :^LICENSES :^scripts/spdxcheck.py :^*/license-rules.rst
> arch/arm/kernel/bugs.c:// SPDX-Identifier: GPL-2.0
> drivers/phy/st/phy-stm32-usbphyc.c:// SPDX-Licence-Identifier: GPL-2.0
> drivers/pinctrl/sh-pfc/pfc-r8a77980.c:// SPDX-Lincense-Identifier: GPL 2.0
> lib/test_stackinit.c:// SPDX-Licenses: GPLv2
> sound/soc/codecs/max9759.c:// SPDX-Licence-Identifier: GPL-2.0
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Very nice catch, thanks! I'll go queue this up now.
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] treewide: fix typos of SPDX-License-Identifier
2019-06-01 3:22 [PATCH] treewide: fix typos of SPDX-License-Identifier Masahiro Yamada
2019-06-01 16:29 ` Greg KH
@ 2019-06-03 7:07 ` Geert Uytterhoeven
1 sibling, 0 replies; 3+ messages in thread
From: Geert Uytterhoeven @ 2019-06-03 7:07 UTC (permalink / raw)
To: Masahiro Yamada
Cc: Andrew Morton, ALSA Development Mailing List, Kees Cook,
Geert Uytterhoeven, open list:GPIO SUBSYSTEM, Russell King,
Liam Girdwood, Linus Walleij, Takashi Iwai,
Linux Kernel Mailing List, Jaroslav Kysela, Linux-Renesas,
Mark Brown, Maxime Coquelin, Joe Perches, linux-spdx,
Thomas Gleixner, Kishon Vijay Abraham I, linux-stm32, Linux ARM,
Alexandre Torgue
Hi Yamada-san,
On Sat, Jun 1, 2019 at 5:24 AM Masahiro Yamada
<yamada.masahiro@socionext.com> wrote:
> Prior to the adoption of SPDX, it was difficult for tools to determine
> the correct license due to incomplete or badly formatted license text.
> The SPDX solves this issue, assuming people can correctly spell
> "SPDX-License-Identifier" although this assumption is broken in some
> places.
>
> Since scripts/spdxcheck.py parses only lines that exactly matches to
> the correct tag, it cannot (should not) detect this kind of error.
>
> If the correct tag is missing, scripts/checkpatch.pl warns like this:
>
> WARNING: Missing or malformed SPDX-License-Identifier tag in line *
>
> So, people should notice it before the patch submission, but in reality
> broken tags sometimes slip in. The checkpatch warning is not useful for
> checking the committed files globally since large number of files still
> have no SPDX tag.
>
> Also, I am not sure about the legal effect when the SPDX tag is broken.
>
> Anyway, these typos are absolutely worth fixing. It is pretty easy to
> find suspicious lines by grep.
>
> $ git grep --not -e SPDX-License-Identifier --and -e SPDX- -- \
> :^LICENSES :^scripts/spdxcheck.py :^*/license-rules.rst
> arch/arm/kernel/bugs.c:// SPDX-Identifier: GPL-2.0
> drivers/phy/st/phy-stm32-usbphyc.c:// SPDX-Licence-Identifier: GPL-2.0
> drivers/pinctrl/sh-pfc/pfc-r8a77980.c:// SPDX-Lincense-Identifier: GPL 2.0
> lib/test_stackinit.c:// SPDX-Licenses: GPLv2
> sound/soc/codecs/max9759.c:// SPDX-Licence-Identifier: GPL-2.0
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Thanks for your patch!
> drivers/pinctrl/sh-pfc/pfc-r8a77980.c | 2 +-
For the sh-pfc change:
Acked-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-06-03 7:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-01 3:22 [PATCH] treewide: fix typos of SPDX-License-Identifier Masahiro Yamada
2019-06-01 16:29 ` Greg KH
2019-06-03 7:07 ` Geert Uytterhoeven
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).