* Re: [PATCH 1/3] staging: emxx_udc: Added static modifier to udc_controller
[not found] ` <1541623464-49041-2-git-send-email-carmeli.tamir@gmail.com>
@ 2018-11-12 9:42 ` Geert Uytterhoeven
0 siblings, 0 replies; only message in thread
From: Geert Uytterhoeven @ 2018-11-12 9:42 UTC (permalink / raw)
To: carmeli.tamir
Cc: Greg KH, Nathan Chancellor, chrisadr, areklis909, Dan Carpenter,
driverdevel, Linux Kernel Mailing List, Magnus Damm,
Linux-Renesas
Hi Carmeli,
CC Magnus
(staging drivers receive so may janitorial changes that the original author is
lost in the git shortlog noise)
On Wed, Nov 7, 2018 at 9:46 PM Carmeli Tamir <carmeli.tamir@gmail.com> wrote:
> Added static modifier to the udc_controller, since it's only
> required within emxx_udc.c.
>
> Signed-off-by: Carmeli Tamir <carmeli.tamir@gmail.com>
Thanks for your patch!
> --- a/drivers/staging/emxx_udc/emxx_udc.c
> +++ b/drivers/staging/emxx_udc/emxx_udc.c
> @@ -56,7 +56,7 @@ static void _nbu2ss_fifo_flush(struct nbu2ss_udc *, struct nbu2ss_ep *);
>
> /*===========================================================================*/
> /* Global */
> -struct nbu2ss_udc udc_controller;
> +static struct nbu2ss_udc udc_controller;
What about the "Global" comment?
Perhaps this was intentional?
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2018-11-12 19:35 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1541623464-49041-1-git-send-email-carmeli.tamir@gmail.com>
[not found] ` <1541623464-49041-2-git-send-email-carmeli.tamir@gmail.com>
2018-11-12 9:42 ` [PATCH 1/3] staging: emxx_udc: Added static modifier to udc_controller Geert Uytterhoeven
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).