Re: [PATCH v12 3/3] dt-bindings: mfd: Document Renesas R-Car Gen3 RPC-IF MFD bindings

From: masonccyang@mxic.com.tw
To: "Sergei Shtylyov" <sergei.shtylyov@cogentembedded.com>,
	"Geert Uytterhoeven" <geert@linux-m68k.org>,
	"Lee Jones" <lee.jones@linaro.org>
Cc: "Boris Brezillon" <bbrezillon@kernel.org>,
	"Mark Brown" <broonie@kernel.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
	<devicetree@vger.kernel.org>,
	"Geert Uytterhoeven" <geert@linux-m68k.org>,
	"Geert Uytterhoeven" <geert+renesas@glider.be>,
	"Simon Horman" <horms@verge.net.au>,
	juliensu@mxic.com.tw, "Lee Jones" <lee.jones@linaro.org>,
	"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
	"Linux-Renesas" <linux-renesas-soc@vger.kernel.org>,
	"linux-spi" <linux-spi@vger.kernel.org>,
	"Marek Vasut" <marek.vasut@gmail.com>,
	"Mark Rutland" <mark.rutland@arm.com>,
	"Rob Herring" <robh@kernel.org>,
	"Sergei Shtylyov" <sergei.shtylyov@cogentembedded.com>,
	zhengxunli@mxic.com.tw
Subject: Re: [PATCH v12 3/3] dt-bindings: mfd: Document Renesas R-Car Gen3 RPC-IF MFD bindings
Date: Tue, 14 May 2019 18:00:13 +0800	[thread overview]
Message-ID: <OFADD61EE8.84C8DE88-ON482583FA.0036510D-482583FA.0036F37A@mxic.com.tw> (raw)
In-Reply-To: <OFAD9AA573.86373900-ON482583FA.0034781A-482583FA.0035B40C@LocalDomain>

Hi Sergei, 

> > 
> >    Could you please indent with 1 or 2 tabs where you used 8 or 16 
spaces?

Sorry, I just copy this new DTS from git to my Notes email system,
therefore, the "tabs space" is not alignment with original file.

> 
> Patch new DTS to
> ===============================================================> 
> 
> +Renesas R-Car Gen3 RPC-IF controller Device Tree Bindings
> +---------------------------------------------------------
> +
> +RPC-IF supports both SPI NOR and HyperFlash (CFI-compliant flash)
> +
> +Required properties:
> +- compatible: should be an SoC-specific compatible value, followed by
> +      "renesas,rcar-gen3-rpc" as a fallback.
> +      supported SoC-specific values are:
> +      "renesas,r8a77995-rpc"   (R-Car D3)
> +- reg: should contain three register areas:
> +   first for RPC-IF registers,
> +   second for the direct mapping read mode and
> +   third for the write buffer area.
> +- reg-names: should contain "regs", "dirmap" and "wbuf"
> +- clocks: should contain 1 entries for the module's clock
> +- clock-names: should contain "rpc"
> +- #address-cells: should be 1
> +- #size-cells: should be 0
> +
> +Example:
> +- SPI mode:
> +
> +   rpc_if: spi@ee200000 {
> +      compatible = "renesas,r8a77995-rpc", "renesas,rcar-gen3-rpc";
> +      reg = <0 0xee200000 0 0x200>, <0 0x08000000 0 0x4000000>,
> +            <0 0xee208000 0 0x100>;
> +      reg-names = "regs", "dirmap", "wbuf";
> +      clocks = <&cpg CPG_MOD 917>;
> +      clock-names = "rpc";
> +      power-domains = <&sysc R8A77995_PD_ALWAYS_ON>;
> +      resets = <&cpg 917>;
> +      #address-cells = <1>;
> +      #size-cells = <0>;
> +
> +      flash@0 {
> +         compatible = "jedec,spi-nor";
> +         reg = <0>;
> +         spi-max-frequency = <40000000>;
> +         spi-tx-bus-width = <1>;
> +         spi-rx-bus-width = <1>;
> +      };
> +   };
> +
> +- HF mode:
> +   rpc_if: hf@ee200000 {
> +      compatible = "renesas,r8a77995-rpc", "renesas,rcar-gen3-rpc";
> +      reg = <0 0xee200000 0 0x200>, <0 0x08000000 0 0x4000000>,
> +            <0 0xee208000 0 0x100>;
> +      reg-names = "regs", "dirmap", "wbuf";
> +      clocks = <&cpg CPG_MOD 917>;
> +      clock-names = "rpc";
> +      power-domains = <&sysc R8A77995_PD_ALWAYS_ON>;
> +      resets = <&cpg 917>;
> +      #address-cells = <1>;
> +      #size-cells = <0>;
> +
> +      flash@0 {
> +         compatible = "cypress,hyperflash", "cfi-flash";
> +         reg = <0>;
> +      };
> +   };
> 
> =======================================================================<

thanks for your review.

best regards,
Mason 

CONFIDENTIALITY NOTE:

This e-mail and any attachments may contain confidential information 
and/or personal data, which is protected by applicable laws. Please be 
reminded that duplication, disclosure, distribution, or use of this e-mail 
(and/or its attachments) or any part thereof is prohibited. If you receive 
this e-mail in error, please notify us immediately and delete this mail as 
well as its attachment(s) from your system. In addition, please be 
informed that collection, processing, and/or use of personal data is 
prohibited unless expressly permitted by personal data protection laws. 
Thank you for your attention and cooperation.

Macronix International Co., Ltd.

=====================================================================

============================================================================

CONFIDENTIALITY NOTE:

This e-mail and any attachments may contain confidential information and/or personal data, which is protected by applicable laws. Please be reminded that duplication, disclosure, distribution, or use of this e-mail (and/or its attachments) or any part thereof is prohibited. If you receive this e-mail in error, please notify us immediately and delete this mail as well as its attachment(s) from your system. In addition, please be informed that collection, processing, and/or use of personal data is prohibited unless expressly permitted by personal data protection laws. Thank you for your attention and cooperation.

Macronix International Co., Ltd.

=====================================================================