From: Marek Vasut <marek.vasut@gmail.com>
To: masonccyang@mxic.com.tw, Lee Jones <lee.jones@linaro.org>
Cc: bbrezillon@kernel.org, broonie@kernel.org,
devicetree@vger.kernel.org,
Geert Uytterhoeven <geert+renesas@glider.be>,
Simon Horman <horms@verge.net.au>,
juliensu@mxic.com.tw, linux-kernel@vger.kernel.org,
linux-renesas-soc@vger.kernel.org, linux-spi@vger.kernel.org,
mark.rutland@arm.com, Rob Herring <robh@kernel.org>,
sergei.shtylyov@cogentembedded.com, zhengxunli@mxic.com.tw
Subject: Re: [PATCH v12 3/3] dt-bindings: mfd: Document Renesas R-Car Gen3 RPC-IF MFD bindings
Date: Wed, 8 May 2019 05:52:16 +0200 [thread overview]
Message-ID: <d229b19e-351c-c576-b5c4-716d10dad1a0@gmail.com> (raw)
In-Reply-To: <OF08A5650B.8AE8977C-ON482583F4.000E5B1E-482583F4.000F7215@mxic.com.tw>
On 5/8/19 4:48 AM, masonccyang@mxic.com.tw wrote:
> Hi Jones,
>
>> "Lee Jones" <lee.jones@linaro.org>
>> 2019/05/07 下午 08:58
>>
>> To
>>
>> "Marek Vasut" <marek.vasut@gmail.com>,
>>
>> cc
>>
>> "Rob Herring" <robh@kernel.org>, "Mason Yang"
>> <masonccyang@mxic.com.tw>, broonie@kernel.org, linux-
>> kernel@vger.kernel.org, linux-spi@vger.kernel.org,
>> bbrezillon@kernel.org, linux-renesas-soc@vger.kernel.org, "Geert
>> Uytterhoeven" <geert+renesas@glider.be>,
>> sergei.shtylyov@cogentembedded.com, mark.rutland@arm.com,
>> devicetree@vger.kernel.org, juliensu@mxic.com.tw, "Simon Horman"
>> <horms@verge.net.au>, zhengxunli@mxic.com.tw
>>
>> Subject
>>
>> Re: [PATCH v12 3/3] dt-bindings: mfd: Document Renesas R-Car Gen3
>> RPC-IF MFD bindings
>>
>> On Wed, 24 Apr 2019, Marek Vasut wrote:
>>
>> > On 4/24/19 11:23 PM, Rob Herring wrote:
>> > > On Wed, Apr 24, 2019 at 03:55:36PM +0800, Mason Yang wrote:
>> > >> Document the bindings used by the Renesas R-Car Gen3 RPC-IF MFD.
>> > >>
>> > >> Signed-off-by: Mason Yang <masonccyang@mxic.com.tw>
>> > >> ---
>> > >> .../devicetree/bindings/mfd/mfd-renesas-rpc.txt | 40 ++++++
>> ++++++++++++++++
>> > >> 1 file changed, 40 insertions(+)
>> > >> create mode 100644 Documentation/devicetree/bindings/mfd/mfd-
>> renesas-rpc.txt
>> > >>
>> > >> diff --git a/Documentation/devicetree/bindings/mfd/mfd-renesas-
>> rpc.txt b/Documentation/devicetree/bindings/mfd/mfd-renesas-rpc.txt
>> > >> new file mode 100644
>> > >> index 0000000..668b822
>> > >> --- /dev/null
>> > >> +++ b/Documentation/devicetree/bindings/mfd/mfd-renesas-rpc.txt
>> > >> @@ -0,0 +1,40 @@
>> > >> +Renesas R-Car Gen3 RPC-IF MFD Device Tree Bindings
>> > >> +--------------------------------------------------
>> > >
>> > > Looks like a SPI flash controller from the example. What makes it an
>> > > MFD?
>> >
>> > It supports both SPI NOR and HyperFlash (CFI-compliant flash with
>> > different bus interface).
>>
>> Looks like you're registering one OR the other.
>>
>> Why don't you just do this from DT?
>>
>> No reason for this to be an MFD IMHO.
>
>
> okay, I will patch it back to SPI mode only.
I don't think that's what Lee meant . The controller supports _both_
modes , hence it would have the same compatible string. You just need to
extract the mode of operation from the DT.
--
Best regards,
Marek Vasut
next prev parent reply other threads:[~2019-05-08 3:52 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-24 7:55 [PATCH v12 0/3] mfd: Add Renesas R-Car Gen3 RPC-IF MFD & SPI driver Mason Yang
2019-04-24 7:55 ` [PATCH v12 1/3] mfd: Add Renesas R-Car Gen3 RPC-IF MFD driver Mason Yang
2019-04-24 7:55 ` [PATCH v12 2/3] spi: Add Renesas R-Car Gen3 RPC-IF SPI controller driver Mason Yang
2019-05-14 6:52 ` Lee Jones
2019-05-15 5:55 ` masonccyang
2019-05-15 7:16 ` Lee Jones
2019-04-24 7:55 ` [PATCH v12 3/3] dt-bindings: mfd: Document Renesas R-Car Gen3 RPC-IF MFD bindings Mason Yang
2019-04-24 21:23 ` Rob Herring
2019-04-24 21:54 ` Marek Vasut
2019-04-25 23:07 ` Rob Herring
2019-04-26 1:44 ` Marek Vasut
2019-05-07 12:57 ` Lee Jones
[not found] ` <OF08A5650B.8AE8977C-ON482583F4.000E5B1E-482583F4.000F7215@mxic.com.tw>
2019-05-08 3:52 ` Marek Vasut [this message]
2019-05-08 6:11 ` Lee Jones
[not found] ` <OFE86674B9.06D723A0-ON482583F5.000AD50C-482583F5.000BA075@mxic.com.tw>
2019-05-09 19:23 ` Sergei Shtylyov
[not found] ` <OFB19BCE91.6EBBAA77-ON482583F6.000234E2-482583F6.00061290@mxic.com.tw>
2019-05-13 7:11 ` Geert Uytterhoeven
[not found] ` <OFD932ABFC.E3FFCEB8-ON482583F9.003412B1-482583F9.0034D5CA@mxic.com.tw>
2019-05-13 14:43 ` Geert Uytterhoeven
2019-05-14 2:33 ` masonccyang
2019-05-13 19:08 ` Sergei Shtylyov
2019-05-14 9:46 ` masonccyang
2019-05-14 10:07 ` Geert Uytterhoeven
2019-05-14 20:27 ` Sergei Shtylyov
2019-05-20 7:23 ` masonccyang
2019-05-20 7:44 ` Geert Uytterhoeven
2019-05-21 1:28 ` masonccyang
2019-05-22 16:32 ` Sergei Shtylyov
2019-05-22 17:05 ` Geert Uytterhoeven
2019-05-22 17:23 ` Sergei Shtylyov
2019-05-22 17:44 ` Geert Uytterhoeven
[not found] ` <OFAD9AA573.86373900-ON482583FA.0034781A-482583FA.0035B40C@LocalDomain>
2019-05-14 10:00 ` masonccyang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d229b19e-351c-c576-b5c4-716d10dad1a0@gmail.com \
--to=marek.vasut@gmail.com \
--cc=bbrezillon@kernel.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=horms@verge.net.au \
--cc=juliensu@mxic.com.tw \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=masonccyang@mxic.com.tw \
--cc=robh@kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=zhengxunli@mxic.com.tw \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).