RE: [PATCH 0/5] media: Fix asd dynamic allocation

From: Chris Paterson <Chris.Paterson2@renesas.com>
To: Fabrizio Castro <fabrizio.castro.jz@renesas.com>,
	Ramesh Shanmugasundaram <rashanmu@gmail.com>,
	Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Cc: "linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
	"linux-renesas-soc@vger.kernel.org"
	<linux-renesas-soc@vger.kernel.org>,
	"Jacopo Mondi" <jacopo+renesas@jmondi.org>,
	"Kieran Bingham" <kieran.bingham+renesas@ideasonboard.com>,
	"Niklas Söderlund" <niklas.soderlund+renesas@ragnatech.se>,
	"Sakari Ailus" <sakari.ailus@linux.intel.com>,
	"Steve Longerbeam" <slongerbeam@gmail.com>
Subject: RE: [PATCH 0/5] media: Fix asd dynamic allocation
Date: Tue, 1 Sep 2020 10:46:09 +0000	[thread overview]
Message-ID: <OSAPR01MB2385DABC0957AE1A7B8F6622B72E0@OSAPR01MB2385.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <CAJWpUEe4VwOL_TQ1WwjG1WT17_GPFpNO+-h92dRfj0jW8pb5wg@mail.gmail.com>

Hello,

> From: Ramesh Shanmugasundaram <rashanmu@gmail.com>
> Sent: 31 August 2020 20:45
> 
> Hi Laurent,
> 
> Thank you for the fix. Sorry about the late reply.
> 
> > This small patch series addresses a bug related to the usage of
> > v4l2_async_notifier_add_subdev() that is widespread among drivers.
> >
> > The issue is explained in 1/4, which improves the documentation of the
> > v4l2_async_notifier_add_subdev() function by stating explicitly that the
> > asd argument needs to be allocated dynamically. Among the 13 drivers
> > that use that function, only one gets it right.
> >
> > The rest of the patches fix the problem in several Renesas-related
> > drivers, with an unrelated fwnode reference leak fix for the rcar-drif
> > driver in 2/5 that made the v4l2_async_notifier_add_subdev() fix easier
> > to implement in that driver.
> >
> > I'm lacking hardware to test 2/5 and 3/5. Ramesh, would you be able to
> > test that ? What development board do you use to test the DRIF driver ?
> > I don't see any DT integration upstream.
> 
> I'm afraid I may not be able to test it as I do not have the hardware.
> I have copied Chris P if he can help out.

Thanks Ramesh.

Fabrizio will take a look as he's working on DRIF currently.
We'll also get him added to the maintainers file.

Kind regards, Chris

> 
> I have tested DRIF driver on a H3/M3 Salvator-X/S with a add-on board
> from Maxim having two MAX2175 tuners (MAX2175 evaluation kit). This
> add-on board was a prototype at that time. Hence, the DT updates were
> maintained internally.
> 
> Thanks,
> Ramesh
> 
> > I also haven't dug up my MAX9286 development kit to test 5/5. I would
> > thus appreciate if someone could test it, but worst case I can do so
> > myself.
> >
> > Laurent Pinchart (5):
> >   media: v4l2-async: Document asd allocation requirements
> >   media: rcar_drif: Fix fwnode reference leak when parsing DT
> >   media: rcar_drif: Allocate v4l2_async_subdev dynamically
> >   media: rcar-csi2: Allocate v4l2_async_subdev dynamically
> >   media: i2c: max9286: Allocate v4l2_async_subdev dynamically
> >
> >  drivers/media/i2c/max9286.c                 | 38 +++++++++++----------
> >  drivers/media/platform/rcar-vin/rcar-csi2.c | 24 ++++++-------
> >  drivers/media/platform/rcar_drif.c          | 30 +++++-----------
> >  include/media/v4l2-async.h                  |  5 +--
> >  4 files changed, 42 insertions(+), 55 deletions(-)
> >
> > --
> > Regards,
> >
> > Laurent Pinchart
> >