* [PATCH] clk: renesas: r8a774c0: Fix LAST_DT_CORE_CLK
@ 2019-02-20 16:09 Fabrizio Castro
2019-02-20 20:39 ` Chris Paterson
2019-02-21 18:33 ` Geert Uytterhoeven
0 siblings, 2 replies; 6+ messages in thread
From: Fabrizio Castro @ 2019-02-20 16:09 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Fabrizio Castro, Michael Turquette, Stephen Boyd,
linux-renesas-soc, linux-clk, Simon Horman, Chris Paterson,
Biju Das
Enum LAST_DT_CORE_CLK needs updating as R8A774C0_CLK_CANFD
was recently added and it's the core clock with the highest
index.
Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
---
drivers/clk/renesas/r8a774c0-cpg-mssr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clk/renesas/r8a774c0-cpg-mssr.c b/drivers/clk/renesas/r8a774c0-cpg-mssr.c
index 4f3111b..48a578a 100644
--- a/drivers/clk/renesas/r8a774c0-cpg-mssr.c
+++ b/drivers/clk/renesas/r8a774c0-cpg-mssr.c
@@ -22,7 +22,7 @@
enum clk_ids {
/* Core Clock Outputs exported to DT */
- LAST_DT_CORE_CLK = R8A774C0_CLK_CPEX,
+ LAST_DT_CORE_CLK = R8A774C0_CLK_CANFD,
/* External Input Clocks */
CLK_EXTAL,
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* RE: [PATCH] clk: renesas: r8a774c0: Fix LAST_DT_CORE_CLK
2019-02-20 16:09 [PATCH] clk: renesas: r8a774c0: Fix LAST_DT_CORE_CLK Fabrizio Castro
@ 2019-02-20 20:39 ` Chris Paterson
2019-02-21 18:33 ` Geert Uytterhoeven
1 sibling, 0 replies; 6+ messages in thread
From: Chris Paterson @ 2019-02-20 20:39 UTC (permalink / raw)
To: Fabrizio Castro, Geert Uytterhoeven
Cc: Fabrizio Castro, Michael Turquette, Stephen Boyd,
linux-renesas-soc, linux-clk, Simon Horman, Biju Das
> From: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> Sent: 20 February 2019 16:09
> To: Geert Uytterhoeven <geert+renesas@glider.be>
> Cc: Fabrizio Castro <fabrizio.castro@bp.renesas.com>; Michael Turquette
> <mturquette@baylibre.com>; Stephen Boyd <sboyd@kernel.org>; linux-
> renesas-soc@vger.kernel.org; linux-clk@vger.kernel.org; Simon Horman
> <horms@verge.net.au>; Chris Paterson <Chris.Paterson2@renesas.com>;
> Biju Das <biju.das@bp.renesas.com>
> Subject: [PATCH] clk: renesas: r8a774c0: Fix LAST_DT_CORE_CLK
>
> Enum LAST_DT_CORE_CLK needs updating as R8A774C0_CLK_CANFD
> was recently added and it's the core clock with the highest
> index.
>
> Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
Reviewed-by: Chris Paterson <chris.paterson2@renesas.com>
> ---
> drivers/clk/renesas/r8a774c0-cpg-mssr.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/renesas/r8a774c0-cpg-mssr.c
> b/drivers/clk/renesas/r8a774c0-cpg-mssr.c
> index 4f3111b..48a578a 100644
> --- a/drivers/clk/renesas/r8a774c0-cpg-mssr.c
> +++ b/drivers/clk/renesas/r8a774c0-cpg-mssr.c
> @@ -22,7 +22,7 @@
>
> enum clk_ids {
> /* Core Clock Outputs exported to DT */
> - LAST_DT_CORE_CLK = R8A774C0_CLK_CPEX,
> + LAST_DT_CORE_CLK = R8A774C0_CLK_CANFD,
>
> /* External Input Clocks */
> CLK_EXTAL,
> --
> 2.7.4
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] clk: renesas: r8a774c0: Fix LAST_DT_CORE_CLK
2019-02-20 16:09 [PATCH] clk: renesas: r8a774c0: Fix LAST_DT_CORE_CLK Fabrizio Castro
2019-02-20 20:39 ` Chris Paterson
@ 2019-02-21 18:33 ` Geert Uytterhoeven
2019-02-21 21:10 ` Stephen Boyd
2019-02-22 10:12 ` Fabrizio Castro
1 sibling, 2 replies; 6+ messages in thread
From: Geert Uytterhoeven @ 2019-02-21 18:33 UTC (permalink / raw)
To: Fabrizio Castro
Cc: Geert Uytterhoeven, Michael Turquette, Stephen Boyd,
Linux-Renesas, linux-clk, Simon Horman, Chris Paterson, Biju Das
On Wed, Feb 20, 2019 at 5:09 PM Fabrizio Castro
<fabrizio.castro@bp.renesas.com> wrote:
> Enum LAST_DT_CORE_CLK needs updating as R8A774C0_CLK_CANFD
> was recently added and it's the core clock with the highest
> index.
>
> Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
Nice catch!
You only notice this kind of bug when you start referencing the clock
from DT, right? At registration time, the clock number space is shared with
internal core clocks, so no error is detected.
Can we improve that?
Fixes: 2a6efbc6da5d248c ("clk: renesas: r8a774c0: Add missing CANFD clock")
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Mike/Stephen: can you please take this one directly, as it is a fix for
clk-next?
Fabrizio: Looks like R8A774A1 has the same bug. Care to fix that as well?
Thanks!
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] clk: renesas: r8a774c0: Fix LAST_DT_CORE_CLK
2019-02-21 18:33 ` Geert Uytterhoeven
@ 2019-02-21 21:10 ` Stephen Boyd
2019-02-22 10:12 ` Fabrizio Castro
1 sibling, 0 replies; 6+ messages in thread
From: Stephen Boyd @ 2019-02-21 21:10 UTC (permalink / raw)
To: Fabrizio Castro, Geert Uytterhoeven
Cc: Geert Uytterhoeven, Michael Turquette, Linux-Renesas, linux-clk,
Simon Horman, Chris Paterson, Biju Das
Quoting Geert Uytterhoeven (2019-02-21 10:33:42)
> On Wed, Feb 20, 2019 at 5:09 PM Fabrizio Castro
> <fabrizio.castro@bp.renesas.com> wrote:
> > Enum LAST_DT_CORE_CLK needs updating as R8A774C0_CLK_CANFD
> > was recently added and it's the core clock with the highest
> > index.
> >
> > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
>
> Nice catch!
> You only notice this kind of bug when you start referencing the clock
> from DT, right? At registration time, the clock number space is shared with
> internal core clocks, so no error is detected.
> Can we improve that?
>
> Fixes: 2a6efbc6da5d248c ("clk: renesas: r8a774c0: Add missing CANFD clock")
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
> Mike/Stephen: can you please take this one directly, as it is a fix for
> clk-next?
>
Yep. Applied to clk-renesas and merged up.
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH] clk: renesas: r8a774c0: Fix LAST_DT_CORE_CLK
2019-02-21 18:33 ` Geert Uytterhoeven
2019-02-21 21:10 ` Stephen Boyd
@ 2019-02-22 10:12 ` Fabrizio Castro
2019-02-22 12:03 ` Fabrizio Castro
1 sibling, 1 reply; 6+ messages in thread
From: Fabrizio Castro @ 2019-02-22 10:12 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Geert Uytterhoeven, Michael Turquette, Stephen Boyd,
Linux-Renesas, linux-clk, Simon Horman, Chris Paterson, Biju Das
Hello Geert,
> From: linux-renesas-soc-owner@vger.kernel.org <linux-renesas-soc-owner@vger.kernel.org> On Behalf Of Geert Uytterhoeven
> Sent: 21 February 2019 18:34
> To: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> Subject: Re: [PATCH] clk: renesas: r8a774c0: Fix LAST_DT_CORE_CLK
>
> On Wed, Feb 20, 2019 at 5:09 PM Fabrizio Castro
> <fabrizio.castro@bp.renesas.com> wrote:
> > Enum LAST_DT_CORE_CLK needs updating as R8A774C0_CLK_CANFD
> > was recently added and it's the core clock with the highest
> > index.
> >
> > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
>
> Nice catch!
> You only notice this kind of bug when you start referencing the clock
> from DT, right? At registration time, the clock number space is shared with
> internal core clocks, so no error is detected.
> Can we improve that?
I can look into it
>
> Fixes: 2a6efbc6da5d248c ("clk: renesas: r8a774c0: Add missing CANFD clock")
Commit 2a6efbc6da5d248c is not in a release or in a rc, is it ok to refer to it with a fixes tag?
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
> Mike/Stephen: can you please take this one directly, as it is a fix for
> clk-next?
>
> Fabrizio: Looks like R8A774A1 has the same bug. Care to fix that as well?
Will do
Thanks,
Fab
>
> Thanks!
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH] clk: renesas: r8a774c0: Fix LAST_DT_CORE_CLK
2019-02-22 10:12 ` Fabrizio Castro
@ 2019-02-22 12:03 ` Fabrizio Castro
0 siblings, 0 replies; 6+ messages in thread
From: Fabrizio Castro @ 2019-02-22 12:03 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Geert Uytterhoeven, Michael Turquette, Stephen Boyd,
Linux-Renesas, linux-clk, Simon Horman, Chris Paterson, Biju Das,
Fabrizio Castro
Hello Geert,
> From: linux-renesas-soc-owner@vger.kernel.org <linux-renesas-soc-owner@vger.kernel.org> On Behalf Of Fabrizio Castro
> Sent: 22 February 2019 10:12
> Subject: RE: [PATCH] clk: renesas: r8a774c0: Fix LAST_DT_CORE_CLK
>
> Hello Geert,
>
> > From: linux-renesas-soc-owner@vger.kernel.org <linux-renesas-soc-owner@vger.kernel.org> On Behalf Of Geert Uytterhoeven
> > Sent: 21 February 2019 18:34
> > To: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> > Subject: Re: [PATCH] clk: renesas: r8a774c0: Fix LAST_DT_CORE_CLK
> >
> > On Wed, Feb 20, 2019 at 5:09 PM Fabrizio Castro
> > <fabrizio.castro@bp.renesas.com> wrote:
> > > Enum LAST_DT_CORE_CLK needs updating as R8A774C0_CLK_CANFD
> > > was recently added and it's the core clock with the highest
> > > index.
> > >
> > > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> >
> > Nice catch!
> > You only notice this kind of bug when you start referencing the clock
> > from DT, right? At registration time, the clock number space is shared with
> > internal core clocks, so no error is detected.
> > Can we improve that?
>
> I can look into it
Actually, it seems like I am a bit tight on time, not sure I am going to have the chance to look into this, sorry Geert
Thanks,
Fab
>
> >
> > Fixes: 2a6efbc6da5d248c ("clk: renesas: r8a774c0: Add missing CANFD clock")
>
> Commit 2a6efbc6da5d248c is not in a release or in a rc, is it ok to refer to it with a fixes tag?
>
> > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> >
> > Mike/Stephen: can you please take this one directly, as it is a fix for
> > clk-next?
> >
> > Fabrizio: Looks like R8A774A1 has the same bug. Care to fix that as well?
>
> Will do
>
> Thanks,
> Fab
>
> >
> > Thanks!
> >
> > Gr{oetje,eeting}s,
> >
> > Geert
> >
> > --
> > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
> >
> > In personal conversations with technical people, I call myself a hacker. But
> > when I'm talking to journalists I just say "programmer" or something like that.
> > -- Linus Torvalds
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-02-22 12:03 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-20 16:09 [PATCH] clk: renesas: r8a774c0: Fix LAST_DT_CORE_CLK Fabrizio Castro
2019-02-20 20:39 ` Chris Paterson
2019-02-21 18:33 ` Geert Uytterhoeven
2019-02-21 21:10 ` Stephen Boyd
2019-02-22 10:12 ` Fabrizio Castro
2019-02-22 12:03 ` Fabrizio Castro
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).