[PATCH 0/5] Add VIN support to RZ/G2M

[PATCH 0/5] Add VIN support to RZ/G2M

[Biju Das]

This patch series aims to add VIN support for RZ/G2M SoC.
RZ/G2M SoC is similar to R-Car Gen3 M3-W SoC.

This patchset is based on media_tree git and 
renesas-devel-20180906-v4.19-rc2.

Biju Das (5):
  media: dt-bindings: media: rcar-csi2: Add r8a774a1 support
  media: rcar-csi2: Enable support for r8a774a1
  media: dt-bindings: media: rcar_vin: Add r8a774a1 support
  media: rcar-vin: Enable support for r8a774a1
  arm64: dts: renesas: r8a774a1: Add VIN and CSI-2 nodes

 .../devicetree/bindings/media/rcar_vin.txt         |   5 +-
 .../bindings/media/renesas,rcar-csi2.txt           |   5 +-
 arch/arm64/boot/dts/renesas/r8a774a1.dtsi          | 367 +++++++++++++++++++++
 drivers/media/platform/rcar-vin/rcar-core.c        |   4 +
 drivers/media/platform/rcar-vin/rcar-csi2.c        |   4 +
 5 files changed, 381 insertions(+), 4 deletions(-)

-- 
2.7.4

[PATCH 1/5] media: dt-bindings: media: rcar-csi2: Add r8a774a1 support

[Biju Das]

Document RZ/G2M (R8A774A1) SoC bindings.

The RZ/G2M SoC is similar to R-Car M3-W (R8A7796).

Signed-off-by: Biju Das <biju.das@bp.renesas.com>
Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
---
 Documentation/devicetree/bindings/media/renesas,rcar-csi2.txt | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/media/renesas,rcar-csi2.txt b/Documentation/devicetree/bindings/media/renesas,rcar-csi2.txt
index 2d385b6..12fe685 100644
--- a/Documentation/devicetree/bindings/media/renesas,rcar-csi2.txt
+++ b/Documentation/devicetree/bindings/media/renesas,rcar-csi2.txt
@@ -2,12 +2,13 @@ Renesas R-Car MIPI CSI-2
 ------------------------
 
 The R-Car CSI-2 receiver device provides MIPI CSI-2 capabilities for the
-Renesas R-Car family of devices. It is used in conjunction with the
-R-Car VIN module, which provides the video capture capabilities.
+Renesas R-Car Gen3 and RZ/G2 family of devices. It is used in conjunction
+with the R-Car VIN module, which provides the video capture capabilities.
 
 Mandatory properties
 --------------------
  - compatible: Must be one or more of the following
+   - "renesas,r8a774a1-csi2" for the R8A774A1 device.
    - "renesas,r8a7795-csi2" for the R8A7795 device.
    - "renesas,r8a7796-csi2" for the R8A7796 device.
    - "renesas,r8a77965-csi2" for the R8A77965 device.
-- 
2.7.4

Re: [PATCH 1/5] media: dt-bindings: media: rcar-csi2: Add r8a774a1 support

[Niklas Söderlund]

Hi Biju,

Thanks for your work.

On 2018-09-10 15:31:14 +0100, Biju Das wrote:
> Document RZ/G2M (R8A774A1) SoC bindings.
> 
> The RZ/G2M SoC is similar to R-Car M3-W (R8A7796).
> 
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>

Acked-by: Niklas S�derlund <niklas.soderlund+renesas@ragnatech.se>

> ---
>  Documentation/devicetree/bindings/media/renesas,rcar-csi2.txt | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/media/renesas,rcar-csi2.txt b/Documentation/devicetree/bindings/media/renesas,rcar-csi2.txt
> index 2d385b6..12fe685 100644
> --- a/Documentation/devicetree/bindings/media/renesas,rcar-csi2.txt
> +++ b/Documentation/devicetree/bindings/media/renesas,rcar-csi2.txt
> @@ -2,12 +2,13 @@ Renesas R-Car MIPI CSI-2
>  ------------------------
>  
>  The R-Car CSI-2 receiver device provides MIPI CSI-2 capabilities for the
> -Renesas R-Car family of devices. It is used in conjunction with the
> -R-Car VIN module, which provides the video capture capabilities.
> +Renesas R-Car Gen3 and RZ/G2 family of devices. It is used in conjunction
> +with the R-Car VIN module, which provides the video capture capabilities.
>  
>  Mandatory properties
>  --------------------
>   - compatible: Must be one or more of the following
> +   - "renesas,r8a774a1-csi2" for the R8A774A1 device.
>     - "renesas,r8a7795-csi2" for the R8A7795 device.
>     - "renesas,r8a7796-csi2" for the R8A7796 device.
>     - "renesas,r8a77965-csi2" for the R8A77965 device.
> -- 
> 2.7.4
> 

-- 
Regards,
Niklas S�derlund

RE: [PATCH 1/5] media: dt-bindings: media: rcar-csi2: Add r8a774a1 support

[Fabrizio Castro]

Dear All,

Who is the best person to take this patch?

Thanks,
Fab

> From: Biju Das <biju.das@bp.renesas.com>
> Sent: 10 September 2018 15:31
> Subject: [PATCH 1/5] media: dt-bindings: media: rcar-csi2: Add r8a774a1 support
>
> Document RZ/G2M (R8A774A1) SoC bindings.
>
> The RZ/G2M SoC is similar to R-Car M3-W (R8A7796).
>
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> ---
>  Documentation/devicetree/bindings/media/renesas,rcar-csi2.txt | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/media/renesas,rcar-csi2.txt
> b/Documentation/devicetree/bindings/media/renesas,rcar-csi2.txt
> index 2d385b6..12fe685 100644
> --- a/Documentation/devicetree/bindings/media/renesas,rcar-csi2.txt
> +++ b/Documentation/devicetree/bindings/media/renesas,rcar-csi2.txt
> @@ -2,12 +2,13 @@ Renesas R-Car MIPI CSI-2
>  ------------------------
>
>  The R-Car CSI-2 receiver device provides MIPI CSI-2 capabilities for the
> -Renesas R-Car family of devices. It is used in conjunction with the
> -R-Car VIN module, which provides the video capture capabilities.
> +Renesas R-Car Gen3 and RZ/G2 family of devices. It is used in conjunction
> +with the R-Car VIN module, which provides the video capture capabilities.
>
>  Mandatory properties
>  --------------------
>   - compatible: Must be one or more of the following
> +   - "renesas,r8a774a1-csi2" for the R8A774A1 device.
>     - "renesas,r8a7795-csi2" for the R8A7795 device.
>     - "renesas,r8a7796-csi2" for the R8A7796 device.
>     - "renesas,r8a77965-csi2" for the R8A77965 device.
> --
> 2.7.4




Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.

Re: [PATCH 1/5] media: dt-bindings: media: rcar-csi2: Add r8a774a1 support

[Simon Horman]

On Thu, Nov 08, 2018 at 12:50:22PM +0000, Fabrizio Castro wrote:
> Dear All,
> 
> Who is the best person to take this patch?

I believe this patch is for Mauro.

RE: [PATCH 1/5] media: dt-bindings: media: rcar-csi2: Add r8a774a1 support

[Fabrizio Castro]

Thank you Simon for getting back to me.

Cheers,
Fab

> Subject: Re: [PATCH 1/5] media: dt-bindings: media: rcar-csi2: Add r8a774a1 support
>
> On Thu, Nov 08, 2018 at 12:50:22PM +0000, Fabrizio Castro wrote:
> > Dear All,
> >
> > Who is the best person to take this patch?
>
> I believe this patch is for Mauro.



Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.

Re: [PATCH 1/5] media: dt-bindings: media: rcar-csi2: Add r8a774a1 support

[Simon Horman]

On Mon, Sep 10, 2018 at 03:31:14PM +0100, Biju Das wrote:
> Document RZ/G2M (R8A774A1) SoC bindings.
> 
> The RZ/G2M SoC is similar to R-Car M3-W (R8A7796).
> 
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>

Reviewed-by: Simon Horman <horms+renesas@verge.net.au>

RE: [PATCH 1/5] media: dt-bindings: media: rcar-csi2: Add r8a774a1 support

[Fabrizio Castro]

Hello Mauro,

Does this patch look ok to you?

Thanks,
Fab

> From: Biju Das <biju.das@bp.renesas.com>
> Sent: 10 September 2018 15:31
> Subject: [PATCH 1/5] media: dt-bindings: media: rcar-csi2: Add r8a774a1 support
>
> Document RZ/G2M (R8A774A1) SoC bindings.
>
> The RZ/G2M SoC is similar to R-Car M3-W (R8A7796).
>
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> ---
>  Documentation/devicetree/bindings/media/renesas,rcar-csi2.txt | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/media/renesas,rcar-csi2.txt
> b/Documentation/devicetree/bindings/media/renesas,rcar-csi2.txt
> index 2d385b6..12fe685 100644
> --- a/Documentation/devicetree/bindings/media/renesas,rcar-csi2.txt
> +++ b/Documentation/devicetree/bindings/media/renesas,rcar-csi2.txt
> @@ -2,12 +2,13 @@ Renesas R-Car MIPI CSI-2
>  ------------------------
>
>  The R-Car CSI-2 receiver device provides MIPI CSI-2 capabilities for the
> -Renesas R-Car family of devices. It is used in conjunction with the
> -R-Car VIN module, which provides the video capture capabilities.
> +Renesas R-Car Gen3 and RZ/G2 family of devices. It is used in conjunction
> +with the R-Car VIN module, which provides the video capture capabilities.
>
>  Mandatory properties
>  --------------------
>   - compatible: Must be one or more of the following
> +   - "renesas,r8a774a1-csi2" for the R8A774A1 device.
>     - "renesas,r8a7795-csi2" for the R8A7795 device.
>     - "renesas,r8a7796-csi2" for the R8A7796 device.
>     - "renesas,r8a77965-csi2" for the R8A77965 device.
> --
> 2.7.4




Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.

RE: [PATCH 1/5] media: dt-bindings: media: rcar-csi2: Add r8a774a1 support

[Fabrizio Castro]

Hello Mauro,

This is a gentle reminder.

Thanks,
Fab

> From: linux-renesas-soc-owner@vger.kernel.org <linux-renesas-soc-owner@vger.kernel.org> On Behalf Of Fabrizio Castro
> Sent: 08 November 2018 14:19
> Subject: RE: [PATCH 1/5] media: dt-bindings: media: rcar-csi2: Add r8a774a1 support
>
> Hello Mauro,
>
> Does this patch look ok to you?
>
> Thanks,
> Fab
>
> > From: Biju Das <biju.das@bp.renesas.com>
> > Sent: 10 September 2018 15:31
> > Subject: [PATCH 1/5] media: dt-bindings: media: rcar-csi2: Add r8a774a1 support
> >
> > Document RZ/G2M (R8A774A1) SoC bindings.
> >
> > The RZ/G2M SoC is similar to R-Car M3-W (R8A7796).
> >
> > Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> > Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> > ---
> >  Documentation/devicetree/bindings/media/renesas,rcar-csi2.txt | 5 +++--
> >  1 file changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/media/renesas,rcar-csi2.txt
> > b/Documentation/devicetree/bindings/media/renesas,rcar-csi2.txt
> > index 2d385b6..12fe685 100644
> > --- a/Documentation/devicetree/bindings/media/renesas,rcar-csi2.txt
> > +++ b/Documentation/devicetree/bindings/media/renesas,rcar-csi2.txt
> > @@ -2,12 +2,13 @@ Renesas R-Car MIPI CSI-2
> >  ------------------------
> >
> >  The R-Car CSI-2 receiver device provides MIPI CSI-2 capabilities for the
> > -Renesas R-Car family of devices. It is used in conjunction with the
> > -R-Car VIN module, which provides the video capture capabilities.
> > +Renesas R-Car Gen3 and RZ/G2 family of devices. It is used in conjunction
> > +with the R-Car VIN module, which provides the video capture capabilities.
> >
> >  Mandatory properties
> >  --------------------
> >   - compatible: Must be one or more of the following
> > +   - "renesas,r8a774a1-csi2" for the R8A774A1 device.
> >     - "renesas,r8a7795-csi2" for the R8A7795 device.
> >     - "renesas,r8a7796-csi2" for the R8A7796 device.
> >     - "renesas,r8a77965-csi2" for the R8A77965 device.
> > --
> > 2.7.4
>
>
>
>
> Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England &
> Wales under Registered No. 04586709.



Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.

RE: [PATCH 1/5] media: dt-bindings: media: rcar-csi2: Add r8a774a1 support

[Fabrizio Castro]

Hello Mauro,

This patch has been around for some time now, do you think you can take it?

Cheers,
Fab

> From: Biju Das <biju.das@bp.renesas.com>
> Sent: 10 September 2018 15:31
> Subject: [PATCH 1/5] media: dt-bindings: media: rcar-csi2: Add r8a774a1 support
> 
> Document RZ/G2M (R8A774A1) SoC bindings.
> 
> The RZ/G2M SoC is similar to R-Car M3-W (R8A7796).
> 
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> ---
>  Documentation/devicetree/bindings/media/renesas,rcar-csi2.txt | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/media/renesas,rcar-csi2.txt
> b/Documentation/devicetree/bindings/media/renesas,rcar-csi2.txt
> index 2d385b6..12fe685 100644
> --- a/Documentation/devicetree/bindings/media/renesas,rcar-csi2.txt
> +++ b/Documentation/devicetree/bindings/media/renesas,rcar-csi2.txt
> @@ -2,12 +2,13 @@ Renesas R-Car MIPI CSI-2
>  ------------------------
> 
>  The R-Car CSI-2 receiver device provides MIPI CSI-2 capabilities for the
> -Renesas R-Car family of devices. It is used in conjunction with the
> -R-Car VIN module, which provides the video capture capabilities.
> +Renesas R-Car Gen3 and RZ/G2 family of devices. It is used in conjunction
> +with the R-Car VIN module, which provides the video capture capabilities.
> 
>  Mandatory properties
>  --------------------
>   - compatible: Must be one or more of the following
> +   - "renesas,r8a774a1-csi2" for the R8A774A1 device.
>     - "renesas,r8a7795-csi2" for the R8A7795 device.
>     - "renesas,r8a7796-csi2" for the R8A7796 device.
>     - "renesas,r8a77965-csi2" for the R8A77965 device.
> --
> 2.7.4

Re: [PATCH 1/5] media: dt-bindings: media: rcar-csi2: Add r8a774a1 support

[Hans Verkuil]

Hi Fabrizio,

It looks like this series fell through the cracks.

I looked at it and the main problem is that it is missing a Reviewed-by
from Rob Herring (devicetree maintainer). It's a bit surprising since he
is usually fairly prompt.

I recommend that you rebase and repost it and I'll delegate the v2 series
to me so we can hopefully get it in for 5.2 (5.1 is likely too late) once
Rob reviews it.

BTW, I'm the one who usually processes rcar patches. But it was delegated in
patchwork to Laurent, so I never saw it.

Regards,

	Hans

On 3/1/19 1:09 PM, Fabrizio Castro wrote:
> Hello Mauro,
> 
> This patch has been around for some time now, do you think you can take it?
> 
> Cheers,
> Fab
> 
>> From: Biju Das <biju.das@bp.renesas.com>
>> Sent: 10 September 2018 15:31
>> Subject: [PATCH 1/5] media: dt-bindings: media: rcar-csi2: Add r8a774a1 support
>>
>> Document RZ/G2M (R8A774A1) SoC bindings.
>>
>> The RZ/G2M SoC is similar to R-Car M3-W (R8A7796).
>>
>> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
>> Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
>> ---
>>  Documentation/devicetree/bindings/media/renesas,rcar-csi2.txt | 5 +++--
>>  1 file changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/media/renesas,rcar-csi2.txt
>> b/Documentation/devicetree/bindings/media/renesas,rcar-csi2.txt
>> index 2d385b6..12fe685 100644
>> --- a/Documentation/devicetree/bindings/media/renesas,rcar-csi2.txt
>> +++ b/Documentation/devicetree/bindings/media/renesas,rcar-csi2.txt
>> @@ -2,12 +2,13 @@ Renesas R-Car MIPI CSI-2
>>  ------------------------
>>
>>  The R-Car CSI-2 receiver device provides MIPI CSI-2 capabilities for the
>> -Renesas R-Car family of devices. It is used in conjunction with the
>> -R-Car VIN module, which provides the video capture capabilities.
>> +Renesas R-Car Gen3 and RZ/G2 family of devices. It is used in conjunction
>> +with the R-Car VIN module, which provides the video capture capabilities.
>>
>>  Mandatory properties
>>  --------------------
>>   - compatible: Must be one or more of the following
>> +   - "renesas,r8a774a1-csi2" for the R8A774A1 device.
>>     - "renesas,r8a7795-csi2" for the R8A7795 device.
>>     - "renesas,r8a7796-csi2" for the R8A7796 device.
>>     - "renesas,r8a77965-csi2" for the R8A77965 device.
>> --
>> 2.7.4
> 

Re: [PATCH 1/5] media: dt-bindings: media: rcar-csi2: Add r8a774a1 support

[Geert Uytterhoeven]

Hi Hans,

On Fri, Mar 1, 2019 at 1:55 PM Hans Verkuil <hverkuil@xs4all.nl> wrote:
> It looks like this series fell through the cracks.
>
> I looked at it and the main problem is that it is missing a Reviewed-by
> from Rob Herring (devicetree maintainer). It's a bit surprising since he
> is usually fairly prompt.

He actually did provide his Rb on Sep 17.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH 1/5] media: dt-bindings: media: rcar-csi2: Add r8a774a1 support

[Hans Verkuil]

On 3/1/19 1:58 PM, Geert Uytterhoeven wrote:
> Hi Hans,
> 
> On Fri, Mar 1, 2019 at 1:55 PM Hans Verkuil <hverkuil@xs4all.nl> wrote:
>> It looks like this series fell through the cracks.
>>
>> I looked at it and the main problem is that it is missing a Reviewed-by
>> from Rob Herring (devicetree maintainer). It's a bit surprising since he
>> is usually fairly prompt.
> 
> He actually did provide his Rb on Sep 17.

Hmm, I don't see anything about that in my linux-media archive, and patchwork
didn't pick that up either.

Was linux-media in the CC list of Rob's reply?

Regards,

	Hans

> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 

RE: [PATCH 1/5] media: dt-bindings: media: rcar-csi2: Add r8a774a1 support

[Biju Das]

Hi Hans,

Thanks for the feedback.

> -----Original Message-----
> From: Hans Verkuil <hverkuil@xs4all.nl>
> Sent: 01 March 2019 13:09
> To: Geert Uytterhoeven <geert@linux-m68k.org>
> Cc: Fabrizio Castro <fabrizio.castro@bp.renesas.com>; Mauro Carvalho
> Chehab <mchehab@kernel.org>; Biju Das <biju.das@bp.renesas.com>;
> Niklas Söderlund <niklas.soderlund@ragnatech.se>; linux-
> media@vger.kernel.org; linux-renesas-soc@vger.kernel.org;
> devicetree@vger.kernel.org; Simon Horman <horms@verge.net.au>; Geert
> Uytterhoeven <geert+renesas@glider.be>; Chris Paterson
> <Chris.Paterson2@renesas.com>; Rob Herring <robh+dt@kernel.org>; Mark
> Rutland <mark.rutland@arm.com>; Laurent Pinchart
> <laurent.pinchart@ideasonboard.com>
> Subject: Re: [PATCH 1/5] media: dt-bindings: media: rcar-csi2: Add r8a774a1
> support
>
> On 3/1/19 1:58 PM, Geert Uytterhoeven wrote:
> > Hi Hans,
> >
> > On Fri, Mar 1, 2019 at 1:55 PM Hans Verkuil <hverkuil@xs4all.nl> wrote:
> >> It looks like this series fell through the cracks.
> >>
> >> I looked at it and the main problem is that it is missing a
> >> Reviewed-by from Rob Herring (devicetree maintainer). It's a bit
> >> surprising since he is usually fairly prompt.
> >
> > He actually did provide his Rb on Sep 17.
>
> Hmm, I don't see anything about that in my linux-media archive, and
> patchwork didn't pick that up either.
>
> Was linux-media in the CC list of Rob's reply?

Yes. Please see below.

> -----Original Message-----
> From: Rob Herring <robh@kernel.org>
> Sent: 17 September 2018 06:45
> To: Biju Das <biju.das@bp.renesas.com>
> Cc: Mauro Carvalho Chehab <mchehab@kernel.org>; Mark Rutland
> <mark.rutland@arm.com>; Biju Das <biju.das@bp.renesas.com>; Niklas
> Söderlund <niklas.soderlund@ragnatech.se>; linux-media@vger.kernel.org;
> linux-renesas-soc@vger.kernel.org; devicetree@vger.kernel.org; Simon
> Horman <horms@verge.net.au>; Geert Uytterhoeven
> <geert+renesas@glider.be>; Chris Paterson
> <Chris.Paterson2@renesas.com>; Fabrizio Castro
> <fabrizio.castro@bp.renesas.com>
> Subject: Re: [PATCH 1/5] media: dt-bindings: media: rcar-csi2: Add r8a774a1
> support
>
> On Mon, 10 Sep 2018 15:31:14 +0100, Biju Das wrote:
> > Document RZ/G2M (R8A774A1) SoC bindings.
> >
> > The RZ/G2M SoC is similar to R-Car M3-W (R8A7796).
> >
> > Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> > Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> > ---
> >  Documentation/devicetree/bindings/media/renesas,rcar-csi2.txt | 5 +++--
> >  1 file changed, 3 insertions(+), 2 deletions(-)
> >
>
> Reviewed-by: Rob Herring <robh@kernel.org>

Regards,
Biju


Renesas Electronics Europe GmbH,Geschaeftsfuehrer/President : Michael Hannawald, Sitz der Gesellschaft/Registered office: Duesseldorf, Arcadiastrasse 10, 40472 Duesseldorf, Germany,Handelsregister/Commercial Register: Duesseldorf, HRB 3708 USt-IDNr./Tax identification no.: DE 119353406 WEEE-Reg.-Nr./WEEE reg. no.: DE 14978647

Re: [PATCH 1/5] media: dt-bindings: media: rcar-csi2: Add r8a774a1 support

[Hans Verkuil]

Hi Biju,

Can you do the following:

1) forward both of Rob's replies with his Reviewed-by tag to linux-media,
   that way I have seen it.
2) rebase the patch series and add all Reviewed-by etc. tags and post as
   a v2. I'll pick it up and make sure it will get merged. Not sure if we
   can manage 5.1, but it will certainly get in 5.2.

Regards,

	Hans

On 3/1/19 2:12 PM, Biju Das wrote:
> Hi Hans,
> 
> Thanks for the feedback.
> 
>> -----Original Message-----
>> From: Hans Verkuil <hverkuil@xs4all.nl>
>> Sent: 01 March 2019 13:09
>> To: Geert Uytterhoeven <geert@linux-m68k.org>
>> Cc: Fabrizio Castro <fabrizio.castro@bp.renesas.com>; Mauro Carvalho
>> Chehab <mchehab@kernel.org>; Biju Das <biju.das@bp.renesas.com>;
>> Niklas Söderlund <niklas.soderlund@ragnatech.se>; linux-
>> media@vger.kernel.org; linux-renesas-soc@vger.kernel.org;
>> devicetree@vger.kernel.org; Simon Horman <horms@verge.net.au>; Geert
>> Uytterhoeven <geert+renesas@glider.be>; Chris Paterson
>> <Chris.Paterson2@renesas.com>; Rob Herring <robh+dt@kernel.org>; Mark
>> Rutland <mark.rutland@arm.com>; Laurent Pinchart
>> <laurent.pinchart@ideasonboard.com>
>> Subject: Re: [PATCH 1/5] media: dt-bindings: media: rcar-csi2: Add r8a774a1
>> support
>>
>> On 3/1/19 1:58 PM, Geert Uytterhoeven wrote:
>>> Hi Hans,
>>>
>>> On Fri, Mar 1, 2019 at 1:55 PM Hans Verkuil <hverkuil@xs4all.nl> wrote:
>>>> It looks like this series fell through the cracks.
>>>>
>>>> I looked at it and the main problem is that it is missing a
>>>> Reviewed-by from Rob Herring (devicetree maintainer). It's a bit
>>>> surprising since he is usually fairly prompt.
>>>
>>> He actually did provide his Rb on Sep 17.
>>
>> Hmm, I don't see anything about that in my linux-media archive, and
>> patchwork didn't pick that up either.
>>
>> Was linux-media in the CC list of Rob's reply?
> 
> Yes. Please see below.
> 
>> -----Original Message-----
>> From: Rob Herring <robh@kernel.org>
>> Sent: 17 September 2018 06:45
>> To: Biju Das <biju.das@bp.renesas.com>
>> Cc: Mauro Carvalho Chehab <mchehab@kernel.org>; Mark Rutland
>> <mark.rutland@arm.com>; Biju Das <biju.das@bp.renesas.com>; Niklas
>> Söderlund <niklas.soderlund@ragnatech.se>; linux-media@vger.kernel.org;
>> linux-renesas-soc@vger.kernel.org; devicetree@vger.kernel.org; Simon
>> Horman <horms@verge.net.au>; Geert Uytterhoeven
>> <geert+renesas@glider.be>; Chris Paterson
>> <Chris.Paterson2@renesas.com>; Fabrizio Castro
>> <fabrizio.castro@bp.renesas.com>
>> Subject: Re: [PATCH 1/5] media: dt-bindings: media: rcar-csi2: Add r8a774a1
>> support
>>
>> On Mon, 10 Sep 2018 15:31:14 +0100, Biju Das wrote:
>>> Document RZ/G2M (R8A774A1) SoC bindings.
>>>
>>> The RZ/G2M SoC is similar to R-Car M3-W (R8A7796).
>>>
>>> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
>>> Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
>>> ---
>>>  Documentation/devicetree/bindings/media/renesas,rcar-csi2.txt | 5 +++--
>>>  1 file changed, 3 insertions(+), 2 deletions(-)
>>>
>>
>> Reviewed-by: Rob Herring <robh@kernel.org>
> 
> Regards,
> Biju
> 
> 
> Renesas Electronics Europe GmbH,Geschaeftsfuehrer/President : Michael Hannawald, Sitz der Gesellschaft/Registered office: Duesseldorf, Arcadiastrasse 10, 40472 Duesseldorf, Germany,Handelsregister/Commercial Register: Duesseldorf, HRB 3708 USt-IDNr./Tax identification no.: DE 119353406 WEEE-Reg.-Nr./WEEE reg. no.: DE 14978647
> 

RE: [PATCH 1/5] media: dt-bindings: media: rcar-csi2: Add r8a774a1 support

[Biju Das]

Hi Hans,

Yes. Will do.

Regards,
Biju

> -----Original Message-----
> From: Hans Verkuil <hverkuil@xs4all.nl>
> Sent: 01 March 2019 13:19
> To: Biju Das <biju.das@bp.renesas.com>; Geert Uytterhoeven
> <geert@linux-m68k.org>
> Cc: Fabrizio Castro <fabrizio.castro@bp.renesas.com>; Mauro Carvalho
> Chehab <mchehab@kernel.org>; Niklas Söderlund
> <niklas.soderlund@ragnatech.se>; linux-media@vger.kernel.org; linux-
> renesas-soc@vger.kernel.org; devicetree@vger.kernel.org; Simon Horman
> <horms@verge.net.au>; Geert Uytterhoeven <geert+renesas@glider.be>;
> Chris Paterson <Chris.Paterson2@renesas.com>; Rob Herring
> <robh+dt@kernel.org>; Mark Rutland <mark.rutland@arm.com>; Laurent
> Pinchart <laurent.pinchart@ideasonboard.com>
> Subject: Re: [PATCH 1/5] media: dt-bindings: media: rcar-csi2: Add r8a774a1
> support
>
> Hi Biju,
>
> Can you do the following:
>
> 1) forward both of Rob's replies with his Reviewed-by tag to linux-media,
>    that way I have seen it.
> 2) rebase the patch series and add all Reviewed-by etc. tags and post as
>    a v2. I'll pick it up and make sure it will get merged. Not sure if we
>    can manage 5.1, but it will certainly get in 5.2.
>
> Regards,
>
> Hans
>
> On 3/1/19 2:12 PM, Biju Das wrote:
> > Hi Hans,
> >
> > Thanks for the feedback.
> >
> >> -----Original Message-----
> >> From: Hans Verkuil <hverkuil@xs4all.nl>
> >> Sent: 01 March 2019 13:09
> >> To: Geert Uytterhoeven <geert@linux-m68k.org>
> >> Cc: Fabrizio Castro <fabrizio.castro@bp.renesas.com>; Mauro Carvalho
> >> Chehab <mchehab@kernel.org>; Biju Das <biju.das@bp.renesas.com>;
> >> Niklas Söderlund <niklas.soderlund@ragnatech.se>; linux-
> >> media@vger.kernel.org; linux-renesas-soc@vger.kernel.org;
> >> devicetree@vger.kernel.org; Simon Horman <horms@verge.net.au>;
> Geert
> >> Uytterhoeven <geert+renesas@glider.be>; Chris Paterson
> >> <Chris.Paterson2@renesas.com>; Rob Herring <robh+dt@kernel.org>;
> Mark
> >> Rutland <mark.rutland@arm.com>; Laurent Pinchart
> >> <laurent.pinchart@ideasonboard.com>
> >> Subject: Re: [PATCH 1/5] media: dt-bindings: media: rcar-csi2: Add
> >> r8a774a1 support
> >>
> >> On 3/1/19 1:58 PM, Geert Uytterhoeven wrote:
> >>> Hi Hans,
> >>>
> >>> On Fri, Mar 1, 2019 at 1:55 PM Hans Verkuil <hverkuil@xs4all.nl> wrote:
> >>>> It looks like this series fell through the cracks.
> >>>>
> >>>> I looked at it and the main problem is that it is missing a
> >>>> Reviewed-by from Rob Herring (devicetree maintainer). It's a bit
> >>>> surprising since he is usually fairly prompt.
> >>>
> >>> He actually did provide his Rb on Sep 17.
> >>
> >> Hmm, I don't see anything about that in my linux-media archive, and
> >> patchwork didn't pick that up either.
> >>
> >> Was linux-media in the CC list of Rob's reply?
> >
> > Yes. Please see below.
> >
> >> -----Original Message-----
> >> From: Rob Herring <robh@kernel.org>
> >> Sent: 17 September 2018 06:45
> >> To: Biju Das <biju.das@bp.renesas.com>
> >> Cc: Mauro Carvalho Chehab <mchehab@kernel.org>; Mark Rutland
> >> <mark.rutland@arm.com>; Biju Das <biju.das@bp.renesas.com>; Niklas
> >> Söderlund <niklas.soderlund@ragnatech.se>;
> >> linux-media@vger.kernel.org; linux-renesas-soc@vger.kernel.org;
> >> devicetree@vger.kernel.org; Simon Horman <horms@verge.net.au>;
> Geert
> >> Uytterhoeven <geert+renesas@glider.be>; Chris Paterson
> >> <Chris.Paterson2@renesas.com>; Fabrizio Castro
> >> <fabrizio.castro@bp.renesas.com>
> >> Subject: Re: [PATCH 1/5] media: dt-bindings: media: rcar-csi2: Add
> >> r8a774a1 support
> >>
> >> On Mon, 10 Sep 2018 15:31:14 +0100, Biju Das wrote:
> >>> Document RZ/G2M (R8A774A1) SoC bindings.
> >>>
> >>> The RZ/G2M SoC is similar to R-Car M3-W (R8A7796).
> >>>
> >>> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> >>> Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> >>> ---
> >>>  Documentation/devicetree/bindings/media/renesas,rcar-csi2.txt | 5
> >>> +++--
> >>>  1 file changed, 3 insertions(+), 2 deletions(-)
> >>>
> >>
> >> Reviewed-by: Rob Herring <robh@kernel.org>
> >
> > Regards,
> > Biju
> >
> >
> > Renesas Electronics Europe GmbH,Geschaeftsfuehrer/President : Michael
> > Hannawald, Sitz der Gesellschaft/Registered office: Duesseldorf,
> > Arcadiastrasse 10, 40472 Duesseldorf,
> > Germany,Handelsregister/Commercial Register: Duesseldorf, HRB 3708
> > USt-IDNr./Tax identification no.: DE 119353406 WEEE-Reg.-Nr./WEEE reg.
> > no.: DE 14978647
> >



Renesas Electronics Europe GmbH,Geschaeftsfuehrer/President : Michael Hannawald, Sitz der Gesellschaft/Registered office: Duesseldorf, Arcadiastrasse 10, 40472 Duesseldorf, Germany,Handelsregister/Commercial Register: Duesseldorf, HRB 3708 USt-IDNr./Tax identification no.: DE 119353406 WEEE-Reg.-Nr./WEEE reg. no.: DE 14978647

Re: [PATCH 1/5] media: dt-bindings: media: rcar-csi2: Add r8a774a1 support

[Geert Uytterhoeven]

Hi Hans,

On Fri, Mar 1, 2019 at 2:08 PM Hans Verkuil <hverkuil@xs4all.nl> wrote:
> On 3/1/19 1:58 PM, Geert Uytterhoeven wrote:
> > On Fri, Mar 1, 2019 at 1:55 PM Hans Verkuil <hverkuil@xs4all.nl> wrote:
> >> It looks like this series fell through the cracks.
> >>
> >> I looked at it and the main problem is that it is missing a Reviewed-by
> >> from Rob Herring (devicetree maintainer). It's a bit surprising since he
> >> is usually fairly prompt.
> >
> > He actually did provide his Rb on Sep 17.
>
> Hmm, I don't see anything about that in my linux-media archive, and patchwork
> didn't pick that up either.
>
> Was linux-media in the CC list of Rob's reply?

Yes it was, just like linux-renesas-soc. But lore.kernel.org also has
no evidence.
I have received it directly, as I was on CC.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH 1/5] media: dt-bindings: media: rcar-csi2: Add r8a774a1 support

[Laurent Pinchart]

Hi Hans,

On Fri, Mar 01, 2019 at 01:55:53PM +0100, Hans Verkuil wrote:
> Hi Fabrizio,
> 
> It looks like this series fell through the cracks.
> 
> I looked at it and the main problem is that it is missing a Reviewed-by
> from Rob Herring (devicetree maintainer). It's a bit surprising since he
> is usually fairly prompt.
> 
> I recommend that you rebase and repost it and I'll delegate the v2 series
> to me so we can hopefully get it in for 5.2 (5.1 is likely too late) once
> Rob reviews it.
> 
> BTW, I'm the one who usually processes rcar patches. But it was delegated in
> patchwork to Laurent, so I never saw it.

I handle the VSP and FDP patches. I propose delegating the CSI-2 and VIN
to Niklas.

> On 3/1/19 1:09 PM, Fabrizio Castro wrote:
> > Hello Mauro,
> > 
> > This patch has been around for some time now, do you think you can take it?
> > 
> > Cheers,
> > Fab
> > 
> >> From: Biju Das <biju.das@bp.renesas.com>
> >> Sent: 10 September 2018 15:31
> >> Subject: [PATCH 1/5] media: dt-bindings: media: rcar-csi2: Add r8a774a1 support
> >>
> >> Document RZ/G2M (R8A774A1) SoC bindings.
> >>
> >> The RZ/G2M SoC is similar to R-Car M3-W (R8A7796).
> >>
> >> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> >> Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> >> ---
> >>  Documentation/devicetree/bindings/media/renesas,rcar-csi2.txt | 5 +++--
> >>  1 file changed, 3 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/Documentation/devicetree/bindings/media/renesas,rcar-csi2.txt
> >> b/Documentation/devicetree/bindings/media/renesas,rcar-csi2.txt
> >> index 2d385b6..12fe685 100644
> >> --- a/Documentation/devicetree/bindings/media/renesas,rcar-csi2.txt
> >> +++ b/Documentation/devicetree/bindings/media/renesas,rcar-csi2.txt
> >> @@ -2,12 +2,13 @@ Renesas R-Car MIPI CSI-2
> >>  ------------------------
> >>
> >>  The R-Car CSI-2 receiver device provides MIPI CSI-2 capabilities for the
> >> -Renesas R-Car family of devices. It is used in conjunction with the
> >> -R-Car VIN module, which provides the video capture capabilities.
> >> +Renesas R-Car Gen3 and RZ/G2 family of devices. It is used in conjunction
> >> +with the R-Car VIN module, which provides the video capture capabilities.
> >>
> >>  Mandatory properties
> >>  --------------------
> >>   - compatible: Must be one or more of the following
> >> +   - "renesas,r8a774a1-csi2" for the R8A774A1 device.
> >>     - "renesas,r8a7795-csi2" for the R8A7795 device.
> >>     - "renesas,r8a7796-csi2" for the R8A7796 device.
> >>     - "renesas,r8a77965-csi2" for the R8A77965 device.

-- 
Regards,

Laurent Pinchart

Re: [PATCH 1/5] media: dt-bindings: media: rcar-csi2: Add r8a774a1 support

[Niklas Söderlund]

Hi Hans, Laurent,

On 2019-03-01 15:06:13 +0200, Laurent Pinchart wrote:
> Hi Hans,
> 
> On Fri, Mar 01, 2019 at 01:55:53PM +0100, Hans Verkuil wrote:
> > Hi Fabrizio,
> > 
> > It looks like this series fell through the cracks.
> > 
> > I looked at it and the main problem is that it is missing a Reviewed-by
> > from Rob Herring (devicetree maintainer). It's a bit surprising since he
> > is usually fairly prompt.
> > 
> > I recommend that you rebase and repost it and I'll delegate the v2 series
> > to me so we can hopefully get it in for 5.2 (5.1 is likely too late) once
> > Rob reviews it.
> > 
> > BTW, I'm the one who usually processes rcar patches. But it was delegated in
> > patchwork to Laurent, so I never saw it.
> 
> I handle the VSP and FDP patches. I propose delegating the CSI-2 and VIN
> to Niklas.

I be more then happy to collect patches for R-Car VIN and CSI-2 and send
PRs for them to you Hans. Would that work for you Hans?

-- 
Regards,
Niklas Söderlund

[PATCH 2/5] media: rcar-csi2: Enable support for r8a774a1

[Biju Das]

Add the MIPI CSI-2 driver support for RZ/G2M(r8a774a1) SoC.
The CSI-2 module of RZ/G2M is similar to R-Car M3-W.

Signed-off-by: Biju Das <biju.das@bp.renesas.com>
Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
---
 drivers/media/platform/rcar-vin/rcar-csi2.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/media/platform/rcar-vin/rcar-csi2.c b/drivers/media/platform/rcar-vin/rcar-csi2.c
index daef72d..65c7efb 100644
--- a/drivers/media/platform/rcar-vin/rcar-csi2.c
+++ b/drivers/media/platform/rcar-vin/rcar-csi2.c
@@ -953,6 +953,10 @@ static const struct rcar_csi2_info rcar_csi2_info_r8a77970 = {
 
 static const struct of_device_id rcar_csi2_of_table[] = {
 	{
+		.compatible = "renesas,r8a774a1-csi2",
+		.data = &rcar_csi2_info_r8a7796,
+	},
+	{
 		.compatible = "renesas,r8a7795-csi2",
 		.data = &rcar_csi2_info_r8a7795,
 	},
-- 
2.7.4

Re: [PATCH 2/5] media: rcar-csi2: Enable support for r8a774a1

[Niklas Söderlund]

Hi Biju,

Thanks for your work.

On 2018-09-10 15:31:15 +0100, Biju Das wrote:
> Add the MIPI CSI-2 driver support for RZ/G2M(r8a774a1) SoC.
> The CSI-2 module of RZ/G2M is similar to R-Car M3-W.
> 
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>

Acked-by: Niklas S�derlund <niklas.soderlund+renesas@ragnatech.se>

> ---
>  drivers/media/platform/rcar-vin/rcar-csi2.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/media/platform/rcar-vin/rcar-csi2.c b/drivers/media/platform/rcar-vin/rcar-csi2.c
> index daef72d..65c7efb 100644
> --- a/drivers/media/platform/rcar-vin/rcar-csi2.c
> +++ b/drivers/media/platform/rcar-vin/rcar-csi2.c
> @@ -953,6 +953,10 @@ static const struct rcar_csi2_info rcar_csi2_info_r8a77970 = {
>  
>  static const struct of_device_id rcar_csi2_of_table[] = {
>  	{
> +		.compatible = "renesas,r8a774a1-csi2",
> +		.data = &rcar_csi2_info_r8a7796,
> +	},
> +	{
>  		.compatible = "renesas,r8a7795-csi2",
>  		.data = &rcar_csi2_info_r8a7795,
>  	},
> -- 
> 2.7.4
> 

-- 
Regards,
Niklas S�derlund

RE: [PATCH 2/5] media: rcar-csi2: Enable support for r8a774a1

[Fabrizio Castro]

Dear All,

Who is the best person to take this patch?

Thanks,
Fab

> From: linux-renesas-soc-owner@vger.kernel.org <linux-renesas-soc-owner@vger.kernel.org> On Behalf Of Biju Das
> Sent: 10 September 2018 15:31
> Subject: [PATCH 2/5] media: rcar-csi2: Enable support for r8a774a1
>
> Add the MIPI CSI-2 driver support for RZ/G2M(r8a774a1) SoC.
> The CSI-2 module of RZ/G2M is similar to R-Car M3-W.
>
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> ---
>  drivers/media/platform/rcar-vin/rcar-csi2.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/drivers/media/platform/rcar-vin/rcar-csi2.c b/drivers/media/platform/rcar-vin/rcar-csi2.c
> index daef72d..65c7efb 100644
> --- a/drivers/media/platform/rcar-vin/rcar-csi2.c
> +++ b/drivers/media/platform/rcar-vin/rcar-csi2.c
> @@ -953,6 +953,10 @@ static const struct rcar_csi2_info rcar_csi2_info_r8a77970 = {
>
>  static const struct of_device_id rcar_csi2_of_table[] = {
>  {
> +.compatible = "renesas,r8a774a1-csi2",
> +.data = &rcar_csi2_info_r8a7796,
> +},
> +{
>  .compatible = "renesas,r8a7795-csi2",
>  .data = &rcar_csi2_info_r8a7795,
>  },
> --
> 2.7.4




Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.

Re: [PATCH 2/5] media: rcar-csi2: Enable support for r8a774a1

[Simon Horman]

On Thu, Nov 08, 2018 at 12:51:29PM +0000, Fabrizio Castro wrote:
> Dear All,
> 
> Who is the best person to take this patch?

I believe this is for Mauro.

RE: [PATCH 2/5] media: rcar-csi2: Enable support for r8a774a1

[Fabrizio Castro]

Thank you Simon for getting back to me.

Cheers,
Fab

> Subject: Re: [PATCH 2/5] media: rcar-csi2: Enable support for r8a774a1
>
> On Thu, Nov 08, 2018 at 12:51:29PM +0000, Fabrizio Castro wrote:
> > Dear All,
> >
> > Who is the best person to take this patch?
>
> I believe this is for Mauro.



Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.

RE: [PATCH 2/5] media: rcar-csi2: Enable support for r8a774a1

[Fabrizio Castro]

Hello Mauro,

Does this patch look ok to you?

Thanks,
Fab

> From: linux-renesas-soc-owner@vger.kernel.org <linux-renesas-soc-owner@vger.kernel.org> On Behalf Of Biju Das
> Sent: 10 September 2018 15:31
> Subject: [PATCH 2/5] media: rcar-csi2: Enable support for r8a774a1
>
> Add the MIPI CSI-2 driver support for RZ/G2M(r8a774a1) SoC.
> The CSI-2 module of RZ/G2M is similar to R-Car M3-W.
>
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> ---
>  drivers/media/platform/rcar-vin/rcar-csi2.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/drivers/media/platform/rcar-vin/rcar-csi2.c b/drivers/media/platform/rcar-vin/rcar-csi2.c
> index daef72d..65c7efb 100644
> --- a/drivers/media/platform/rcar-vin/rcar-csi2.c
> +++ b/drivers/media/platform/rcar-vin/rcar-csi2.c
> @@ -953,6 +953,10 @@ static const struct rcar_csi2_info rcar_csi2_info_r8a77970 = {
>
>  static const struct of_device_id rcar_csi2_of_table[] = {
>  {
> +.compatible = "renesas,r8a774a1-csi2",
> +.data = &rcar_csi2_info_r8a7796,
> +},
> +{
>  .compatible = "renesas,r8a7795-csi2",
>  .data = &rcar_csi2_info_r8a7795,
>  },
> --
> 2.7.4




Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.

RE: [PATCH 2/5] media: rcar-csi2: Enable support for r8a774a1

[Fabrizio Castro]

Hello Mauro,

This is a gentle reminder.

Thanks,
Fab

> From: linux-renesas-soc-owner@vger.kernel.org <linux-renesas-soc-owner@vger.kernel.org> On Behalf Of Fabrizio Castro
> Sent: 08 November 2018 14:24
> Subject: RE: [PATCH 2/5] media: rcar-csi2: Enable support for r8a774a1
>
> Hello Mauro,
>
> Does this patch look ok to you?
>
> Thanks,
> Fab
>
> > From: linux-renesas-soc-owner@vger.kernel.org <linux-renesas-soc-owner@vger.kernel.org> On Behalf Of Biju Das
> > Sent: 10 September 2018 15:31
> > Subject: [PATCH 2/5] media: rcar-csi2: Enable support for r8a774a1
> >
> > Add the MIPI CSI-2 driver support for RZ/G2M(r8a774a1) SoC.
> > The CSI-2 module of RZ/G2M is similar to R-Car M3-W.
> >
> > Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> > Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> > ---
> >  drivers/media/platform/rcar-vin/rcar-csi2.c | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/drivers/media/platform/rcar-vin/rcar-csi2.c b/drivers/media/platform/rcar-vin/rcar-csi2.c
> > index daef72d..65c7efb 100644
> > --- a/drivers/media/platform/rcar-vin/rcar-csi2.c
> > +++ b/drivers/media/platform/rcar-vin/rcar-csi2.c
> > @@ -953,6 +953,10 @@ static const struct rcar_csi2_info rcar_csi2_info_r8a77970 = {
> >
> >  static const struct of_device_id rcar_csi2_of_table[] = {
> >  {
> > +.compatible = "renesas,r8a774a1-csi2",
> > +.data = &rcar_csi2_info_r8a7796,
> > +},
> > +{
> >  .compatible = "renesas,r8a7795-csi2",
> >  .data = &rcar_csi2_info_r8a7795,
> >  },
> > --
> > 2.7.4
>
>
>
>
> Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England &
> Wales under Registered No. 04586709.



Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.

Re: [PATCH 2/5] media: rcar-csi2: Enable support for r8a774a1

[Simon Horman]

On Mon, Sep 10, 2018 at 03:31:15PM +0100, Biju Das wrote:
> Add the MIPI CSI-2 driver support for RZ/G2M(r8a774a1) SoC.
> The CSI-2 module of RZ/G2M is similar to R-Car M3-W.
> 
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>

Reviewed-by: Simon Horman <horms+renesas@verge.net.au>

RE: [PATCH 2/5] media: rcar-csi2: Enable support for r8a774a1

[Fabrizio Castro]

Hello Mauro,

This patch has been around for some time now, do you think you can take it?

Thanks,
Fab

> From: linux-renesas-soc-owner@vger.kernel.org <linux-renesas-soc-owner@vger.kernel.org> On Behalf Of Biju Das
> Sent: 10 September 2018 15:31
> Subject: [PATCH 2/5] media: rcar-csi2: Enable support for r8a774a1
> 
> Add the MIPI CSI-2 driver support for RZ/G2M(r8a774a1) SoC.
> The CSI-2 module of RZ/G2M is similar to R-Car M3-W.
> 
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> ---
>  drivers/media/platform/rcar-vin/rcar-csi2.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/media/platform/rcar-vin/rcar-csi2.c b/drivers/media/platform/rcar-vin/rcar-csi2.c
> index daef72d..65c7efb 100644
> --- a/drivers/media/platform/rcar-vin/rcar-csi2.c
> +++ b/drivers/media/platform/rcar-vin/rcar-csi2.c
> @@ -953,6 +953,10 @@ static const struct rcar_csi2_info rcar_csi2_info_r8a77970 = {
> 
>  static const struct of_device_id rcar_csi2_of_table[] = {
>  	{
> +		.compatible = "renesas,r8a774a1-csi2",
> +		.data = &rcar_csi2_info_r8a7796,
> +	},
> +	{
>  		.compatible = "renesas,r8a7795-csi2",
>  		.data = &rcar_csi2_info_r8a7795,
>  	},
> --
> 2.7.4

[PATCH 3/5] media: dt-bindings: media: rcar_vin: Add r8a774a1 support

[Biju Das]

Document RZ/G2M (R8A774A1) SoC bindings.

The RZ/G2M SoC is similar to R-Car M3-W (R8A7796).

Signed-off-by: Biju Das <biju.das@bp.renesas.com>
Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
---
 Documentation/devicetree/bindings/media/rcar_vin.txt | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/media/rcar_vin.txt b/Documentation/devicetree/bindings/media/rcar_vin.txt
index 2f42005..8c81689 100644
--- a/Documentation/devicetree/bindings/media/rcar_vin.txt
+++ b/Documentation/devicetree/bindings/media/rcar_vin.txt
@@ -12,6 +12,7 @@ on Gen3 platforms to a CSI-2 receiver.
  - compatible: Must be one or more of the following
    - "renesas,vin-r8a7743" for the R8A7743 device
    - "renesas,vin-r8a7745" for the R8A7745 device
+   - "renesas,vin-r8a774a1" for the R8A774A1 device
    - "renesas,vin-r8a7778" for the R8A7778 device
    - "renesas,vin-r8a7779" for the R8A7779 device
    - "renesas,vin-r8a7790" for the R8A7790 device
@@ -58,9 +59,9 @@ The per-board settings Gen2 platforms:
     - data-enable-active: polarity of CLKENB signal, see [1] for
       description. Default is active high.
 
-The per-board settings Gen3 platforms:
+The per-board settings Gen3 and RZ/G2 platforms:
 
-Gen3 platforms can support both a single connected parallel input source
+Gen3 and RZ/G2 platforms can support both a single connected parallel input source
 from external SoC pins (port@0) and/or multiple parallel input sources
 from local SoC CSI-2 receivers (port@1) depending on SoC.
 
-- 
2.7.4

Re: [PATCH 3/5] media: dt-bindings: media: rcar_vin: Add r8a774a1 support

[Niklas Söderlund]

Hi Biju,

Thanks for your patch.

On 2018-09-10 15:31:16 +0100, Biju Das wrote:
> Document RZ/G2M (R8A774A1) SoC bindings.
> 
> The RZ/G2M SoC is similar to R-Car M3-W (R8A7796).
> 
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>

Acked-by: Niklas S�derlund <niklas.soderlund+renesas@ragnatech.se>

> ---
>  Documentation/devicetree/bindings/media/rcar_vin.txt | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/media/rcar_vin.txt b/Documentation/devicetree/bindings/media/rcar_vin.txt
> index 2f42005..8c81689 100644
> --- a/Documentation/devicetree/bindings/media/rcar_vin.txt
> +++ b/Documentation/devicetree/bindings/media/rcar_vin.txt
> @@ -12,6 +12,7 @@ on Gen3 platforms to a CSI-2 receiver.
>   - compatible: Must be one or more of the following
>     - "renesas,vin-r8a7743" for the R8A7743 device
>     - "renesas,vin-r8a7745" for the R8A7745 device
> +   - "renesas,vin-r8a774a1" for the R8A774A1 device
>     - "renesas,vin-r8a7778" for the R8A7778 device
>     - "renesas,vin-r8a7779" for the R8A7779 device
>     - "renesas,vin-r8a7790" for the R8A7790 device
> @@ -58,9 +59,9 @@ The per-board settings Gen2 platforms:
>      - data-enable-active: polarity of CLKENB signal, see [1] for
>        description. Default is active high.
>  
> -The per-board settings Gen3 platforms:
> +The per-board settings Gen3 and RZ/G2 platforms:
>  
> -Gen3 platforms can support both a single connected parallel input source
> +Gen3 and RZ/G2 platforms can support both a single connected parallel input source
>  from external SoC pins (port@0) and/or multiple parallel input sources
>  from local SoC CSI-2 receivers (port@1) depending on SoC.
>  
> -- 
> 2.7.4
> 

-- 
Regards,
Niklas S�derlund

RE: [PATCH 3/5] media: dt-bindings: media: rcar_vin: Add r8a774a1 support

[Fabrizio Castro]

Dear All,

Who is the best person to take this patch?

Thanks,
Fab

> From: linux-renesas-soc-owner@vger.kernel.org <linux-renesas-soc-owner@vger.kernel.org> On Behalf Of Biju Das
> Sent: 10 September 2018 15:31
> Subject: [PATCH 3/5] media: dt-bindings: media: rcar_vin: Add r8a774a1 support
>
> Document RZ/G2M (R8A774A1) SoC bindings.
>
> The RZ/G2M SoC is similar to R-Car M3-W (R8A7796).
>
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> ---
>  Documentation/devicetree/bindings/media/rcar_vin.txt | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/media/rcar_vin.txt b/Documentation/devicetree/bindings/media/rcar_vin.txt
> index 2f42005..8c81689 100644
> --- a/Documentation/devicetree/bindings/media/rcar_vin.txt
> +++ b/Documentation/devicetree/bindings/media/rcar_vin.txt
> @@ -12,6 +12,7 @@ on Gen3 platforms to a CSI-2 receiver.
>   - compatible: Must be one or more of the following
>     - "renesas,vin-r8a7743" for the R8A7743 device
>     - "renesas,vin-r8a7745" for the R8A7745 device
> +   - "renesas,vin-r8a774a1" for the R8A774A1 device
>     - "renesas,vin-r8a7778" for the R8A7778 device
>     - "renesas,vin-r8a7779" for the R8A7779 device
>     - "renesas,vin-r8a7790" for the R8A7790 device
> @@ -58,9 +59,9 @@ The per-board settings Gen2 platforms:
>      - data-enable-active: polarity of CLKENB signal, see [1] for
>        description. Default is active high.
>
> -The per-board settings Gen3 platforms:
> +The per-board settings Gen3 and RZ/G2 platforms:
>
> -Gen3 platforms can support both a single connected parallel input source
> +Gen3 and RZ/G2 platforms can support both a single connected parallel input source
>  from external SoC pins (port@0) and/or multiple parallel input sources
>  from local SoC CSI-2 receivers (port@1) depending on SoC.
>
> --
> 2.7.4




Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.

Re: [PATCH 3/5] media: dt-bindings: media: rcar_vin: Add r8a774a1 support

[Simon Horman]

On Thu, Nov 08, 2018 at 12:52:30PM +0000, Fabrizio Castro wrote:
> Dear All,
> 
> Who is the best person to take this patch?

I believe this is for Mauro.

RE: [PATCH 3/5] media: dt-bindings: media: rcar_vin: Add r8a774a1 support

[Fabrizio Castro]

Thank you Simon for getting back to me.

Cheers,
Fab

> Subject: Re: [PATCH 3/5] media: dt-bindings: media: rcar_vin: Add r8a774a1 support
>
> On Thu, Nov 08, 2018 at 12:52:30PM +0000, Fabrizio Castro wrote:
> > Dear All,
> >
> > Who is the best person to take this patch?
>
> I believe this is for Mauro.



Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.

RE: [PATCH 3/5] media: dt-bindings: media: rcar_vin: Add r8a774a1 support

[Fabrizio Castro]

Hello Mauro,

Does this patch look ok to you?

Thanks,
Fab

> From: linux-renesas-soc-owner@vger.kernel.org <linux-renesas-soc-owner@vger.kernel.org> On Behalf Of Biju Das
> Sent: 10 September 2018 15:31
> Subject: [PATCH 3/5] media: dt-bindings: media: rcar_vin: Add r8a774a1 support
>
> Document RZ/G2M (R8A774A1) SoC bindings.
>
> The RZ/G2M SoC is similar to R-Car M3-W (R8A7796).
>
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> ---
>  Documentation/devicetree/bindings/media/rcar_vin.txt | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/media/rcar_vin.txt b/Documentation/devicetree/bindings/media/rcar_vin.txt
> index 2f42005..8c81689 100644
> --- a/Documentation/devicetree/bindings/media/rcar_vin.txt
> +++ b/Documentation/devicetree/bindings/media/rcar_vin.txt
> @@ -12,6 +12,7 @@ on Gen3 platforms to a CSI-2 receiver.
>   - compatible: Must be one or more of the following
>     - "renesas,vin-r8a7743" for the R8A7743 device
>     - "renesas,vin-r8a7745" for the R8A7745 device
> +   - "renesas,vin-r8a774a1" for the R8A774A1 device
>     - "renesas,vin-r8a7778" for the R8A7778 device
>     - "renesas,vin-r8a7779" for the R8A7779 device
>     - "renesas,vin-r8a7790" for the R8A7790 device
> @@ -58,9 +59,9 @@ The per-board settings Gen2 platforms:
>      - data-enable-active: polarity of CLKENB signal, see [1] for
>        description. Default is active high.
>
> -The per-board settings Gen3 platforms:
> +The per-board settings Gen3 and RZ/G2 platforms:
>
> -Gen3 platforms can support both a single connected parallel input source
> +Gen3 and RZ/G2 platforms can support both a single connected parallel input source
>  from external SoC pins (port@0) and/or multiple parallel input sources
>  from local SoC CSI-2 receivers (port@1) depending on SoC.
>
> --
> 2.7.4




Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.

RE: [PATCH 3/5] media: dt-bindings: media: rcar_vin: Add r8a774a1 support

[Fabrizio Castro]

Hello Mauro,

This is a gentle reminder.

Thanks,
Fab

> From: Fabrizio Castro
> Sent: 08 November 2018 14:26
> Subject: RE: [PATCH 3/5] media: dt-bindings: media: rcar_vin: Add r8a774a1 support
>
> Hello Mauro,
>
> Does this patch look ok to you?
>
> Thanks,
> Fab
>
> > From: linux-renesas-soc-owner@vger.kernel.org <linux-renesas-soc-owner@vger.kernel.org> On Behalf Of Biju Das
> > Sent: 10 September 2018 15:31
> > Subject: [PATCH 3/5] media: dt-bindings: media: rcar_vin: Add r8a774a1 support
> >
> > Document RZ/G2M (R8A774A1) SoC bindings.
> >
> > The RZ/G2M SoC is similar to R-Car M3-W (R8A7796).
> >
> > Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> > Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> > ---
> >  Documentation/devicetree/bindings/media/rcar_vin.txt | 5 +++--
> >  1 file changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/media/rcar_vin.txt b/Documentation/devicetree/bindings/media/rcar_vin.txt
> > index 2f42005..8c81689 100644
> > --- a/Documentation/devicetree/bindings/media/rcar_vin.txt
> > +++ b/Documentation/devicetree/bindings/media/rcar_vin.txt
> > @@ -12,6 +12,7 @@ on Gen3 platforms to a CSI-2 receiver.
> >   - compatible: Must be one or more of the following
> >     - "renesas,vin-r8a7743" for the R8A7743 device
> >     - "renesas,vin-r8a7745" for the R8A7745 device
> > +   - "renesas,vin-r8a774a1" for the R8A774A1 device
> >     - "renesas,vin-r8a7778" for the R8A7778 device
> >     - "renesas,vin-r8a7779" for the R8A7779 device
> >     - "renesas,vin-r8a7790" for the R8A7790 device
> > @@ -58,9 +59,9 @@ The per-board settings Gen2 platforms:
> >      - data-enable-active: polarity of CLKENB signal, see [1] for
> >        description. Default is active high.
> >
> > -The per-board settings Gen3 platforms:
> > +The per-board settings Gen3 and RZ/G2 platforms:
> >
> > -Gen3 platforms can support both a single connected parallel input source
> > +Gen3 and RZ/G2 platforms can support both a single connected parallel input source
> >  from external SoC pins (port@0) and/or multiple parallel input sources
> >  from local SoC CSI-2 receivers (port@1) depending on SoC.
> >
> > --
> > 2.7.4




Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.

Re: [PATCH 3/5] media: dt-bindings: media: rcar_vin: Add r8a774a1 support

[Simon Horman]

On Mon, Sep 10, 2018 at 03:31:16PM +0100, Biju Das wrote:
> Document RZ/G2M (R8A774A1) SoC bindings.
> 
> The RZ/G2M SoC is similar to R-Car M3-W (R8A7796).
> 
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>

Reviewed-by: Simon Horman <horms+renesas@verge.net.au>

RE: [PATCH 3/5] media: dt-bindings: media: rcar_vin: Add r8a774a1 support

[Fabrizio Castro]

Hello Mauro,

This patch has been around for some time, do you think you can take it?

Thanks,
Fab

> From: linux-renesas-soc-owner@vger.kernel.org <linux-renesas-soc-owner@vger.kernel.org> On Behalf Of Biju Das
> Sent: 10 September 2018 15:31
> Subject: [PATCH 3/5] media: dt-bindings: media: rcar_vin: Add r8a774a1 support
> 
> Document RZ/G2M (R8A774A1) SoC bindings.
> 
> The RZ/G2M SoC is similar to R-Car M3-W (R8A7796).
> 
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> ---
>  Documentation/devicetree/bindings/media/rcar_vin.txt | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/media/rcar_vin.txt b/Documentation/devicetree/bindings/media/rcar_vin.txt
> index 2f42005..8c81689 100644
> --- a/Documentation/devicetree/bindings/media/rcar_vin.txt
> +++ b/Documentation/devicetree/bindings/media/rcar_vin.txt
> @@ -12,6 +12,7 @@ on Gen3 platforms to a CSI-2 receiver.
>   - compatible: Must be one or more of the following
>     - "renesas,vin-r8a7743" for the R8A7743 device
>     - "renesas,vin-r8a7745" for the R8A7745 device
> +   - "renesas,vin-r8a774a1" for the R8A774A1 device
>     - "renesas,vin-r8a7778" for the R8A7778 device
>     - "renesas,vin-r8a7779" for the R8A7779 device
>     - "renesas,vin-r8a7790" for the R8A7790 device
> @@ -58,9 +59,9 @@ The per-board settings Gen2 platforms:
>      - data-enable-active: polarity of CLKENB signal, see [1] for
>        description. Default is active high.
> 
> -The per-board settings Gen3 platforms:
> +The per-board settings Gen3 and RZ/G2 platforms:
> 
> -Gen3 platforms can support both a single connected parallel input source
> +Gen3 and RZ/G2 platforms can support both a single connected parallel input source
>  from external SoC pins (port@0) and/or multiple parallel input sources
>  from local SoC CSI-2 receivers (port@1) depending on SoC.
> 
> --
> 2.7.4

[PATCH 4/5] media: rcar-vin: Enable support for r8a774a1

[Biju Das]

Add the SoC specific information for RZ/G2M(r8a774a1) SoC.
The VIN module of RZ/G2M is similar to R-Car M3-W.

Signed-off-by: Biju Das <biju.das@bp.renesas.com>
Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
---
 drivers/media/platform/rcar-vin/rcar-core.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/media/platform/rcar-vin/rcar-core.c b/drivers/media/platform/rcar-vin/rcar-core.c
index d3072e1..c0c84d1 100644
--- a/drivers/media/platform/rcar-vin/rcar-core.c
+++ b/drivers/media/platform/rcar-vin/rcar-core.c
@@ -995,6 +995,10 @@ static const struct rvin_info rcar_info_r8a77970 = {
 
 static const struct of_device_id rvin_of_id_table[] = {
 	{
+		.compatible = "renesas,vin-r8a774a1",
+		.data = &rcar_info_r8a7796,
+	},
+	{
 		.compatible = "renesas,vin-r8a7778",
 		.data = &rcar_info_m1,
 	},
-- 
2.7.4

Re: [PATCH 4/5] media: rcar-vin: Enable support for r8a774a1

[Niklas Söderlund]

Hi Biju,

Thanks for your work.

On 2018-09-10 15:31:17 +0100, Biju Das wrote:
> Add the SoC specific information for RZ/G2M(r8a774a1) SoC.
> The VIN module of RZ/G2M is similar to R-Car M3-W.
> 
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>

Acked-by: Niklas S�derlund <niklas.soderlund+renesas@ragnatech.se>

> ---
>  drivers/media/platform/rcar-vin/rcar-core.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/media/platform/rcar-vin/rcar-core.c b/drivers/media/platform/rcar-vin/rcar-core.c
> index d3072e1..c0c84d1 100644
> --- a/drivers/media/platform/rcar-vin/rcar-core.c
> +++ b/drivers/media/platform/rcar-vin/rcar-core.c
> @@ -995,6 +995,10 @@ static const struct rvin_info rcar_info_r8a77970 = {
>  
>  static const struct of_device_id rvin_of_id_table[] = {
>  	{
> +		.compatible = "renesas,vin-r8a774a1",
> +		.data = &rcar_info_r8a7796,
> +	},
> +	{
>  		.compatible = "renesas,vin-r8a7778",
>  		.data = &rcar_info_m1,
>  	},
> -- 
> 2.7.4
> 

-- 
Regards,
Niklas S�derlund

RE: [PATCH 4/5] media: rcar-vin: Enable support for r8a774a1

[Fabrizio Castro]

Dear All,

Who is the best person to take this patch?

Cheers,
Fab

> From: Biju Das <biju.das@bp.renesas.com>
> Sent: 10 September 2018 15:31
> Subject: [PATCH 4/5] media: rcar-vin: Enable support for r8a774a1
>
> Add the SoC specific information for RZ/G2M(r8a774a1) SoC.
> The VIN module of RZ/G2M is similar to R-Car M3-W.
>
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> ---
>  drivers/media/platform/rcar-vin/rcar-core.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/drivers/media/platform/rcar-vin/rcar-core.c b/drivers/media/platform/rcar-vin/rcar-core.c
> index d3072e1..c0c84d1 100644
> --- a/drivers/media/platform/rcar-vin/rcar-core.c
> +++ b/drivers/media/platform/rcar-vin/rcar-core.c
> @@ -995,6 +995,10 @@ static const struct rvin_info rcar_info_r8a77970 = {
>
>  static const struct of_device_id rvin_of_id_table[] = {
>  {
> +.compatible = "renesas,vin-r8a774a1",
> +.data = &rcar_info_r8a7796,
> +},
> +{
>  .compatible = "renesas,vin-r8a7778",
>  .data = &rcar_info_m1,
>  },
> --
> 2.7.4




Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.

Re: [PATCH 4/5] media: rcar-vin: Enable support for r8a774a1

[Simon Horman]

On Mon, Sep 10, 2018 at 03:31:17PM +0100, Biju Das wrote:
> Add the SoC specific information for RZ/G2M(r8a774a1) SoC.
> The VIN module of RZ/G2M is similar to R-Car M3-W.
> 
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>

Reviewed-by: Simon Horman <horms+renesas@verge.net.au>

RE: [PATCH 4/5] media: rcar-vin: Enable support for r8a774a1

[Biju Das]

Hello Mauro,

Does this patch look ok to you?

Thanks,
Fab

> -----Original Message-----
> From: Biju Das <biju.das@bp.renesas.com>
> Sent: 10 September 2018 15:31
> To: Mauro Carvalho Chehab <mchehab@kernel.org>
> Cc: Biju Das <biju.das@bp.renesas.com>; Niklas Söderlund
> <niklas.soderlund@ragnatech.se>; linux-media@vger.kernel.org; linux-
> renesas-soc@vger.kernel.org; Simon Horman <horms@verge.net.au>; Geert
> Uytterhoeven <geert+renesas@glider.be>; Chris Paterson
> <Chris.Paterson2@renesas.com>; Fabrizio Castro
> <fabrizio.castro@bp.renesas.com>
> Subject: [PATCH 4/5] media: rcar-vin: Enable support for r8a774a1
>
> Add the SoC specific information for RZ/G2M(r8a774a1) SoC.
> The VIN module of RZ/G2M is similar to R-Car M3-W.
>
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> ---
>  drivers/media/platform/rcar-vin/rcar-core.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/drivers/media/platform/rcar-vin/rcar-core.c
> b/drivers/media/platform/rcar-vin/rcar-core.c
> index d3072e1..c0c84d1 100644
> --- a/drivers/media/platform/rcar-vin/rcar-core.c
> +++ b/drivers/media/platform/rcar-vin/rcar-core.c
> @@ -995,6 +995,10 @@ static const struct rvin_info rcar_info_r8a77970 = {
>
>  static const struct of_device_id rvin_of_id_table[] = {
>  {
> +.compatible = "renesas,vin-r8a774a1",
> +.data = &rcar_info_r8a7796,
> +},
> +{
>  .compatible = "renesas,vin-r8a7778",
>  .data = &rcar_info_m1,
>  },
> --
> 2.7.4




Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.

RE: [PATCH 4/5] media: rcar-vin: Enable support for r8a774a1

[Fabrizio Castro]

Hello Mauro,

This is a gentle reminder.

Thanks,
Fab

> From: Biju Das
> Sent: 29 November 2018 15:13
> Subject: RE: [PATCH 4/5] media: rcar-vin: Enable support for r8a774a1
>
> Hello Mauro,
>
> Does this patch look ok to you?
>
> Thanks,
> Fab
>
> > -----Original Message-----
> > From: Biju Das <biju.das@bp.renesas.com>
> > Sent: 10 September 2018 15:31
> > To: Mauro Carvalho Chehab <mchehab@kernel.org>
> > Cc: Biju Das <biju.das@bp.renesas.com>; Niklas Söderlund
> > <niklas.soderlund@ragnatech.se>; linux-media@vger.kernel.org; linux-
> > renesas-soc@vger.kernel.org; Simon Horman <horms@verge.net.au>; Geert
> > Uytterhoeven <geert+renesas@glider.be>; Chris Paterson
> > <Chris.Paterson2@renesas.com>; Fabrizio Castro
> > <fabrizio.castro@bp.renesas.com>
> > Subject: [PATCH 4/5] media: rcar-vin: Enable support for r8a774a1
> >
> > Add the SoC specific information for RZ/G2M(r8a774a1) SoC.
> > The VIN module of RZ/G2M is similar to R-Car M3-W.
> >
> > Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> > Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> > ---
> >  drivers/media/platform/rcar-vin/rcar-core.c | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/drivers/media/platform/rcar-vin/rcar-core.c
> > b/drivers/media/platform/rcar-vin/rcar-core.c
> > index d3072e1..c0c84d1 100644
> > --- a/drivers/media/platform/rcar-vin/rcar-core.c
> > +++ b/drivers/media/platform/rcar-vin/rcar-core.c
> > @@ -995,6 +995,10 @@ static const struct rvin_info rcar_info_r8a77970 = {
> >
> >  static const struct of_device_id rvin_of_id_table[] = {
> >  {
> > +.compatible = "renesas,vin-r8a774a1",
> > +.data = &rcar_info_r8a7796,
> > +},
> > +{
> >  .compatible = "renesas,vin-r8a7778",
> >  .data = &rcar_info_m1,
> >  },
> > --
> > 2.7.4




Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.

RE: [PATCH 4/5] media: rcar-vin: Enable support for r8a774a1

[Fabrizio Castro]

Hello Mauro,

This patch has been around for some time, do you think you can take it?

Thanks,
Fab

> From: Biju Das <biju.das@bp.renesas.com>
> Sent: 10 September 2018 15:31
> Subject: [PATCH 4/5] media: rcar-vin: Enable support for r8a774a1
> 
> Add the SoC specific information for RZ/G2M(r8a774a1) SoC.
> The VIN module of RZ/G2M is similar to R-Car M3-W.
> 
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> ---
>  drivers/media/platform/rcar-vin/rcar-core.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/media/platform/rcar-vin/rcar-core.c b/drivers/media/platform/rcar-vin/rcar-core.c
> index d3072e1..c0c84d1 100644
> --- a/drivers/media/platform/rcar-vin/rcar-core.c
> +++ b/drivers/media/platform/rcar-vin/rcar-core.c
> @@ -995,6 +995,10 @@ static const struct rvin_info rcar_info_r8a77970 = {
> 
>  static const struct of_device_id rvin_of_id_table[] = {
>  	{
> +		.compatible = "renesas,vin-r8a774a1",
> +		.data = &rcar_info_r8a7796,
> +	},
> +	{
>  		.compatible = "renesas,vin-r8a7778",
>  		.data = &rcar_info_m1,
>  	},
> --
> 2.7.4

[PATCH 5/5] arm64: dts: renesas: r8a774a1: Add VIN and CSI-2 nodes

[Biju Das]

Add VIN and CSI-2 nodes to RZ/G2M SoC dtsi.

Signed-off-by: Biju Das <biju.das@bp.renesas.com>
Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
---
 arch/arm64/boot/dts/renesas/r8a774a1.dtsi | 367 ++++++++++++++++++++++++++++++
 1 file changed, 367 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/r8a774a1.dtsi b/arch/arm64/boot/dts/renesas/r8a774a1.dtsi
index d9005cb..43db993 100644
--- a/arch/arm64/boot/dts/renesas/r8a774a1.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a774a1.dtsi
@@ -1127,6 +1127,262 @@
 			status = "disabled";
 		};
 
+		vin0: video@e6ef0000 {
+			compatible = "renesas,vin-r8a774a1";
+			reg = <0 0xe6ef0000 0 0x1000>;
+			interrupts = <GIC_SPI 188 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&cpg CPG_MOD 811>;
+			power-domains = <&sysc 32>;
+			resets = <&cpg 811>;
+			renesas,id = <0>;
+			status = "disabled";
+
+			ports {
+				#address-cells = <1>;
+				#size-cells = <0>;
+
+				port@1 {
+					#address-cells = <1>;
+					#size-cells = <0>;
+
+					reg = <1>;
+
+					vin0csi20: endpoint@0 {
+						reg = <0>;
+						remote-endpoint = <&csi20vin0>;
+					};
+					vin0csi40: endpoint@2 {
+						reg = <2>;
+						remote-endpoint = <&csi40vin0>;
+					};
+				};
+			};
+		};
+
+		vin1: video@e6ef1000 {
+			compatible = "renesas,vin-r8a774a1";
+			reg = <0 0xe6ef1000 0 0x1000>;
+			interrupts = <GIC_SPI 189 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&cpg CPG_MOD 810>;
+			power-domains = <&sysc 32>;
+			resets = <&cpg 810>;
+			renesas,id = <1>;
+			status = "disabled";
+
+			ports {
+				#address-cells = <1>;
+				#size-cells = <0>;
+
+				port@1 {
+					#address-cells = <1>;
+					#size-cells = <0>;
+
+					reg = <1>;
+
+					vin1csi20: endpoint@0 {
+						reg = <0>;
+						remote-endpoint = <&csi20vin1>;
+					};
+					vin1csi40: endpoint@2 {
+						reg = <2>;
+						remote-endpoint = <&csi40vin1>;
+					};
+				};
+			};
+		};
+
+		vin2: video@e6ef2000 {
+			compatible = "renesas,vin-r8a774a1";
+			reg = <0 0xe6ef2000 0 0x1000>;
+			interrupts = <GIC_SPI 190 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&cpg CPG_MOD 809>;
+			power-domains = <&sysc 32>;
+			resets = <&cpg 809>;
+			renesas,id = <2>;
+			status = "disabled";
+
+			ports {
+				#address-cells = <1>;
+				#size-cells = <0>;
+
+				port@1 {
+					#address-cells = <1>;
+					#size-cells = <0>;
+
+					reg = <1>;
+
+					vin2csi20: endpoint@0 {
+						reg = <0>;
+						remote-endpoint = <&csi20vin2>;
+					};
+					vin2csi40: endpoint@2 {
+						reg = <2>;
+						remote-endpoint = <&csi40vin2>;
+					};
+				};
+			};
+		};
+
+		vin3: video@e6ef3000 {
+			compatible = "renesas,vin-r8a774a1";
+			reg = <0 0xe6ef3000 0 0x1000>;
+			interrupts = <GIC_SPI 191 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&cpg CPG_MOD 808>;
+			power-domains = <&sysc 32>;
+			resets = <&cpg 808>;
+			renesas,id = <3>;
+			status = "disabled";
+
+			ports {
+				#address-cells = <1>;
+				#size-cells = <0>;
+
+				port@1 {
+					#address-cells = <1>;
+					#size-cells = <0>;
+
+					reg = <1>;
+
+					vin3csi20: endpoint@0 {
+						reg = <0>;
+						remote-endpoint = <&csi20vin3>;
+					};
+					vin3csi40: endpoint@2 {
+						reg = <2>;
+						remote-endpoint = <&csi40vin3>;
+					};
+				};
+			};
+		};
+
+		vin4: video@e6ef4000 {
+			compatible = "renesas,vin-r8a774a1";
+			reg = <0 0xe6ef4000 0 0x1000>;
+			interrupts = <GIC_SPI 174 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&cpg CPG_MOD 807>;
+			power-domains = <&sysc 32>;
+			resets = <&cpg 807>;
+			renesas,id = <4>;
+			status = "disabled";
+
+			ports {
+				#address-cells = <1>;
+				#size-cells = <0>;
+
+				port@1 {
+					#address-cells = <1>;
+					#size-cells = <0>;
+
+					reg = <1>;
+
+					vin4csi20: endpoint@0 {
+						reg = <0>;
+						remote-endpoint = <&csi20vin4>;
+					};
+					vin4csi40: endpoint@2 {
+						reg = <2>;
+						remote-endpoint = <&csi40vin4>;
+					};
+				};
+			};
+		};
+
+		vin5: video@e6ef5000 {
+			compatible = "renesas,vin-r8a774a1";
+			reg = <0 0xe6ef5000 0 0x1000>;
+			interrupts = <GIC_SPI 175 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&cpg CPG_MOD 806>;
+			power-domains = <&sysc 32>;
+			resets = <&cpg 806>;
+			renesas,id = <5>;
+			status = "disabled";
+
+			ports {
+				#address-cells = <1>;
+				#size-cells = <0>;
+
+				port@1 {
+					#address-cells = <1>;
+					#size-cells = <0>;
+
+					reg = <1>;
+
+					vin5csi20: endpoint@0 {
+						reg = <0>;
+						remote-endpoint = <&csi20vin5>;
+					};
+					vin5csi40: endpoint@2 {
+						reg = <2>;
+						remote-endpoint = <&csi40vin5>;
+					};
+				};
+			};
+		};
+
+		vin6: video@e6ef6000 {
+			compatible = "renesas,vin-r8a774a1";
+			reg = <0 0xe6ef6000 0 0x1000>;
+			interrupts = <GIC_SPI 176 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&cpg CPG_MOD 805>;
+			power-domains = <&sysc 32>;
+			resets = <&cpg 805>;
+			renesas,id = <6>;
+			status = "disabled";
+
+			ports {
+				#address-cells = <1>;
+				#size-cells = <0>;
+
+				port@1 {
+					#address-cells = <1>;
+					#size-cells = <0>;
+
+					reg = <1>;
+
+					vin6csi20: endpoint@0 {
+						reg = <0>;
+						remote-endpoint = <&csi20vin6>;
+					};
+					vin6csi40: endpoint@2 {
+						reg = <2>;
+						remote-endpoint = <&csi40vin6>;
+					};
+				};
+			};
+		};
+
+		vin7: video@e6ef7000 {
+			compatible = "renesas,vin-r8a774a1";
+			reg = <0 0xe6ef7000 0 0x1000>;
+			interrupts = <GIC_SPI 171 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&cpg CPG_MOD 804>;
+			power-domains = <&sysc 32>;
+			resets = <&cpg 804>;
+			renesas,id = <7>;
+			status = "disabled";
+
+			ports {
+				#address-cells = <1>;
+				#size-cells = <0>;
+
+				port@1 {
+					#address-cells = <1>;
+					#size-cells = <0>;
+
+					reg = <1>;
+
+					vin7csi20: endpoint@0 {
+						reg = <0>;
+						remote-endpoint = <&csi20vin7>;
+					};
+					vin7csi40: endpoint@2 {
+						reg = <2>;
+						remote-endpoint = <&csi40vin7>;
+					};
+				};
+			};
+		};
+
 		rcar_sound: sound@ec500000 {
 			/*
 			 * #sound-dai-cells is required
@@ -1614,6 +1870,117 @@
 			iommus = <&ipmmu_vc0 19>;
 		};
 
+		csi20: csi2@fea80000 {
+			compatible = "renesas,r8a774a1-csi2";
+			reg = <0 0xfea80000 0 0x10000>;
+			interrupts = <GIC_SPI 184 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&cpg CPG_MOD 714>;
+			power-domains = <&sysc 32>;
+			resets = <&cpg 714>;
+			status = "disabled";
+
+			ports {
+				#address-cells = <1>;
+				#size-cells = <0>;
+
+				port@1 {
+					#address-cells = <1>;
+					#size-cells = <0>;
+
+					reg = <1>;
+
+					csi20vin0: endpoint@0 {
+						reg = <0>;
+						remote-endpoint = <&vin0csi20>;
+					};
+					csi20vin1: endpoint@1 {
+						reg = <1>;
+						remote-endpoint = <&vin1csi20>;
+					};
+					csi20vin2: endpoint@2 {
+						reg = <2>;
+						remote-endpoint = <&vin2csi20>;
+					};
+					csi20vin3: endpoint@3 {
+						reg = <3>;
+						remote-endpoint = <&vin3csi20>;
+					};
+					csi20vin4: endpoint@4 {
+						reg = <4>;
+						remote-endpoint = <&vin4csi20>;
+					};
+					csi20vin5: endpoint@5 {
+						reg = <5>;
+						remote-endpoint = <&vin5csi20>;
+					};
+					csi20vin6: endpoint@6 {
+						reg = <6>;
+						remote-endpoint = <&vin6csi20>;
+					};
+					csi20vin7: endpoint@7 {
+						reg = <7>;
+						remote-endpoint = <&vin7csi20>;
+					};
+				};
+			};
+		};
+
+		csi40: csi2@feaa0000 {
+			compatible = "renesas,r8a774a1-csi2";
+			reg = <0 0xfeaa0000 0 0x10000>;
+			interrupts = <GIC_SPI 246 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&cpg CPG_MOD 716>;
+			power-domains = <&sysc 32>;
+			resets = <&cpg 716>;
+			status = "disabled";
+
+			ports {
+				#address-cells = <1>;
+				#size-cells = <0>;
+
+				port@1 {
+					#address-cells = <1>;
+					#size-cells = <0>;
+
+					reg = <1>;
+
+					csi40vin0: endpoint@0 {
+						reg = <0>;
+						remote-endpoint = <&vin0csi40>;
+					};
+					csi40vin1: endpoint@1 {
+						reg = <1>;
+						remote-endpoint = <&vin1csi40>;
+					};
+					csi40vin2: endpoint@2 {
+						reg = <2>;
+						remote-endpoint = <&vin2csi40>;
+					};
+					csi40vin3: endpoint@3 {
+						reg = <3>;
+						remote-endpoint = <&vin3csi40>;
+					};
+					csi40vin4: endpoint@4 {
+						reg = <4>;
+						remote-endpoint = <&vin4csi40>;
+					};
+					csi40vin5: endpoint@5 {
+						reg = <5>;
+						remote-endpoint = <&vin5csi40>;
+					};
+					csi40vin6: endpoint@6 {
+						reg = <6>;
+						remote-endpoint = <&vin6csi40>;
+					};
+					csi40vin7: endpoint@7 {
+						reg = <7>;
+						remote-endpoint = <&vin7csi40>;
+					};
+				};
+
+			};
+		};
+
 		prr: chipid@fff00044 {
 			compatible = "renesas,prr";
 			reg = <0 0xfff00044 0 4>;
-- 
2.7.4

Re: [PATCH 5/5] arm64: dts: renesas: r8a774a1: Add VIN and CSI-2 nodes

[Simon Horman]

On Mon, Sep 10, 2018 at 03:31:18PM +0100, Biju Das wrote:
> Add VIN and CSI-2 nodes to RZ/G2M SoC dtsi.
> 
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>

Thanks, I would value a review of this entire series before I apply this
patch.

Re: [PATCH 5/5] arm64: dts: renesas: r8a774a1: Add VIN and CSI-2 nodes

[Simon Horman]

On Tue, Sep 11, 2018 at 03:53:42PM +0200, Simon Horman wrote:
> On Mon, Sep 10, 2018 at 03:31:18PM +0100, Biju Das wrote:
> > Add VIN and CSI-2 nodes to RZ/G2M SoC dtsi.
> > 
> > Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> > Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> 
> Thanks, I would value a review of this entire series before I apply this
> patch.

That has now happened, applied for v4.21.