Linux-Renesas-SoC Archive on lore.kernel.org
 help / color / Atom feed
From: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Neil Armstrong <narmstrong@baylibre.com>,
	David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Andrzej Hajda <a.hajda@samsung.com>,
	Simon Horman <horms@verge.net.au>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	Magnus Damm <magnus.damm@gmail.com>,
	Peter Rosin <peda@axentia.se>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-renesas-soc@vger.kernel.org" 
	<linux-renesas-soc@vger.kernel.org>,
	Chris Paterson <Chris.Paterson2@renesas.com>,
	Biju Das <biju.das@bp.renesas.com>,
	Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>,
	Jacopo Mondi <jacopo+renesas@jmondi.org>
Subject: RE: [PATCH v3 6/7] ARM: dts: iwg20d-q7-common: Add LCD support
Date: Fri, 8 Nov 2019 12:02:04 +0000
Message-ID: <TY1PR01MB1770D144464371F5DB5746B8C07B0@TY1PR01MB1770.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <20191107205520.GR24983@pendragon.ideasonboard.com>

Hi Laurent,

Thank you for your feedback!

> From: linux-renesas-soc-owner@vger.kernel.org <linux-renesas-soc-owner@vger.kernel.org> On Behalf Of Laurent Pinchart
> Sent: 07 November 2019 20:55
> Subject: Re: [PATCH v3 6/7] ARM: dts: iwg20d-q7-common: Add LCD support
> 
> Hi Fabrizio,
> 
> Thank you for the patch.
> 
> On Thu, Nov 07, 2019 at 08:11:02PM +0000, Fabrizio Castro wrote:
> > The iwg20d comes with a 7" capacitive touch screen, therefore
> > add support for it.
> >
> > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> >
> > ---
> > v2->v3:
> > * No change
> > v1->v2:
> > * No change
> > ---
> >  arch/arm/boot/dts/iwg20d-q7-common.dtsi  | 85 ++++++++++++++++++++++++++++++++
> >  arch/arm/boot/dts/iwg20d-q7-dbcm-ca.dtsi |  1 -
> >  2 files changed, 85 insertions(+), 1 deletion(-)
> >
> > diff --git a/arch/arm/boot/dts/iwg20d-q7-common.dtsi b/arch/arm/boot/dts/iwg20d-q7-common.dtsi
> > index ae75a1db..3428b8d 100644
> > --- a/arch/arm/boot/dts/iwg20d-q7-common.dtsi
> > +++ b/arch/arm/boot/dts/iwg20d-q7-common.dtsi
> > @@ -46,6 +46,49 @@
> >  		clock-frequency = <26000000>;
> >  	};
> >
> > +	lcd_backlight: backlight {
> > +		compatible = "pwm-backlight";
> > +
> > +		pwms = <&pwm3 0 5000000 0>;
> > +		brightness-levels = <0 4 8 16 32 64 128 255>;
> > +		default-brightness-level = <7>;
> > +		enable-gpios = <&gpio5 14 GPIO_ACTIVE_HIGH>;
> > +	};
> > +
> > +	lvds-receiver {
> > +		compatible = "lvds-decoder";
> 
> A specific compatible string is required.

Will document the specific compatible in the binding doc

> 
> I think the lvds-decoder driver should error out at probe time if only
> one compatible string is listed.

Ok, will modify the driver accordingly

> 
> > +		powerdown = <&gpio7 25 GPIO_ACTIVE_LOW>;
> 
> powerdown-gpios ?

That's a bug, well spotted.

> 
> > +
> > +		ports {
> > +			#address-cells = <1>;
> > +			#size-cells = <0>;
> > +
> > +			port@0 {
> > +				reg = <0>;
> > +				lvds_receiver_in: endpoint {
> > +					remote-endpoint = <&lvds0_out>;
> > +				};
> > +			};
> > +			port@1 {
> > +				reg = <1>;
> > +				lvds_receiver_out: endpoint {
> > +					remote-endpoint = <&panel_in>;
> > +				};
> > +			};
> > +		};
> > +	};
> > +
> > +	panel {
> > +		compatible = "edt,etm0700g0dh6", "simple-panel";
> 
> There's no "simple-panel" compatible string defined anywhere as far as I
> can tell.

The usage of "simple-panel" as a compatible is widespread and really confusing. 
The fact that you made this comment is good enough for me to say we don't
need it, I'll take it out.

> 
> > +		backlight = <&lcd_backlight>;
> > +
> > +		port {
> > +			panel_in: endpoint {
> > +				remote-endpoint = <&lvds_receiver_out>;
> > +			};
> > +		};
> > +	};
> > +
> >  	reg_1p5v: 1p5v {
> >  		compatible = "regulator-fixed";
> >  		regulator-name = "1P5V";
> > @@ -120,6 +163,18 @@
> >  	status = "okay";
> >  };
> >
> > +&du {
> > +	status = "okay";
> > +};
> > +
> > +&gpio2 {
> > +	touch-interrupt {
> > +		gpio-hog;
> > +		gpios = <12 GPIO_ACTIVE_LOW>;
> > +		input;
> > +	};
> 
> Do you need this, with the touchpanel@38 node already listing the
> interrupt ?

Yes, unfortunately we do need this as the bootloader is poking with the gpio.
I can't fix this in the bootloader as we have no control over it.

Thanks,
Fab

> 
> > +};
> > +
> >  &hsusb {
> >  	status = "okay";
> >  	pinctrl-0 = <&usb0_pins>;
> > @@ -147,6 +202,25 @@
> >  		VDDIO-supply = <&reg_3p3v>;
> >  		VDDD-supply = <&reg_1p5v>;
> >  	};
> > +
> > +	touch: touchpanel@38 {
> > +		compatible = "edt,edt-ft5406";
> > +		reg = <0x38>;
> > +		interrupt-parent = <&gpio2>;
> > +		interrupts = <12 IRQ_TYPE_EDGE_FALLING>;
> > +	};
> > +};
> > +
> > +&lvds0 {
> > +	status = "okay";
> > +
> > +	ports {
> > +		port@1 {
> > +			lvds0_out: endpoint {
> > +				remote-endpoint = <&lvds_receiver_in>;
> > +			};
> > +		};
> > +	};
> >  };
> >
> >  &pci0 {
> > @@ -180,6 +254,11 @@
> >  		function = "i2c2";
> >  	};
> >
> > +	pwm3_pins: pwm3 {
> > +		groups = "pwm3";
> > +		function = "pwm3";
> > +	};
> > +
> >  	scif0_pins: scif0 {
> >  		groups = "scif0_data_d";
> >  		function = "scif0";
> > @@ -218,6 +297,12 @@
> >  	};
> >  };
> >
> > +&pwm3 {
> > +	pinctrl-0 = <&pwm3_pins>;
> > +	pinctrl-names = "default";
> > +	status = "okay";
> > +};
> > +
> >  &rcar_sound {
> >  	pinctrl-0 = <&sound_pins>;
> >  	pinctrl-names = "default";
> > diff --git a/arch/arm/boot/dts/iwg20d-q7-dbcm-ca.dtsi b/arch/arm/boot/dts/iwg20d-q7-dbcm-ca.dtsi
> > index 0e99df2..ede2e0c 100644
> > --- a/arch/arm/boot/dts/iwg20d-q7-dbcm-ca.dtsi
> > +++ b/arch/arm/boot/dts/iwg20d-q7-dbcm-ca.dtsi
> > @@ -39,7 +39,6 @@
> >  &du {
> >  	pinctrl-0 = <&du_pins>;
> >  	pinctrl-names = "default";
> > -	status = "okay";
> >
> >  	ports {
> >  		port@0 {
> 
> --
> Regards,
> 
> Laurent Pinchart

  reply index

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-07 20:10 [PATCH v3 0/7] Add LCD panel support to iwg20d Fabrizio Castro
2019-11-07 20:10 ` [PATCH v3 1/7] dt-bindings: display: bridge: Convert lvds-transmitter binding to json-schema Fabrizio Castro
2019-11-07 20:20   ` Laurent Pinchart
2019-11-08  9:15     ` Fabrizio Castro
2019-11-08 10:54       ` Laurent Pinchart
2019-11-07 20:10 ` [PATCH v3 2/7] drm/bridge: Repurpose lvds-encoder.c Fabrizio Castro
2019-11-07 20:34   ` Laurent Pinchart
2019-11-08  9:22     ` Fabrizio Castro
2019-11-08  9:39       ` Jacopo Mondi
2019-11-08 11:06         ` Laurent Pinchart
2019-11-08 11:37           ` Jacopo Mondi
2019-11-08 11:40             ` Laurent Pinchart
2019-11-08 11:02       ` Laurent Pinchart
2019-11-07 20:10 ` [PATCH v3 3/7] dt-bindings: display: bridge: Repurpose lvds-encoder Fabrizio Castro
2019-11-07 20:38   ` Laurent Pinchart
2019-11-08  9:26     ` Fabrizio Castro
2019-11-07 20:11 ` [PATCH v3 4/7] drm: Define DRM_MODE_CONNECTOR_PARALLEL Fabrizio Castro
2019-11-07 20:46   ` Laurent Pinchart
2019-11-08  9:32     ` Fabrizio Castro
2019-11-07 20:11 ` [PATCH v3 5/7] drm/panel: panel-simple: Add connector type for etm0700g0dh6 Fabrizio Castro
2019-11-07 20:48   ` Laurent Pinchart
2019-11-08  9:51     ` Fabrizio Castro
2019-11-07 20:11 ` [PATCH v3 6/7] ARM: dts: iwg20d-q7-common: Add LCD support Fabrizio Castro
2019-11-07 20:55   ` Laurent Pinchart
2019-11-08 12:02     ` Fabrizio Castro [this message]
2019-11-07 20:11 ` [PATCH v3 7/7] ARM: shmobile_defconfig: Enable support for panels from EDT Fabrizio Castro
2019-11-07 20:56   ` Laurent Pinchart
2019-11-08  8:38     ` Geert Uytterhoeven

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=TY1PR01MB1770D144464371F5DB5746B8C07B0@TY1PR01MB1770.jpnprd01.prod.outlook.com \
    --to=fabrizio.castro@bp.renesas.com \
    --cc=Chris.Paterson2@renesas.com \
    --cc=a.hajda@samsung.com \
    --cc=airlied@linux.ie \
    --cc=biju.das@bp.renesas.com \
    --cc=daniel@ffwll.ch \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=geert+renesas@glider.be \
    --cc=horms@verge.net.au \
    --cc=jacopo+renesas@jmondi.org \
    --cc=kieran.bingham+renesas@ideasonboard.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=mark.rutland@arm.com \
    --cc=narmstrong@baylibre.com \
    --cc=peda@axentia.se \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Renesas-SoC Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-renesas-soc/0 linux-renesas-soc/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-renesas-soc linux-renesas-soc/ https://lore.kernel.org/linux-renesas-soc \
		linux-renesas-soc@vger.kernel.org
	public-inbox-index linux-renesas-soc

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-renesas-soc


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git