linux-renesas-soc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] arm64: dts: renesas: r8a77961: Add iommus to SDHI/MMC nodes
@ 2021-07-14  9:08 Yoshihiro Shimoda
  2021-07-20 10:27 ` Yoshihiro Shimoda
  0 siblings, 1 reply; 4+ messages in thread
From: Yoshihiro Shimoda @ 2021-07-14  9:08 UTC (permalink / raw)
  To: geert+renesas, magnus.damm; +Cc: linux-renesas-soc, Yoshihiro Shimoda

This patch adds iommus properties to the r8a77961 sdhi nodes.

Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
---
 arch/arm64/boot/dts/renesas/r8a77961.dtsi | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/r8a77961.dtsi b/arch/arm64/boot/dts/renesas/r8a77961.dtsi
index 91b501e0121e..6e80fee23891 100644
--- a/arch/arm64/boot/dts/renesas/r8a77961.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a77961.dtsi
@@ -2280,6 +2280,7 @@ sdhi0: mmc@ee100000 {
 			max-frequency = <200000000>;
 			power-domains = <&sysc R8A77961_PD_ALWAYS_ON>;
 			resets = <&cpg 314>;
+			iommus = <&ipmmu_ds1 32>;
 			status = "disabled";
 		};
 
@@ -2292,6 +2293,7 @@ sdhi1: mmc@ee120000 {
 			max-frequency = <200000000>;
 			power-domains = <&sysc R8A77961_PD_ALWAYS_ON>;
 			resets = <&cpg 313>;
+			iommus = <&ipmmu_ds1 33>;
 			status = "disabled";
 		};
 
@@ -2304,6 +2306,7 @@ sdhi2: mmc@ee140000 {
 			max-frequency = <200000000>;
 			power-domains = <&sysc R8A77961_PD_ALWAYS_ON>;
 			resets = <&cpg 312>;
+			iommus = <&ipmmu_ds1 34>;
 			status = "disabled";
 		};
 
@@ -2316,6 +2319,7 @@ sdhi3: mmc@ee160000 {
 			max-frequency = <200000000>;
 			power-domains = <&sysc R8A77961_PD_ALWAYS_ON>;
 			resets = <&cpg 311>;
+			iommus = <&ipmmu_ds1 35>;
 			status = "disabled";
 		};
 
-- 
2.25.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* RE: [PATCH] arm64: dts: renesas: r8a77961: Add iommus to SDHI/MMC nodes
  2021-07-14  9:08 [PATCH] arm64: dts: renesas: r8a77961: Add iommus to SDHI/MMC nodes Yoshihiro Shimoda
@ 2021-07-20 10:27 ` Yoshihiro Shimoda
  2021-07-20 10:33   ` Geert Uytterhoeven
  0 siblings, 1 reply; 4+ messages in thread
From: Yoshihiro Shimoda @ 2021-07-20 10:27 UTC (permalink / raw)
  To: geert+renesas; +Cc: linux-renesas-soc, magnus.damm

Hi Geert-san,

> From: Yoshihiro Shimoda, Sent: Wednesday, July 14, 2021 6:09 PM
> 
> This patch adds iommus properties to the r8a77961 sdhi nodes.
> 
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>

I realized that the r8a77961.dtsi is missing iommus properties on dmacN and avb nodes.
Can I make incremental patches? Or, can I add these properties into this patch as v2?

Best regards,
Yoshihiro Shimoda

> ---
>  arch/arm64/boot/dts/renesas/r8a77961.dtsi | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/renesas/r8a77961.dtsi b/arch/arm64/boot/dts/renesas/r8a77961.dtsi
> index 91b501e0121e..6e80fee23891 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77961.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a77961.dtsi
> @@ -2280,6 +2280,7 @@ sdhi0: mmc@ee100000 {
>  			max-frequency = <200000000>;
>  			power-domains = <&sysc R8A77961_PD_ALWAYS_ON>;
>  			resets = <&cpg 314>;
> +			iommus = <&ipmmu_ds1 32>;
>  			status = "disabled";
>  		};
> 
> @@ -2292,6 +2293,7 @@ sdhi1: mmc@ee120000 {
>  			max-frequency = <200000000>;
>  			power-domains = <&sysc R8A77961_PD_ALWAYS_ON>;
>  			resets = <&cpg 313>;
> +			iommus = <&ipmmu_ds1 33>;
>  			status = "disabled";
>  		};
> 
> @@ -2304,6 +2306,7 @@ sdhi2: mmc@ee140000 {
>  			max-frequency = <200000000>;
>  			power-domains = <&sysc R8A77961_PD_ALWAYS_ON>;
>  			resets = <&cpg 312>;
> +			iommus = <&ipmmu_ds1 34>;
>  			status = "disabled";
>  		};
> 
> @@ -2316,6 +2319,7 @@ sdhi3: mmc@ee160000 {
>  			max-frequency = <200000000>;
>  			power-domains = <&sysc R8A77961_PD_ALWAYS_ON>;
>  			resets = <&cpg 311>;
> +			iommus = <&ipmmu_ds1 35>;
>  			status = "disabled";
>  		};
> 
> --
> 2.25.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] arm64: dts: renesas: r8a77961: Add iommus to SDHI/MMC nodes
  2021-07-20 10:27 ` Yoshihiro Shimoda
@ 2021-07-20 10:33   ` Geert Uytterhoeven
  2021-07-21  8:16     ` Yoshihiro Shimoda
  0 siblings, 1 reply; 4+ messages in thread
From: Geert Uytterhoeven @ 2021-07-20 10:33 UTC (permalink / raw)
  To: Yoshihiro Shimoda; +Cc: linux-renesas-soc, magnus.damm

Hi Shimoda-san,

On Tue, Jul 20, 2021 at 12:27 PM Yoshihiro Shimoda
<yoshihiro.shimoda.uh@renesas.com> wrote:
> > From: Yoshihiro Shimoda, Sent: Wednesday, July 14, 2021 6:09 PM
> >
> > This patch adds iommus properties to the r8a77961 sdhi nodes.
> >
> > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
>
> I realized that the r8a77961.dtsi is missing iommus properties on dmacN and avb nodes.
> Can I make incremental patches? Or, can I add these properties into this patch as v2?

Feel free to send a v2 (with updated summary/description), as I haven't
reviewed this patch yet.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 4+ messages in thread

* RE: [PATCH] arm64: dts: renesas: r8a77961: Add iommus to SDHI/MMC nodes
  2021-07-20 10:33   ` Geert Uytterhoeven
@ 2021-07-21  8:16     ` Yoshihiro Shimoda
  0 siblings, 0 replies; 4+ messages in thread
From: Yoshihiro Shimoda @ 2021-07-21  8:16 UTC (permalink / raw)
  To: Geert Uytterhoeven; +Cc: linux-renesas-soc, magnus.damm

Hi Geert-san,

> From: Geert Uytterhoeven, Sent: Tuesday, July 20, 2021 7:34 PM
> 
> On Tue, Jul 20, 2021 at 12:27 PM Yoshihiro Shimoda
> <yoshihiro.shimoda.uh@renesas.com> wrote:
> > > From: Yoshihiro Shimoda, Sent: Wednesday, July 14, 2021 6:09 PM
> > >
> > > This patch adds iommus properties to the r8a77961 sdhi nodes.
> > >
> > > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> >
> > I realized that the r8a77961.dtsi is missing iommus properties on dmacN and avb nodes.
> > Can I make incremental patches? Or, can I add these properties into this patch as v2?
> 
> Feel free to send a v2 (with updated summary/description), as I haven't
> reviewed this patch yet.

Thank you for your reply! I got it. I'll send a v2 patch with updated summary/description later.

Best regards,
Yoshihiro Shimoda


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-07-21  8:21 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-14  9:08 [PATCH] arm64: dts: renesas: r8a77961: Add iommus to SDHI/MMC nodes Yoshihiro Shimoda
2021-07-20 10:27 ` Yoshihiro Shimoda
2021-07-20 10:33   ` Geert Uytterhoeven
2021-07-21  8:16     ` Yoshihiro Shimoda

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).