From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
To: Linus Walleij <linus.walleij@linaro.org>,
Geert Uytterhoeven <geert+renesas@glider.be>
Cc: "thierry.reding@gmail.com" <thierry.reding@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
"linux-pwm@vger.kernel.org" <linux-pwm@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>
Subject: RE: [PATCH RFC 2/7] pinctrl: sh-pfc: remove incomplete flag "cfg->type"
Date: Mon, 29 Jul 2019 05:16:33 +0000 [thread overview]
Message-ID: <TYAPR01MB4544031C6A027A3690FFFB77D8DD0@TYAPR01MB4544.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <CACRpkdZqTaA04bja16xh338JiwoSqFpH_2rV95FaF7YhawQzMg@mail.gmail.com>
Hi Linus, Geert,
> From: Linus Walleij, Sent: Monday, July 29, 2019 8:02 AM
>
> On Mon, Jul 8, 2019 at 11:08 AM Yoshihiro Shimoda
> <yoshihiro.shimoda.uh@renesas.com> wrote:
>
> > The old commit c58d9c1b26e3 ("sh-pfc: Implement generic pinconf
> > support") broke the cfg->type flag to PINMUX_TYPE_FUNCTION because
> > sh_pfc_pinconf_set() didn't call sh_pfc_reconfig_pin().
> > Now if we fix the cfg->type condition, it gets worse because:
> > - Some drivers might be deferred so that .set_mux() will be called
> > multiple times.
> > - In such the case, the sh-pfc driver returns -EBUSY even if
> > the group is the same, and then that driver fails to probe.
> >
> > Since the pinctrl subsystem already has such conditions according
> > to @set_mux and @gpio_request_enable, this patch just remove
> > the incomplete flag from sh-pfc/pinctrl.c.
> >
> > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
>
> This looks like it should have a Fixes: tag as well.
I got it. The Fixes tag should be:
Fixes: c58d9c1b26e3 ("sh-pfc: Implement generic pinconf support")
> Geert will decide what to do with this.
I got it.
> Can all the pinctrl patches be applied independently of the other
> changes so Geert can apply and send me those patches in his pull
> requests?
The pinctrl patches (1/7 through 3/7) can be applied on next-20190726
so I think Geert can apply these patches into his repo.
Geert, if I should resend the pinctrl patches, please let me know!
Best regards,
Yoshihiro Shimoda
> Yours,
> Linus Walleij
next prev parent reply other threads:[~2019-07-29 5:16 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-08 9:07 [PATCH RFC 0/7] treewide: modify sh-pfc and add support pwm duty zero Yoshihiro Shimoda
2019-07-08 9:07 ` [PATCH RFC 1/7] pinctrl: sh-pfc: add new flags into struct sh_pfc_pin_config Yoshihiro Shimoda
2019-07-08 15:51 ` Sergei Shtylyov
2019-08-06 8:46 ` Geert Uytterhoeven
2019-07-08 9:07 ` [PATCH RFC 2/7] pinctrl: sh-pfc: remove incomplete flag "cfg->type" Yoshihiro Shimoda
2019-07-28 23:02 ` Linus Walleij
2019-07-29 5:16 ` Yoshihiro Shimoda [this message]
2019-08-06 8:49 ` Geert Uytterhoeven
2019-08-06 9:23 ` Geert Uytterhoeven
2019-08-06 11:48 ` Yoshihiro Shimoda
2019-07-08 9:07 ` [PATCH RFC 3/7] pinctrl: sh-pfc: Rollback to mux if requires when the gpio is freed Yoshihiro Shimoda
2019-08-06 9:02 ` Geert Uytterhoeven
2019-08-06 11:38 ` Yoshihiro Shimoda
2019-08-06 12:01 ` Geert Uytterhoeven
2019-07-08 9:07 ` [PATCH RFC 4/7] dt-bindings: pwm: rcar: Add specific gpios property to output duty zero Yoshihiro Shimoda
2019-08-06 9:21 ` Geert Uytterhoeven
2019-07-08 9:07 ` [PATCH RFC 5/7] pwm: rcar: remove a redundant condition in rcar_pwm_apply() Yoshihiro Shimoda
2019-08-06 9:05 ` Geert Uytterhoeven
2019-08-06 11:39 ` Yoshihiro Shimoda
2019-08-06 16:00 ` Uwe Kleine-König
2019-08-07 2:56 ` Yoshihiro Shimoda
2019-08-07 6:33 ` Uwe Kleine-König
2019-07-08 9:07 ` [PATCH RFC 6/7] pwm: rcar: Add gpio support to output duty zero Yoshihiro Shimoda
2019-08-07 7:03 ` Uwe Kleine-König
2019-08-08 3:52 ` Yoshihiro Shimoda
2019-08-08 6:49 ` Geert Uytterhoeven
2019-08-08 7:02 ` Yoshihiro Shimoda
2019-08-08 7:31 ` Uwe Kleine-König
2019-07-08 9:07 ` [PATCH RFC 7/7] arm64: dts: renesas: salvator-common: add gpio property into pwm1 Yoshihiro Shimoda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=TYAPR01MB4544031C6A027A3690FFFB77D8DD0@TYAPR01MB4544.jpnprd01.prod.outlook.com \
--to=yoshihiro.shimoda.uh@renesas.com \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).