From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Kishon Vijay Abraham I <kishon@ti.com>,
Rob Herring <robh+dt@kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>
Subject: RE: [PATCH v2 3/4] dt-bindings: phy: renesas: usb3-phy: convert bindings to json-schema
Date: Fri, 27 Mar 2020 02:39:35 +0000 [thread overview]
Message-ID: <TYAPR01MB454422247D0D1AF062625803D8CC0@TYAPR01MB4544.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <CAMuHMdXe6GjjQDCjGAE=GfkEYkBZjqj4PNNB+Sp_NOtYXx8ZTA@mail.gmail.com>
Hi Geert-san,
Thank you for your review!
> From: Geert Uytterhoeven, Sent: Thursday, March 26, 2020 5:53 PM
<snip>
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/phy/renesas,usb3-phy.yaml
> > @@ -0,0 +1,78 @@
> > +# SPDX-License-Identifier: GPL-2.0-only
>
> In think Rob would prefer
>
> # SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
I got it.
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/phy/renesas,usb3-phy.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Renesas R-Car generation 3 USB 3.0 PHY
> > +
> > +maintainers:
> > + - Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> > +
> > +properties:
> > + compatible:
> > + items:
> > + - enum:
> > + - renesas,r8a774a1-usb3-phy # RZ/G2M
> > + - renesas,r8a774b1-usb3-phy # RZ/G2N
> > + - renesas,r8a7795-usb3-phy # R-Car H3
> > + - renesas,r8a7796-usb3-phy # R-Car M3-W
> > + - renesas,r8a77965-usb3-phy # R-Car M3-N
> > + - const: renesas,rcar-gen3-usb3-phy
> > +
> > + reg:
> > + # base address and length of the registers block for the PHY.
>
> I think this comment can be removed.
I think so. So, I'll remove it.
> > + maxItems: 1
> > +
> > + clocks:
> > + # A list of phandles and clock-specifier pairs.
>
> Likewise.
Yes, I'll remove it.
> "minItems: 2"?
Thank you for pointed it out. Yes, this should have "minItems: 2".
> > + maxItems: 3
> > +
> > + clock-names:
> > + # If you want to use the ssc, the clock-frequency of usb_extal
> > + # must not be 0.
>
> "minItems: 2"?
Yes, I'll add it.
> > + maxItems: 3
> > + items:
> > + - const: usb3-if # The funcional clock
> > + - const: usb3s_clk # The usb3's external clock
> > + - const: usb_extal # The usb2's external clock
> > +
> > + '#phy-cells':
> > + # see phy-bindings.txt in the same directory
> > + const: 0
> > +
> > + power-domains:
> > + maxItems: 1
> > +
> > + resets:
> > + maxItems: 1
> > +
> > + renesas,ssc-range:
> > + description: |
> > + Enable/disable spread spectrum clock (ssc). 0 or the property doesn't
> > + exist means disabliing the ssc.
>
> disabling
Oops, I'll fix it.
> The actual value will be -<value> ppm.
Yes, that's right. So, I'll add this sentence.
> > + allOf:
> > + - $ref: /schemas/types.yaml#/definitions/uint32
> > + - enum: [ 0, 4003, 4492, 4980 ]
> > +
> > +required:
> > + - compatible
> > + - reg
> > + - clocks
> > + - clock-names
> > + - '#phy-cells'
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > + - |
> > + #include <dt-bindings/clock/r8a7795-cpg-mssr.h>
> > + #include <dt-bindings/power/r8a7795-sysc.h>
> > +
> > + usb-phy@e65ee000 {
> > + compatible = "renesas,r8a7795-usb3-phy", "renesas,rcar-gen3-usb3-phy";
> > + reg = <0 0xe65ee000 0 0x90>;
>
> Examples use the default #{address,size}-cells of <1>, so
>
> reg = <0xe65ee000 0x90>;
Oh, I didn't know. I'll fix it.
Best regards,
Yoshihiro Shimoda
next prev parent reply other threads:[~2020-03-27 2:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-26 5:29 [PATCH v2 0/4] dt-bindings: phy: add r8a77961 support Yoshihiro Shimoda
2020-03-26 5:29 ` [PATCH v2 1/4] dt-bindings: phy: renesas: usb2-phy: convert bindings to json-schema Yoshihiro Shimoda
2020-03-26 8:59 ` Geert Uytterhoeven
2020-03-27 2:42 ` Yoshihiro Shimoda
2020-03-26 5:29 ` [PATCH v2 2/4] dt-bindings: phy: renesas: usb2-phy: add r8a77961 support Yoshihiro Shimoda
2020-03-26 5:29 ` [PATCH v2 3/4] dt-bindings: phy: renesas: usb3-phy: convert bindings to json-schema Yoshihiro Shimoda
2020-03-26 8:52 ` Geert Uytterhoeven
2020-03-27 2:39 ` Yoshihiro Shimoda [this message]
2020-03-26 5:29 ` [PATCH v2 4/4] dt-bindings: phy: renesas: usb3-phy: add r8a77961 support Yoshihiro Shimoda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=TYAPR01MB454422247D0D1AF062625803D8CC0@TYAPR01MB4544.jpnprd01.prod.outlook.com \
--to=yoshihiro.shimoda.uh@renesas.com \
--cc=devicetree@vger.kernel.org \
--cc=geert@linux-m68k.org \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).