* [PATCH] drm: renesas: rcar-du: rzg2l_mipi_dsi: Update the comment in rzg2l_mipi_dsi_start_video()
@ 2023-09-06 9:43 Biju Das
2023-09-06 10:04 ` Geert Uytterhoeven
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Biju Das @ 2023-09-06 9:43 UTC (permalink / raw)
To: David Airlie, Daniel Vetter
Cc: Biju Das, Laurent Pinchart, Kieran Bingham, Sam Ravnborg,
Rob Herring, dri-devel, linux-renesas-soc, Geert Uytterhoeven,
Prabhakar Mahadev Lad, Biju Das, Pavel Machek
Add missing space in the comment in rzg2l_mipi_dsi_start_video().
Reported-by: Pavel Machek <pavel@denx.de>
Closes: https://lore.kernel.org/all/ZPg7STHDn4LbLy7f@duo.ucw.cz/
Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
---
This issue is noticed while backporting this driver to 6.1.y-cip [1].
[1] https://lore.kernel.org/all/20230905160737.167877-1-biju.das.jz@bp.renesas.com/
---
drivers/gpu/drm/renesas/rcar-du/rzg2l_mipi_dsi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/renesas/rcar-du/rzg2l_mipi_dsi.c b/drivers/gpu/drm/renesas/rcar-du/rzg2l_mipi_dsi.c
index 10febea473cd..9b5cfdd3e1c5 100644
--- a/drivers/gpu/drm/renesas/rcar-du/rzg2l_mipi_dsi.c
+++ b/drivers/gpu/drm/renesas/rcar-du/rzg2l_mipi_dsi.c
@@ -479,7 +479,7 @@ static int rzg2l_mipi_dsi_start_video(struct rzg2l_mipi_dsi *dsi)
u32 status;
int ret;
- /* Configuration for Blanking sequence and start video input*/
+ /* Configuration for Blanking sequence and start video input */
vich1set0r = VICH1SET0R_HFPNOLP | VICH1SET0R_HBPNOLP |
VICH1SET0R_HSANOLP | VICH1SET0R_VSTART;
rzg2l_mipi_dsi_link_write(dsi, VICH1SET0R, vich1set0r);
--
2.25.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] drm: renesas: rcar-du: rzg2l_mipi_dsi: Update the comment in rzg2l_mipi_dsi_start_video()
2023-09-06 9:43 [PATCH] drm: renesas: rcar-du: rzg2l_mipi_dsi: Update the comment in rzg2l_mipi_dsi_start_video() Biju Das
@ 2023-09-06 10:04 ` Geert Uytterhoeven
2023-09-06 13:25 ` Laurent Pinchart
[not found] ` <TYCPR01MB1126962629C0E20D78BDE8C8386B0A@TYCPR01MB11269.jpnprd01.prod.outlook.com>
2 siblings, 0 replies; 5+ messages in thread
From: Geert Uytterhoeven @ 2023-09-06 10:04 UTC (permalink / raw)
To: Biju Das
Cc: David Airlie, Daniel Vetter, Laurent Pinchart, Kieran Bingham,
Sam Ravnborg, Rob Herring, dri-devel, linux-renesas-soc,
Geert Uytterhoeven, Prabhakar Mahadev Lad, Biju Das,
Pavel Machek
On Wed, Sep 6, 2023 at 11:44 AM Biju Das <biju.das.jz@bp.renesas.com> wrote:
> Add missing space in the comment in rzg2l_mipi_dsi_start_video().
>
> Reported-by: Pavel Machek <pavel@denx.de>
> Closes: https://lore.kernel.org/all/ZPg7STHDn4LbLy7f@duo.ucw.cz/
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm: renesas: rcar-du: rzg2l_mipi_dsi: Update the comment in rzg2l_mipi_dsi_start_video()
2023-09-06 9:43 [PATCH] drm: renesas: rcar-du: rzg2l_mipi_dsi: Update the comment in rzg2l_mipi_dsi_start_video() Biju Das
2023-09-06 10:04 ` Geert Uytterhoeven
@ 2023-09-06 13:25 ` Laurent Pinchart
[not found] ` <TYCPR01MB1126962629C0E20D78BDE8C8386B0A@TYCPR01MB11269.jpnprd01.prod.outlook.com>
2 siblings, 0 replies; 5+ messages in thread
From: Laurent Pinchart @ 2023-09-06 13:25 UTC (permalink / raw)
To: Biju Das
Cc: David Airlie, Daniel Vetter, Kieran Bingham, Sam Ravnborg,
Rob Herring, dri-devel, linux-renesas-soc, Geert Uytterhoeven,
Prabhakar Mahadev Lad, Biju Das, Pavel Machek
Hi Biju,
Thank you for the patch.
On Wed, Sep 06, 2023 at 10:43:46AM +0100, Biju Das wrote:
> Add missing space in the comment in rzg2l_mipi_dsi_start_video().
>
> Reported-by: Pavel Machek <pavel@denx.de>
> Closes: https://lore.kernel.org/all/ZPg7STHDn4LbLy7f@duo.ucw.cz/
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> This issue is noticed while backporting this driver to 6.1.y-cip [1].
>
> [1] https://lore.kernel.org/all/20230905160737.167877-1-biju.das.jz@bp.renesas.com/
> ---
> drivers/gpu/drm/renesas/rcar-du/rzg2l_mipi_dsi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/renesas/rcar-du/rzg2l_mipi_dsi.c b/drivers/gpu/drm/renesas/rcar-du/rzg2l_mipi_dsi.c
> index 10febea473cd..9b5cfdd3e1c5 100644
> --- a/drivers/gpu/drm/renesas/rcar-du/rzg2l_mipi_dsi.c
> +++ b/drivers/gpu/drm/renesas/rcar-du/rzg2l_mipi_dsi.c
> @@ -479,7 +479,7 @@ static int rzg2l_mipi_dsi_start_video(struct rzg2l_mipi_dsi *dsi)
> u32 status;
> int ret;
>
> - /* Configuration for Blanking sequence and start video input*/
> + /* Configuration for Blanking sequence and start video input */
> vich1set0r = VICH1SET0R_HFPNOLP | VICH1SET0R_HBPNOLP |
> VICH1SET0R_HSANOLP | VICH1SET0R_VSTART;
> rzg2l_mipi_dsi_link_write(dsi, VICH1SET0R, vich1set0r);
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm: renesas: rcar-du: rzg2l_mipi_dsi: Update the comment in rzg2l_mipi_dsi_start_video()
[not found] ` <TYCPR01MB1126962629C0E20D78BDE8C8386B0A@TYCPR01MB11269.jpnprd01.prod.outlook.com>
@ 2023-11-16 11:03 ` Laurent Pinchart
2024-01-04 11:01 ` Biju Das
0 siblings, 1 reply; 5+ messages in thread
From: Laurent Pinchart @ 2023-11-16 11:03 UTC (permalink / raw)
To: Biju Das
Cc: David Airlie, Daniel Vetter, Kieran Bingham, Sam Ravnborg,
Rob Herring, dri-devel, linux-renesas-soc, Geert Uytterhoeven,
Prabhakar Mahadev Lad, biju.das.au, Pavel Machek
Hi Biju,
On Thu, Nov 16, 2023 at 10:58:56AM +0000, Biju Das wrote:
> Hi All,
>
> Gentle ping. It is reviewed by both Laurent and Geert.
>
> Can it be applied to drm-misc-next, if everyone is happy with this patch?
Yes, now that v6.7-rc1 is out I'll send pull requests shortly.
> > From: Biju Das <biju.das.jz@bp.renesas.com>
> > Sent: Wednesday, September 6, 2023 10:44 AM
> > Subject: [PATCH] drm: renesas: rcar-du: rzg2l_mipi_dsi: Update the comment
> > in rzg2l_mipi_dsi_start_video()
> >
> > Add missing space in the comment in rzg2l_mipi_dsi_start_video().
> >
> > Reported-by: Pavel Machek <pavel@denx.de>
> > Closes:
> > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> > ---
> > This issue is noticed while backporting this driver to 6.1.y-cip [1].
> >
> > [1]
> > ---
> > drivers/gpu/drm/renesas/rcar-du/rzg2l_mipi_dsi.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/renesas/rcar-du/rzg2l_mipi_dsi.c
> > b/drivers/gpu/drm/renesas/rcar-du/rzg2l_mipi_dsi.c
> > index 10febea473cd..9b5cfdd3e1c5 100644
> > --- a/drivers/gpu/drm/renesas/rcar-du/rzg2l_mipi_dsi.c
> > +++ b/drivers/gpu/drm/renesas/rcar-du/rzg2l_mipi_dsi.c
> > @@ -479,7 +479,7 @@ static int rzg2l_mipi_dsi_start_video(struct
> > rzg2l_mipi_dsi *dsi)
> > u32 status;
> > int ret;
> >
> > - /* Configuration for Blanking sequence and start video input*/
> > + /* Configuration for Blanking sequence and start video input */
> > vich1set0r = VICH1SET0R_HFPNOLP | VICH1SET0R_HBPNOLP |
> > VICH1SET0R_HSANOLP | VICH1SET0R_VSTART;
> > rzg2l_mipi_dsi_link_write(dsi, VICH1SET0R, vich1set0r);
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH] drm: renesas: rcar-du: rzg2l_mipi_dsi: Update the comment in rzg2l_mipi_dsi_start_video()
2023-11-16 11:03 ` Laurent Pinchart
@ 2024-01-04 11:01 ` Biju Das
0 siblings, 0 replies; 5+ messages in thread
From: Biju Das @ 2024-01-04 11:01 UTC (permalink / raw)
To: Laurent Pinchart
Cc: David Airlie, Daniel Vetter, Kieran Bingham, Sam Ravnborg,
Rob Herring, dri-devel, linux-renesas-soc, Geert Uytterhoeven,
Prabhakar Mahadev Lad, biju.das.au, Pavel Machek
Hi Laurent,
> Subject: Re: [PATCH] drm: renesas: rcar-du: rzg2l_mipi_dsi: Update the
> comment in rzg2l_mipi_dsi_start_video()
>
> Hi Biju,
>
> On Thu, Nov 16, 2023 at 10:58:56AM +0000, Biju Das wrote:
> > Hi All,
> >
> > Gentle ping. It is reviewed by both Laurent and Geert.
> >
> > Can it be applied to drm-misc-next, if everyone is happy with this
> patch?
>
> Yes, now that v6.7-rc1 is out I'll send pull requests shortly.
Looks like you missed this patch.
Cheers,
Biju
>
> > > From: Biju Das <biju.das.jz@bp.renesas.com>
> > > Sent: Wednesday, September 6, 2023 10:44 AM
> > > Subject: [PATCH] drm: renesas: rcar-du: rzg2l_mipi_dsi: Update the
> > > comment in rzg2l_mipi_dsi_start_video()
> > >
> > > Add missing space in the comment in rzg2l_mipi_dsi_start_video().
> > >
> > > Reported-by: Pavel Machek <pavel@denx.de>
> > > Closes:
> > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> > > ---
> > > This issue is noticed while backporting this driver to 6.1.y-cip [1].
> > >
> > > [1]
> > > ---
> > > drivers/gpu/drm/renesas/rcar-du/rzg2l_mipi_dsi.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/gpu/drm/renesas/rcar-du/rzg2l_mipi_dsi.c
> > > b/drivers/gpu/drm/renesas/rcar-du/rzg2l_mipi_dsi.c
> > > index 10febea473cd..9b5cfdd3e1c5 100644
> > > --- a/drivers/gpu/drm/renesas/rcar-du/rzg2l_mipi_dsi.c
> > > +++ b/drivers/gpu/drm/renesas/rcar-du/rzg2l_mipi_dsi.c
> > > @@ -479,7 +479,7 @@ static int rzg2l_mipi_dsi_start_video(struct
> > > rzg2l_mipi_dsi *dsi)
> > > u32 status;
> > > int ret;
> > >
> > > - /* Configuration for Blanking sequence and start video input*/
> > > + /* Configuration for Blanking sequence and start video input */
> > > vich1set0r = VICH1SET0R_HFPNOLP | VICH1SET0R_HBPNOLP |
> > > VICH1SET0R_HSANOLP | VICH1SET0R_VSTART;
> > > rzg2l_mipi_dsi_link_write(dsi, VICH1SET0R, vich1set0r);
>
> --
> Regards,
>
> Laurent Pinchart
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-01-04 11:01 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-09-06 9:43 [PATCH] drm: renesas: rcar-du: rzg2l_mipi_dsi: Update the comment in rzg2l_mipi_dsi_start_video() Biju Das
2023-09-06 10:04 ` Geert Uytterhoeven
2023-09-06 13:25 ` Laurent Pinchart
[not found] ` <TYCPR01MB1126962629C0E20D78BDE8C8386B0A@TYCPR01MB11269.jpnprd01.prod.outlook.com>
2023-11-16 11:03 ` Laurent Pinchart
2024-01-04 11:01 ` Biju Das
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).