* [PATCH] arm64: dts: renesas: r9a09g011: Reword ethernet status
@ 2023-01-18 13:52 Fabrizio Castro
2023-01-18 15:07 ` Laurent Pinchart
2023-01-25 11:08 ` Geert Uytterhoeven
0 siblings, 2 replies; 3+ messages in thread
From: Fabrizio Castro @ 2023-01-18 13:52 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Geert Uytterhoeven
Cc: Fabrizio Castro, Magnus Damm, linux-renesas-soc, devicetree,
linux-kernel, Chris Paterson, Biju Das, Laurent Pinchart,
Jacopo Mondi
Although of_fdt_device_is_available returns true when the DT
property "status" is assigned "ok" or "okay", and false for every
other value, it's become common practice to assign "disabled"
when we want of_fdt_device_is_available to return false.
For some reason, the status property of the ethernet node was
assigned "disable" when originally added to the kernel. Change
it to "disabled" for consistency.
Signed-off-by: Fabrizio Castro <fabrizio.castro.jz@renesas.com>
---
arch/arm64/boot/dts/renesas/r9a09g011.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/renesas/r9a09g011.dtsi b/arch/arm64/boot/dts/renesas/r9a09g011.dtsi
index dd35a8ff72ee..b0c066c5e0ba 100644
--- a/arch/arm64/boot/dts/renesas/r9a09g011.dtsi
+++ b/arch/arm64/boot/dts/renesas/r9a09g011.dtsi
@@ -165,7 +165,7 @@ avb: ethernet@a3300000 {
power-domains = <&cpg>;
#address-cells = <1>;
#size-cells = <0>;
- status = "disable";
+ status = "disabled";
};
cpg: clock-controller@a3500000 {
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: dts: renesas: r9a09g011: Reword ethernet status
2023-01-18 13:52 [PATCH] arm64: dts: renesas: r9a09g011: Reword ethernet status Fabrizio Castro
@ 2023-01-18 15:07 ` Laurent Pinchart
2023-01-25 11:08 ` Geert Uytterhoeven
1 sibling, 0 replies; 3+ messages in thread
From: Laurent Pinchart @ 2023-01-18 15:07 UTC (permalink / raw)
To: Fabrizio Castro
Cc: Rob Herring, Krzysztof Kozlowski, Geert Uytterhoeven,
Magnus Damm, linux-renesas-soc, devicetree, linux-kernel,
Chris Paterson, Biju Das, Jacopo Mondi
Hi Fabrizio,
Thank you for the patch.
On Wed, Jan 18, 2023 at 01:52:59PM +0000, Fabrizio Castro wrote:
> Although of_fdt_device_is_available returns true when the DT
> property "status" is assigned "ok" or "okay", and false for every
> other value, it's become common practice to assign "disabled"
> when we want of_fdt_device_is_available to return false.
> For some reason, the status property of the ethernet node was
> assigned "disable" when originally added to the kernel. Change
> it to "disabled" for consistency.
>
> Signed-off-by: Fabrizio Castro <fabrizio.castro.jz@renesas.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> ---
> arch/arm64/boot/dts/renesas/r9a09g011.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/renesas/r9a09g011.dtsi b/arch/arm64/boot/dts/renesas/r9a09g011.dtsi
> index dd35a8ff72ee..b0c066c5e0ba 100644
> --- a/arch/arm64/boot/dts/renesas/r9a09g011.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r9a09g011.dtsi
> @@ -165,7 +165,7 @@ avb: ethernet@a3300000 {
> power-domains = <&cpg>;
> #address-cells = <1>;
> #size-cells = <0>;
> - status = "disable";
> + status = "disabled";
> };
>
> cpg: clock-controller@a3500000 {
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: dts: renesas: r9a09g011: Reword ethernet status
2023-01-18 13:52 [PATCH] arm64: dts: renesas: r9a09g011: Reword ethernet status Fabrizio Castro
2023-01-18 15:07 ` Laurent Pinchart
@ 2023-01-25 11:08 ` Geert Uytterhoeven
1 sibling, 0 replies; 3+ messages in thread
From: Geert Uytterhoeven @ 2023-01-25 11:08 UTC (permalink / raw)
To: Fabrizio Castro
Cc: Rob Herring, Krzysztof Kozlowski, Magnus Damm, linux-renesas-soc,
devicetree, linux-kernel, Chris Paterson, Biju Das,
Laurent Pinchart, Jacopo Mondi
On Wed, Jan 18, 2023 at 2:53 PM Fabrizio Castro
<fabrizio.castro.jz@renesas.com> wrote:
> Although of_fdt_device_is_available returns true when the DT
> property "status" is assigned "ok" or "okay", and false for every
> other value, it's become common practice to assign "disabled"
> when we want of_fdt_device_is_available to return false.
> For some reason, the status property of the ethernet node was
> assigned "disable" when originally added to the kernel. Change
> it to "disabled" for consistency.
>
> Signed-off-by: Fabrizio Castro <fabrizio.castro.jz@renesas.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
i.e. will queue in renesas-devel for v6.3.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-01-25 11:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-18 13:52 [PATCH] arm64: dts: renesas: r9a09g011: Reword ethernet status Fabrizio Castro
2023-01-18 15:07 ` Laurent Pinchart
2023-01-25 11:08 ` Geert Uytterhoeven
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).