linux-renesas-soc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2] dt-bindings: leds: Document Bluetooth and WLAN triggers
@ 2023-01-22 10:47 Geert Uytterhoeven
  2023-01-24 23:40 ` patchwork-bot+bluetooth
  2023-01-26  8:01 ` Lee Jones
  0 siblings, 2 replies; 10+ messages in thread
From: Geert Uytterhoeven @ 2023-01-22 10:47 UTC (permalink / raw)
  To: Pavel Machek, Lee Jones, Rob Herring, Krzysztof Kozlowski,
	Jacek Anaszewski
  Cc: linux-leds, devicetree, linux-wireless, linux-bluetooth,
	linux-renesas-soc, Geert Uytterhoeven, Rob Herring

Add the missing trigger patterns for Bluetooth and WLAN activity, which
are already in active use.

While at it, move the mmc pattern comment where it belongs, and restore
alphabetical sort order.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Rob Herring <robh@kernel.org>
---
arch/arm64/boot/dts/renesas/r8a774a1-hihope-rzg2m-rev2.dtb: leds: bt_active_led:linux,default-trigger: 'oneOf' conditional failed, one must be fixed:
	'hci0-power' is not one of ['backlight', 'default-on', 'heartbeat', 'disk-activity', 'ide-disk', 'timer', 'pattern']
	'hci0-power' does not match '^mmc[0-9]+$'
	From schema: Documentation/devicetree/bindings/leds/leds-gpio.yaml
arch/arm64/boot/dts/renesas/r8a774a1-hihope-rzg2m-rev2.dtb: leds: wlan_active_led:linux,default-trigger: 'oneOf' conditional failed, one must be fixed:
	'phy0tx' is not one of ['backlight', 'default-on', 'heartbeat', 'disk-activity', 'ide-disk', 'timer', 'pattern']
	'phy0tx' does not match '^mmc[0-9]+$'
	From schema: Documentation/devicetree/bindings/leds/leds-gpio.yaml

v2:
  - Add Reviewed-by.
---
 Documentation/devicetree/bindings/leds/common.yaml | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/leds/common.yaml b/Documentation/devicetree/bindings/leds/common.yaml
index f5c57a580078ea23..d34bb58c00371402 100644
--- a/Documentation/devicetree/bindings/leds/common.yaml
+++ b/Documentation/devicetree/bindings/leds/common.yaml
@@ -98,9 +98,13 @@ properties:
             # LED alters the brightness for the specified duration with one software
             # timer (requires "led-pattern" property)
           - pattern
-        # LED is triggered by SD/MMC activity
-      - pattern: "^mmc[0-9]+$"
       - pattern: "^cpu[0-9]*$"
+      - pattern: "^hci[0-9]+-power$"
+        # LED is triggered by Bluetooth activity
+      - pattern: "^mmc[0-9]+$"
+        # LED is triggered by SD/MMC activity
+      - pattern: "^phy[0-9]+tx$"
+        # LED is triggered by WLAN activity
 
   led-pattern:
     description: |
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 10+ messages in thread

* Re: [PATCH v2] dt-bindings: leds: Document Bluetooth and WLAN triggers
  2023-01-22 10:47 [PATCH v2] dt-bindings: leds: Document Bluetooth and WLAN triggers Geert Uytterhoeven
@ 2023-01-24 23:40 ` patchwork-bot+bluetooth
  2023-01-25 15:12   ` Lee Jones
  2023-01-26  8:01 ` Lee Jones
  1 sibling, 1 reply; 10+ messages in thread
From: patchwork-bot+bluetooth @ 2023-01-24 23:40 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: pavel, lee, robh+dt, krzysztof.kozlowski+dt, jacek.anaszewski,
	linux-leds, devicetree, linux-wireless, linux-bluetooth,
	linux-renesas-soc, robh

Hello:

This patch was applied to bluetooth/bluetooth-next.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Sun, 22 Jan 2023 11:47:27 +0100 you wrote:
> Add the missing trigger patterns for Bluetooth and WLAN activity, which
> are already in active use.
> 
> While at it, move the mmc pattern comment where it belongs, and restore
> alphabetical sort order.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> Reviewed-by: Rob Herring <robh@kernel.org>
> 
> [...]

Here is the summary with links:
  - [v2] dt-bindings: leds: Document Bluetooth and WLAN triggers
    https://git.kernel.org/bluetooth/bluetooth-next/c/ef017002b93b

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH v2] dt-bindings: leds: Document Bluetooth and WLAN triggers
  2023-01-24 23:40 ` patchwork-bot+bluetooth
@ 2023-01-25 15:12   ` Lee Jones
  2023-01-25 19:23     ` Luiz Augusto von Dentz
  0 siblings, 1 reply; 10+ messages in thread
From: Lee Jones @ 2023-01-25 15:12 UTC (permalink / raw)
  To: patchwork-bot+bluetooth
  Cc: Geert Uytterhoeven, pavel, robh+dt, krzysztof.kozlowski+dt,
	jacek.anaszewski, linux-leds, devicetree, linux-wireless,
	linux-bluetooth, linux-renesas-soc, robh

On Tue, 24 Jan 2023, patchwork-bot+bluetooth@kernel.org wrote:

> Hello:
> 
> This patch was applied to bluetooth/bluetooth-next.git (master)
> by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:
> 
> On Sun, 22 Jan 2023 11:47:27 +0100 you wrote:
> > Add the missing trigger patterns for Bluetooth and WLAN activity, which
> > are already in active use.
> > 
> > While at it, move the mmc pattern comment where it belongs, and restore
> > alphabetical sort order.
> > 
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > Reviewed-by: Rob Herring <robh@kernel.org>
> > 
> > [...]
> 
> Here is the summary with links:
>   - [v2] dt-bindings: leds: Document Bluetooth and WLAN triggers
>     https://git.kernel.org/bluetooth/bluetooth-next/c/ef017002b93b

Why are you taking LED patches through the Bluetooth tree?

-- 
Lee Jones [李琼斯]

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH v2] dt-bindings: leds: Document Bluetooth and WLAN triggers
  2023-01-25 15:12   ` Lee Jones
@ 2023-01-25 19:23     ` Luiz Augusto von Dentz
  2023-01-26  8:00       ` Lee Jones
  2023-01-26 10:01       ` Krzysztof Kozlowski
  0 siblings, 2 replies; 10+ messages in thread
From: Luiz Augusto von Dentz @ 2023-01-25 19:23 UTC (permalink / raw)
  To: Lee Jones
  Cc: patchwork-bot+bluetooth, Geert Uytterhoeven, pavel, robh+dt,
	krzysztof.kozlowski+dt, jacek.anaszewski, linux-leds, devicetree,
	linux-wireless, linux-bluetooth, linux-renesas-soc, robh

Hi Lee,

On Wed, Jan 25, 2023 at 7:16 AM Lee Jones <lee@kernel.org> wrote:
>
> On Tue, 24 Jan 2023, patchwork-bot+bluetooth@kernel.org wrote:
>
> > Hello:
> >
> > This patch was applied to bluetooth/bluetooth-next.git (master)
> > by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:
> >
> > On Sun, 22 Jan 2023 11:47:27 +0100 you wrote:
> > > Add the missing trigger patterns for Bluetooth and WLAN activity, which
> > > are already in active use.
> > >
> > > While at it, move the mmc pattern comment where it belongs, and restore
> > > alphabetical sort order.
> > >
> > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > > Reviewed-by: Rob Herring <robh@kernel.org>
> > >
> > > [...]
> >
> > Here is the summary with links:
> >   - [v2] dt-bindings: leds: Document Bluetooth and WLAN triggers
> >     https://git.kernel.org/bluetooth/bluetooth-next/c/ef017002b93b
>
> Why are you taking LED patches through the Bluetooth tree?

I assume there isn't a tree dedicated to dt-bindings/leds, not to
mention this was submitted to linux-bluetooth and nobody else other
than Rob reviewed it, anyway I'd be happy if the dt-bindings patches
would be handled elsewhere.

>
> --
> Lee Jones [李琼斯]



-- 
Luiz Augusto von Dentz

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH v2] dt-bindings: leds: Document Bluetooth and WLAN triggers
  2023-01-25 19:23     ` Luiz Augusto von Dentz
@ 2023-01-26  8:00       ` Lee Jones
  2023-01-26 20:46         ` Luiz Augusto von Dentz
  2023-01-26 10:01       ` Krzysztof Kozlowski
  1 sibling, 1 reply; 10+ messages in thread
From: Lee Jones @ 2023-01-26  8:00 UTC (permalink / raw)
  To: Luiz Augusto von Dentz
  Cc: patchwork-bot+bluetooth, Geert Uytterhoeven, pavel, robh+dt,
	krzysztof.kozlowski+dt, jacek.anaszewski, linux-leds, devicetree,
	linux-wireless, linux-bluetooth, linux-renesas-soc, robh

On Wed, 25 Jan 2023, Luiz Augusto von Dentz wrote:

> Hi Lee,
> 
> On Wed, Jan 25, 2023 at 7:16 AM Lee Jones <lee@kernel.org> wrote:
> >
> > On Tue, 24 Jan 2023, patchwork-bot+bluetooth@kernel.org wrote:
> >
> > > Hello:
> > >
> > > This patch was applied to bluetooth/bluetooth-next.git (master)
> > > by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:
> > >
> > > On Sun, 22 Jan 2023 11:47:27 +0100 you wrote:
> > > > Add the missing trigger patterns for Bluetooth and WLAN activity, which
> > > > are already in active use.
> > > >
> > > > While at it, move the mmc pattern comment where it belongs, and restore
> > > > alphabetical sort order.
> > > >
> > > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > > > Reviewed-by: Rob Herring <robh@kernel.org>
> > > >
> > > > [...]
> > >
> > > Here is the summary with links:
> > >   - [v2] dt-bindings: leds: Document Bluetooth and WLAN triggers
> > >     https://git.kernel.org/bluetooth/bluetooth-next/c/ef017002b93b
> >
> > Why are you taking LED patches through the Bluetooth tree?
> 
> I assume there isn't a tree dedicated to dt-bindings/leds

% ./scripts/get_maintainer.pl -f Documentation/devicetree/bindings/leds/common.yaml
 Pavel Machek <pavel@ucw.cz> (maintainer:LED SUBSYSTEM,in file)
 Lee Jones <lee@kernel.org> (maintainer:LED SUBSYSTEM)
 Rob Herring <robh+dt@kernel.org> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
 Jacek Anaszewski <jacek.anaszewski@gmail.com> (in file)
 linux-leds@vger.kernel.org (open list:LED SUBSYSTEM)
 devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
 linux-kernel@vger.kernel.org (open list)

> not to mention this was submitted to linux-bluetooth and nobody else
> other than Rob reviewed it,

To: Pavel Machek <pavel@ucw.cz>, Lee Jones <lee@kernel.org>,
    Rob Herring <robh+dt@kernel.org>,
    Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
    Jacek Anaszewski <jacek.anaszewski@gmail.com>                                      
Cc: linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
    linux-wireless@vger.kernel.org, linux-bluetooth@vger.kernel.org,
    linux-renesas-soc@vger.kernel.org,
    Geert Uytterhoeven <geert+renesas@glider.be>,
    Rob Herring <robh@kernel.org>

> anyway I'd be happy if the dt-bindings patches
> would be handled elsewhere.

Yep, we got this. :)

-- 
Lee Jones [李琼斯]

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH v2] dt-bindings: leds: Document Bluetooth and WLAN triggers
  2023-01-22 10:47 [PATCH v2] dt-bindings: leds: Document Bluetooth and WLAN triggers Geert Uytterhoeven
  2023-01-24 23:40 ` patchwork-bot+bluetooth
@ 2023-01-26  8:01 ` Lee Jones
  1 sibling, 0 replies; 10+ messages in thread
From: Lee Jones @ 2023-01-26  8:01 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: Pavel Machek, Rob Herring, Krzysztof Kozlowski, Jacek Anaszewski,
	linux-leds, devicetree, linux-wireless, linux-bluetooth,
	linux-renesas-soc, Rob Herring

On Sun, 22 Jan 2023, Geert Uytterhoeven wrote:

> Add the missing trigger patterns for Bluetooth and WLAN activity, which
> are already in active use.
> 
> While at it, move the mmc pattern comment where it belongs, and restore
> alphabetical sort order.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> Reviewed-by: Rob Herring <robh@kernel.org>
> ---
> arch/arm64/boot/dts/renesas/r8a774a1-hihope-rzg2m-rev2.dtb: leds: bt_active_led:linux,default-trigger: 'oneOf' conditional failed, one must be fixed:
> 	'hci0-power' is not one of ['backlight', 'default-on', 'heartbeat', 'disk-activity', 'ide-disk', 'timer', 'pattern']
> 	'hci0-power' does not match '^mmc[0-9]+$'
> 	From schema: Documentation/devicetree/bindings/leds/leds-gpio.yaml
> arch/arm64/boot/dts/renesas/r8a774a1-hihope-rzg2m-rev2.dtb: leds: wlan_active_led:linux,default-trigger: 'oneOf' conditional failed, one must be fixed:
> 	'phy0tx' is not one of ['backlight', 'default-on', 'heartbeat', 'disk-activity', 'ide-disk', 'timer', 'pattern']
> 	'phy0tx' does not match '^mmc[0-9]+$'
> 	From schema: Documentation/devicetree/bindings/leds/leds-gpio.yaml
> 
> v2:
>   - Add Reviewed-by.
> ---
>  Documentation/devicetree/bindings/leds/common.yaml | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)

Applied, thanks

-- 
Lee Jones [李琼斯]

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH v2] dt-bindings: leds: Document Bluetooth and WLAN triggers
  2023-01-25 19:23     ` Luiz Augusto von Dentz
  2023-01-26  8:00       ` Lee Jones
@ 2023-01-26 10:01       ` Krzysztof Kozlowski
  1 sibling, 0 replies; 10+ messages in thread
From: Krzysztof Kozlowski @ 2023-01-26 10:01 UTC (permalink / raw)
  To: Luiz Augusto von Dentz, Lee Jones
  Cc: patchwork-bot+bluetooth, Geert Uytterhoeven, pavel, robh+dt,
	krzysztof.kozlowski+dt, jacek.anaszewski, linux-leds, devicetree,
	linux-wireless, linux-bluetooth, linux-renesas-soc, robh

On 25/01/2023 20:23, Luiz Augusto von Dentz wrote:
>>>> While at it, move the mmc pattern comment where it belongs, and restore
>>>> alphabetical sort order.
>>>>
>>>> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
>>>> Reviewed-by: Rob Herring <robh@kernel.org>
>>>>
>>>> [...]
>>>
>>> Here is the summary with links:
>>>   - [v2] dt-bindings: leds: Document Bluetooth and WLAN triggers
>>>     https://git.kernel.org/bluetooth/bluetooth-next/c/ef017002b93b
>>
>> Why are you taking LED patches through the Bluetooth tree?
> 
> I assume there isn't a tree dedicated to dt-bindings/leds, not to

dt-bindings patches are supposed to go via subsystem (with drivers) or
as fallback via Rob's DT tree. The subsystem here is LED, so the patches
should be picked by Pavel and Lee, as maintainers of LED subsystem.

If the subsystem was Bluetooth, then the patch would be for you. I hope
that clarifies.

Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH v2] dt-bindings: leds: Document Bluetooth and WLAN triggers
  2023-01-26  8:00       ` Lee Jones
@ 2023-01-26 20:46         ` Luiz Augusto von Dentz
  2023-01-27  8:47           ` Krzysztof Kozlowski
  2023-01-27  9:27           ` Lee Jones
  0 siblings, 2 replies; 10+ messages in thread
From: Luiz Augusto von Dentz @ 2023-01-26 20:46 UTC (permalink / raw)
  To: Lee Jones
  Cc: patchwork-bot+bluetooth, Geert Uytterhoeven, pavel, robh+dt,
	krzysztof.kozlowski+dt, jacek.anaszewski, linux-leds, devicetree,
	linux-wireless, linux-bluetooth, linux-renesas-soc, robh

Hi Lee,

On Thu, Jan 26, 2023 at 12:00 AM Lee Jones <lee@kernel.org> wrote:
>
> On Wed, 25 Jan 2023, Luiz Augusto von Dentz wrote:
>
> > Hi Lee,
> >
> > On Wed, Jan 25, 2023 at 7:16 AM Lee Jones <lee@kernel.org> wrote:
> > >
> > > On Tue, 24 Jan 2023, patchwork-bot+bluetooth@kernel.org wrote:
> > >
> > > > Hello:
> > > >
> > > > This patch was applied to bluetooth/bluetooth-next.git (master)
> > > > by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:
> > > >
> > > > On Sun, 22 Jan 2023 11:47:27 +0100 you wrote:
> > > > > Add the missing trigger patterns for Bluetooth and WLAN activity, which
> > > > > are already in active use.
> > > > >
> > > > > While at it, move the mmc pattern comment where it belongs, and restore
> > > > > alphabetical sort order.
> > > > >
> > > > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > > > > Reviewed-by: Rob Herring <robh@kernel.org>
> > > > >
> > > > > [...]
> > > >
> > > > Here is the summary with links:
> > > >   - [v2] dt-bindings: leds: Document Bluetooth and WLAN triggers
> > > >     https://git.kernel.org/bluetooth/bluetooth-next/c/ef017002b93b
> > >
> > > Why are you taking LED patches through the Bluetooth tree?
> >
> > I assume there isn't a tree dedicated to dt-bindings/leds
>
> % ./scripts/get_maintainer.pl -f Documentation/devicetree/bindings/leds/common.yaml
>  Pavel Machek <pavel@ucw.cz> (maintainer:LED SUBSYSTEM,in file)
>  Lee Jones <lee@kernel.org> (maintainer:LED SUBSYSTEM)
>  Rob Herring <robh+dt@kernel.org> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
>  Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
>  Jacek Anaszewski <jacek.anaszewski@gmail.com> (in file)
>  linux-leds@vger.kernel.org (open list:LED SUBSYSTEM)
>  devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
>  linux-kernel@vger.kernel.org (open list)

Well this doesn't tell us what parts of the dt_bindings have a
dedicated tree and which doesn't, anyway this doesn't show
linux-bluetooth so I wonder why people are CCing it.

> > not to mention this was submitted to linux-bluetooth and nobody else
> > other than Rob reviewed it,
>
> To: Pavel Machek <pavel@ucw.cz>, Lee Jones <lee@kernel.org>,
>     Rob Herring <robh+dt@kernel.org>,
>     Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
>     Jacek Anaszewski <jacek.anaszewski@gmail.com>
> Cc: linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
>     linux-wireless@vger.kernel.org, linux-bluetooth@vger.kernel.org,
>     linux-renesas-soc@vger.kernel.org,
>     Geert Uytterhoeven <geert+renesas@glider.be>,
>     Rob Herring <robh@kernel.org>
>
> > anyway I'd be happy if the dt-bindings patches
> > would be handled elsewhere.
>
> Yep, we got this. :)

So if it starts with dt-binding: prefix shall we ignore? Or is just
for dt-bindings: leds? Or perhaps we can just ignore patches received
as CC: rather than directly To: field.

>
> --
> Lee Jones [李琼斯]



-- 
Luiz Augusto von Dentz

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH v2] dt-bindings: leds: Document Bluetooth and WLAN triggers
  2023-01-26 20:46         ` Luiz Augusto von Dentz
@ 2023-01-27  8:47           ` Krzysztof Kozlowski
  2023-01-27  9:27           ` Lee Jones
  1 sibling, 0 replies; 10+ messages in thread
From: Krzysztof Kozlowski @ 2023-01-27  8:47 UTC (permalink / raw)
  To: Luiz Augusto von Dentz, Lee Jones
  Cc: patchwork-bot+bluetooth, Geert Uytterhoeven, pavel, robh+dt,
	krzysztof.kozlowski+dt, jacek.anaszewski, linux-leds, devicetree,
	linux-wireless, linux-bluetooth, linux-renesas-soc, robh

On 26/01/2023 21:46, Luiz Augusto von Dentz wrote:
> Hi Lee,
> 
> On Thu, Jan 26, 2023 at 12:00 AM Lee Jones <lee@kernel.org> wrote:
>>
>> On Wed, 25 Jan 2023, Luiz Augusto von Dentz wrote:
>>
>>> Hi Lee,
>>>
>>> On Wed, Jan 25, 2023 at 7:16 AM Lee Jones <lee@kernel.org> wrote:
>>>>
>>>> On Tue, 24 Jan 2023, patchwork-bot+bluetooth@kernel.org wrote:
>>>>
>>>>> Hello:
>>>>>
>>>>> This patch was applied to bluetooth/bluetooth-next.git (master)
>>>>> by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:
>>>>>
>>>>> On Sun, 22 Jan 2023 11:47:27 +0100 you wrote:
>>>>>> Add the missing trigger patterns for Bluetooth and WLAN activity, which
>>>>>> are already in active use.
>>>>>>
>>>>>> While at it, move the mmc pattern comment where it belongs, and restore
>>>>>> alphabetical sort order.
>>>>>>
>>>>>> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
>>>>>> Reviewed-by: Rob Herring <robh@kernel.org>
>>>>>>
>>>>>> [...]
>>>>>
>>>>> Here is the summary with links:
>>>>>   - [v2] dt-bindings: leds: Document Bluetooth and WLAN triggers
>>>>>     https://git.kernel.org/bluetooth/bluetooth-next/c/ef017002b93b
>>>>
>>>> Why are you taking LED patches through the Bluetooth tree?
>>>
>>> I assume there isn't a tree dedicated to dt-bindings/leds
>>
>> % ./scripts/get_maintainer.pl -f Documentation/devicetree/bindings/leds/common.yaml
>>  Pavel Machek <pavel@ucw.cz> (maintainer:LED SUBSYSTEM,in file)
>>  Lee Jones <lee@kernel.org> (maintainer:LED SUBSYSTEM)
>>  Rob Herring <robh+dt@kernel.org> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
>>  Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
>>  Jacek Anaszewski <jacek.anaszewski@gmail.com> (in file)
>>  linux-leds@vger.kernel.org (open list:LED SUBSYSTEM)
>>  devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
>>  linux-kernel@vger.kernel.org (open list)
> 
> Well this doesn't tell us what parts of the dt_bindings have a
> dedicated tree and which doesn't, 

There is no such "parts" anywhere. I don't understand that remark and
how is related here. This is a list of maintainers for this file. Why
information are you missing in MAINTAINERS? And why bindings would be
special (e.g. you don't miss this information for other parts of kernel)?

>>
>>> anyway I'd be happy if the dt-bindings patches
>>> would be handled elsewhere.
>>
>> Yep, we got this. :)
> 
> So if it starts with dt-binding: prefix shall we ignore? Or is just
> for dt-bindings: leds? Or perhaps we can just ignore patches received
> as CC: rather than directly To: field.

What was exactly unclear in my response? The bindings for your subsystem
are for you. Bindings for other subsystems are not for you. dt-bindings:
leds: are for leds suubsystem. dt-bindings: mfd: are for mfd subsystem.
If the prefix is incorrect because people make mistakes, the paths point
to it - Documentation/devicetree/bindings/SUBSYSTEM_OR_HARDWARE_CLASS/....


Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH v2] dt-bindings: leds: Document Bluetooth and WLAN triggers
  2023-01-26 20:46         ` Luiz Augusto von Dentz
  2023-01-27  8:47           ` Krzysztof Kozlowski
@ 2023-01-27  9:27           ` Lee Jones
  1 sibling, 0 replies; 10+ messages in thread
From: Lee Jones @ 2023-01-27  9:27 UTC (permalink / raw)
  To: Luiz Augusto von Dentz
  Cc: patchwork-bot+bluetooth, Geert Uytterhoeven, pavel, robh+dt,
	krzysztof.kozlowski+dt, jacek.anaszewski, linux-leds, devicetree,
	linux-wireless, linux-bluetooth, linux-renesas-soc, robh

On Thu, 26 Jan 2023, Luiz Augusto von Dentz wrote:

> Hi Lee,
> 
> On Thu, Jan 26, 2023 at 12:00 AM Lee Jones <lee@kernel.org> wrote:
> >
> > On Wed, 25 Jan 2023, Luiz Augusto von Dentz wrote:
> >
> > > Hi Lee,
> > >
> > > On Wed, Jan 25, 2023 at 7:16 AM Lee Jones <lee@kernel.org> wrote:
> > > >
> > > > On Tue, 24 Jan 2023, patchwork-bot+bluetooth@kernel.org wrote:
> > > >
> > > > > Hello:
> > > > >
> > > > > This patch was applied to bluetooth/bluetooth-next.git (master)
> > > > > by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:
> > > > >
> > > > > On Sun, 22 Jan 2023 11:47:27 +0100 you wrote:
> > > > > > Add the missing trigger patterns for Bluetooth and WLAN activity, which
> > > > > > are already in active use.
> > > > > >
> > > > > > While at it, move the mmc pattern comment where it belongs, and restore
> > > > > > alphabetical sort order.
> > > > > >
> > > > > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > > > > > Reviewed-by: Rob Herring <robh@kernel.org>
> > > > > >
> > > > > > [...]
> > > > >
> > > > > Here is the summary with links:
> > > > >   - [v2] dt-bindings: leds: Document Bluetooth and WLAN triggers
> > > > >     https://git.kernel.org/bluetooth/bluetooth-next/c/ef017002b93b
> > > >
> > > > Why are you taking LED patches through the Bluetooth tree?
> > >
> > > I assume there isn't a tree dedicated to dt-bindings/leds
> >
> > % ./scripts/get_maintainer.pl -f Documentation/devicetree/bindings/leds/common.yaml
> >  Pavel Machek <pavel@ucw.cz> (maintainer:LED SUBSYSTEM,in file)
> >  Lee Jones <lee@kernel.org> (maintainer:LED SUBSYSTEM)
> >  Rob Herring <robh+dt@kernel.org> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
> >  Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
> >  Jacek Anaszewski <jacek.anaszewski@gmail.com> (in file)
> >  linux-leds@vger.kernel.org (open list:LED SUBSYSTEM)
> >  devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
> >  linux-kernel@vger.kernel.org (open list)
> 
> Well this doesn't tell us what parts of the dt_bindings have a
> dedicated tree and which doesn't, anyway this doesn't show
> linux-bluetooth so I wonder why people are CCing it.

It is not possible to infer responsibilities from how contributors craft
their submissions.  The only reliable way to do that is to check the
MAINTAINERS file.

According to the MAINTAINERS excerpt below [0] if a commit only touches
files contained in; drivers/bluetooth/, include/net/bluetooth/ and/or
net/bluetooth/ AND there are no build-time dependencies or dependents,
they are yours to process how you see fit.  However, if commits ALSO touch
files outside of those directories OR do have dependencies or
dependents, you will need to consult with the other affected maintainers
to agree on a strategy for merging them.  If the aforementioned
directories are not touched (as in this case), you can safely ignore
them - regardless of which mailing list(s) or individual's inboxes they
end up in.

Does that help at all?

[0]

BLUETOOTH DRIVERS
M:      Marcel Holtmann <marcel@holtmann.org>
M:      Johan Hedberg <johan.hedberg@gmail.com>
M:      Luiz Augusto von Dentz <luiz.dentz@gmail.com>
L:      linux-bluetooth@vger.kernel.org
S:      Supported
W:      http://www.bluez.org/
T:      git git://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth.git
T:      git git://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next.g
F:      drivers/bluetooth/

BLUETOOTH SUBSYSTEM
M:      Marcel Holtmann <marcel@holtmann.org>
M:      Johan Hedberg <johan.hedberg@gmail.com>
M:      Luiz Augusto von Dentz <luiz.dentz@gmail.com>
L:      linux-bluetooth@vger.kernel.org
S:      Supported
W:      http://www.bluez.org/
T:      git git://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth.git
T:      git git://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next.g
F:      include/net/bluetooth/
F:      net/bluetooth/

-- 
Lee Jones [李琼斯]

^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2023-01-27  9:27 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-22 10:47 [PATCH v2] dt-bindings: leds: Document Bluetooth and WLAN triggers Geert Uytterhoeven
2023-01-24 23:40 ` patchwork-bot+bluetooth
2023-01-25 15:12   ` Lee Jones
2023-01-25 19:23     ` Luiz Augusto von Dentz
2023-01-26  8:00       ` Lee Jones
2023-01-26 20:46         ` Luiz Augusto von Dentz
2023-01-27  8:47           ` Krzysztof Kozlowski
2023-01-27  9:27           ` Lee Jones
2023-01-26 10:01       ` Krzysztof Kozlowski
2023-01-26  8:01 ` Lee Jones

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).