* [PATCH] irqchip/renesas-intc-irqpin: Remove devm_kzalloc() error printing
@ 2019-04-29 15:15 Geert Uytterhoeven
2019-04-29 15:30 ` Marc Zyngier
0 siblings, 1 reply; 2+ messages in thread
From: Geert Uytterhoeven @ 2019-04-29 15:15 UTC (permalink / raw)
To: Thomas Gleixner, Jason Cooper, Marc Zyngier
Cc: linux-renesas-soc, linux-kernel, Geert Uytterhoeven
There is no need to print a message if devm_kzalloc() fails, as the
memory allocation core already takes care of that.
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
drivers/irqchip/irq-renesas-intc-irqpin.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/irqchip/irq-renesas-intc-irqpin.c b/drivers/irqchip/irq-renesas-intc-irqpin.c
index 8c039525703f7c9a..04c05a18600cf71f 100644
--- a/drivers/irqchip/irq-renesas-intc-irqpin.c
+++ b/drivers/irqchip/irq-renesas-intc-irqpin.c
@@ -389,10 +389,8 @@ static int intc_irqpin_probe(struct platform_device *pdev)
int k;
p = devm_kzalloc(dev, sizeof(*p), GFP_KERNEL);
- if (!p) {
- dev_err(dev, "failed to allocate driver data\n");
+ if (!p)
return -ENOMEM;
- }
/* deal with driver instance configuration */
of_property_read_u32(dev->of_node, "sense-bitfield-width",
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] irqchip/renesas-intc-irqpin: Remove devm_kzalloc() error printing
2019-04-29 15:15 [PATCH] irqchip/renesas-intc-irqpin: Remove devm_kzalloc() error printing Geert Uytterhoeven
@ 2019-04-29 15:30 ` Marc Zyngier
0 siblings, 0 replies; 2+ messages in thread
From: Marc Zyngier @ 2019-04-29 15:30 UTC (permalink / raw)
To: Geert Uytterhoeven, Thomas Gleixner, Jason Cooper
Cc: linux-renesas-soc, linux-kernel
On 29/04/2019 16:15, Geert Uytterhoeven wrote:
> There is no need to print a message if devm_kzalloc() fails, as the
> memory allocation core already takes care of that.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Applied, thanks.
M.
--
Jazz is not dead. It just smells funny...
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-04-29 15:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-29 15:15 [PATCH] irqchip/renesas-intc-irqpin: Remove devm_kzalloc() error printing Geert Uytterhoeven
2019-04-29 15:30 ` Marc Zyngier
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).