From: Kieran Bingham <kieran.bingham@ideasonboard.com>
To: "Jacopo Mondi" <jacopo+renesas@jmondi.org>,
"Mauro Carvalho Chehab" <mchehab@kernel.org>,
"Kieran Bingham" <kieran.bingham+renesas@ideasonboard.com>,
"Laurent Pinchart" <laurent.pinchart+renesas@ideasonboard.com>,
"Niklas Söderlund" <niklas.soderlund+renesas@ragnatech.se>
Cc: Hans Verkuil <hverkuil-cisco@xs4all.nl>,
Sakari Ailus <sakari.ailus@iki.fi>,
Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
Thomas NIZAN <tnizan@witekio.com>,
linux-renesas-soc@vger.kernel.org, linux-media@vger.kernel.org
Subject: Re: [RFC 1/5] media: i2c: max9271: Rename max9271 library driver
Date: Wed, 18 Aug 2021 13:48:45 +0100 [thread overview]
Message-ID: <bfe2547e-e824-63be-5380-03fb16bd26d0@ideasonboard.com> (raw)
In-Reply-To: <20210817072703.1167-2-jacopo+renesas@jmondi.org>
Hi Jacopo,
On 17/08/2021 08:26, Jacopo Mondi wrote:
> Support for the MAX9271 GMSL serializer was provided in the form of a
> library driver, with the RDACM20 and RDACM21 camera module drivers using
> the functions exported by the library.
>
> In preparation to introduce an i2c subdevice driver to support the
> MAX9271 serializer, rename the library driver from max9271 to
> max9271-lib.
I may as well add this here now to save me later if this continues ;-)
Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
>
> Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
> ---
> MAINTAINERS | 8 ++++----
> drivers/media/i2c/Makefile | 2 +-
> drivers/media/i2c/{max9271.c => max9271-lib.c} | 2 +-
> drivers/media/i2c/{max9271.h => max9271-lib.h} | 0
> drivers/media/i2c/rdacm20.c | 2 +-
> drivers/media/i2c/rdacm21.c | 2 +-
> 6 files changed, 8 insertions(+), 8 deletions(-)
> rename drivers/media/i2c/{max9271.c => max9271-lib.c} (99%)
> rename drivers/media/i2c/{max9271.h => max9271-lib.h} (100%)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 524eabe50d79..7ad89cac19b7 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -15625,8 +15625,8 @@ M: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> L: linux-media@vger.kernel.org
> S: Maintained
> F: Documentation/devicetree/bindings/media/i2c/imi,rdacm2x-gmsl.yaml
> -F: drivers/media/i2c/max9271.c
> -F: drivers/media/i2c/max9271.h
> +F: drivers/media/i2c/max9271-lib.c
> +F: drivers/media/i2c/max9271-lib.h
> F: drivers/media/i2c/rdacm20.c
>
> RDACM21 Camera Sensor
> @@ -15637,8 +15637,8 @@ M: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> L: linux-media@vger.kernel.org
> S: Maintained
> F: Documentation/devicetree/bindings/media/i2c/imi,rdacm2x-gmsl.yaml
> -F: drivers/media/i2c/max9271.c
> -F: drivers/media/i2c/max9271.h
> +F: drivers/media/i2c/max9271-lib.c
> +F: drivers/media/i2c/max9271-lib.h
> F: drivers/media/i2c/rdacm21.c
>
> RDC R-321X SoC
> diff --git a/drivers/media/i2c/Makefile b/drivers/media/i2c/Makefile
> index 83268f20aa3a..4d879373bd48 100644
> --- a/drivers/media/i2c/Makefile
> +++ b/drivers/media/i2c/Makefile
> @@ -129,7 +129,7 @@ obj-$(CONFIG_VIDEO_IMX335) += imx335.o
> obj-$(CONFIG_VIDEO_IMX355) += imx355.o
> obj-$(CONFIG_VIDEO_IMX412) += imx412.o
> obj-$(CONFIG_VIDEO_MAX9286) += max9286.o
> -obj-$(CONFIG_VIDEO_MAX9271_LIB) += max9271.o
> +obj-$(CONFIG_VIDEO_MAX9271_LIB) += max9271-lib.o
> obj-$(CONFIG_VIDEO_RDACM20) += rdacm20.o
> obj-$(CONFIG_VIDEO_RDACM21) += rdacm21.o
> obj-$(CONFIG_VIDEO_ST_MIPID02) += st-mipid02.o
> diff --git a/drivers/media/i2c/max9271.c b/drivers/media/i2c/max9271-lib.c
> similarity index 99%
> rename from drivers/media/i2c/max9271.c
> rename to drivers/media/i2c/max9271-lib.c
> index ff86c8c4ea61..c554bb0f42f4 100644
> --- a/drivers/media/i2c/max9271.c
> +++ b/drivers/media/i2c/max9271-lib.c
> @@ -20,7 +20,7 @@
> #include <linux/i2c.h>
> #include <linux/module.h>
>
> -#include "max9271.h"
> +#include "max9271-lib.h"
>
> static int max9271_read(struct max9271_device *dev, u8 reg)
> {
> diff --git a/drivers/media/i2c/max9271.h b/drivers/media/i2c/max9271-lib.h
> similarity index 100%
> rename from drivers/media/i2c/max9271.h
> rename to drivers/media/i2c/max9271-lib.h
> diff --git a/drivers/media/i2c/rdacm20.c b/drivers/media/i2c/rdacm20.c
> index eb0e3dc22cc3..bf06a1c50306 100644
> --- a/drivers/media/i2c/rdacm20.c
> +++ b/drivers/media/i2c/rdacm20.c
> @@ -27,7 +27,7 @@
> #include <media/v4l2-ctrls.h>
> #include <media/v4l2-subdev.h>
>
> -#include "max9271.h"
> +#include "max9271-lib.h"
>
> #define OV10635_I2C_ADDRESS 0x30
>
> diff --git a/drivers/media/i2c/rdacm21.c b/drivers/media/i2c/rdacm21.c
> index 35217782f693..3a05abe4e96c 100644
> --- a/drivers/media/i2c/rdacm21.c
> +++ b/drivers/media/i2c/rdacm21.c
> @@ -21,7 +21,7 @@
> #include <media/v4l2-async.h>
> #include <media/v4l2-ctrls.h>
> #include <media/v4l2-subdev.h>
> -#include "max9271.h"
> +#include "max9271-lib.h"
>
> #define MAX9271_RESET_CYCLES 10
>
>
next prev parent reply other threads:[~2021-08-18 12:48 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-17 7:26 [RFC 0/5] media: i2c: Add MAX9271 subdevice driver Jacopo Mondi
2021-08-17 7:26 ` [RFC 1/5] media: i2c: max9271: Rename max9271 library driver Jacopo Mondi
2021-08-18 12:48 ` Kieran Bingham [this message]
2021-08-23 2:09 ` Laurent Pinchart
2021-08-17 7:27 ` [RFC 2/5] media: i2c: Add MAX9271 I2C driver Jacopo Mondi
2021-08-17 15:49 ` Kieran Bingham
2021-08-18 8:27 ` Jacopo Mondi
2021-08-18 12:38 ` Kieran Bingham
2021-08-23 2:22 ` Laurent Pinchart
2021-08-23 7:21 ` Jacopo Mondi
2021-08-23 12:05 ` Geert Uytterhoeven
2021-08-17 7:27 ` [RFC 3/5] media: i2c: rdacm20: Adapt to work with MAX9271 Jacopo Mondi
2021-08-17 7:27 ` [RFC 4/5] media: i2c: max9286: Fetch PIXEL_RATE in s_stream Jacopo Mondi
2021-08-23 2:17 ` Laurent Pinchart
2021-08-23 7:20 ` Jacopo Mondi
2021-08-23 9:34 ` Laurent Pinchart
2021-08-17 7:27 ` [RFC 5/5] arm64: dts: GMSL: Adapt to the use max9271 driver Jacopo Mondi
2021-08-18 12:47 ` [RFC 0/5] media: i2c: Add MAX9271 subdevice driver Kieran Bingham
2021-08-23 2:12 ` Laurent Pinchart
2021-08-23 2:06 ` Laurent Pinchart
2021-09-13 7:59 ` Jacopo Mondi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bfe2547e-e824-63be-5380-03fb16bd26d0@ideasonboard.com \
--to=kieran.bingham@ideasonboard.com \
--cc=hverkuil-cisco@xs4all.nl \
--cc=jacopo+renesas@jmondi.org \
--cc=kieran.bingham+renesas@ideasonboard.com \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=mchehab@kernel.org \
--cc=niklas.soderlund+renesas@ragnatech.se \
--cc=sakari.ailus@iki.fi \
--cc=tnizan@witekio.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).