* [PATCH 1/2] ARM: dts: r8a7745: Remove generic compatible strings from iic blocks
2021-05-04 14:49 [PATCH 0/2] ARM: dts: r8a7745,r8a7794: Remove generic compatible strings from iic blocks Geert Uytterhoeven
@ 2021-05-04 14:49 ` Geert Uytterhoeven
2021-05-04 14:49 ` [PATCH 2/2] ARM: dts: r8a7794: " Geert Uytterhoeven
2021-05-04 18:23 ` [PATCH 0/2] ARM: dts: r8a7745,r8a7794: " Geert Uytterhoeven
2 siblings, 0 replies; 5+ messages in thread
From: Geert Uytterhoeven @ 2021-05-04 14:49 UTC (permalink / raw)
To: Wolfram Sang, Magnus Damm, Chris Paterson, Fabrizio Castro
Cc: linux-renesas-soc, linux-i2c, Geert Uytterhoeven
The IIC blocks on RZ/G1E do not have the automatic transmission registers.
Hence they thus must not declare compatibility with the R-Car
Gen2-specific and generic versions.
Fixes: 0ee0aff583ddb6e9 ("ARM: dts: r8a7745: Add IIC cores to dtsi")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
arch/arm/boot/dts/r8a7745.dtsi | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/arch/arm/boot/dts/r8a7745.dtsi b/arch/arm/boot/dts/r8a7745.dtsi
index 36892ea87d7df941..0756197258de4a4b 100644
--- a/arch/arm/boot/dts/r8a7745.dtsi
+++ b/arch/arm/boot/dts/r8a7745.dtsi
@@ -475,9 +475,7 @@ i2c5: i2c@e6528000 {
iic0: i2c@e6500000 {
#address-cells = <1>;
#size-cells = <0>;
- compatible = "renesas,iic-r8a7745",
- "renesas,rcar-gen2-iic",
- "renesas,rmobile-iic";
+ compatible = "renesas,iic-r8a7745";
reg = <0 0xe6500000 0 0x425>;
interrupts = <GIC_SPI 174 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&cpg CPG_MOD 318>;
@@ -492,9 +490,7 @@ iic0: i2c@e6500000 {
iic1: i2c@e6510000 {
#address-cells = <1>;
#size-cells = <0>;
- compatible = "renesas,iic-r8a7745",
- "renesas,rcar-gen2-iic",
- "renesas,rmobile-iic";
+ compatible = "renesas,iic-r8a7745";
reg = <0 0xe6510000 0 0x425>;
interrupts = <GIC_SPI 175 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&cpg CPG_MOD 323>;
--
2.25.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 2/2] ARM: dts: r8a7794: Remove generic compatible strings from iic blocks
2021-05-04 14:49 [PATCH 0/2] ARM: dts: r8a7745,r8a7794: Remove generic compatible strings from iic blocks Geert Uytterhoeven
2021-05-04 14:49 ` [PATCH 1/2] ARM: dts: r8a7745: " Geert Uytterhoeven
@ 2021-05-04 14:49 ` Geert Uytterhoeven
2021-05-04 18:23 ` [PATCH 0/2] ARM: dts: r8a7745,r8a7794: " Geert Uytterhoeven
2 siblings, 0 replies; 5+ messages in thread
From: Geert Uytterhoeven @ 2021-05-04 14:49 UTC (permalink / raw)
To: Wolfram Sang, Magnus Damm, Chris Paterson, Fabrizio Castro
Cc: linux-renesas-soc, linux-i2c, Geert Uytterhoeven
The IIC blocks on R-Car E2 do not have the automatic transmission
registers. Hence they thus must not declare compatibility with the
R-Car Gen2-specific and generic versions.
Fixes: aa9b992ea2d3c2cc ("ARM: dts: r8a7794: Add IIC nodes")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
arch/arm/boot/dts/r8a7794.dtsi | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/arch/arm/boot/dts/r8a7794.dtsi b/arch/arm/boot/dts/r8a7794.dtsi
index 0035770e74de80a5..f974b8676bc59222 100644
--- a/arch/arm/boot/dts/r8a7794.dtsi
+++ b/arch/arm/boot/dts/r8a7794.dtsi
@@ -457,9 +457,7 @@ i2c5: i2c@e6528000 {
};
i2c6: i2c@e6500000 {
- compatible = "renesas,iic-r8a7794",
- "renesas,rcar-gen2-iic",
- "renesas,rmobile-iic";
+ compatible = "renesas,iic-r8a7794";
reg = <0 0xe6500000 0 0x425>;
interrupts = <GIC_SPI 174 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&cpg CPG_MOD 318>;
@@ -474,9 +472,7 @@ i2c6: i2c@e6500000 {
};
i2c7: i2c@e6510000 {
- compatible = "renesas,iic-r8a7794",
- "renesas,rcar-gen2-iic",
- "renesas,rmobile-iic";
+ compatible = "renesas,iic-r8a7794";
reg = <0 0xe6510000 0 0x425>;
interrupts = <GIC_SPI 175 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&cpg CPG_MOD 323>;
--
2.25.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 0/2] ARM: dts: r8a7745,r8a7794: Remove generic compatible strings from iic blocks
2021-05-04 14:49 [PATCH 0/2] ARM: dts: r8a7745,r8a7794: Remove generic compatible strings from iic blocks Geert Uytterhoeven
2021-05-04 14:49 ` [PATCH 1/2] ARM: dts: r8a7745: " Geert Uytterhoeven
2021-05-04 14:49 ` [PATCH 2/2] ARM: dts: r8a7794: " Geert Uytterhoeven
@ 2021-05-04 18:23 ` Geert Uytterhoeven
2021-05-28 8:03 ` Wolfram Sang
2 siblings, 1 reply; 5+ messages in thread
From: Geert Uytterhoeven @ 2021-05-04 18:23 UTC (permalink / raw)
To: Wolfram Sang, Magnus Damm, Chris Paterson, Fabrizio Castro
Cc: Linux-Renesas, Linux I2C
On Tue, May 4, 2021 at 4:49 PM Geert Uytterhoeven
<geert+renesas@glider.be> wrote:
> This patch series fixes the first issues discovered by[1], and removes
> the generic compatible strings from the IIC blocks on the R-Car E2 and
> RZ/G1E SoCs, as they do not have the automatic transmission registers.
> More follow-up patches are expected, when IIC will have dislosed all of
> its secrets...
>
> Thanks for your comments!
>
> [1] "[PATCH/RFC 4/6] dt-bindings: i2c: renesas,iic: Convert to json-schema"
> lore.kernel.org/r/ecfaf6be5e8c285db2bcc823bb1dd89931fa5c29.1620138454.git.geert+renesas@glider.be
>
> Geert Uytterhoeven (2):
> ARM: dts: r8a7745: Remove generic compatible strings from iic blocks
> ARM: dts: r8a7794: Remove generic compatible strings from iic blocks
>
> arch/arm/boot/dts/r8a7745.dtsi | 8 ++------
> arch/arm/boot/dts/r8a7794.dtsi | 8 ++------
While drivers/i2c/busses/i2c-sh_mobile.c already has a match entry for
"renesas,iic-r8a7794", it does not have one for "renesas,iic-r8a7745"
yet. Hence patch 2/2 depends on a to-be-sent patch to update the
driver.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 0/2] ARM: dts: r8a7745,r8a7794: Remove generic compatible strings from iic blocks
2021-05-04 18:23 ` [PATCH 0/2] ARM: dts: r8a7745,r8a7794: " Geert Uytterhoeven
@ 2021-05-28 8:03 ` Wolfram Sang
0 siblings, 0 replies; 5+ messages in thread
From: Wolfram Sang @ 2021-05-28 8:03 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Magnus Damm, Chris Paterson, Fabrizio Castro, Linux-Renesas, Linux I2C
[-- Attachment #1: Type: text/plain, Size: 353 bytes --]
> While drivers/i2c/busses/i2c-sh_mobile.c already has a match entry for
> "renesas,iic-r8a7794", it does not have one for "renesas,iic-r8a7745"
> yet. Hence patch 2/2 depends on a to-be-sent patch to update the
> driver.
For the record, this patch was never sent because we are still
investigating the presence of those registers in IIC revisions.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread