linux-renesas-soc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 0/2] thermal/drivers/rcar_gen3: Add support for R-Car V4M
@ 2024-03-06 10:56 Geert Uytterhoeven
  2024-03-06 10:56 ` [PATCH 1/2] dt-bindings: thermal: rcar-gen3-thermal: Add r8a779h0 support Geert Uytterhoeven
  2024-03-06 10:56 ` [PATCH 2/2] thermal/drivers/rcar_gen3: Add support for R-Car V4M Geert Uytterhoeven
  0 siblings, 2 replies; 6+ messages in thread
From: Geert Uytterhoeven @ 2024-03-06 10:56 UTC (permalink / raw)
  To: Niklas Söderlund, Rafael J . Wysocki, Daniel Lezcano,
	Zhang Rui, Lukasz Luba, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley
  Cc: linux-renesas-soc, linux-pm, devicetree, Geert Uytterhoeven

	Hi all,

This patch series adds support for the Thermal Sensor/Chip Internal
Voltage Monitor/Core Voltage Monitor (THS/CIVM/CVM) on the Renesas R-Car
V4M (R8A779H0) SoC.

It has been tested on the Renesas Gray Hawk Single development board,
with an R-Car V4M SoC that has unfortunately no calibration values
fused.

Thanks for your comments!

Duy Nguyen (1):
  dt-bindings: thermal: rcar-gen3-thermal: Add r8a779h0 support

Geert Uytterhoeven (1):
  thermal/drivers/rcar_gen3: Add support for R-Car V4M

 .../devicetree/bindings/thermal/rcar-gen3-thermal.yaml        | 2 ++
 drivers/thermal/rcar_gen3_thermal.c                           | 4 ++++
 2 files changed, 6 insertions(+)

-- 
2.34.1

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH 1/2] dt-bindings: thermal: rcar-gen3-thermal: Add r8a779h0 support
  2024-03-06 10:56 [PATCH 0/2] thermal/drivers/rcar_gen3: Add support for R-Car V4M Geert Uytterhoeven
@ 2024-03-06 10:56 ` Geert Uytterhoeven
  2024-03-06 12:32   ` Niklas Söderlund
  2024-03-06 18:12   ` Conor Dooley
  2024-03-06 10:56 ` [PATCH 2/2] thermal/drivers/rcar_gen3: Add support for R-Car V4M Geert Uytterhoeven
  1 sibling, 2 replies; 6+ messages in thread
From: Geert Uytterhoeven @ 2024-03-06 10:56 UTC (permalink / raw)
  To: Niklas Söderlund, Rafael J . Wysocki, Daniel Lezcano,
	Zhang Rui, Lukasz Luba, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley
  Cc: linux-renesas-soc, linux-pm, devicetree, Duy Nguyen, Geert Uytterhoeven

From: Duy Nguyen <duy.nguyen.rh@renesas.com>

Document support for the Thermal Sensor/Chip Internal Voltage
Monitor/Core Voltage Monitor (THS/CIVM/CVM) on the Renesas R-Car V4M
(R8A779H0) SoC.

Just like on other R-Car Gen4 SoCs, interrupts are not routed to the
INTC-AP (GIC) but to the Error Control Module (ECM).

Signed-off-by: Duy Nguyen <duy.nguyen.rh@renesas.com>
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
Changes compared to the BSP:
  - No interrupts property, as interrupts are routed to the ECM.
---
 .../devicetree/bindings/thermal/rcar-gen3-thermal.yaml          | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/thermal/rcar-gen3-thermal.yaml b/Documentation/devicetree/bindings/thermal/rcar-gen3-thermal.yaml
index ecf276fd155cfb27..6a81cb6e11bc1e14 100644
--- a/Documentation/devicetree/bindings/thermal/rcar-gen3-thermal.yaml
+++ b/Documentation/devicetree/bindings/thermal/rcar-gen3-thermal.yaml
@@ -29,6 +29,7 @@ properties:
       - renesas,r8a779a0-thermal # R-Car V3U
       - renesas,r8a779f0-thermal # R-Car S4-8
       - renesas,r8a779g0-thermal # R-Car V4H
+      - renesas,r8a779h0-thermal # R-Car V4M
 
   reg: true
 
@@ -90,6 +91,7 @@ else:
             enum:
               - renesas,r8a779f0-thermal
               - renesas,r8a779g0-thermal
+              - renesas,r8a779h0-thermal
   then:
     required:
       - interrupts
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH 2/2] thermal/drivers/rcar_gen3: Add support for R-Car V4M
  2024-03-06 10:56 [PATCH 0/2] thermal/drivers/rcar_gen3: Add support for R-Car V4M Geert Uytterhoeven
  2024-03-06 10:56 ` [PATCH 1/2] dt-bindings: thermal: rcar-gen3-thermal: Add r8a779h0 support Geert Uytterhoeven
@ 2024-03-06 10:56 ` Geert Uytterhoeven
  2024-03-06 12:32   ` Niklas Söderlund
  1 sibling, 1 reply; 6+ messages in thread
From: Geert Uytterhoeven @ 2024-03-06 10:56 UTC (permalink / raw)
  To: Niklas Söderlund, Rafael J . Wysocki, Daniel Lezcano,
	Zhang Rui, Lukasz Luba, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley
  Cc: linux-renesas-soc, linux-pm, devicetree, Geert Uytterhoeven

Add support for the Thermal Sensor/Chip Internal Voltage Monitor/Core
Voltage Monitor (THS/CIVM/CVM) on the Renesas R-Car V4M (R8A779H0) SoC.

The conversion formulas for R-Car V4M are the same as for other R-Car
Gen4 SoCs.

Based on a patch in the BSP by Duy Nguyen.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
Changes compared to the BSP:
  - Use existing rcar_gen4_thermal_info instead of new data_v4m.
---
 drivers/thermal/rcar_gen3_thermal.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/thermal/rcar_gen3_thermal.c b/drivers/thermal/rcar_gen3_thermal.c
index cafcb6d6e235be44..a764cb1115a57562 100644
--- a/drivers/thermal/rcar_gen3_thermal.c
+++ b/drivers/thermal/rcar_gen3_thermal.c
@@ -428,6 +428,10 @@ static const struct of_device_id rcar_gen3_thermal_dt_ids[] = {
 		.compatible = "renesas,r8a779g0-thermal",
 		.data = &rcar_gen4_thermal_info,
 	},
+	{
+		.compatible = "renesas,r8a779h0-thermal",
+		.data = &rcar_gen4_thermal_info,
+	},
 	{},
 };
 MODULE_DEVICE_TABLE(of, rcar_gen3_thermal_dt_ids);
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/2] dt-bindings: thermal: rcar-gen3-thermal: Add r8a779h0 support
  2024-03-06 10:56 ` [PATCH 1/2] dt-bindings: thermal: rcar-gen3-thermal: Add r8a779h0 support Geert Uytterhoeven
@ 2024-03-06 12:32   ` Niklas Söderlund
  2024-03-06 18:12   ` Conor Dooley
  1 sibling, 0 replies; 6+ messages in thread
From: Niklas Söderlund @ 2024-03-06 12:32 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: Rafael J . Wysocki, Daniel Lezcano, Zhang Rui, Lukasz Luba,
	Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	linux-renesas-soc, linux-pm, devicetree, Duy Nguyen

Hi Geert,

Thanks for your work.

On 2024-03-06 11:56:02 +0100, Geert Uytterhoeven wrote:
> From: Duy Nguyen <duy.nguyen.rh@renesas.com>
> 
> Document support for the Thermal Sensor/Chip Internal Voltage
> Monitor/Core Voltage Monitor (THS/CIVM/CVM) on the Renesas R-Car V4M
> (R8A779H0) SoC.
> 
> Just like on other R-Car Gen4 SoCs, interrupts are not routed to the
> INTC-AP (GIC) but to the Error Control Module (ECM).
> 
> Signed-off-by: Duy Nguyen <duy.nguyen.rh@renesas.com>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>

> ---
> Changes compared to the BSP:
>   - No interrupts property, as interrupts are routed to the ECM.
> ---
>  .../devicetree/bindings/thermal/rcar-gen3-thermal.yaml          | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/thermal/rcar-gen3-thermal.yaml b/Documentation/devicetree/bindings/thermal/rcar-gen3-thermal.yaml
> index ecf276fd155cfb27..6a81cb6e11bc1e14 100644
> --- a/Documentation/devicetree/bindings/thermal/rcar-gen3-thermal.yaml
> +++ b/Documentation/devicetree/bindings/thermal/rcar-gen3-thermal.yaml
> @@ -29,6 +29,7 @@ properties:
>        - renesas,r8a779a0-thermal # R-Car V3U
>        - renesas,r8a779f0-thermal # R-Car S4-8
>        - renesas,r8a779g0-thermal # R-Car V4H
> +      - renesas,r8a779h0-thermal # R-Car V4M
>  
>    reg: true
>  
> @@ -90,6 +91,7 @@ else:
>              enum:
>                - renesas,r8a779f0-thermal
>                - renesas,r8a779g0-thermal
> +              - renesas,r8a779h0-thermal
>    then:
>      required:
>        - interrupts
> -- 
> 2.34.1
> 

-- 
Kind Regards,
Niklas Söderlund

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 2/2] thermal/drivers/rcar_gen3: Add support for R-Car V4M
  2024-03-06 10:56 ` [PATCH 2/2] thermal/drivers/rcar_gen3: Add support for R-Car V4M Geert Uytterhoeven
@ 2024-03-06 12:32   ` Niklas Söderlund
  0 siblings, 0 replies; 6+ messages in thread
From: Niklas Söderlund @ 2024-03-06 12:32 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: Rafael J . Wysocki, Daniel Lezcano, Zhang Rui, Lukasz Luba,
	Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	linux-renesas-soc, linux-pm, devicetree

Hello Geert,

Thanks for your patch.

On 2024-03-06 11:56:03 +0100, Geert Uytterhoeven wrote:
> Add support for the Thermal Sensor/Chip Internal Voltage Monitor/Core
> Voltage Monitor (THS/CIVM/CVM) on the Renesas R-Car V4M (R8A779H0) SoC.
> 
> The conversion formulas for R-Car V4M are the same as for other R-Car
> Gen4 SoCs.
> 
> Based on a patch in the BSP by Duy Nguyen.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>

> ---
> Changes compared to the BSP:
>   - Use existing rcar_gen4_thermal_info instead of new data_v4m.
> ---
>  drivers/thermal/rcar_gen3_thermal.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/thermal/rcar_gen3_thermal.c b/drivers/thermal/rcar_gen3_thermal.c
> index cafcb6d6e235be44..a764cb1115a57562 100644
> --- a/drivers/thermal/rcar_gen3_thermal.c
> +++ b/drivers/thermal/rcar_gen3_thermal.c
> @@ -428,6 +428,10 @@ static const struct of_device_id rcar_gen3_thermal_dt_ids[] = {
>  		.compatible = "renesas,r8a779g0-thermal",
>  		.data = &rcar_gen4_thermal_info,
>  	},
> +	{
> +		.compatible = "renesas,r8a779h0-thermal",
> +		.data = &rcar_gen4_thermal_info,
> +	},
>  	{},
>  };
>  MODULE_DEVICE_TABLE(of, rcar_gen3_thermal_dt_ids);
> -- 
> 2.34.1
> 

-- 
Kind Regards,
Niklas Söderlund

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/2] dt-bindings: thermal: rcar-gen3-thermal: Add r8a779h0 support
  2024-03-06 10:56 ` [PATCH 1/2] dt-bindings: thermal: rcar-gen3-thermal: Add r8a779h0 support Geert Uytterhoeven
  2024-03-06 12:32   ` Niklas Söderlund
@ 2024-03-06 18:12   ` Conor Dooley
  1 sibling, 0 replies; 6+ messages in thread
From: Conor Dooley @ 2024-03-06 18:12 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: Niklas Söderlund, Rafael J . Wysocki, Daniel Lezcano,
	Zhang Rui, Lukasz Luba, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, linux-renesas-soc, linux-pm, devicetree,
	Duy Nguyen

[-- Attachment #1: Type: text/plain, Size: 590 bytes --]

On Wed, Mar 06, 2024 at 11:56:02AM +0100, Geert Uytterhoeven wrote:
> From: Duy Nguyen <duy.nguyen.rh@renesas.com>
> 
> Document support for the Thermal Sensor/Chip Internal Voltage
> Monitor/Core Voltage Monitor (THS/CIVM/CVM) on the Renesas R-Car V4M
> (R8A779H0) SoC.
> 
> Just like on other R-Car Gen4 SoCs, interrupts are not routed to the
> INTC-AP (GIC) but to the Error Control Module (ECM).
> 
> Signed-off-by: Duy Nguyen <duy.nguyen.rh@renesas.com>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

Acked-by: Conor Dooley <conor.dooley@microchip.com>


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2024-03-06 18:12 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-03-06 10:56 [PATCH 0/2] thermal/drivers/rcar_gen3: Add support for R-Car V4M Geert Uytterhoeven
2024-03-06 10:56 ` [PATCH 1/2] dt-bindings: thermal: rcar-gen3-thermal: Add r8a779h0 support Geert Uytterhoeven
2024-03-06 12:32   ` Niklas Söderlund
2024-03-06 18:12   ` Conor Dooley
2024-03-06 10:56 ` [PATCH 2/2] thermal/drivers/rcar_gen3: Add support for R-Car V4M Geert Uytterhoeven
2024-03-06 12:32   ` Niklas Söderlund

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).