* [PATCH RFC 0/2] Add R8A77970 support to the Renesas RPC-IF driver
@ 2019-01-10 19:01 Sergei Shtylyov
2019-01-10 19:02 ` [PATCH RFC 1/2] dt-bindings: spi: renesas-rpc: document R8A77970 bindings Sergei Shtylyov
2019-01-10 19:04 ` [PATCH RFC 2/2] spi-renesas-rpc: add R8A77970 support Sergei Shtylyov
0 siblings, 2 replies; 4+ messages in thread
From: Sergei Shtylyov @ 2019-01-10 19:01 UTC (permalink / raw)
To: linux-spi, Mason Yang, Rob Herring, devicetree
Cc: linux-renesas-soc, Mark Rutland
Hello!
Here's the set of 2 patches against the 'devel' branch of Simon Horman's 'renesas.git'
repo, the 2 patches adding R8A77980 support (posted before NY), and the Renesas RPC-IF driver/bindings patches v5. We're adding support for the R-Car V3M (R8A77970) RPC-IF
(which needs a special handling)...
[1/2] dt-bindings: spi: renesas-rpc: document R8A77970 bindings
[2/2] spi-renesas-rpc: add R8A77970 support
MBR, Sergei
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH RFC 1/2] dt-bindings: spi: renesas-rpc: document R8A77970 bindings
2019-01-10 19:01 [PATCH RFC 0/2] Add R8A77970 support to the Renesas RPC-IF driver Sergei Shtylyov
@ 2019-01-10 19:02 ` Sergei Shtylyov
2019-01-21 21:11 ` Rob Herring
2019-01-10 19:04 ` [PATCH RFC 2/2] spi-renesas-rpc: add R8A77970 support Sergei Shtylyov
1 sibling, 1 reply; 4+ messages in thread
From: Sergei Shtylyov @ 2019-01-10 19:02 UTC (permalink / raw)
To: linux-spi, Mason Yang, Rob Herring, devicetree
Cc: linux-renesas-soc, Mark Rutland
Document the R-Car V3M (R8A77970) SoC in the Renesas RPC-IF bindings.
Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
---
Documentation/devicetree/bindings/spi/spi-renesas-rpc.txt | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
Index: renesas/Documentation/devicetree/bindings/spi/spi-renesas-rpc.txt
===================================================================
--- renesas.orig/Documentation/devicetree/bindings/spi/spi-renesas-rpc.txt
+++ renesas/Documentation/devicetree/bindings/spi/spi-renesas-rpc.txt
@@ -2,7 +2,8 @@ Renesas R-Car Gen3 RPC-IF controller Dev
----------------------------------------------------------
Required properties:
-- compatible: should be "renesas,r8a77980-rpc" or
+- compatible: should be "renesas,r8a77970-rpc" or
+ "renesas,r8a77980-rpc" or
"renesas,r8a77995-rpc"
- #address-cells: should be 1
- #size-cells: should be 0
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH RFC 2/2] spi-renesas-rpc: add R8A77970 support
2019-01-10 19:01 [PATCH RFC 0/2] Add R8A77970 support to the Renesas RPC-IF driver Sergei Shtylyov
2019-01-10 19:02 ` [PATCH RFC 1/2] dt-bindings: spi: renesas-rpc: document R8A77970 bindings Sergei Shtylyov
@ 2019-01-10 19:04 ` Sergei Shtylyov
1 sibling, 0 replies; 4+ messages in thread
From: Sergei Shtylyov @ 2019-01-10 19:04 UTC (permalink / raw)
To: linux-spi, Mason Yang, Rob Herring, devicetree
Cc: linux-renesas-soc, Mark Rutland
Add the R-Car V3M (R8A77970) SoC support to the Renesas RPC-IF SPI driver.
This SoC has special RPC-IF register (DIVREG) that controls the RPC[D2]CK
clock divider instead of the CPG register (RPCCKCR) present in all other
R-Car gen3 SoC...
Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
---
drivers/spi/spi-renesas-rpc.c | 31 +++++++++++++++++++++++++++----
1 file changed, 27 insertions(+), 4 deletions(-)
Index: renesas/drivers/spi/spi-renesas-rpc.c
===================================================================
--- renesas.orig/drivers/spi/spi-renesas-rpc.c
+++ renesas/drivers/spi/spi-renesas-rpc.c
@@ -17,6 +17,7 @@
#include <linux/platform_device.h>
#include <linux/pm_runtime.h>
#include <linux/of.h>
+#include <linux/of_device.h>
#include <linux/regmap.h>
#include <linux/reset.h>
#include <linux/spi/spi.h>
@@ -140,6 +141,9 @@
#define RPC_PHYOFFSET2 0x0084 // R/W
#define RPC_PHYOFFSET2_OCTTMG(v) (((v) & 0x7) << 8)
+#define RPC_DIVREG 0x00A8 // R8A77970 only
+#define RPC_DIVREG_RATIO(v) (((v) & 0x3) << 0)
+
#define RPC_WBUF 0x8000 // Write Buffer
#define RPC_WBUF_SIZE 256 // Write Buffer size
@@ -158,8 +162,24 @@ struct rpc_spi {
u32 totalxferlen;
enum spi_mem_data_dir xfer_dir;
struct reset_control *rstc;
+ int (*set_freq)(struct rpc_spi *rpc, unsigned long freq);
};
+static int rpc_spi_clk_set_freq(struct rpc_spi *rpc, unsigned long freq)
+{
+ return clk_set_rate(rpc->clk_rpc, freq);
+}
+
+static int rpc_spi_v3m_set_freq(struct rpc_spi *rpc, unsigned long freq)
+{
+ u32 ratio;
+
+ ratio = ilog2(DIV_ROUND_UP(clk_get_rate(rpc->clk_rpc), freq));
+ if (ratio > 2)
+ ratio = 2;
+ return regmap_write(rpc->regmap, RPC_DIVREG, RPC_DIVREG_RATIO(ratio));
+}
+
static int rpc_spi_set_freq(struct rpc_spi *rpc, unsigned long freq)
{
int ret;
@@ -167,7 +187,7 @@ static int rpc_spi_set_freq(struct rpc_s
if (rpc->cur_speed_hz == freq)
return 0;
- ret = clk_set_rate(rpc->clk_rpc, freq);
+ ret = rpc->set_freq(rpc, freq);
if (ret)
return ret;
@@ -650,7 +670,7 @@ static const struct regmap_config rpc_sp
.val_bits = 32,
.reg_stride = 4,
.fast_io = true,
- .max_register = RPC_PHYOFFSET2,
+ .max_register = RPC_DIVREG,
.volatile_table = &rpc_spi_volatile_table,
};
@@ -708,6 +728,8 @@ static int rpc_spi_probe(struct platform
if (IS_ERR(rpc->rstc))
return PTR_ERR(rpc->rstc);
+ rpc->set_freq = of_device_get_match_data(&pdev->dev);
+
pm_runtime_enable(&pdev->dev);
master->auto_runtime_pm = true;
@@ -745,8 +767,9 @@ static int rpc_spi_remove(struct platfor
}
static const struct of_device_id rpc_spi_of_ids[] = {
- { .compatible = "renesas,r8a77980-rpc", },
- { .compatible = "renesas,r8a77995-rpc", },
+ { .compatible = "renesas,r8a77970-rpc", .data = rpc_spi_v3m_set_freq, },
+ { .compatible = "renesas,r8a77980-rpc", .data = rpc_spi_clk_set_freq, },
+ { .compatible = "renesas,r8a77995-rpc", .data = rpc_spi_clk_set_freq, },
{ /* sentinel */ }
};
MODULE_DEVICE_TABLE(of, rpc_spi_of_ids);
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH RFC 1/2] dt-bindings: spi: renesas-rpc: document R8A77970 bindings
2019-01-10 19:02 ` [PATCH RFC 1/2] dt-bindings: spi: renesas-rpc: document R8A77970 bindings Sergei Shtylyov
@ 2019-01-21 21:11 ` Rob Herring
0 siblings, 0 replies; 4+ messages in thread
From: Rob Herring @ 2019-01-21 21:11 UTC (permalink / raw)
To: Sergei Shtylyov
Cc: linux-spi, Mason Yang, devicetree, linux-renesas-soc, Mark Rutland
On Thu, 10 Jan 2019 22:02:38 +0300, Sergei Shtylyov wrote:
> Document the R-Car V3M (R8A77970) SoC in the Renesas RPC-IF bindings.
>
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>
> ---
> Documentation/devicetree/bindings/spi/spi-renesas-rpc.txt | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-01-21 21:11 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-10 19:01 [PATCH RFC 0/2] Add R8A77970 support to the Renesas RPC-IF driver Sergei Shtylyov
2019-01-10 19:02 ` [PATCH RFC 1/2] dt-bindings: spi: renesas-rpc: document R8A77970 bindings Sergei Shtylyov
2019-01-21 21:11 ` Rob Herring
2019-01-10 19:04 ` [PATCH RFC 2/2] spi-renesas-rpc: add R8A77970 support Sergei Shtylyov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).