* [PATCH] clock: renesas: cpg-mssr: Fix the typo
@ 2019-12-18 11:09 Biju Das
2019-12-18 12:27 ` Sergei Shtylyov
0 siblings, 1 reply; 4+ messages in thread
From: Biju Das @ 2019-12-18 11:09 UTC (permalink / raw)
To: Michael Turquette, Stephen Boyd, Rob Herring, Mark Rutland
Cc: Biju Das, Geert Uytterhoeven, linux-clk, devicetree,
Simon Horman, Chris Paterson, Marian-Cristian Rotariu,
Fabrizio Castro, linux-renesas-soc
This patch fixes the typo %s/r8a774a1/r8a774b1/.
Fixes: 1000393 ("dt-bindings: clock: renesas: cpg-mssr: Document r8a774b1
binding")
Signed-off-by: Biju Das <biju.das@bp.renesas.com>
---
Documentation/devicetree/bindings/clock/renesas,cpg-mssr.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/clock/renesas,cpg-mssr.txt b/Documentation/devicetree/bindings/clock/renesas,cpg-mssr.txt
index c7674d0..f4d153f 100644
--- a/Documentation/devicetree/bindings/clock/renesas,cpg-mssr.txt
+++ b/Documentation/devicetree/bindings/clock/renesas,cpg-mssr.txt
@@ -19,7 +19,7 @@ Required Properties:
- "renesas,r8a7745-cpg-mssr" for the r8a7745 SoC (RZ/G1E)
- "renesas,r8a77470-cpg-mssr" for the r8a77470 SoC (RZ/G1C)
- "renesas,r8a774a1-cpg-mssr" for the r8a774a1 SoC (RZ/G2M)
- - "renesas,r8a774b1-cpg-mssr" for the r8a774a1 SoC (RZ/G2N)
+ - "renesas,r8a774b1-cpg-mssr" for the r8a774b1 SoC (RZ/G2N)
- "renesas,r8a774c0-cpg-mssr" for the r8a774c0 SoC (RZ/G2E)
- "renesas,r8a7790-cpg-mssr" for the r8a7790 SoC (R-Car H2)
- "renesas,r8a7791-cpg-mssr" for the r8a7791 SoC (R-Car M2-W)
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] clock: renesas: cpg-mssr: Fix the typo
2019-12-18 11:09 [PATCH] clock: renesas: cpg-mssr: Fix the typo Biju Das
@ 2019-12-18 12:27 ` Sergei Shtylyov
2019-12-18 12:49 ` Biju Das
0 siblings, 1 reply; 4+ messages in thread
From: Sergei Shtylyov @ 2019-12-18 12:27 UTC (permalink / raw)
To: Biju Das, Michael Turquette, Stephen Boyd, Rob Herring, Mark Rutland
Cc: Geert Uytterhoeven, linux-clk, devicetree, Simon Horman,
Chris Paterson, Marian-Cristian Rotariu, Fabrizio Castro,
linux-renesas-soc
On 18.12.2019 14:09, Biju Das wrote:
> This patch fixes the typo %s/r8a774a1/r8a774b1/.
>
> Fixes: 1000393 ("dt-bindings: clock: renesas: cpg-mssr: Document r8a774b1
SHA1 should have at least 12 digits.
> binding")
And never break up the tag lines please.
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
[...]
MBR, Sergei
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH] clock: renesas: cpg-mssr: Fix the typo
2019-12-18 12:27 ` Sergei Shtylyov
@ 2019-12-18 12:49 ` Biju Das
2019-12-18 18:01 ` Sergei Shtylyov
0 siblings, 1 reply; 4+ messages in thread
From: Biju Das @ 2019-12-18 12:49 UTC (permalink / raw)
To: Sergei Shtylyov, Michael Turquette, Stephen Boyd, Rob Herring,
Mark Rutland
Cc: Geert Uytterhoeven, linux-clk, devicetree, Simon Horman,
Chris Paterson, Marian-Cristian Rotariu, Fabrizio Castro,
linux-renesas-soc
Hi Sergei,
Thanks for the feedback.
> Subject: Re: [PATCH] clock: renesas: cpg-mssr: Fix the typo
>
> On 18.12.2019 14:09, Biju Das wrote:
>
> > This patch fixes the typo %s/r8a774a1/r8a774b1/.
> >
> > Fixes: 1000393 ("dt-bindings: clock: renesas: cpg-mssr: Document r8a774b1
>
> SHA1 should have at least 12 digits.
>
Ok will do.
> > binding")
>
> And never break up the tag lines please.
Do you mean , do the changes like below and ignore check patch warnings? Is it acceptable to everyone?
Fixes: 10003938a0c64c2f0d89 ("dt-bindings: clock: renesas: cpg-mssr: Document r8a774b1 binding")
> > Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> [...]
>
> MBR, Sergei
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] clock: renesas: cpg-mssr: Fix the typo
2019-12-18 12:49 ` Biju Das
@ 2019-12-18 18:01 ` Sergei Shtylyov
0 siblings, 0 replies; 4+ messages in thread
From: Sergei Shtylyov @ 2019-12-18 18:01 UTC (permalink / raw)
To: Biju Das, Michael Turquette, Stephen Boyd, Rob Herring, Mark Rutland
Cc: Geert Uytterhoeven, linux-clk, devicetree, Simon Horman,
Chris Paterson, Marian-Cristian Rotariu, Fabrizio Castro,
linux-renesas-soc
On 12/18/2019 03:49 PM, Biju Das wrote:
>> Subject: Re: [PATCH] clock: renesas: cpg-mssr: Fix the typo
>>
>> On 18.12.2019 14:09, Biju Das wrote:
>>
>>> This patch fixes the typo %s/r8a774a1/r8a774b1/.
>>>
>>> Fixes: 1000393 ("dt-bindings: clock: renesas: cpg-mssr: Document r8a774b1
>>
>> SHA1 should have at least 12 digits.
>>
> Ok will do.
>
>>> binding")
>>
>> And never break up the tag lines please.
>
> Do you mean , do the changes like below and ignore check patch warnings?
checkpatch.pl doesn't complain to me, even about short SHA1...
> Is it acceptable to everyone?
I remember e.g. Dave Miller complaining about breaking up the "Fixes:" tag --
I think it breaks patchwork. Looking at Documentation/process/submitting-patches.rst,
this format is even codified...
> Fixes: 10003938a0c64c2f0d89 ("dt-bindings: clock: renesas: cpg-mssr: Document r8a774b1 binding")
>
>>> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
>> [...]
MBR, Sergei
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-12-18 18:01 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-18 11:09 [PATCH] clock: renesas: cpg-mssr: Fix the typo Biju Das
2019-12-18 12:27 ` Sergei Shtylyov
2019-12-18 12:49 ` Biju Das
2019-12-18 18:01 ` Sergei Shtylyov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).